22958 2008-12-22 01:10:55 -0800 Attribute namespaces are serialized as if they were element ones 2019-02-06 09:03:45 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap webkit-unassigned alex cdumez emacemac7 jchaffraix peter.rietzler rwlbuis webkitbooger oldest_to_newest 103161 0 ap 2008-12-22 01:10:55 -0800 If an attribute is created with setAttributeNS(), its namespace is printed as if it were a default one. On the attached test, two default namespaces are printed. 103162 1 26197 ap 2008-12-22 01:11:17 -0800 Created attachment 26197 test case 383287 2 ap 2011-04-11 11:12:17 -0700 *** Bug 58221 has been marked as a duplicate of this bug. *** 869065 3 webkitbooger 2013-04-04 02:09:35 -0700 Still seeing essentially same problem in Google Chrome Version 26.0.1410.43 m. As verified in the developer tools debugger, in scope variables, setAttributeNS does this: For the element creates an attribute, but the attribute's namespaceURI is null. And for the element it creates a second attribute that hasn't been asked for, of name xmlns with value being what should have been the namespaceURI of the attribute that has been asked for. The solution / workaround is: Pass in a qualified name and it will work! For most compatibility, you probably should get the prefix with yourElement.lookupPrefix(yourNamespaceURI). Workaround found by paying attention to http://www.w3.org/TR/DOM-Level-2-Core/core.html#ID-ElSetAttrNS where it says the second parameter is the qualifiedName, the qualified name of the attribute to create or alter. Problem found when running new tests in http://srguiwiz.github.com/adj-js/user-docs/tests.html and it failed in Chrome as a consequence of setAttributeNS behavior. It had passed in Firefox. Since then fixed http://srguiwiz.github.com/adj-js/user-docs/ to use qualified name, now it works in Chrome as well. Does this workaround and the specification mean this isn't a bug any more? 900810 4 alex 2013-06-15 14:48:06 -0700 (In reply to comment #3) > > Does this workaround and the specification mean this isn't a bug any more? This is still a bug. The DOM API allows for the case where the prefix is not specified. In such cases, the serializer needs to generate a prefix. In my testing, the serializer clearly assumes the prefix property will be present. The extra default namespace comes from the attempt to declare the prefix used for the namespace attribute. When the prefix is not specified and there needs to be a prefix, the wrong thing happens. I have a simple example the demonstrates the problem that I will attach. 900811 5 204774 alex 2013-06-15 14:51:46 -0700 Created attachment 204774 A example that demonstrates the different possible ways to cause and/or fix the problem. Note: In Firefox, you aren't allowed to set the prefix. This is clearly a DOM bug for them as [1] says you are allowed to set the prefix. [1] http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-NodeNSPrefix 901576 6 alex 2013-06-18 16:22:54 -0700 Looking at the source, the problem is two fold: 1. A prefix is not generated for the qualified name when it is missing. 2. The attribute prefix, when set, is not passed properly to appendNamespace(). For (1), at MarkupAccumulator.cpp:455: QualifiedName prefixedName = attribute.name(); if (attribute.namespaceURI() == XLinkNames::xlinkNamespaceURI) { if (!attribute.prefix()) prefixedName.setPrefix(xlinkAtom); } else if (attribute.namespaceURI() == XMLNames::xmlNamespaceURI) { if (!attribute.prefix()) prefixedName.setPrefix(xmlAtom); } else if (attribute.namespaceURI() == XMLNSNames::xmlnsNamespaceURI) { if (attribute.name() != XMLNSNames::xmlnsAttr && !attribute.prefix()) prefixedName.setPrefix(xmlnsAtom); } result.append(prefixedName.toString()); There are an infinite number of cases that need to be handled here by a check for: } else if (attribute.namespaceURI() && !attribute.prefix()) { // generate a prefix ... } and that is missing. For (2), the actually prefix used (either what was set or what was given) needs to be tracked and passed later on to appendNamespace() instead of attribute.prefix() as that field may remain null in the case of generated or set prefixes. Because you have to generate namespaces, it is unclear to me as of yet whether the current method of tracking in-scope namespaces will work properly. 901591 7 alex 2013-06-18 17:11:12 -0700 Bug 117764 is related to this problem. 922435 8 rwlbuis 2013-08-29 06:46:49 -0700 Committed r154779: <http://trac.webkit.org/changeset/154779> 1503032 9 lforschler 2019-02-06 09:03:45 -0800 Mass moving XML DOM bugs to the "DOM" Component. 26197 2008-12-22 01:11:17 -0800 2008-12-22 01:11:17 -0800 test case setAttributeNS.xml application/xhtml+xml 493 ap PGh0bWwgeG1sOmxhbmc9ImVuIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+ CiA8aGVhZD4KICA8dGl0bGUvPgogIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAg IGZ1bmN0aW9uIGRvVGVzdDEoKSB7CiAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1 bHQxJykuc2V0QXR0cmlidXRlTlMoJ25zJywgJ3RpdGxlJywgJ3ZhbHVlJyk7CiAgICAgIGlmIChk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0MScpLm91dGVySFRNTC5tYXRjaCgneG1sbnM9 Im5zIicpKQogICAgICAgIGFsZXJ0KCdGQUlMOiAnICsgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3Jlc3VsdDEnKS5vdXRlckhUTUwpOwogICAgICBlbHNlCiAgICAgICAgYWxlcnQoIlBBU1MiKTsK ICAgIH0KICA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0iZG9UZXN0MSgpIj4KICA8 cCBpZD0icmVzdWx0MSI+PC9wPgogPC9ib2R5Pgo8L2h0bWw+Cg== 204774 2013-06-15 14:51:46 -0700 2013-06-15 14:51:46 -0700 A example that demonstrates the different possible ways to cause and/or fix the problem. xml-serialization.xhtml application/xhtml+xml 2984 alex PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPCFET0NUWVBFIGh0bWw+Cjxo dG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KICAgIDxoZWFkPgogICAg ICAgIDx0aXRsZT5YTUwgU2VyaWFsaXphdGlvbiBUZXN0PC90aXRsZT4KICAgICAgICA8c2NyaXB0 IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiAgIHZhciBzZXJpYWxpemVyID0gbmV3IFhNTFNlcmlh bGl6ZXIoKTsKCiAgIC8vIEV4YW1wbGUgMTogQ3JlYXRlIGEgZG9jdW1lbnQgd2l0aCBhIG5hbWVz cGFjZWQgYXR0cmlidXRlIGJ1dCB2aWEgdGhlIERPTSBBUEkgYnV0IGRvIG5vdCBzcGVjaWZpYyBh IHByZWZpeC4KICAgLy8gT3V0Y29tZTogIEZhaWxlZCB0byBzZXJpYWxpemUgY29ycmVjdGx5Lgog ICB2YXIgZG9jID0gZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1lbnQoImh0dHA6 Ly93d3cudzMub3JnLzIwMDAvc3ZnIiwic3ZnIixudWxsKTsKICAgZG9jLmRvY3VtZW50RWxlbWVu dC5zZXRBdHRyaWJ1dGVOUygiaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIsImhyZWYiLCIj Zm9vIik7CiAgIGNvbnNvbGUubG9nKCJ7Iitkb2MuZG9jdW1lbnRFbGVtZW50LmF0dHJpYnV0ZXNb MF0ubmFtZXNwYWNlVVJJKyJ9Iitkb2MuZG9jdW1lbnRFbGVtZW50LmF0dHJpYnV0ZXNbMF0ubG9j YWxOYW1lKyIsIHByZWZpeD0iK2RvYy5kb2N1bWVudEVsZW1lbnQuYXR0cmlidXRlc1swXS5wcmVm aXgpOwogICB2YXIgeG1sID0gc2VyaWFsaXplci5zZXJpYWxpemVUb1N0cmluZyhkb2MpOwogICBj b25zb2xlLmxvZyh4bWwpOwogICAKICAgLy8gRXhhbXBsZSAyOiBBdHRlbXB0IHRvIGZpeCB0aGUg ZG9jdW1lbnQgYnkgc2V0dGluZyB0aGUgYXR0cmlidXRlLiAgVGhlIE5vZGUucHJlZml4IHByb3Bl cnR5IHNob3VsZCBub3cgY29udGFpbiAieGxpbmsiLgogICAvLyBPdXRjb21lOiAgTm9kZS5wcmVm aXggaXMgc3RpbGwgbnVsbCBidXQgdGhlIHF1YWxpZmllZCBuYW1lIHN0aWxsIHNob3dzIHVwLiAg RmFpbGVkIHRvIHNlcmlhbGl6ZSBjb3JyZWN0bHkuCiAgIGRvYyA9IGRvY3VtZW50LmltcGxlbWVu dGF0aW9uLmNyZWF0ZURvY3VtZW50KCJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIsInN2ZyIs bnVsbCk7CiAgIGRvYy5kb2N1bWVudEVsZW1lbnQuc2V0QXR0cmlidXRlTlMoImh0dHA6Ly93d3cu dzMub3JnLzE5OTkveGxpbmsiLCJocmVmIiwiI2ZvbyIpOwogICBkb2MuZG9jdW1lbnRFbGVtZW50 LnNldEF0dHJpYnV0ZU5TKCJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiwieGxpbms6aHJl ZiIsIiNmb28iKTsKICAgY29uc29sZS5sb2coInsiK2RvYy5kb2N1bWVudEVsZW1lbnQuYXR0cmli dXRlc1swXS5uYW1lc3BhY2VVUkkrIn0iK2RvYy5kb2N1bWVudEVsZW1lbnQuYXR0cmlidXRlc1sw XS5sb2NhbE5hbWUrIiwgcHJlZml4PSIrZG9jLmRvY3VtZW50RWxlbWVudC5hdHRyaWJ1dGVzWzBd LnByZWZpeCk7CiAgIHhtbCA9IHNlcmlhbGl6ZXIuc2VyaWFsaXplVG9TdHJpbmcoZG9jKTsKICAg Y29uc29sZS5sb2coeG1sKTsKICAgCiAgIC8vIEV4YW1wbGUgMzogQXR0ZW1wdCB0byBmaXggdGhl IGRvY3VtZW50IGJ5IHNldHRpbmcgTm9kZS5wcmVmaXguICBUaGUgTm9kZS5wcmVmaXggcHJvcGVy dHkgc2hvdWxkIG5vdyBjb250YWluICJ4bGluayIuCiAgIC8vIE91dGNvbWU6ICBTZXJpYWxpemVz IGNvcnJlY3RseSEKICAgZG9jID0gZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1l bnQoImh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiwic3ZnIixudWxsKTsKICAgZG9jLmRvY3Vt ZW50RWxlbWVudC5zZXRBdHRyaWJ1dGVOUygiaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIs ImhyZWYiLCIjZm9vIik7CiAgIGRvYy5kb2N1bWVudEVsZW1lbnQuYXR0cmlidXRlc1swXS5wcmVm aXggPSAieGxpbmsiOwogICBjb25zb2xlLmxvZygieyIrZG9jLmRvY3VtZW50RWxlbWVudC5hdHRy aWJ1dGVzWzBdLm5hbWVzcGFjZVVSSSsifSIrZG9jLmRvY3VtZW50RWxlbWVudC5hdHRyaWJ1dGVz WzBdLmxvY2FsTmFtZSsiLCBwcmVmaXg9Iitkb2MuZG9jdW1lbnRFbGVtZW50LmF0dHJpYnV0ZXNb MF0ucHJlZml4KTsKICAgeG1sID0gc2VyaWFsaXplci5zZXJpYWxpemVUb1N0cmluZyhkb2MpOwog ICBjb25zb2xlLmxvZyh4bWwpOwogICAKICAgLy8gRXhhbXBsZSA0OiBDcmVhdGUgdGhlIGRvY3Vt ZW50IHdpdGggcHJlZml4ZXMgc3BlY2lmaWVkLiAgVGhlIE5vZGUucHJlZml4IHByb3BlcnR5IHNo b3VsZCBub3cgY29udGFpbiAieGxpbmsiLgogICAvLyBPdXRjb21lOiAgU2VyaWFsaXplcyBjb3Jy ZWN0bHkhCiAgIGRvYyA9IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KCJo dHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIsInN2ZyIsbnVsbCk7CiAgIGRvYy5kb2N1bWVudEVs ZW1lbnQuc2V0QXR0cmlidXRlTlMoImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiLCJ4bGlu azpocmVmIiwiI2ZvbyIpOwogICBjb25zb2xlLmxvZygieyIrZG9jLmRvY3VtZW50RWxlbWVudC5h dHRyaWJ1dGVzWzBdLm5hbWVzcGFjZVVSSSsifSIrZG9jLmRvY3VtZW50RWxlbWVudC5hdHRyaWJ1 dGVzWzBdLmxvY2FsTmFtZSsiLCBwcmVmaXg9Iitkb2MuZG9jdW1lbnRFbGVtZW50LmF0dHJpYnV0 ZXNbMF0ucHJlZml4KTsKICAgeG1sID0gc2VyaWFsaXplci5zZXJpYWxpemVUb1N0cmluZyhkb2Mp OwogICBjb25zb2xlLmxvZyh4bWwpOyAgICAgICAgICAgCiAgICAgICAgPC9zY3JpcHQ+CiAgICA8 L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgIDxzdmcgaWQ9J3N2ZycgeG1sbnM9J2h0dHA6Ly93d3cu dzMub3JnLzIwMDAvc3ZnJyB4bWxuczp4bGluaz0naHR0cDovL3d3dy53My5vcmcvMTk5OS94bGlu ayc+PGRlZnM+PHBhdGggaWQ9J3gnLz48L2RlZnM+PHVzZSB4bGluazpocmVmPSd4Jy8+PC9zdmc+ CiAgICA8L2JvZHk+CjwvaHRtbD4=