<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>229577</bug_id>
          
          <creation_ts>2021-08-26 10:58:02 -0700</creation_ts>
          <short_desc>[EWS] find-modified-layout-tests step should include .svg tests</short_desc>
          <delta_ts>2024-04-25 15:39:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1787679</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-08-26 10:58:02 -0700</bug_when>
    <thetext>[EWS] find-modified-layout-tests step should include .svg tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1787682</commentid>
    <comment_count>1</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-08-26 10:58:59 -0700</bug_when>
    <thetext>I think the right logic is to re-run any tests whose:
1. test changed
2. expectation changed
3. change in TestExpectations (removed/added/changed lines)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1787877</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-08-26 17:00:36 -0700</bug_when>
    <thetext>It would also be relevant to run tests whose subresources changed, but that&apos;s hard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1787878</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-08-26 17:00:56 -0700</bug_when>
    <thetext>But let&apos;s just track .svg in this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1787914</commentid>
    <comment_count>4</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2021-08-26 18:16:47 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #2)
&gt; It would also be relevant to run tests whose subresources changed, but
&gt; that&apos;s hard.

Would this include script? (I imagine that stress-testing all layout tests that import &quot;resources/js-test.js&quot; when adjusting that script could be a bit excessive, for instance).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1789780</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-09-02 10:58:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/82683414&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2030720</commentid>
    <comment_count>6</comment_count>
    <who name="Brianna Fan">bfan2</who>
    <bug_when>2024-04-23 16:40:48 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/27663</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2031326</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-04-25 15:39:28 -0700</bug_when>
    <thetext>Committed 278009@main (5d452549f3c4): &lt;https://commits.webkit.org/278009@main&gt;

Reviewed commits have been landed. Closing PR #27663 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>