229572 2021-08-26 10:11:40 -0700 [GLIB] mark fast/text/trak-optimizeLegibility.html as a skip 2021-08-26 14:17:18 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 crzwdjk webkit-unassigned lmoura mmaxfield webkit-bug-importer oldest_to_newest 1787661 0 crzwdjk 2021-08-26 10:11:40 -0700 This test is checking that the rendering with optimizeLegibility is different from the default rendering when using a font with the 'trak' table included for custom tracking information. Harfbuzz does support using this table, so I think this test should pass on GLIB. 1787713 1 mmaxfield 2021-08-26 12:01:34 -0700 There’s a chance I missed up the font when I generated it, too. If that’s the case, please let me know; I’m happy to fix the font. 1787714 2 mmaxfield 2021-08-26 12:01:51 -0700 *messed 1787717 3 mmaxfield 2021-08-26 12:06:15 -0700 Oh, I bet optimizeLegibility just isn’t hooked up to anything on the HarfBuzz ports. We implement this by passing a magic flag into CoreText. I guess it’s up to each port what they want optimizeLegibility to mean. The right fix here might to be to intentionally mark this test as only passing on some ports, if other ports want to use optimizeLegibility to do something different. 1787719 4 mmaxfield 2021-08-26 12:09:27 -0700 Some more context: this trak thing isn’t necessary for web compatibility. It’s here because Apple teams wanted to serve San Francisco as a web font so it would work on Windows computers, and SF has a trak table, and they wanted to have some way to opt-in to making it work. It would be totally reasonable for a port to say they are uninterested in hooking up optimizeLegibility to trak. Or, if a port wants to enable trak unconditionally. It’s up to each port. 1787721 5 mmaxfield 2021-08-26 12:11:45 -0700 *isn’t necessary for _general_ web compatibility. It was a specific request from specific (high profile, at least to our port) sites. 1787758 6 crzwdjk 2021-08-26 13:10:06 -0700 Upon further investigation, I think this test needs to be skipped on Linux because I don't think optimizeLegibility is hooked up to anything, or rather I think it's always on since all text goes through the complex path. And upon examination it does look like HarfBuzz tries to read and use the trak in fonts that have one. I am going to reuse the bug for the gardening patch to skip this test. 1787759 7 436555 crzwdjk 2021-08-26 13:13:46 -0700 Created attachment 436555 Patch 1787771 8 436555 mmaxfield 2021-08-26 13:26:40 -0700 Comment on attachment 436555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436555&action=review > LayoutTests/platform/glib/TestExpectations:1771 > +fast/text/trak-optimizeLegibility.html [ Skip ] Actually skipping the test can hide crashes. Usually it's better to mark them as either passing or failing (or, if you want to be notified of progressions, mark as just failing), so we can make sure they don't crash. 1787791 9 ews-feeder 2021-08-26 14:16:37 -0700 Committed r281653 (241008@main): <https://commits.webkit.org/241008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436555. 1787792 10 webkit-bug-importer 2021-08-26 14:17:18 -0700 <rdar://problem/82407020> 436555 2021-08-26 13:13:46 -0700 2021-08-26 14:16:37 -0700 Patch bug-229572-20210826161345.patch text/plain 3356 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNjMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjk3NmNhNGNiOGVjNTAyNDM5ODg0 MjEwMTQwYWUxZGE4ODlmZDBmNC4uNzljYTJlZDllY2ExNDA0ZTkyOWZjZTJkMDU0ZDE5N2QxNjVk M2EzNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTI2ICBBcmNhZHkgR29sZG1pbnRz LU9ybG92ICA8YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTElCXSBtYXJrIGZh c3QvdGV4dC90cmFrLW9wdGltaXplTGVnaWJpbGl0eS5odG1sIGFzIGEgc2tpcAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NTcyCisKKyAgICAgICAg b3B0aW1pemVMZWdpYmlsaXR5IGRvZXNuJ3QgYWZmZWN0IHRleHQgcmVuZGVyaW5nIG9uIEdMSUIg cGxhdGZvcm1zLAorICAgICAgICBlZmZlY3RpdmVseSBiZWluZyBhbHdheXMgZW5hYmxlZC4KKwor ICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0v Z2xpYi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9mYXN0L3RleHQv dHJhay1vcHRpbWl6ZUxlZ2liaWxpdHktZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAq IHBsYXRmb3JtL3dwZS9mYXN0L3RleHQvdHJhay1vcHRpbWl6ZUxlZ2liaWxpdHktZXhwZWN0ZWQu dHh0OiBSZW1vdmVkLgorCiAyMDIxLTA4LTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI4MTUxNik6IFtBcHBsZVNpbGljb24gV0syXSBm YXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBsdWdpbi5odG1sIGlzIHRpbWluZyBvdXQKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5N2U5OTc4OGM3 OWU1NmMwNDJmMTY0ZWJhMTIzMmQxNWNiN2E3MTFiLi4zNDIwYTJlNzQ2Mzc2MWI0ODI3MTVhYzlk MTk3NmYxYzU2YmZlNzc1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0 YXRpb25zCkBAIC0xNzY4LDYgKzE3NjgsNyBAQCBmYXN0L3RleHQvaGlkcGktdGV4dC1zZWxlY3Rp b24tZ2FwLWJldHdlZW4td29yZHMuaHRtbCBbIFNraXAgXQogCiAjIE5vIGRpZmZlcmVudCByZW5k ZXJpbmcgZm9yIHRleHQtcmVuZGVyaW5nOiBvcHRpbWl6ZUxlZ2liaWxpdHkuCiBmYXN0L3RleHQv dmFyaWF0aW9ucy9vcHRpY2FsLXNpemluZy10cmFrLTIuaHRtbCBbIFNraXAgXQorZmFzdC90ZXh0 L3RyYWstb3B0aW1pemVMZWdpYmlsaXR5Lmh0bWwgWyBTa2lwIF0KIAogIyBDdXJyZW50bHkgZW5h YmxlZCBvbiBNYWMgb25seS4KIG1lZGlhL21lZGlhLXVzYWdlLXN0YXRlLmh0bWwgWyBTa2lwIF0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L3RleHQvdHJhay1vcHRp bWl6ZUxlZ2liaWxpdHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zh c3QvdGV4dC90cmFrLW9wdGltaXplTGVnaWJpbGl0eS1leHBlY3RlZC50eHQKZGVsZXRlZCBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDk4YjZkMjllNjE1OTdlNzRlOWYzZWI4NDM0Y2NhNzcxY2IzZDlh YzIuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvdGV4dC90cmFrLW9wdGltaXplTGVnaWJpbGl0eS1leHBl Y3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSwxMiArMCwwIEBACi1QQVNTIGZpcnN0LmdldENs aWVudFJlY3RzKCkubGVuZ3RoIGlzIDEKLVBBU1MgdGhpcmQuZ2V0Q2xpZW50UmVjdHMoKS5sZW5n dGggaXMgMQotUEFTUyBmaXJzdC5nZXRDbGllbnRSZWN0cygpWzBdLnJpZ2h0IGlzIHdpdGhpbiA0 IG9mIDM0NgotUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBMRVRF Ci1UaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IHlvdSBjYW4gb3B0LWluIHRvIGhvbm9yaW5nIHRo ZSAndHJhaycgdGFibGUgYnkgc3BlY2lmeWluZyB0ZXh0LXJlbmRlcmluZzogb3B0aW1pemVMZWdp YmlsaXR5LiBUaGUgZmlyc3QgYW5kIHRoaXJkIGxpbmVzIGJlbG93IHNob3VsZCBoYXZlIHRoZSBz YW1lIHdpZHRoLiBUaGUgbWlkZGxlIG9uZSBjYW4gKGJ1dCBkb2Vzbid0IGhhdmUgdG8pIGhhdmUg YSBkaWZmZXJlbnQgd2lkdGguCi1oYW1idXJnZWZvbnN0aXYKLQotaGFtYnVyZ2Vmb25zdGl2Ci0K LWhhbWJ1cmdlZm9uc3RpdgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL2Zh c3QvdGV4dC90cmFrLW9wdGltaXplTGVnaWJpbGl0eS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS93cGUvZmFzdC90ZXh0L3RyYWstb3B0aW1pemVMZWdpYmlsaXR5LWV4cGVjdGVk LnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYmM3YzU4NGE2NTAxMmVhZDkxZWI0 ZDVlZTM5Y2VkYzM4MDFhZmNmZi4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvZmFzdC90ZXh0L3RyYWstb3B0aW1p emVMZWdpYmlsaXR5LWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDEyICswLDAgQEAK LVBBU1MgZmlyc3QuZ2V0Q2xpZW50UmVjdHMoKS5sZW5ndGggaXMgMQotUEFTUyB0aGlyZC5nZXRD bGllbnRSZWN0cygpLmxlbmd0aCBpcyAxCi1QQVNTIGZpcnN0LmdldENsaWVudFJlY3RzKClbMF0u cmlnaHQgaXMgdGhpcmQuZ2V0Q2xpZW50UmVjdHMoKVswXS5yaWdodAotUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBMRVRFCi1UaGlzIHRlc3QgbWFrZXMgc3VyZSB0 aGF0IHlvdSBjYW4gb3B0LWluIHRvIGhvbm9yaW5nIHRoZSAndHJhaycgdGFibGUgYnkgc3BlY2lm eWluZyB0ZXh0LXJlbmRlcmluZzogb3B0aW1pemVMZWdpYmlsaXR5LiBUaGUgZmlyc3QgYW5kIHRo aXJkIGxpbmVzIGJlbG93IHNob3VsZCBoYXZlIHRoZSBzYW1lIHdpZHRoLiBUaGUgbWlkZGxlIG9u ZSBjYW4gKGJ1dCBkb2Vzbid0IGhhdmUgdG8pIGhhdmUgYSBkaWZmZXJlbnQgd2lkdGguCi1oYW1i dXJnZWZvbnN0aXYKLQotaGFtYnVyZ2Vmb25zdGl2Ci0KLWhhbWJ1cmdlZm9uc3Rpdgo=