229560 2021-08-26 08:45:29 -0700 [iOS] editing/input/cocoa/autocorrect-on.html occasionally fails with a text diff 2021-08-26 12:09:35 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes akeerthi hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1787603 0 wenson_hsieh 2021-08-26 08:45:29 -0700 rdar://82191308 1787606 1 wenson_hsieh 2021-08-26 08:48:42 -0700 r281576 fixed a timeout in editing/input/cocoa/autocorrect-on.html that was caused by running the previous test (which made kbd learn the spelling for "Tset"). However, even after that change, this test still *sometimes* fails with a text diff, due to "Tset" being autocorrected to "Set" instead of "Test". 😐 1787610 2 436514 wenson_hsieh 2021-08-26 08:53:35 -0700 Created attachment 436514 Patch 1787690 3 436514 wenson_hsieh 2021-08-26 11:20:50 -0700 Comment on attachment 436514 Patch Thanks for the review! 1787720 4 ews-feeder 2021-08-26 12:09:35 -0700 Committed r281641 (240997@main): <https://commits.webkit.org/240997@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436514. 436514 2021-08-26 08:53:35 -0700 2021-08-26 12:09:35 -0700 Patch bug-229560-20210826085334.patch text/plain 3409 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNjEwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGYwOWQxOWQ3NjNkYmM1YWFmYWE3 NzdiNWI5Zjc2MWRlZjAyZmFiOS4uYThhN2YyMjE4ZmQ1YWIwZGNlMTJiM2Y1N2ZmMGZmNjE0OTIx ZjNjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTI2ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGVkaXRpbmcvaW5wdXQvY29j b2EvYXV0b2NvcnJlY3Qtb24uaHRtbCBvY2Nhc2lvbmFsbHkgZmFpbHMgd2l0aCBhIHRleHQgZGlm ZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NTYw CisgICAgICAgIHJkYXI6Ly84MjE5MTMwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkanVzdCB0aGUgdGVzdCBzbyB0aGF0IGl0IGRvZXNuJ3QgcmVx dWlyZSAiVHNldCIgdG8gYmUgYXV0b2NvcnJlY3RlZCB0byAiVGVzdCIuIEluc3RlYWQsIGp1c3Qg Y2hlY2sgdGhhdCBpdCB3YXMKKyAgICAgICAgY2hhbmdlZCBmcm9tICJUc2V0IiB0byBhbnl0aGlu ZyBlbHNlLgorCisgICAgICAgICogZWRpdGluZy9pbnB1dC9jb2NvYS9hdXRvY29ycmVjdC1vbi1l eHBlY3RlZC50eHQ6CisgICAgICAgICogZWRpdGluZy9pbnB1dC9jb2NvYS9hdXRvY29ycmVjdC1v bi5odG1sOgorCiAyMDIxLTA4LTI1ICBUcnVpdHQgU2F2ZWxsICA8dHNhdmVsbEBhcHBsZS5jb20+ CiAKICAgICAgICAgMjUgd2Via2l0IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3Nz LyBsYXlvdXQgdGVzdHMgZmFpbGluZyB3aXRoIGJsYWNrIGJhcnMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2VkaXRpbmcvaW5wdXQvY29jb2EvYXV0b2NvcnJlY3Qtb24tZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9jb2NvYS9hdXRvY29ycmVjdC1vbi1leHBlY3RlZC50 eHQKaW5kZXggZWI3MWY1MWI0OGE5NDkxMmQzMWY2MWNmMmM2MTEyM2MyYjFmY2E1ZS4uOWMzNTkx MGFjMGM0NDNkMWY1Njk3ZDdhYWNmNzIzMmYxYmM0YzU0MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZWRpdGluZy9pbnB1dC9jb2NvYS9hdXRvY29ycmVjdC1vbi1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9jb2NvYS9hdXRvY29ycmVjdC1vbi1leHBlY3RlZC50 eHQKQEAgLTgsMTQgKzgsMTQgQEAgUEFTUyBpbnNlcnRlZFRleHQgYmVjYW1lIHRydWUKIFBBU1Mg aW5zZXJ0ZWRUZXh0IGJlY2FtZSB0cnVlCiBQQVNTIGluc2VydGVkVGV4dCBiZWNhbWUgdHJ1ZQog UEFTUyBpbnNlcnRlZFJlcGxhY2VtZW50VGV4dCBiZWNhbWUgdHJ1ZQotUEFTUyBjb250ZW50ZWRp dGFibGUudGV4dENvbnRlbnQgaXMgIlRlc3QuIgorUEFTUyBjb250ZW50ZWRpdGFibGUudGV4dENv bnRlbnQgaXMgbm90IHN0cmluZ1RvVHlwZQogUEFTUyBpbnNlcnRlZFRleHQgYmVjYW1lIHRydWUK IFBBU1MgaW5zZXJ0ZWRUZXh0IGJlY2FtZSB0cnVlCiBQQVNTIGluc2VydGVkVGV4dCBiZWNhbWUg dHJ1ZQogUEFTUyBpbnNlcnRlZFRleHQgYmVjYW1lIHRydWUKIFBBU1MgaW5zZXJ0ZWRUZXh0IGJl Y2FtZSB0cnVlCiBQQVNTIGluc2VydGVkUmVwbGFjZW1lbnRUZXh0IGJlY2FtZSB0cnVlCi1QQVNT IHRleHRhcmVhLnZhbHVlIGlzICJUZXN0LiIKK1BBU1MgdGV4dGFyZWEudmFsdWUgaXMgbm90IHN0 cmluZ1RvVHlwZQogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBM RVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L2NvY29hL2F1dG9jb3Jy ZWN0LW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L2NvY29hL2F1dG9jb3JyZWN0 LW9uLmh0bWwKaW5kZXggNGI0NmQzYzFiZjQ1NDY4Y2UzMDg5NzY3Y2I4Y2RkNzUxYTc3ZGUyMC4u NzNhMTFiZGM5Nzg0MjRmZGU1MThhNDUxNDY3ZTAxNjRlNjc5MWY0YiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9jb2NvYS9hdXRvY29ycmVjdC1vbi5odG1sCisrKyBiL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvY29jb2EvYXV0b2NvcnJlY3Qtb24uaHRtbApAQCAtMjAs MTEgKzIwLDEwIEBACiAgICAgPHByZSBpZD0iZGVzY3JpcHRpb24iPjwvcHJlPgogICAgIDxwcmUg aWQ9ImNvbnNvbGUiPjwvcHJlPgogICAgIDxzY3JpcHQ+Ci0gICAgY29uc3Qgc3RyaW5nVG9UeXBl ID0gIlRzZXQuIjsKLSAgICBjb25zdCBhdXRvY29ycmVjdGVkU3RyaW5nID0gIlRlc3QuIjsKLSAg ICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7Ci0gICAgd2luZG93Lmluc2VydGVkVGV4dCA9 IGZhbHNlOwotICAgIHdpbmRvdy5pbnNlcnRlZFJlcGxhY2VtZW50VGV4dCA9IGZhbHNlOworICAg IHN0cmluZ1RvVHlwZSA9ICJUc2V0LiI7CisgICAganNUZXN0SXNBc3luYyA9IHRydWU7CisgICAg aW5zZXJ0ZWRUZXh0ID0gZmFsc2U7CisgICAgaW5zZXJ0ZWRSZXBsYWNlbWVudFRleHQgPSBmYWxz ZTsKICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYXV0b2NvcnJlY3Rp b249b24gZW5hYmxlcyBhdXRvY29ycmVjdGlvbi4gVG8gbWFudWFsbHkgdGVzdCwgdHlwZSAnVHNl dCcgaW50byBib3RoIGVkaXRhYmxlIGFyZWFzIGFuZCBhIHBlcmlvZCwgYW5kIHZlcmlmeSB0aGF0 IGl0IGlzIG5vdCBhdXRvY29ycmVjdGVkLiIpOwogCiAgICAgZnVuY3Rpb24gaGFuZGxlSW5wdXQo ZXZlbnQpIHsKQEAgLTgwLDEwICs3OSwxMCBAQAogICAgICAgICB0ZXh0YXJlYS5hZGRFdmVudExp c3RlbmVyKCJpbnB1dCIsIGhhbmRsZUlucHV0KTsKIAogICAgICAgICBhd2FpdCBydW5UZXN0Rm9y RWxlbWVudChjb250ZW50ZWRpdGFibGUsIHN0cmluZ1RvVHlwZSk7Ci0gICAgICAgIHNob3VsZEJl RXF1YWxUb1N0cmluZygiY29udGVudGVkaXRhYmxlLnRleHRDb250ZW50IiwgYXV0b2NvcnJlY3Rl ZFN0cmluZyk7CisgICAgICAgIHNob3VsZE5vdEJlKCJjb250ZW50ZWRpdGFibGUudGV4dENvbnRl bnQiLCAic3RyaW5nVG9UeXBlIik7CiAKICAgICAgICAgYXdhaXQgcnVuVGVzdEZvckVsZW1lbnQo dGV4dGFyZWEsIHN0cmluZ1RvVHlwZSk7Ci0gICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygi dGV4dGFyZWEudmFsdWUiLCBhdXRvY29ycmVjdGVkU3RyaW5nKTsKKyAgICAgICAgc2hvdWxkTm90 QmUoInRleHRhcmVhLnZhbHVlIiwgInN0cmluZ1RvVHlwZSIpOwogCiAgICAgICAgIGNvbnRlbnRl ZGl0YWJsZS5yZW1vdmUoKTsKICAgICAgICAgdGV4dGFyZWEucmVtb3ZlKCk7Cg==