229551 2021-08-26 05:29:28 -0700 PrivateClickMeasurementManager::firePendingAttributionRequests() is crashing in debug 2021-08-27 09:30:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229550 InRadar P2 Normal --- 1 youennf youennf katherine_cheney webkit-bot-watchers-bugzilla webkit-bug-importer wilander oldest_to_newest 1787548 0 youennf 2021-08-26 05:29:28 -0700 See https://build-safari.apple.com/#/builders/2620/builds/100 TestWebKitAPI.WebKit.AutoplayOnVisibilityChange 2021-08-25 10:40:45.775 com.apple.WebKit.WebContent.Development[40235:2276300] XType: can't switch to GlobalFontRegistry. XTFontStaticRegistry is not enabled. SHOULD NEVER BE REACHED /Volumes/Data/worker/trunk-starbravo-debug-archive/build/OpenSource/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp(423) : auto WebKit::PrivateClickMeasurementManager::firePendingAttributionRequests()::(anonymous class)::operator()(auto &&) const [attributions:auto = WTF::Vector<WebCore::PrivateClickMeasurement, 0, WTF::CrashOnOverflow, 16>] 1 0x11fe61009 WTFCrash 2 0x129c9adeb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12aaec14e auto WebKit::PrivateClickMeasurementManager::firePendingAttributionRequests()::$_22::operator()<WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >(WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) const 4 0x12aaebf41 WTF::Detail::CallableWrapper<WebKit::PrivateClickMeasurementManager::firePendingAttributionRequests()::$_22, void, WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&>::call(WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) 5 0x12abd96a7 WTF::Function<void (WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)>::operator()(WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) const 6 0x12ab42a10 WTF::CompletionHandler<void (WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)>::operator()(WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) 7 0x12abda89c WebKit::WebResourceLoadStatisticsStore::allAttributedPrivateClickMeasurement(WTF::CompletionHandler<void (WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)>&&)::$_114::operator()()::'lambda0'()::operator()() 8 0x12abda7c9 WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::allAttributedPrivateClickMeasurement(WTF::CompletionHandler<void (WTF::Vector<WebCore::PrivateClickMeasurement, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)>&&)::$_114::operator()()::'lambda0'(), void>::call() 9 0x11fe8a0f2 WTF::Function<void ()>::operator()() const 10 0x11ff0744e WTF::RunLoop::performWork() 11 0x11ff0ad1e WTF::RunLoop::performWork(void*) 12 0x7ff8027d0ded __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 13 0x7ff8027d0d55 __CFRunLoopDoSource0 14 0x7ff8027d0ad4 __CFRunLoopDoSources0 15 0x7ff8027cf50b __CFRunLoopRun 16 0x7ff8027ceacd CFRunLoopRunSpecific 17 0x7ff80363366e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 18 0x7ff8036bda03 -[NSRunLoop(NSRunLoop) run] 19 0x7ff80245f233 _xpc_objc_main 20 0x7ff80245ec22 xpc_main 21 0x12aaeedbf WebKit::XPCServiceMain(int, char const**) 22 0x12c1cb26b WKXPCServiceMain 23 0x1005b1ea2 main 24 0x106c944d5 1787551 1 436501 youennf 2021-08-26 05:31:35 -0700 Created attachment 436501 Patch 1787552 2 youennf 2021-08-26 05:31:45 -0700 <rdar://81997710> 1787553 3 youennf 2021-08-26 05:32:57 -0700 Bug 229550 might be explained by this crash. 1787593 4 436501 katherine_cheney 2021-08-26 07:57:12 -0700 Comment on attachment 436501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436501&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:423 > + // Attribution has already been sent. I am not sure this is the right solution. I added an ASSERT here because I thought this code path was not possible. We should figure out why it is being hit instead of removing the ASSERT. 1787599 5 youennf 2021-08-26 08:36:46 -0700 (In reply to Kate Cheney from comment #4) > Comment on attachment 436501 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436501&action=review > > > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:423 > > + // Attribution has already been sent. > > I am not sure this is the right solution. I added an ASSERT here because I > thought this code path was not possible. We should figure out why it is > being hit instead of removing the ASSERT. Agreed it might be fine to investigate why this assert is buggy. But this disrupts tests so it seems good to remove this assert as soon as possible. I am fine adding release logging instead for now. 1787845 6 436579 katherine_cheney 2021-08-26 15:47:14 -0700 Created attachment 436579 Patch 1787860 7 wilander 2021-08-26 16:06:56 -0700 r=me 1788036 8 ews-feeder 2021-08-27 09:30:53 -0700 Committed r281697 (241047@main): <https://commits.webkit.org/241047@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436579. 436501 2021-08-26 05:31:35 -0700 2021-08-26 15:47:12 -0700 Patch bug-229551-20210826143133.patch text/plain 2197 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY0NzE4MWQ4YjhjNWYxZGUx ZDQ4NTQ1NjJiOGEzOGUwNjJkMjI3NDYuLmI4ZmU3ZWY0MjczMTQxNTMyNTBkMTgyYzJjZmI5ZWFj ODEzNGIwOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDgtMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFByaXZhdGVDbGlja01lYXN1cmVt ZW50TWFuYWdlcjo6ZmlyZVBlbmRpbmdBdHRyaWJ1dGlvblJlcXVlc3RzKCkgaXMgY3Jhc2hpbmcg aW4gZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyOTU1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEl0IGlzIG5vdCBndWFyYW50ZWVkIHRoYXQgYXR0cmlidXRpb25zIGFyZSBub3QgYWxyZWFkeSBz ZW50LgorICAgICAgICBSZW1vdmUgZGVidWcgYXNzZXJ0IHRoYXQgaXMgaGl0IGluIEFQSSB0ZXN0 cy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1ByaXZhdGVDbGlja01lYXN1cmVtZW50TWFu YWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdl cjo6ZmlyZVBlbmRpbmdBdHRyaWJ1dGlvblJlcXVlc3RzKToKKwogMjAyMS0wOC0yNSAgV2Vuc29u IEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIDE1XSBlZGl0 aW5nL2lucHV0L2NvY29hL2F1dG9jb3JyZWN0LW9uLmh0bWwgdGltZXMgb3V0IHdoZW4gcnVuIGFm dGVyIGVkaXRpbmcvaW5wdXQvY29jb2EvYXV0b2NvcnJlY3Qtb2ZmLmh0bWwKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5h Z2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUHJpdmF0ZUNsaWNrTWVhc3Vy ZW1lbnRNYW5hZ2VyLmNwcAppbmRleCA2YTYzNWQ4OWQ3NzMwODA4NTJjM2ExZGZmMWE4ZGU4NzZl YWU2MDczLi5hMjUzM2JmMjM4ZGM1NTE1MzdhZjZhZjk0NDE4ZjdlZTMyYjVhOTBjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1ByaXZhdGVDbGlja01lYXN1cmVtZW50 TWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Qcml2YXRlQ2xp Y2tNZWFzdXJlbWVudE1hbmFnZXIuY3BwCkBAIC00MTYsMTEgKzQxNiwxMSBAQCB2b2lkIFByaXZh dGVDbGlja01lYXN1cmVtZW50TWFuYWdlcjo6ZmlyZVBlbmRpbmdBdHRyaWJ1dGlvblJlcXVlc3Rz KCkKICAgICAgICAgYm9vbCBoYXNTZW50QXR0cmlidXRpb24gPSBmYWxzZTsKIAogICAgICAgICBm b3IgKGF1dG8mIGF0dHJpYnV0aW9uIDogYXR0cmlidXRpb25zKSB7Ci0gICAgICAgICAgICBzdGQ6 Om9wdGlvbmFsPFdhbGxUaW1lPiBlYXJsaWVzdFRpbWVUb1NlbmQgPSBhdHRyaWJ1dGlvbi50aW1l c1RvU2VuZCgpLmVhcmxpZXN0VGltZVRvU2VuZCgpOwotICAgICAgICAgICAgc3RkOjpvcHRpb25h bDxXZWJDb3JlOjpQcml2YXRlQ2xpY2tNZWFzdXJlbWVudDo6QXR0cmlidXRpb25SZXBvcnRFbmRw b2ludD4gYXR0cmlidXRpb25SZXBvcnRFbmRwb2ludCA9IGF0dHJpYnV0aW9uLnRpbWVzVG9TZW5k KCkuYXR0cmlidXRpb25SZXBvcnRFbmRwb2ludCgpOworICAgICAgICAgICAgYXV0byBlYXJsaWVz dFRpbWVUb1NlbmQgPSBhdHRyaWJ1dGlvbi50aW1lc1RvU2VuZCgpLmVhcmxpZXN0VGltZVRvU2Vu ZCgpOworICAgICAgICAgICAgYXV0byBhdHRyaWJ1dGlvblJlcG9ydEVuZHBvaW50ID0gYXR0cmli dXRpb24udGltZXNUb1NlbmQoKS5hdHRyaWJ1dGlvblJlcG9ydEVuZHBvaW50KCk7CiAKICAgICAg ICAgICAgIGlmICghZWFybGllc3RUaW1lVG9TZW5kIHx8ICFhdHRyaWJ1dGlvblJlcG9ydEVuZHBv aW50KSB7Ci0gICAgICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAg ICAgICAgLy8gQXR0cmlidXRpb24gaGFzIGFscmVhZHkgYmVlbiBzZW50LgogICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgfQogCg== 436579 2021-08-26 15:47:14 -0700 2021-08-27 09:30:54 -0700 Patch bug-229551-20210826154713.patch text/plain 1533 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDU0MGRlOWE1NWFhNTZlZWMyZDllNjE3YjY2NzUxYzY4 NGU1YmY5Ni4uMjc5ODZkZWEyOTk2NTYwMjRhMTA2ZTU4NzBkMzA5N2ZlZTllMmJlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTA4LTI2ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29t PgorCisgICAgICAgIFByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlcjo6ZmlyZVBlbmRpbmdB dHRyaWJ1dGlvblJlcXVlc3RzKCkgaXMgY3Jhc2hpbmcgaW4gZGVidWcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTU1MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHByZS1maWxsIHRoZSBQQ00gZGF0 YWJhc2Ugd2l0aCBkYXRhIGZvciB0aGlzIHRlc3QgYnV0IGRvbid0IGNsZWFyCisgICAgICAgIGl0 IG9uY2UgdGhlIHRlc3QgaXMgb3Zlci4gVGhpcyBjYXVzZXMgY3Jhc2hlcyBpbiBvdGhlciB0ZXN0 cy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUmVzb3VyY2VM b2FkU3RhdGlzdGljcy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA4LTI0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lP TiAocjI4MTQ3Myk6IFsgaU9TICYgTWFjT1MgXSBUZXN0V2ViS2l0QVBJLlByb2Nlc3NTd2FwLk5h dmlnYXRlVG9JbnZhbGlkVVJMIGlzIHRpbWluZyBvdXQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUmVzb3VyY2VMb2FkU3RhdGlzdGljcy5tbSBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUmVzb3VyY2VMb2FkU3RhdGlzdGlj cy5tbQppbmRleCBlYmMzNTI3ZWJjNWI4Y2Y1MzcxM2FkYmY1YjVhNDczYmJmYTBkODkzLi5mMzk3 NWY2ZDY2Y2MzN2JmNTQ1MmQxMDg3MTU0MzdkYzU1MzEwMzk1IDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Jlc291cmNlTG9hZFN0YXRpc3RpY3MubW0K KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXNvdXJjZUxvYWRT dGF0aXN0aWNzLm1tCkBAIC0xNDYwLDQgKzE0NjAsNyBAQCBURVNUKFJlc291cmNlTG9hZFN0YXRp c3RpY3MsIE1pZ3JhdGVEaXN0aW5jdERhdGFGcm9tVGFibGVXaXRoTWlzc2luZ0luZGV4ZXMpCiAg ICAgfV07CiAKICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmVGbGFnKTsKKyAgICAK KyAgICAvLyBDbGVhciBwcmUtZmlsbGVkIGRhdGFiYXNlLgorICAgIFtkZWZhdWx0RmlsZU1hbmFn ZXIgcmVtb3ZlSXRlbUF0UGF0aDppdHBSb290VVJMLnBhdGggZXJyb3I6bmlsXTsKIH0K