229518 2021-08-25 14:39:14 -0700 [iOS] Visual Look Up animates from the wrong rect when the web view is scaled 2021-08-25 18:22:37 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi darin hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1787324 0 wenson_hsieh 2021-08-25 14:39:14 -0700 rdar://82147473 1787325 1 436427 wenson_hsieh 2021-08-25 14:41:02 -0700 Created attachment 436427 Patch 1787330 2 436427 darin 2021-08-25 14:47:29 -0700 Comment on attachment 436427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436427&action=review > Source/WebKit/ChangeLog:14 > + Fix this by first converting `_visualSearchPreviewImageBounds` to window coordinates. And dropping the origin, using only the size? Is that correct. 1787336 3 436427 wenson_hsieh 2021-08-25 14:52:41 -0700 Comment on attachment 436427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436427&action=review >> Source/WebKit/ChangeLog:14 >> + Fix this by first converting `_visualSearchPreviewImageBounds` to window coordinates. > > And dropping the origin, using only the size? Is that correct. Yes, I believe this is correct. The `origin` of `outContentRect` is used to additionally offset the previewed item frame (in window coordinates), while the `size` replaces the size of the previewed item frame. In this case, `_visualSearchPreviewImageBounds` already provided the correct frame for the previewed item in the coordinate space of `sourceView` (WKContentView), so no additional offset is needed. 1787370 4 436427 wenson_hsieh 2021-08-25 16:11:52 -0700 Comment on attachment 436427 Patch Thanks for the review! 1787380 5 ews-feeder 2021-08-25 16:39:19 -0700 Committed r281599 (240960@main): <https://commits.webkit.org/240960@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436427. 436427 2021-08-25 14:41:02 -0700 2021-08-25 18:22:37 -0700 Patch bug-229518-20210825144101.patch text/plain 2142 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViMDNhNzc5ODJkMGM1NDk0 ZDkxOTI3Njk5MGEyYTFlMjU2NmY1MjIuLmI0ZjlkNTk2MGVlNWMzMTM5YzhhMzU5OGI5NTI1NThj MWVmNWI5YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDgtMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVmlzdWFsIExv b2sgVXAgYW5pbWF0ZXMgZnJvbSB0aGUgd3JvbmcgcmVjdCB3aGVuIHRoZSB3ZWIgdmlldyBpcyBz Y2FsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy OTUxOAorICAgICAgICByZGFyOi8vODIxNDc0NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGFkb3B0aW5nIFFMUHJldmlld0NvbnRyb2xsZXJE ZWxlZ2F0ZSdzIGFuaW1hdGVkIHRyYW5zaXRpb24gbWV0aG9kcyBmb3IgcmRhcjovLzc2MDIwMzQ5 LCBJIG1pc3Rha2VubHkKKyAgICAgICAgdGhvdWdodCB0aGF0IHRoZSBgb3V0Q29udGVudFJlY3Rg IHBhc3NlZCBpbnRvIGAtcHJldmlld0NvbnRyb2xsZXI6dHJhbnNpdGlvbkltYWdlRm9yUHJldmll d0l0ZW06Y29udGVudFJlY3Q6YAorICAgICAgICB3b3VsZCBiZSBpbiBzb3VyY2UgdmlldyAoV0tD b250ZW50VmlldykgY29vcmRpbmF0ZXM7IGluc3RlYWQsIFF1aWNrTG9vayBleHBlY3RzIHRoaXMg YGNvbnRlbnRSZWN0YCB0byBiZSBpbgorICAgICAgICB3aW5kb3cgY29vcmRpbmF0ZXMuCisKKyAg ICAgICAgRml4IHRoaXMgYnkgZmlyc3QgY29udmVydGluZyBgX3Zpc3VhbFNlYXJjaFByZXZpZXdJ bWFnZUJvdW5kc2AgdG8gd2luZG93IGNvb3JkaW5hdGVzLgorCisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgcHJldmlld0NvbnRyb2xsZXI6dHJhbnNpdGlvbkltYWdlRm9yUHJldmlld0l0ZW06Y29udGVu dFJlY3Q6XSk6CisKIDIwMjEtMDgtMjUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgaU9TLXNwZWNpZmljIGNvbXBpbGUtdGltZSBn dWFyZHMgdGhhdCBhcmUgbm8gbG9uZ2VyIG5lZWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggZWYxNGNm ODhmZGZjNWUwODY3MTVhNDAzNjZiMDUxNDBhZThkZDE0YS4uYmRiMzNiOTFmZGY3NDE3MGEyM2Fi NTQ0N2FkMmE4NDU0Y2U0ZDY1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC05OTU0LDcgKzk5NTQsNyBA QCAtIChDR1JlY3QpcHJldmlld0NvbnRyb2xsZXI6KFFMUHJldmlld0NvbnRyb2xsZXIgKiljb250 cm9sbGVyIGZyYW1lRm9yUHJldmlld0l0ZQogCiAtIChVSUltYWdlICopcHJldmlld0NvbnRyb2xs ZXI6KFFMUHJldmlld0NvbnRyb2xsZXIgKiljb250cm9sbGVyIHRyYW5zaXRpb25JbWFnZUZvclBy ZXZpZXdJdGVtOihpZCA8UUxQcmV2aWV3SXRlbT4paXRlbSBjb250ZW50UmVjdDooQ0dSZWN0ICop b3V0Q29udGVudFJlY3QKIHsKLSAgICAqb3V0Q29udGVudFJlY3QgPSBDR1JlY3QgeyBDR1BvaW50 WmVybywgX3Zpc3VhbFNlYXJjaFByZXZpZXdJbWFnZUJvdW5kcy5zaXplIH07CisgICAgKm91dENv bnRlbnRSZWN0ID0geyBDR1BvaW50WmVybywgW3NlbGYgY29udmVydFJlY3Q6X3Zpc3VhbFNlYXJj aFByZXZpZXdJbWFnZUJvdW5kcyB0b1ZpZXc6bmlsXS5zaXplIH07CiAgICAgcmV0dXJuIF92aXN1 YWxTZWFyY2hQcmV2aWV3SW1hZ2UuZ2V0KCk7CiB9CiAK