229491 2021-08-25 02:16:40 -0700 postprocess-asm/resolve-asm-file-conflicts.rb build failure with GCC 11.1.0 2021-08-30 09:07:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Linux RESOLVED DUPLICATE 228267 https://bugs.webkit.org/show_bug.cgi?id=223136 P2 Normal --- 1 aperez mcatanzaro angelos bugs-noreply mcatanzaro oldest_to_newest 1787117 0 aperez 2021-08-25 02:16:40 -0700 Today trying to build WebKitGTK 2.33.3 with GCC 11.1.0 this error was produced (reformatted for clarity): Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.s: Assembler messages: Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.s:114513: Error: file table slot 1 is already occupied by a different file (/home/aperez/webkitgtk-2.33.3/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp vs /home/aperez/webkitgtk-2.33.3/build-gtk//home/aperez/webkitgtk-2.33.3/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp) While this was building 2.33.3, currently the “resolve-asm-conflicts.rb” script is the same in trunk, so we have the issue there as well. I got past the issue with the following, but I think it's not a correct solution at all: --- /home/aperez/WebKit/Source/JavaScriptCore/Scripts/resolve-asm-file-conflicts.rb 2021-03-25 16:41:56.741540337 +0200 +++ ./Source/JavaScriptCore/Scripts/resolve-asm-file-conflicts.rb 2021-08-25 12:07:38.225428021 +0300 @@ -86,8 +87,10 @@ if not @s.eos? return ParseResultError.new("Expected end of line after #{ret2.str}") end - return ParseResultSuccess.new((Pathname.new(ret1.str) / ret2.str).cleanpath.to_s) + # return ParseResultSuccess.new((Pathname.new(ret1.str) / ret2.str).cleanpath.to_s) + return ParseResultSuccess.new(Pathname.new(ret1.str).cleanpath.to_s) end + def parse_string_literal if @s.scan(/"/).nil? err = "Expected string literal at `#{@s.string}` (pos #{@s.pos})" @@ -395,7 +399,7 @@ # First, make sure our tests still pass. This only takes a fraction of # our runtime and ensures the tests will get run by anyone trying out # changes to this file. -selftest +# selftest if ARGV.size != 2 $stderr.puts("Usage: #{$0} input output") 1787118 1 aperez 2021-08-25 02:17:43 -0700 The last time the script was touched was in bug #223136 so CC'ing Angelos in case he has some idea on how to go about this :) 1788504 2 mcatanzaro 2021-08-30 08:17:45 -0700 Unfortunately I didn't notice this because I had added -DGCC_OFFLINEASM_SOURCE_MAP=OFF to my build script in order to facilitate building. Now that I've removed it, I cannot build anymore due to this issue. I'm going to turn this option off for now in an unreviewed commit, to get the build working again for now. I'm bamboozled as to why this didn't break any Fedora or GNOME builds. 1788505 3 436773 mcatanzaro 2021-08-30 08:17:58 -0700 Created attachment 436773 Patch for landing 1788507 4 mcatanzaro 2021-08-30 08:19:29 -0700 Apparently it's already fixed in bug #228267. We just forgot to land that patch. *** This bug has been marked as a duplicate of bug 228267 *** 436773 2021-08-30 08:17:58 -0700 2021-08-30 09:07:14 -0700 Patch for landing bug-229491-20210830101757.patch text/plain 1439 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDZjNDBmMjM4YWI3N2RjZGJhZDE1NzA0N2QxODY0ZjU0NTlmNjIwM2MuLjcwY2E2MzA1OTkzNjU1 MWZmNzAyZGViNjA5NzhkOWQ0MWVlMWUwMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC05MSwxNCArOTEsOSBAQCBpZiAoREVCVUdfRklTU0lPTikKICAgICBzZXQoQ01BS0VfU0hBUkVE X0xJTktFUl9GTEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdTfSAtV2wsLS1nZGItaW5kZXgi KQogZW5kaWYgKCkKIAotc2V0KEdDQ19PRkZMSU5FQVNNX1NPVVJDRV9NQVBfREVGQVVMVCBPRkYp Ci1pZiAoQ01BS0VfQlVJTERfVFlQRSBTVFJFUVVBTCAiRGVidWciIE9SIENNQUtFX0JVSUxEX1RZ UEUgU1RSRVFVQUwgIlJlbFdpdGhEZWJJbmZvIikKLSAgICBzZXQoR0NDX09GRkxJTkVBU01fU09V UkNFX01BUF9ERUZBVUxUIE9OKQotZW5kaWYgKCkKLQogb3B0aW9uKEdDQ19PRkZMSU5FQVNNX1NP VVJDRV9NQVAKICAgIlByb2R1Y2UgZGVidWcgbGluZSBpbmZvcm1hdGlvbiBmb3Igb2ZmbGluZWFz bS1nZW5lcmF0ZWQgY29kZSIKLSAgJHtHQ0NfT0ZGTElORUFTTV9TT1VSQ0VfTUFQX0RFRkFVTFR9 KQorICBPRkYpCiAKIG9wdGlvbihVU0VfQVBQTEVfSUNVICJVc2UgQXBwbGUncyBpbnRlcm5hbCBJ Q1UiICR7QVBQTEV9KQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg MTU1YjczZTBlZjk5MzY5ZDExZTEwZDIzZTE4NzE2ZWJkODQxNzdjMC4uNzQ5NzY2Y2RjOGI4MTU3 YjQzMTc4YmUyZGFkNWQ4N2FmZjk2NGMwNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA4LTMwICBNaWNoYWVsIENhdGFuemFybyAg PG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQsIGRpc2FibGUgb2Zm bGluZWFzbSBzb3VyY2UgbWFwIGZvciBub3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyOTQ5MQorCisgICAgICAgIEl0IGJyZWFrcyB0aGUgYnVpbGQs IGFuZCByZXF1aXJlcyBmdXJ0aGVyIGludmVzdGlnYXRpb24gdG8gdW5kZXJzdGFuZC4KKworICAg ICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDIxLTA4LTI3ICBT dGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KIAogICAgICAgICBbUGxheVN0 YXRpb25dW0NNYWtlXSBBZGQgY29udHJvbCBvdmVyIHdoZXRoZXIgSmF2YVNjcmlwdENvcmUgc2hv dWxkIGJlIHNoYXJlZAo=