229484 2021-08-24 17:58:45 -0700 ImageBitmap::create(ScriptExecutionContext&, const IntSize&) is unused 2021-08-24 18:11:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 heycam heycam bfulgham cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim simon.fraser webkit-bug-importer zalan oldest_to_newest 1787038 0 heycam 2021-08-24 17:58:45 -0700 . 1787039 1 webkit-bug-importer 2021-08-24 17:59:13 -0700 <rdar://problem/82318976> 1787040 2 436356 heycam 2021-08-24 18:00:30 -0700 Created attachment 436356 Patch 1787042 3 436356 simon.fraser 2021-08-24 18:02:38 -0700 Comment on attachment 436356 Patch Wasn't this for ImageBitmap creation in workers? 1787044 4 heycam 2021-08-24 18:05:45 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 436356 [details] > Patch > > Wasn't this for ImageBitmap creation in workers? When it was originally added, OffscreenCanvas::transferToImageBitmap used it. But now that uses the other one (which takes an ImageBitmapBacking). 1787046 5 heycam 2021-08-24 18:09:26 -0700 Ah no I'm wrong, there's another current caller to it below in that same function. (Why did that not cause a build failure for me locally?) 1787047 6 436356 heycam 2021-08-24 18:10:56 -0700 Comment on attachment 436356 Patch Sorry for the noise. 436356 2021-08-24 18:00:30 -0700 2021-08-24 18:10:56 -0700 Patch bug-229484-20210825110028.patch text/plain 2069 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGVkOTg1ZTRhNjBkMDMw ODk2ZjdiYjVjZDEyNjMxYzhkNzkzNzZkNy4uMDhjMmZiZmU4MDM1MTU0NTQ0OGI4Y2UyZTAzNGEw NzQzZmE0YjVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTI0ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBJbWFnZUJpdG1hcDo6Y3JlYXRlIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk0ODQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgy MzE4OTc2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaHRtbC9JbWFnZUJpdG1hcC5jcHA6CisgICAgICAgICogaHRtbC9JbWFnZUJpdG1hcC5oOgor CiAyMDIxLTA4LTI0ICBDYW1lcm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CiAKICAg ICAgICAgV2luZG93cyBidWlsZCBmaXggYWZ0ZXIgcjI4MTQ3MApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdl Qml0bWFwLmNwcAppbmRleCA3NTY5NmE4NDliMDQ0MzBiZDgwMzk3NGY1ZjA2NTMyMjZlMzY5MGJm Li4wZjNjM2NhNGExMmIwN2ZlNGRlNzdhMTFjMThkYjQ0MTBkMmMxNjMzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0ltYWdlQml0bWFwLmNwcApAQCAtNjcsMTEgKzY3LDYgQEAgc3RhdGljIFJlbmRlcmluZ01v ZGUgYnVmZmVyUmVuZGVyaW5nTW9kZSA9IFJlbmRlcmluZ01vZGU6OkFjY2VsZXJhdGVkOwogc3Rh dGljIFJlbmRlcmluZ01vZGUgYnVmZmVyUmVuZGVyaW5nTW9kZSA9IFJlbmRlcmluZ01vZGU6OlVu YWNjZWxlcmF0ZWQ7CiAjZW5kaWYKIAotUmVmPEltYWdlQml0bWFwPiBJbWFnZUJpdG1hcDo6Y3Jl YXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIGNvbnN0 IEludFNpemUmIHNpemUpCi17Ci0gICAgcmV0dXJuIGNyZWF0ZSh7IGNyZWF0ZUltYWdlQnVmZmVy KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIHNpemUsIGJ1ZmZlclJlbmRlcmluZ01vZGUpIH0pOwot fQotCiBSZWY8SW1hZ2VCaXRtYXA+IEltYWdlQml0bWFwOjpjcmVhdGUoc3RkOjpvcHRpb25hbDxJ bWFnZUJpdG1hcEJhY2tpbmc+JiYgYmFja2luZ1N0b3JlKQogewogICAgIHJldHVybiBhZG9wdFJl ZigqbmV3IEltYWdlQml0bWFwKFdURk1vdmUoYmFja2luZ1N0b3JlKSkpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9J bWFnZUJpdG1hcC5oCmluZGV4IDAyYjdmMTVjZWQ5Yzc0ZmM2MmZkZjVlYTE2ZTkxNmI2ZjYzMzdh OWYuLmRjYzBiMDIzZGZkYzQxYjI3ZmMzYjcxNWJjYjI0NTlkNWY1MmE0YTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VCaXRtYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0ltYWdlQml0bWFwLmgKQEAgLTg0LDcgKzg0LDYgQEAgcHVibGljOgogCiAgICAgc3RhdGlj IFJlZlB0cjxJbWFnZUJ1ZmZlcj4gY3JlYXRlSW1hZ2VCdWZmZXIoU2NyaXB0RXhlY3V0aW9uQ29u dGV4dCYsIGNvbnN0IEZsb2F0U2l6ZSYsIFJlbmRlcmluZ01vZGUsIGZsb2F0IHJlc29sdXRpb25T Y2FsZSA9IDEpOwogCi0gICAgc3RhdGljIFJlZjxJbWFnZUJpdG1hcD4gY3JlYXRlKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQmLCBjb25zdCBJbnRTaXplJik7CiAgICAgc3RhdGljIFJlZjxJbWFnZUJp dG1hcD4gY3JlYXRlKHN0ZDo6b3B0aW9uYWw8SW1hZ2VCaXRtYXBCYWNraW5nPiYmKTsKIAogICAg IH5JbWFnZUJpdG1hcCgpOwo=