229480 2021-08-24 17:07:39 -0700 removeFromTopLayer shouldn't be called in every removal of an element 2021-08-25 00:59:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229488 1 rniwa rniwa cdumez changseok cmarcelo esprehn+autocc ews-watchlist gyuyoung.kim kangil.han simon.fraser webkit-bug-importer oldest_to_newest 1787016 0 rniwa 2021-08-24 17:07:39 -0700 removeFromTopLayer shouldn't be called in every removal of an element 1787018 1 436350 rniwa 2021-08-24 17:09:39 -0700 Created attachment 436350 Move the call to HTMLDialogElement 1787021 2 436351 rniwa 2021-08-24 17:21:52 -0700 Created attachment 436351 Move the call to HTMLDialogElement 1787026 3 436351 simon.fraser 2021-08-24 17:31:14 -0700 Comment on attachment 436351 Move the call to HTMLDialogElement View in context: https://bugs.webkit.org/attachment.cgi?id=436351&action=review > Source/WebCore/ChangeLog:9 > + the only place where top layer is currenlty used. "currenlty" 1787034 4 rniwa 2021-08-24 17:48:53 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 436351 [details] > Move the call to HTMLDialogElement > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436351&action=review > > > Source/WebCore/ChangeLog:9 > > + the only place where top layer is currenlty used. > > "currenlty" Fixed. Thanks. 1787085 5 436351 rniwa 2021-08-24 23:07:06 -0700 Comment on attachment 436351 Move the call to HTMLDialogElement Clearing flags on attachment: 436351 Committed r281548 (240915@main): <https://commits.webkit.org/240915@main> 1787086 6 rniwa 2021-08-24 23:07:09 -0700 All reviewed patches have been landed. Closing bug. 1787087 7 webkit-bug-importer 2021-08-24 23:08:17 -0700 <rdar://problem/82326535> 436350 2021-08-24 17:09:39 -0700 2021-08-24 17:26:38 -0700 Move the call to HTMLDialogElement bug-229480-20210824170938.patch text/plain 2979 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUzNmNlOTIwMzE5MTg2 NTIzMWEzZDRjMjUzNTYyYTRkY2NjM2EzNC4uZjM2NTVjMTk0YzM2NDYwN2YwODBjMDkzYjU3MTdi ZWJlOTY3ZjIwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA4LTI0ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHJlbW92ZUZyb21Ub3BMYXll ciBzaG91bGRuJ3QgYmUgY2FsbGVkIGluIGV2ZXJ5IHJlbW92YWwgb2YgYW4gZWxlbWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbCBpdCBpbiBI VE1MRGlhbG9nRWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3RvciBmb3Igbm93IHNpbmNlIHRoYXQn cworICAgICAgICB0aGUgb25seSBwbGFjZSB3aGVyZSB0b3AgbGF5ZXIgaXMgY3VycmVubHR5IHVz ZWQuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVt ZW50OjpyZW1vdmVkRnJvbUFuY2VzdG9yKToKKyAgICAgICAgKiBodG1sL0hUTUxEaWFsb2dFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dFbGVtZW50OjpyZW1vdmVkRnJv bUFuY2VzdG9yKTogQWRkZWQuCisgICAgICAgICogaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5oOgor CiAyMDIxLTA4LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg Y2hhbmdlIGV2ZW50IGlzIGRpc3BhdGNoZWQgd2hlbiAuZmlsZXMgcHJvcGVydHkgaXMgc2V0IGF0 IDxpbnB1dCB0eXBlPSJmaWxlIj4gZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IGRj NzU1MDM3ZDdkY2IyOGFjYjU3YzlkZGVmYmU4ZGJlMTEwZGRjMzcuLjBlZTg4MDJmMGFhZTI5NzEz ZjA4MjIyMDQ2YWQ2MGJiMjE2Y2FlNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTIyNTAs OCArMjI1MCw2IEBAIE5vZGU6Okluc2VydGVkSW50b0FuY2VzdG9yUmVzdWx0IEVsZW1lbnQ6Omlu c2VydGVkSW50b0FuY2VzdG9yKEluc2VydGlvblR5cGUgaW5zCiAKIHZvaWQgRWxlbWVudDo6cmVt b3ZlZEZyb21BbmNlc3RvcihSZW1vdmFsVHlwZSByZW1vdmFsVHlwZSwgQ29udGFpbmVyTm9kZSYg b2xkUGFyZW50T2ZSZW1vdmVkVHJlZSkKIHsKLSAgICBkb2N1bWVudCgpLnJlbW92ZUZyb21Ub3BM YXllcigqdGhpcyk7Ci0KICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAgICAgaWYgKGNvbnRh aW5zRnVsbFNjcmVlbkVsZW1lbnQoKSkKICAgICAgICAgc2V0Q29udGFpbnNGdWxsU2NyZWVuRWxl bWVudE9uQW5jZXN0b3JzQ3Jvc3NpbmdGcmFtZUJvdW5kYXJpZXMoZmFsc2UpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcAppbmRleCAyNjE4MmZmYmU2NjE3MzM2Y2Q1 MjQ1M2U3MWIzZTNkZmU4YjhkOTRkLi5lMzMyNzUwMDU0ZGEyNjU5NGNkNzNlYTY2ODY3YzBhYjZm ZTU5MWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcApAQCAt OTUsNiArOTUsMTMgQEAgdm9pZCBIVE1MRGlhbG9nRWxlbWVudDo6Y2xvc2UoY29uc3QgU3RyaW5n JiByZXN1bHQpCiAgICAgfSk7CiB9CiAKK3ZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnJlbW92ZWRG cm9tQW5jZXN0b3IoUmVtb3ZhbFR5cGUgcmVtb3ZhbFR5cGUsIENvbnRhaW5lck5vZGUmIG9sZFBh cmVudE9mUmVtb3ZlZFRyZWUpIGZpbmFsCit7CisgICAgSFRNTEVsZW1lbnQ6OnJlbW92ZWRGcm9t QW5jZXN0b3IocmVtb3ZhbFR5cGUsIG9sZFBhcmVudE9mUmVtb3ZlZFRyZWUpOworICAgIGlmIChp c0luVG9wTGF5ZXIoKSkKKyAgICAgICAgZG9jdW1lbnQoKS5yZW1vdmVGcm9tVG9wTGF5ZXIoKnRo aXMpOworfQorCiB2b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpxdWV1ZUNhbmNlbFRhc2soKQogewog ICAgIGRvY3VtZW50KCkuZXZlbnRMb29wKCkucXVldWVUYXNrKFRhc2tTb3VyY2U6OlVzZXJJbnRl cmFjdGlvbiwgW3Byb3RlY3RlZFRoaXMgPSBHQ1JlYWNoYWJsZVJlZiB7ICp0aGlzIH1dIHsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaAppbmRleCAxOTZhZGFlODUyODM2YTYz MDI1OGY0YTNmMmY5NWRkODA0NjhhOTRiLi40NzFhNmIzZGRjZWY2NDE4MGFkMjQ1MzVlMjg0NjU2 MGZlY2VkNjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVt ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5oCkBAIC01 MCw2ICs1MCw4IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgSFRNTERpYWxvZ0VsZW1lbnQoY29u c3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50Jik7CiAKKyAgICB2b2lkIHJlbW92ZWRGcm9tQW5j ZXN0b3IoUmVtb3ZhbFR5cGUsIENvbnRhaW5lck5vZGUmIG9sZFBhcmVudE9mUmVtb3ZlZFRyZWUp IGZpbmFsOworCiAgICAgU3RyaW5nIG1fcmV0dXJuVmFsdWU7CiAgICAgYm9vbCBtX2lzTW9kYWwg eyBmYWxzZSB9OwogfTsK 436351 2021-08-24 17:21:52 -0700 2021-08-24 23:07:06 -0700 Move the call to HTMLDialogElement bug-229480-20210824172151.patch text/plain 2973 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUzNmNlOTIwMzE5MTg2 NTIzMWEzZDRjMjUzNTYyYTRkY2NjM2EzNC4uZjM2NTVjMTk0YzM2NDYwN2YwODBjMDkzYjU3MTdi ZWJlOTY3ZjIwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA4LTI0ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHJlbW92ZUZyb21Ub3BMYXll ciBzaG91bGRuJ3QgYmUgY2FsbGVkIGluIGV2ZXJ5IHJlbW92YWwgb2YgYW4gZWxlbWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbCBpdCBpbiBI VE1MRGlhbG9nRWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3RvciBmb3Igbm93IHNpbmNlIHRoYXQn cworICAgICAgICB0aGUgb25seSBwbGFjZSB3aGVyZSB0b3AgbGF5ZXIgaXMgY3VycmVubHR5IHVz ZWQuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVt ZW50OjpyZW1vdmVkRnJvbUFuY2VzdG9yKToKKyAgICAgICAgKiBodG1sL0hUTUxEaWFsb2dFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dFbGVtZW50OjpyZW1vdmVkRnJv bUFuY2VzdG9yKTogQWRkZWQuCisgICAgICAgICogaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5oOgor CiAyMDIxLTA4LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg Y2hhbmdlIGV2ZW50IGlzIGRpc3BhdGNoZWQgd2hlbiAuZmlsZXMgcHJvcGVydHkgaXMgc2V0IGF0 IDxpbnB1dCB0eXBlPSJmaWxlIj4gZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IGRj NzU1MDM3ZDdkY2IyOGFjYjU3YzlkZGVmYmU4ZGJlMTEwZGRjMzcuLjBlZTg4MDJmMGFhZTI5NzEz ZjA4MjIyMDQ2YWQ2MGJiMjE2Y2FlNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTIyNTAs OCArMjI1MCw2IEBAIE5vZGU6Okluc2VydGVkSW50b0FuY2VzdG9yUmVzdWx0IEVsZW1lbnQ6Omlu c2VydGVkSW50b0FuY2VzdG9yKEluc2VydGlvblR5cGUgaW5zCiAKIHZvaWQgRWxlbWVudDo6cmVt b3ZlZEZyb21BbmNlc3RvcihSZW1vdmFsVHlwZSByZW1vdmFsVHlwZSwgQ29udGFpbmVyTm9kZSYg b2xkUGFyZW50T2ZSZW1vdmVkVHJlZSkKIHsKLSAgICBkb2N1bWVudCgpLnJlbW92ZUZyb21Ub3BM YXllcigqdGhpcyk7Ci0KICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAgICAgaWYgKGNvbnRh aW5zRnVsbFNjcmVlbkVsZW1lbnQoKSkKICAgICAgICAgc2V0Q29udGFpbnNGdWxsU2NyZWVuRWxl bWVudE9uQW5jZXN0b3JzQ3Jvc3NpbmdGcmFtZUJvdW5kYXJpZXMoZmFsc2UpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcAppbmRleCAyNjE4MmZmYmU2NjE3MzM2Y2Q1 MjQ1M2U3MWIzZTNkZmU4YjhkOTRkLi4zYzBhYmYzYTRlZTc3NTlmMTc0OTM4NDE5ODc1M2I0Zjdk OTMzMDNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcApAQCAt OTUsNiArOTUsMTMgQEAgdm9pZCBIVE1MRGlhbG9nRWxlbWVudDo6Y2xvc2UoY29uc3QgU3RyaW5n JiByZXN1bHQpCiAgICAgfSk7CiB9CiAKK3ZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnJlbW92ZWRG cm9tQW5jZXN0b3IoUmVtb3ZhbFR5cGUgcmVtb3ZhbFR5cGUsIENvbnRhaW5lck5vZGUmIG9sZFBh cmVudE9mUmVtb3ZlZFRyZWUpCit7CisgICAgSFRNTEVsZW1lbnQ6OnJlbW92ZWRGcm9tQW5jZXN0 b3IocmVtb3ZhbFR5cGUsIG9sZFBhcmVudE9mUmVtb3ZlZFRyZWUpOworICAgIGlmIChpc0luVG9w TGF5ZXIoKSkKKyAgICAgICAgZG9jdW1lbnQoKS5yZW1vdmVGcm9tVG9wTGF5ZXIoKnRoaXMpOwor fQorCiB2b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpxdWV1ZUNhbmNlbFRhc2soKQogewogICAgIGRv Y3VtZW50KCkuZXZlbnRMb29wKCkucXVldWVUYXNrKFRhc2tTb3VyY2U6OlVzZXJJbnRlcmFjdGlv biwgW3Byb3RlY3RlZFRoaXMgPSBHQ1JlYWNoYWJsZVJlZiB7ICp0aGlzIH1dIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaAppbmRleCAxOTZhZGFlODUyODM2YTYzMDI1OGY0 YTNmMmY5NWRkODA0NjhhOTRiLi40NzFhNmIzZGRjZWY2NDE4MGFkMjQ1MzVlMjg0NjU2MGZlY2Vk NjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmgK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5oCkBAIC01MCw2ICs1 MCw4IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgSFRNTERpYWxvZ0VsZW1lbnQoY29uc3QgUXVh bGlmaWVkTmFtZSYsIERvY3VtZW50Jik7CiAKKyAgICB2b2lkIHJlbW92ZWRGcm9tQW5jZXN0b3Io UmVtb3ZhbFR5cGUsIENvbnRhaW5lck5vZGUmIG9sZFBhcmVudE9mUmVtb3ZlZFRyZWUpIGZpbmFs OworCiAgICAgU3RyaW5nIG1fcmV0dXJuVmFsdWU7CiAgICAgYm9vbCBtX2lzTW9kYWwgeyBmYWxz ZSB9OwogfTsK