229479 2021-08-24 17:01:37 -0700 testb3_6 should be using JSSwitchPtrTag instead of JITCompilationPtrTag. 2021-08-24 17:08:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1787009 0 mark.lam 2021-08-24 17:01:37 -0700 This is in testInterpreter() which is emitting code for a jump table. JSSwitchPtrTag is the right tag to use here. 1787011 1 webkit-bug-importer 2021-08-24 17:02:21 -0700 <rdar://problem/82316967> 1787013 2 436349 mark.lam 2021-08-24 17:04:28 -0700 Created attachment 436349 proposed patch. 1787014 3 436349 ysuzuki 2021-08-24 17:05:45 -0700 Comment on attachment 436349 proposed patch. r=me 1787017 4 mark.lam 2021-08-24 17:08:57 -0700 Thanks for the review. Landed in r281534: <http://trac.webkit.org/r281534>. 436349 2021-08-24 17:04:28 -0700 2021-08-24 17:05:45 -0700 proposed patch. bug-229479.patch text/plain 2698 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgxNTMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDIxLTA4LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICB0 ZXN0YjNfNiBzaG91bGQgYmUgdXNpbmcgSlNTd2l0Y2hQdHJUYWcgaW5zdGVhZCBvZiBKSVRDb21w aWxhdGlvblB0clRhZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyOTQ3OQorICAgICAgICByZGFyOi8vODIzMTY5NjcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGluIHRlc3RJbnRlcnByZXRl cigpIHdoaWNoIGlzIGVtaXR0aW5nIGNvZGUgZm9yIGEganVtcCB0YWJsZS4KKyAgICAgICAgSlNT d2l0Y2hQdHJUYWcgaXMgdGhlIHJpZ2h0IHRhZyB0byB1c2UgaGVyZS4KKworICAgICAgICAqIGIz L3Rlc3RiM182LmNwcDoKKyAgICAgICAgKHRlc3RJbnRlcnByZXRlcik6CisKIDIwMjEtMDgtMjQg IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGZv ci1pbiBPd25TdHJ1Y3R1cmVNb2RlIG9wdGltaXphdGlvbnMgdG8gTExJbnQKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfNi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2IzL3Rlc3RiM182LmNwcAkocmV2aXNpb24gMjgxNDk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM182LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsx LDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAyMSBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTE2Nzcs MTkgKzE2NzcsMTkgQEAgdm9pZCB0ZXN0SW50ZXJwcmV0ZXIoKQogICAgICAgICAgICAgQWxsb3dN YWNyb1NjcmF0Y2hSZWdpc3RlclVzYWdlIGFsbG93U2NyYXRjaChqaXQpOwogICAgICAgICAgICAg VmVjdG9yPEJveDxDQ2FsbEhlbHBlcnM6OkxhYmVsPj4gbGFiZWxzID0gcGFyYW1zLnN1Y2Nlc3Nv ckxhYmVscygpOwogCi0gICAgICAgICAgICBNYWNyb0Fzc2VtYmxlckNvZGVQdHI8SklUQ29tcGls YXRpb25QdHJUYWc+KiBqdW1wVGFibGUgPSBiaXR3aXNlX2Nhc3Q8TWFjcm9Bc3NlbWJsZXJDb2Rl UHRyPEpJVENvbXBpbGF0aW9uUHRyVGFnPio+KAotICAgICAgICAgICAgICAgIHBhcmFtcy5wcm9j KCkuYWRkRGF0YVNlY3Rpb24oc2l6ZW9mKE1hY3JvQXNzZW1ibGVyQ29kZVB0cjxKSVRDb21waWxh dGlvblB0clRhZz4pICogbGFiZWxzLnNpemUoKSkpOworICAgICAgICAgICAgTWFjcm9Bc3NlbWJs ZXJDb2RlUHRyPEpTU3dpdGNoUHRyVGFnPioganVtcFRhYmxlID0gYml0d2lzZV9jYXN0PE1hY3Jv QXNzZW1ibGVyQ29kZVB0cjxKU1N3aXRjaFB0clRhZz4qPigKKyAgICAgICAgICAgICAgICBwYXJh bXMucHJvYygpLmFkZERhdGFTZWN0aW9uKHNpemVvZihNYWNyb0Fzc2VtYmxlckNvZGVQdHI8SlNT d2l0Y2hQdHJUYWc+KSAqIGxhYmVscy5zaXplKCkpKTsKIAogICAgICAgICAgICAgR1BSUmVnIHNj cmF0Y2ggPSBwYXJhbXMuZ3BTY3JhdGNoKDApOwogCiAgICAgICAgICAgICBqaXQubW92ZShDQ2Fs bEhlbHBlcnM6OlRydXN0ZWRJbW1QdHIoanVtcFRhYmxlKSwgc2NyYXRjaCk7CiAgICAgICAgICAg ICBqaXQubG9hZDY0KENDYWxsSGVscGVyczo6QmFzZUluZGV4KHNjcmF0Y2gsIHBhcmFtc1swXS5n cHIoKSwgQ0NhbGxIZWxwZXJzOjpTY2FsZVB0ciksIHNjcmF0Y2gpOwotICAgICAgICAgICAgaml0 LmZhckp1bXAoc2NyYXRjaCwgSklUQ29tcGlsYXRpb25QdHJUYWcpOworICAgICAgICAgICAgaml0 LmZhckp1bXAoc2NyYXRjaCwgSlNTd2l0Y2hQdHJUYWcpOwogCiAgICAgICAgICAgICBqaXQuYWRk TGlua1Rhc2soCiAgICAgICAgICAgICAgICAgWyYsIGp1bXBUYWJsZSwgbGFiZWxzXSAoTGlua0J1 ZmZlciYgbGlua0J1ZmZlcikgewogICAgICAgICAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkg PSBsYWJlbHMuc2l6ZSgpOyBpLS07KQotICAgICAgICAgICAgICAgICAgICAgICAganVtcFRhYmxl W2ldID0gbGlua0J1ZmZlci5sb2NhdGlvbk9mPEpJVENvbXBpbGF0aW9uUHRyVGFnPigqbGFiZWxz W2ldKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGp1bXBUYWJsZVtpXSA9IGxpbmtCdWZmZXIu bG9jYXRpb25PZjxKU1N3aXRjaFB0clRhZz4oKmxhYmVsc1tpXSk7CiAgICAgICAgICAgICAgICAg fSk7CiAgICAgICAgIH0pOwogCg==