229464 2021-08-24 12:52:11 -0700 [kill-old-processes] Hardcode directory for stale simulator files 2021-08-24 14:04:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu jenner slewis webkit-bug-importer oldest_to_newest 1786894 0 jbedard 2021-08-24 12:52:11 -0700 When run under sudo, kill-old-prosess has an incorrect temporary directory path. We need to hard-code /var/folders and use maxdepth 4 to find the right set of files to delete. 1786895 1 jbedard 2021-08-24 12:52:36 -0700 <rdar://problem/82148711> 1786896 2 436321 jbedard 2021-08-24 12:55:11 -0700 Created attachment 436321 Patch 1786897 3 436321 slewis 2021-08-24 12:57:55 -0700 Comment on attachment 436321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436321&action=review > Tools/ChangeLog:9 > + * CISupport/kill-old-processes: should probably add a comment explaining why hardcoding is necessary 1786898 4 slewis 2021-08-24 12:58:19 -0700 I r+ed but did you try sudo -u? I think that would be a more correct solution 1786902 5 jbedard 2021-08-24 13:04:49 -0700 (In reply to Stephanie Lewis from comment #4) > I r+ed but did you try sudo -u? I think that would be a more correct solution I didn't, but also, `sudo -u` is a more difficult solution to this particular problem, because it's Buildbot that's invoking this script with sudo, so we would need a Buildbot restart. 1786903 6 436323 jbedard 2021-08-24 13:07:14 -0700 Created attachment 436323 Patch 1786920 7 ews-feeder 2021-08-24 14:04:15 -0700 Committed r281515 (240888@main): <https://commits.webkit.org/240888@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436323. 436321 2021-08-24 12:55:11 -0700 2021-08-24 13:07:12 -0700 Patch bug-229464-20210824125510.patch text/plain 1773 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MTUxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA4LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBba2lsbC1vbGQtcHJvY2Vzc2VzXSBIYXJkY29kZSBkaXJlY3RvcnkgZm9y IHN0YWxlIHNpbXVsYXRvciBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI5NDY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MjE0ODcxMT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3Vw cG9ydC9raWxsLW9sZC1wcm9jZXNzZXM6CisgICAgICAgIChtYWluKToKKwogMjAyMS0wOC0yNCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIyODE0NzMpOiBbIGlPUyAmIE1hY09TIF0gVGVzdFdlYktpdEFQSS5Qcm9jZXNz U3dhcC5OYXZpZ2F0ZVRvSW52YWxpZFVSTCBpcyB0aW1pbmcgb3V0CkluZGV4OiBUb29scy9DSVN1 cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9r aWxsLW9sZC1wcm9jZXNzZXMJKHJldmlzaW9uIDI4MTUxMykKKysrIFRvb2xzL0NJU3VwcG9ydC9r aWxsLW9sZC1wcm9jZXNzZXMJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcgKzI4LDYgQEAgaW1wb3J0 IG9zLCBzeXMKIGltcG9ydCBnZXRwYXNzCiBpbXBvcnQgcmUKIGltcG9ydCBzdWJwcm9jZXNzCi1p bXBvcnQgdGVtcGZpbGUKIAogZGVmIGxpc3RBbGxXZWJLaXRQcm9ncmFtcyhidWlsZGRpcl9iaW4p OgogICAgIGZvdW5kV2ViS2l0UHJvZ3JhbXMgPSBbXQpAQCAtMTc0LDcgKzE3Myw3IEBAIGRlZiBt YWluKHVzZXI9Tm9uZSk6CiAgICAgICAgICMgS2lsbCBhbGwgaW5zdGFuY2VzIG9mIHB5dGhvbiBl eGVjdXRpbmcgcnVuLXdlYmtpdC10ZXN0cwogICAgICAgICBvcy5zeXN0ZW0oInBzIGF1eCB8IGdy ZXAgLUUgJy4rL1B5dGhvbiAuKyhydW5fd2Via2l0X3Rlc3RzfHJ1bi13ZWJraXQtdGVzdHN8bW9k X3B5d2Vic29ja2V0KScgfCBncmVwIC12IGdyZXAgfCBhd2sgJ3twcmludCAkMn0nIHwgeGFyZ3Mg a2lsbCIpCiAgICAgICAgICMgRklYTUU6IDxyZGFyOi8vcHJvYmxlbS84MTQ3NjU0Nj4gUmVtb3Zl IHN0YWxlIHNpbXVsYXRvciB0ZW1wIGZpbGVzCi0gICAgICAgIG9zLnN5c3RlbSgnZmluZCB7fSAt bmFtZSAiRGVsZXRpbmctKiIgLW1heGRlcHRoIDEgLWV4ZWMgc3VkbyBybSAtcmYge3t9fSArJy5m b3JtYXQodGVtcGZpbGUuZ2V0dGVtcGRpcigpKSkKKyAgICAgICAgb3Muc3lzdGVtKCdmaW5kIC92 YXIvZm9sZGVycyAtbmFtZSAiRGVsZXRpbmctKiIgLW1heGRlcHRoIDQgLWV4ZWMgc3VkbyBybSAt cmYge30gKycpCiAgICAgZWxpZiBzeXMucGxhdGZvcm0gPT0gJ2N5Z3dpbicgb3Igc3lzLnBsYXRm b3JtID09ICd3aW4zMic6CiAgICAgICAgIGZvciB0YXNrIGluIHRhc2tzVG9LaWxsICsgdGFza3NU b0tpbGxXaW46CiAgICAgICAgICAgICBvcy5zeXN0ZW0oInRhc2traWxsIC90IC9mIC9pbSAiICsg dGFzaykK 436323 2021-08-24 13:07:14 -0700 2021-08-24 14:04:15 -0700 Patch bug-229464-20210824130713.patch text/plain 1882 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MTUxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA4LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBba2lsbC1vbGQtcHJvY2Vzc2VzXSBIYXJkY29kZSBkaXJlY3RvcnkgZm9y IHN0YWxlIHNpbXVsYXRvciBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI5NDY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MjE0ODcxMT4K KworICAgICAgICBSZXZpZXdlZCBieSBTdGVwaGFuaWUgTGV3aXMuCisKKyAgICAgICAgKiBDSVN1 cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzOgorICAgICAgICAobWFpbik6CisKIDIwMjEtMDgtMjQg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMjgxNDczKTogWyBpT1MgJiBNYWNPUyBdIFRlc3RXZWJLaXRBUEkuUHJvY2Vz c1N3YXAuTmF2aWdhdGVUb0ludmFsaWRVUkwgaXMgdGltaW5nIG91dApJbmRleDogVG9vbHMvQ0lT dXBwb3J0L2tpbGwtb2xkLXByb2Nlc3Nlcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQv a2lsbC1vbGQtcHJvY2Vzc2VzCShyZXZpc2lvbiAyODE1MTMpCisrKyBUb29scy9DSVN1cHBvcnQv a2lsbC1vbGQtcHJvY2Vzc2VzCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw3ICsyOCw2IEBAIGltcG9y dCBvcywgc3lzCiBpbXBvcnQgZ2V0cGFzcwogaW1wb3J0IHJlCiBpbXBvcnQgc3VicHJvY2Vzcwot aW1wb3J0IHRlbXBmaWxlCiAKIGRlZiBsaXN0QWxsV2ViS2l0UHJvZ3JhbXMoYnVpbGRkaXJfYmlu KToKICAgICBmb3VuZFdlYktpdFByb2dyYW1zID0gW10KQEAgLTE3NCw3ICsxNzMsOCBAQCBkZWYg bWFpbih1c2VyPU5vbmUpOgogICAgICAgICAjIEtpbGwgYWxsIGluc3RhbmNlcyBvZiBweXRob24g ZXhlY3V0aW5nIHJ1bi13ZWJraXQtdGVzdHMKICAgICAgICAgb3Muc3lzdGVtKCJwcyBhdXggfCBn cmVwIC1FICcuKy9QeXRob24gLisocnVuX3dlYmtpdF90ZXN0c3xydW4td2Via2l0LXRlc3RzfG1v ZF9weXdlYnNvY2tldCknIHwgZ3JlcCAtdiBncmVwIHwgYXdrICd7cHJpbnQgJDJ9JyB8IHhhcmdz IGtpbGwiKQogICAgICAgICAjIEZJWE1FOiA8cmRhcjovL3Byb2JsZW0vODE0NzY1NDY+IFJlbW92 ZSBzdGFsZSBzaW11bGF0b3IgdGVtcCBmaWxlcwotICAgICAgICBvcy5zeXN0ZW0oJ2ZpbmQge30g LW5hbWUgIkRlbGV0aW5nLSoiIC1tYXhkZXB0aCAxIC1leGVjIHN1ZG8gcm0gLXJmIHt7fX0gKycu Zm9ybWF0KHRlbXBmaWxlLmdldHRlbXBkaXIoKSkpCisgICAgICAgICMgSGFyZC1jb2RlIHBhdGgg YmVjYXVzZSB3aGVuIHJ1biB3aXRoICdzdWRvLCcgdGhpcyBzY3JpcHQgZG9lc24ndCBnZXQgdGhl IHJpZ2h0IHRlbXBmaWxlIGxvY2F0aW9uCisgICAgICAgIG9zLnN5c3RlbSgnZmluZCAvdmFyL2Zv bGRlcnMgLW5hbWUgIkRlbGV0aW5nLSoiIC1tYXhkZXB0aCA0IC1leGVjIHN1ZG8gcm0gLXJmIHt9 ICsnKQogICAgIGVsaWYgc3lzLnBsYXRmb3JtID09ICdjeWd3aW4nIG9yIHN5cy5wbGF0Zm9ybSA9 PSAnd2luMzInOgogICAgICAgICBmb3IgdGFzayBpbiB0YXNrc1RvS2lsbCArIHRhc2tzVG9LaWxs V2luOgogICAgICAgICAgICAgb3Muc3lzdGVtKCJ0YXNra2lsbCAvdCAvZiAvaW0gIiArIHRhc2sp Cg==