22946 2008-12-20 03:43:07 -0800 [Patch] QWebPage/QWebView::selectAll to select all content 2011-01-05 05:06:19 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 50049 0 uwolfer webkit-unassigned hausmann oldest_to_newest 103070 0 uwolfer 2008-12-20 03:43:07 -0800 The attached patch adds functions to select all content of a QWebPage. There is also a helper function in QWebView to select the content. API docs added as well (assuming it will go into Qt 4.6; though I see no problems to add it to 4.5 since the changes are really straight forward.) 103071 1 26167 uwolfer 2008-12-20 03:47:52 -0800 Created attachment 26167 Patch to add QWebPage/QWebView::selectAll 106942 2 26167 hausmann 2009-01-25 07:03:31 -0800 Comment on attachment 26167 Patch to add QWebPage/QWebView::selectAll I agree that the change is straight forward, and it looks correct. But I think this should be a function of QWebFrame only, not QWebPage or QWebView, because the selection is a property of a frame. In a HTML frameset with many frames each frame has its own selection. 106945 3 27018 uwolfer 2009-01-25 08:19:49 -0800 Created attachment 27018 Updated patch as suggested by Simon 106948 4 27020 uwolfer 2009-01-25 09:17:14 -0800 Created attachment 27020 Updated as discussed with Simon on IRC 106950 5 27020 hausmann 2009-01-25 09:28:42 -0800 Comment on attachment 27020 Updated as discussed with Simon on IRC r=me 106951 6 hausmann 2009-01-25 09:29:33 -0800 Landed in r40228 26167 2008-12-20 03:47:52 -0800 2009-01-25 07:03:31 -0800 Patch to add QWebPage/QWebView::selectAll qt-selectall.patch text/plain 2563 uwolfer SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzk0MjMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMTItMjAgIFVycyBXb2xmZXIgIDx1d29sZmVyQGtk ZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgZnVuY3Rpb25zIHRvIHNlbGVjdCBhbGwgY29udGVudCBvZiBhIFFXZWJWaWV3L1FXZWJQ YWdlLgorCisgICAgICAgIEFkZGVkIFFXZWJQYWdlL1FXZWJWaWV3OjpzZWxlY3RBbGwuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTQ2CisKKyAg ICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2U6OnNlbGVjdEFsbCk6 CisgICAgICAgICogQXBpL3F3ZWJwYWdlLmg6CisgICAgICAgICogQXBpL3F3ZWJ2aWV3LmNwcDoK KyAgICAgICAgKFFXZWJWaWV3OjpzZWxlY3RBbGwpOgorICAgICAgICAqIEFwaS9xd2Vidmlldy5o OgorCiAyMDA4LTEyLTE5ICBKYWRlIEhhbiA8amFkZS5oYW5Abm9raWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJw YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkocmV2aXNp b24gMzk0MjMpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjQwMyw2ICsyNDAzLDE1IEBAIHF1aW50NjQgUVdlYlBhZ2U6OmJ5dGVzUmVjZWl2ZWQoKSBj b25zdCAKIH0KIAogLyohCisgICAgU2VsZWN0cyBhbGwgY29udGVudC4KKyAgICBcc2luY2UgNC42 CisqLwordm9pZCBRV2ViUGFnZTo6c2VsZWN0QWxsKCkKK3sKKyAgICBkLT5wYWdlLT5mb2N1c0Nv bnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCktPnNlbGVjdGlvbigpLT5zZWxlY3RBbGwo KTsKK30KKworLyohCiAgICAgXGZuIHZvaWQgUVdlYlBhZ2U6OmxvYWRTdGFydGVkKCkKIAogICAg IFRoaXMgc2lnbmFsIGlzIGVtaXR0ZWQgd2hlbiBhIG5ldyBsb2FkIG9mIHRoZSBwYWdlIGlzIHN0 YXJ0ZWQuCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L3F0L0FwaS9xd2VicGFnZS5oCShyZXZpc2lvbiAzOTQyMykKKysrIFdlYktpdC9xdC9BcGkv cXdlYnBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtMjA3LDYgKzIwNyw4IEBAIHB1YmxpYzoKIAog ICAgIFFTdHJpbmcgc2VsZWN0ZWRUZXh0KCkgY29uc3Q7CiAKKyAgICB2b2lkIHNlbGVjdEFsbCgp OworCiAgICAgUUFjdGlvbiAqYWN0aW9uKFdlYkFjdGlvbiBhY3Rpb24pIGNvbnN0OwogICAgIHZp cnR1YWwgdm9pZCB0cmlnZ2VyQWN0aW9uKFdlYkFjdGlvbiBhY3Rpb24sIGJvb2wgY2hlY2tlZCA9 IGZhbHNlKTsKIApJbmRleDogV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5jcHAJKHJldmlzaW9uIDM5NDIzKQorKysgV2ViS2l0 L3F0L0FwaS9xd2Vidmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5NSw2ICs2OTUsMTYgQEAg UVdlYlZpZXcgKlFXZWJWaWV3OjpjcmVhdGVXaW5kb3coUVdlYlBhZwogICAgIHJldHVybiAwOwog fQogCisvKiEKKyAgICBTZWxlY3RzIGFsbCBjb250ZW50LgorICAgIFxzaW5jZSA0LjYKKyovCit2 b2lkIFFXZWJWaWV3OjpzZWxlY3RBbGwoKQoreworICAgIGlmIChkLT5wYWdlKQorICAgICAgICBk LT5wYWdlLT5zZWxlY3RBbGwoKTsKK30KKwogLyohIFxyZWltcAogKi8KIHZvaWQgUVdlYlZpZXc6 Om1vdXNlTW92ZUV2ZW50KFFNb3VzZUV2ZW50KiBldikKSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdl YnZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmgJKHJldmlzaW9u IDM5NDIzKQorKysgV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC03 OCw2ICs3OCw4IEBAIHB1YmxpYzoKIAogICAgIFFTdHJpbmcgc2VsZWN0ZWRUZXh0KCkgY29uc3Q7 CiAKKyAgICB2b2lkIHNlbGVjdEFsbCgpOworCiAgICAgUUFjdGlvbiAqcGFnZUFjdGlvbihRV2Vi UGFnZTo6V2ViQWN0aW9uIGFjdGlvbikgY29uc3Q7CiAgICAgdm9pZCB0cmlnZ2VyUGFnZUFjdGlv bihRV2ViUGFnZTo6V2ViQWN0aW9uIGFjdGlvbiwgYm9vbCBjaGVja2VkID0gZmFsc2UpOwogCg== 27018 2009-01-25 08:19:49 -0800 2009-01-25 09:21:44 -0800 Updated patch as suggested by Simon selectall.patch text/plain 1494 uwolfer SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDAyMjMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDEtMjUgIFVycyBXb2xmZXIgIDx1d29sZmVyQGtk ZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgZnVuY3Rpb24gdG8gc2VsZWN0IGFsbCBjb250ZW50IG9mIGEgUVdlYkZyYW1lLgorCisg ICAgICAgIEFkZGVkIFFXZWJGcmFtZTo6c2VsZWN0QWxsLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk0NgorCisgICAgICAgICogQXBpL3F3ZWJm cmFtZS5jcHA6CisgICAgICAgIChRV2ViRnJhbWU6OnNlbGVjdEFsbCk6CisgICAgICAgICogQXBp L3F3ZWJmcmFtZS5oOgorCiAyMDA4LTEyLTIwICBVcnMgV29sZmVyICA8dXdvbGZlckBrZGUub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0L3F0 L0FwaS9xd2ViZnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmZyYW1l LmNwcAkocmV2aXNpb24gNDAyMjMpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEwMTgsNiArMTAxOCwxNSBAQAogICAgIHJldHVybiBRV2ViU2VjdXJp dHlPcmlnaW4ocHJpdik7CiB9CiAKKy8qIQorICAgIFNlbGVjdHMgYWxsIGNvbnRlbnQuCisgICAg XHNpbmNlIDQuNgorKi8KK3ZvaWQgUVdlYkZyYW1lOjpzZWxlY3RBbGwoKQoreworICAgIGQtPmZy YW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0QWxsKCk7Cit9CisKIFdlYkNvcmU6OkZyYW1lKiBRV2Vi RnJhbWVQcml2YXRlOjpjb3JlKFFXZWJGcmFtZSogd2ViRnJhbWUpCiB7CiAgICAgcmV0dXJuIHdl YkZyYW1lLT5kLT5mcmFtZTsKSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuaAkocmV2aXNpb24gNDAyMjMpCisrKyBX ZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzcsNiArMTc3LDgg QEAKIAogICAgIFFXZWJTZWN1cml0eU9yaWdpbiBzZWN1cml0eU9yaWdpbigpIGNvbnN0OwogCisg ICAgdm9pZCBzZWxlY3RBbGwoKTsKKwogcHVibGljIFFfU0xPVFM6CiAgICAgUVZhcmlhbnQgZXZh bHVhdGVKYXZhU2NyaXB0KGNvbnN0IFFTdHJpbmcmIHNjcmlwdFNvdXJjZSk7CiAjaWZuZGVmIFFU X05PX1BSSU5URVIK 27020 2009-01-25 09:17:14 -0800 2009-01-25 09:28:42 -0800 Updated as discussed with Simon on IRC selectall.patch text/plain 1962 uwolfer SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDAyMjQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjUgIFVycyBXb2xmZXIgIDx1d29sZmVyQGtk ZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIFFXZWJQYWdlOjpTZWxlY3RBbGwgdG8gV2ViQWN0aW9uIGVudW0gdG8gc2VsZWN0IGFsbCBj b250ZW50LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjk0NgorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdl UHJpdmF0ZTo6ZWRpdG9yQWN0aW9uRm9yS2V5RXZlbnQpOgorICAgICAgICAqIEFwaS9xd2VicGFn ZS5oOgorCiAyMDA5LTAxLTI1ICBUb3IgQXJuZSBWZXN0YsO4ICA8dGF2ZXN0Ym9AdHJvbGx0ZWNo LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktp dC9xdC9BcGkvcXdlYnBhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdl LmgJKHJldmlzaW9uIDQwMjI0KQorKysgV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0xNDgsNiArMTQ4LDggQEAKICAgICAgICAgSW5zZXJ0UGFyYWdyYXBoU2VwYXJh dG9yLAogICAgICAgICBJbnNlcnRMaW5lU2VwYXJhdG9yLAogCisgICAgICAgIFNlbGVjdEFsbCwK KwogICAgICAgICBXZWJBY3Rpb25Db3VudAogICAgIH07CiAKSW5kZXg6IFdlYktpdC9xdC9BcGkv cXdlYnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCShy ZXZpc2lvbiA0MDIyNCkKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNzgsNiArMTc4LDggQEAKICAgICAiSW5zZXJ0TmV3bGluZSIsIC8vIEluc2VydFBh cmFncmFwaFNlcGFyYXRvcgogICAgICJJbnNlcnRMaW5lQnJlYWsiLCAvLyBJbnNlcnRMaW5lU2Vw YXJhdG9yCiAKKyAgICAiU2VsZWN0QWxsIiwgLy8gU2VsZWN0QWxsCisKICAgICAwIC8vIFdlYkFj dGlvbkNvdW50CiB9OwogCkBAIC03NTAsNiArNzUyLDcgQEAKICAgICAgICAgeyBRS2V5U2VxdWVu Y2U6Okluc2VydFBhcmFncmFwaFNlcGFyYXRvciwgUVdlYlBhZ2U6Okluc2VydFBhcmFncmFwaFNl cGFyYXRvciB9LAogICAgICAgICB7IFFLZXlTZXF1ZW5jZTo6SW5zZXJ0TGluZVNlcGFyYXRvciwg UVdlYlBhZ2U6Okluc2VydExpbmVTZXBhcmF0b3IgfSwKICNlbmRpZgorICAgICAgICB7IFFLZXlT ZXF1ZW5jZTo6U2VsZWN0QWxsLCBRV2ViUGFnZTo6U2VsZWN0QWxsIH0sCiAgICAgICAgIHsgUUtl eVNlcXVlbmNlOjpVbmtub3duS2V5LCBRV2ViUGFnZTo6Tm9XZWJBY3Rpb24gfQogICAgIH07CiAK QEAgLTExNzIsNiArMTE3NSw3IEBACiAgICAgXHZhbHVlIEluc3BlY3RFbGVtZW50IFNob3cgdGhl IFdlYiBJbnNwZWN0b3Igd2l0aCB0aGUgY3VycmVudGx5IGhpZ2hsaWdodGVkIEhUTUwgZWxlbWVu dC4KICAgICBcdmFsdWUgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yIEluc2VydCBhIG5ldyBwYXJh Z3JhcGguCiAgICAgXHZhbHVlIEluc2VydExpbmVTZXBhcmF0b3IgSW5zZXJ0IGEgbmV3IGxpbmUu CisgICAgXHZhbHVlIFNlbGVjdEFsbCBTZWxlY3RzIGFsbCBjb250ZW50LgogICAgIFxvbWl0dmFs dWUgV2ViQWN0aW9uQ291bnQKIAogKi8K