229456 2021-08-24 11:19:37 -0700 [iOS] Unable to select files when the accept attribute is set to "*/*" 2021-09-27 16:29:20 -0700 1 1 1 Unclassified WebKit Forms Safari 14 iPhone / iPad iOS 14 RESOLVED FIXED InRadar P2 Normal --- 1 nave akeerthi aestes akeerthi cdumez kevin_neal sabouhallawa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1786833 0 nave 2021-08-24 11:19:37 -0700 Given a web form with a file upload field with the accept attribute set to "*/*", like this: <input type="file" accept="*/*"> Desktop browsers will ignore the accept attribute and allow any file to be uploaded. On iOS, however, this is not the case and instead of being given the equivalent experience (which would be the "Photo Library / Take Photo / Browse" menu), the user is dropped into the file browser but without the ability to actually select any files (they are grayed out). Granted, "*/*" is not a valid accept value per the spec. However, based on searching google for "ios upload grayed out" it is clear that many sites are setting this attribute and causing problems for iOS users. This behavior is difficult to diagnose and inconsistent with the desktop experience. This can be easily reproduced here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file 1786886 1 cdumez 2021-08-24 12:31:18 -0700 "*/*" actually seems like a valid value according to the spec: - https://html.spec.whatwg.org/multipage/input.html#attr-input-accept says "A valid MIME type string with no parameters" points to: - https://mimesniff.spec.whatwg.org/#valid-mime-type-with-no-parameters which points to: - https://mimesniff.spec.whatwg.org/#valid-mime-type which points to: - https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.1.1 says: media-type = type "/" subtype *( OWS ";" OWS parameter ) type = token subtype = token type and subtype are both tokens, defined here: - https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.6 so it seems like '*' is a valid token. 1786890 2 nave 2021-08-24 12:38:54 -0700 Ah, you're right, thanks! 1787207 3 webkit-bug-importer 2021-08-25 10:27:50 -0700 <rdar://problem/82346315> 1787296 4 436422 akeerthi 2021-08-25 13:56:23 -0700 Created attachment 436422 Patch 1787301 5 436422 cdumez 2021-08-25 14:02:56 -0700 Comment on attachment 436422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436422&action=review r=me with comment > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:358 > + if ([mimeType caseInsensitiveCompare:@"*/*"] == NSOrderedSame) nit: Do we really need a caseInsensitiveCompare for "*/*"? 1787311 6 436425 akeerthi 2021-08-25 14:14:17 -0700 Created attachment 436425 Patch 1787314 7 akeerthi 2021-08-25 14:15:55 -0700 (In reply to Chris Dumez from comment #5) > Comment on attachment 436422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436422&action=review > > r=me with comment Thanks for the review! > > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:358 > > + if ([mimeType caseInsensitiveCompare:@"*/*"] == NSOrderedSame) > > nit: Do we really need a caseInsensitiveCompare for "*/*"? Uploaded a new patch using `isEqualToString:`. 1787440 8 ews-feeder 2021-08-25 20:08:49 -0700 Committed r281612 (240968@main): <https://commits.webkit.org/240968@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436425. 1797699 9 nave 2021-09-27 16:29:20 -0700 I just have to say, I'm really impressed with how quickly this bug was fixed. My first time cutting a WebKit issue and was expecting this to sit uncommented and then closed eventually for "no activity" or any of the other outcomes that seem common with large open-source projects supported by any of the Big 5. Very glad to be proven wrong. My only complaints is that I was looking forward to figuring out WebKit development and fixing it myself :-) 436422 2021-08-25 13:56:23 -0700 2021-08-25 14:14:14 -0700 Patch bug-229456-20210825165622.patch text/plain 7239 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM3ZGI4NGMzNmJlNGQ5NmU5 MzNjM2RhYzI5ZTdmZmU4MGFjYTMxZjIuLjUyYTNhN2E2NDVmNTQ0MjU3NGVhNWUzZDY4ZTUzYWE4 Nzk2MjI0MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzQgQEAKKzIwMjEtMDgtMjUgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFVuYWJsZSB0byBz ZWxlY3QgZmlsZXMgd2hlbiB0aGUgYWNjZXB0IGF0dHJpYnV0ZSBpcyBzZXQgdG8gIiovKiIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTQ1NgorICAg ICAgICByZGFyOi8vODIzNDYzMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAiKi8qIiBpcyBhIHZhbGlkIE1JTUUgdHlwZSBzdHJpbmcgcmVwcmVzZW50 aW5nIGFsbCBtZWRpYSB0eXBlcy4gSG93ZXZlciwKKyAgICAgICAgdGhlIFVuaWZvcm1UeXBlSWRl bnRpZmllcnMgZnJhbWV3b3JrIChhcyB3ZWxsIGFzIHRoZSBub3cgZGVwcmVjYXRlZAorICAgICAg ICBDb3JlU2VydmljZXMgdHlwZSBpZGVudGlmaWVycyBBUEkpIGRvZXMgbm90IG1hcCB3aWxkY2Fy ZCBNSU1FIHR5cGVzLgorCisgICAgICAgIEluIG9yZGVyIHRvIHJlc3RyaWN0IGBVSURvY3VtZW50 UGlja2VyVmlld0NvbnRyb2xsZXJgIHRvIHRoZSB0eXBlcyBvZgorICAgICAgICBmaWxlcyBzcGVj aWZpZWQgaW4gdGhlIGFjY2VwdCBhdHRyaWJ1dGUsIGFsbCBNSU1FIHR5cGUgc3RyaW5ncyBhcmUK KyAgICAgICAgY29udmVydGVkIGludG8gYFVUVHlwZWBzLiBIb3dldmVyLCB3aGVuIGF0dGVtcHRp bmcgdG8gcmV0cmlldmUgYSBVVFR5cGUKKyAgICAgICAgZm9yICIqLyoiLCB0aGUgc3lzdGVtIGR5 bmFtaWNhbGx5IGdlbmVyYXRlcyBhIHR5cGUsIHNpbmNlIHRoZSBzdHJpbmcgaXMKKyAgICAgICAg dW5yZWdpc3RlcmVkLiBUaGVuLCBzaW5jZSBubyBmaWxlcyBjb25mb3JtIHRvIHRoZSBkeW5hbWlj IHR5cGUsIGFsbAorICAgICAgICBmaWxlcyBpbiB0aGUgZG9jdW1lbnQgcGlja2VyIGFyZSBncmV5 ZWQgb3V0LCBhbmQgdGhlIHVzZXIgaXMgdW5hYmxlCisgICAgICAgIHRvIGFjY2VzcyB0aGUgIlBo b3RvIExpYnJhcnkiIGFuZCAiVGFrZSBQaG90byBvciBWaWRlbyIgaXRlbXMuCisKKyAgICAgICAg VG8gZml4LCByZXR1cm4gYW4gZW1wdHkgc2V0IG9mIHR5cGUgaWRlbnRpZmllcnMgd2hlbmV2ZXIg IiovKiIgaXMKKyAgICAgICAgcHJlc2VudCBpbiB0aGUgbGlzdCBvZiBNSU1FIHR5cGVzLCBlbnN1 cmluZyB0aGVyZSBhcmUgbm8gcmVzdHJpY3Rpb25zCisgICAgICAgIG9uIHRoZSB0eXBlcyBvZiBm aWxlcyB0aGF0IGNhbiBiZSBzZWxlY3RlZC4KKworICAgICAgICBOb3RlIHRoYXQgdGhlIHNhbWUg aXNzdWUgZG9lcyBub3Qgb2NjdXIgb24gbWFjT1MsIHNpbmNlIGFsbCBNSU1FIHR5cGVzCisgICAg ICAgIGFyZSBtYXBwZWQgdG8gYSBzZXQgb2YgZmlsZSBleHRlbnNpb25zLCByYXRoZXIgdGhhbiBV VFR5cGVzLiBGdXJ0aGVybW9yZSwKKyAgICAgICAgb24gbWFjT1MsIHRoZSBlbWJlZGRpbmcgYXBw LCBub3QgV2ViS2l0LCBpcyByZXNwb25zaWJsZSBmb3IgZGlzcGxheWluZworICAgICAgICB0aGUg ZmlsZSBwaWNrZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9h ZFBhbmVsLm1tOgorCiAyMDIxLTA4LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgW1dLMl0gSW1wbGVtZW50IHByb2Nlc3Mtc3dhcHBpbmcgYmFzZWQgb24gQ3Jv c3MtT3JpZ2luLU9wZW5lci1Qb2xpY3kgSFRUUCBoZWFkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQppbmRleCBlNzI0 NzI0MTI3MDIxODBhZmZiMjMyYzFmYTkzMzlmMzc2ZTgyZGMxLi44NTA2OTk4ZWIxZGU1ZjFlOWEw ZGE2OTZmNDg5MjgwMDJlNTdkN2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCkBAIC0zNTUsNiArMzU1LDkgQEAg c3RhdGljIE5TU2V0PE5TU3RyaW5nICo+ICpVVElzRm9yTUlNRVR5cGVzKE5TQXJyYXkgKm1pbWVU eXBlcykKIHsKICAgICBOU011dGFibGVTZXQgKm1lZGlhVHlwZXMgPSBbTlNNdXRhYmxlU2V0IHNl dF07CiAgICAgZm9yIChOU1N0cmluZyAqbWltZVR5cGUgaW4gbWltZVR5cGVzKSB7CisgICAgICAg IGlmIChbbWltZVR5cGUgY2FzZUluc2Vuc2l0aXZlQ29tcGFyZTpAIiovKiJdID09IE5TT3JkZXJl ZFNhbWUpCisgICAgICAgICAgICByZXR1cm4gW05TU2V0IHNldF07CisKICAgICAgICAgaWYgKFtt aW1lVHlwZSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAiaW1hZ2UvKiJdID09IE5TT3JkZXJlZFNh bWUpCiAgICAgICAgICAgICBbbWVkaWFUeXBlcyBhZGRPYmplY3Q6VVRUeXBlSW1hZ2UuaWRlbnRp Zmllcl07CiAgICAgICAgIGVsc2UgaWYgKFttaW1lVHlwZSBjYXNlSW5zZW5zaXRpdmVDb21wYXJl OkAidmlkZW8vKiJdID09IE5TT3JkZXJlZFNhbWUpCkBAIC0zNjgsNyArMzcxLDYgQEAgc3RhdGlj IE5TU2V0PE5TU3RyaW5nICo+ICpVVElzRm9yTUlNRVR5cGVzKE5TQXJyYXkgKm1pbWVUeXBlcykK ICAgICAgICAgICAgIGlmICh1dGkpCiAgICAgICAgICAgICAgICAgW21lZGlhVHlwZXMgYWRkT2Jq ZWN0OnV0aS5pZGVudGlmaWVyXTsKICAgICAgICAgfQotCiAgICAgfQogICAgIHJldHVybiBtZWRp YVR5cGVzOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IGFmNzk3NmQ4ZDMwMWNjMjU2ODU5YzU0MDMwMzVmZDlhN2Q0MTIw OTMuLjk2MjFhOTVlOTZiMTY5OWIxZjY5ZjFkNjMwNTVhOTUwNWJhMTM1NzIgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0wOC0yNSAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5j b20+CisKKyAgICAgICAgW2lPU10gVW5hYmxlIHRvIHNlbGVjdCBmaWxlcyB3aGVuIHRoZSBhY2Nl cHQgYXR0cmlidXRlIGlzIHNldCB0byAiKi8qIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDU2CisgICAgICAgIHJkYXI6Ly84MjM0NjMxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgdGVz dHMgdG8gdmVyaWZ5IHRoYXQgc2V0dGluZyB0aGUgYWNjZXB0IGF0dHJpYnV0ZSB0byAiKi8qIiBk b2VzCisgICAgICAgIG5vdCBpbXBvc2UgYW55IHJlc3RyaWN0aW9ucyBvbiB0aGUgdHlwZXMgb2Yg ZmlsZXMgdGhhdCBjYW4gYmUgc2VsZWN0ZWQsCisgICAgICAgIGFuZCBnaXZlcyB0aGUgdXNlciBh Y2Nlc3MgdG8gYWxsIG1lbnUgb3B0aW9ucy4KKworICAgICAgICAqIGZhc3QvZm9ybXMvaW9zL2Zp bGUtdXBsb2FkLXBhbmVsLWFjY2VwdC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9mb3Jt cy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtYWNjZXB0Lmh0bWw6CisgICAgICAgICogZmFzdC9mb3Jt cy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZm9y bXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWw6CisKIDIwMjEtMDgtMjQgIEFkaXR5YSBLZWVy dGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNzY1OTgp OiBbIGlPUyBdIGZhc3QvZm9ybXMvaW9zL2FjY2Vzc29yeS1iYXItbmF2aWdhdGlvbi5odG1sIGlz IGEgY29uc3RhbnQgdGltZW91dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9p b3MvZmlsZS11cGxvYWQtcGFuZWwtYWNjZXB0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWFjY2VwdC1leHBlY3RlZC50eHQKaW5kZXgg Njk4MzU4ZDcxMTEwNDU1NTQ1YWE1ZTgzMWFjMTgzOWJjZTAwNzI1My4uNWVjZWVhNWVlZGMzM2Q2 ZTBlNzRmMTYxNTdhNDZlMTE5YjYwYjczZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtYWNjZXB0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC1hY2NlcHQtZXhwZWN0ZWQu dHh0CkBAIC02LDYgKzYsOSBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogKiBhY2NlcHQgPQog UEFTUyBhcmVBcnJheXNFcXVhbChpdGVtcywgW10pIGlzIHRydWUKIAorKiBhY2NlcHQgPSAqLyoK K1BBU1MgYXJlQXJyYXlzRXF1YWwoaXRlbXMsIFtdKSBpcyB0cnVlCisKICogYWNjZXB0ID0gaW1h Z2UvKgogUEFTUyBhcmVBcnJheXNFcXVhbChpdGVtcywgWyJwdWJsaWMuaW1hZ2UiXSkgaXMgdHJ1 ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1w YW5lbC1hY2NlcHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2Fk LXBhbmVsLWFjY2VwdC5odG1sCmluZGV4IGE1YmZlYzM2MGQzMGI2NDJiYWY5ZDJkODY4ZjY5MjEx Y2YxMmM1MTkuLjIwYmEzNDk0MWEwN2IyNDUwMTVmNmJhYTU4NjljNjA1NzljZWU1ZjcgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWFjY2Vw dC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVs LWFjY2VwdC5odG1sCkBAIC0yOSw2ICsyOSw3IEBAIGFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBh c3luYyAoKSA9PiB7CiAgICAgZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgdGhlIGFjY2VwdCBhdHRy aWJ1dGUgZm9yIGZpbGUgaW5wdXRzIGlzIG1hcHBlZCB0byB0aGUgY29ycmVjdCBzZXQgb2YgdHlw ZSBpZGVudGlmaWVycyBvbiBpT1MuIik7CiAKICAgICBhd2FpdCBydW5UZXN0KCIiLCAnW10nKTsK KyAgICBhd2FpdCBydW5UZXN0KCIqLyoiLCAnW10nKTsKICAgICBhd2FpdCBydW5UZXN0KCJpbWFn ZS8qIiwgJ1sicHVibGljLmltYWdlIl0nKTsKICAgICBhd2FpdCBydW5UZXN0KCJ2aWRlby8qIiwg J1sicHVibGljLm1vdmllIl0nKTsKICAgICBhd2FpdCBydW5UZXN0KCJpbWFnZS8qLCB2aWRlby8q IiwgJ1sicHVibGljLmltYWdlIiwgInB1YmxpYy5tb3ZpZSJdJyk7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC1leHBlY3RlZC50eHQK aW5kZXggMmQwM2QxMjAwNzBiMGJhOTkyM2ZkZDA2MTFiNjczNjg3NWM1NTYxZC4uYzM1NjA5ZmZi NWZiOTU4N2IxNTM3Nzk0YzI1NDk5YmFiZTNjNGIyZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWV4cGVjdGVkLnR4dApAQCAt Niw2ICs2LDkgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUKICogYWNjZXB0ID0KIFBBU1MgYXJl QXJyYXlzRXF1YWwoaXRlbXMsIFsiUGhvdG8gTGlicmFyeSIsICJUYWtlIFBob3RvIG9yIFZpZGVv IiwgIkNob29zZSBGaWxlIl0pIGlzIHRydWUKIAorKiBhY2NlcHQgPSAqLyoKK1BBU1MgYXJlQXJy YXlzRXF1YWwoaXRlbXMsIFsiUGhvdG8gTGlicmFyeSIsICJUYWtlIFBob3RvIG9yIFZpZGVvIiwg IkNob29zZSBGaWxlIl0pIGlzIHRydWUKKwogKiBhY2NlcHQgPSBpbWFnZS8qCiBQQVNTIGFyZUFy cmF5c0VxdWFsKGl0ZW1zLCBbIlBob3RvIExpYnJhcnkiLCAiVGFrZSBQaG90byIsICJDaG9vc2Ug RmlsZSJdKSBpcyB0cnVlCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9z L2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxl LXVwbG9hZC1wYW5lbC5odG1sCmluZGV4IGYzODRlNmQ4NTk0OTJlZDA0OTlmYjI2YzA3ZWEyNTI4 NzA1ZTlmMWMuLjUxY2I1NzNmM2FkOGFlYTQzYWQ4Y2IxNjIyZGU5OTY4ZDRhYmM5MWUgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwuaHRtbApA QCAtNjIsNiArNjIsNyBAQCBhc3luYyBmdW5jdGlvbiBydW5UZXN0cygpCiAgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5zdHlsZSA9ICJkaXNwbGF5OiBub25lIjsKIAogICAg IGF3YWl0IHJ1bkFjY2VwdFRlc3QoIiIsICdbIlBob3RvIExpYnJhcnkiLCAiVGFrZSBQaG90byBv ciBWaWRlbyIsICJDaG9vc2UgRmlsZSJdJyk7CisgICAgYXdhaXQgcnVuQWNjZXB0VGVzdCgiKi8q IiwgJ1siUGhvdG8gTGlicmFyeSIsICJUYWtlIFBob3RvIG9yIFZpZGVvIiwgIkNob29zZSBGaWxl Il0nKTsKICAgICBhd2FpdCBydW5BY2NlcHRUZXN0KCJpbWFnZS8qIiwgJ1siUGhvdG8gTGlicmFy eSIsICJUYWtlIFBob3RvIiwgIkNob29zZSBGaWxlIl0nKTsKICAgICBhd2FpdCBydW5BY2NlcHRU ZXN0KCJ2aWRlby8qIiwgJ1siUGhvdG8gTGlicmFyeSIsICJUYWtlIFZpZGVvIiwgIkNob29zZSBG aWxlIl0nKTsKICAgICBhd2FpdCBydW5BY2NlcHRUZXN0KCJpbWFnZS8qLCB2aWRlby8qIiwgJ1si UGhvdG8gTGlicmFyeSIsICJUYWtlIFBob3RvIG9yIFZpZGVvIiwgIkNob29zZSBGaWxlIl0nKTsK 436425 2021-08-25 14:14:17 -0700 2021-08-25 20:08:52 -0700 Patch bug-229456-20210825171416.patch text/plain 7209 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM3ZGI4NGMzNmJlNGQ5NmU5 MzNjM2RhYzI5ZTdmZmU4MGFjYTMxZjIuLjRlMjE2YjBiZTg4MmM5NzliODM4MjU5NzM3NDA3Zjk2 ZDZhMmM2YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzQgQEAKKzIwMjEtMDgtMjUgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFVuYWJsZSB0byBz ZWxlY3QgZmlsZXMgd2hlbiB0aGUgYWNjZXB0IGF0dHJpYnV0ZSBpcyBzZXQgdG8gIiovKiIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTQ1NgorICAg ICAgICByZGFyOi8vODIzNDYzMTUKKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4K KworICAgICAgICAiKi8qIiBpcyBhIHZhbGlkIE1JTUUgdHlwZSBzdHJpbmcgcmVwcmVzZW50aW5n IGFsbCBtZWRpYSB0eXBlcy4gSG93ZXZlciwKKyAgICAgICAgdGhlIFVuaWZvcm1UeXBlSWRlbnRp ZmllcnMgZnJhbWV3b3JrIChhcyB3ZWxsIGFzIHRoZSBub3cgZGVwcmVjYXRlZAorICAgICAgICBD b3JlU2VydmljZXMgdHlwZSBpZGVudGlmaWVycyBBUEkpIGRvZXMgbm90IG1hcCB3aWxkY2FyZCBN SU1FIHR5cGVzLgorCisgICAgICAgIEluIG9yZGVyIHRvIHJlc3RyaWN0IGBVSURvY3VtZW50UGlj a2VyVmlld0NvbnRyb2xsZXJgIHRvIHRoZSB0eXBlcyBvZgorICAgICAgICBmaWxlcyBzcGVjaWZp ZWQgaW4gdGhlIGFjY2VwdCBhdHRyaWJ1dGUsIGFsbCBNSU1FIHR5cGUgc3RyaW5ncyBhcmUKKyAg ICAgICAgY29udmVydGVkIGludG8gYFVUVHlwZWBzLiBIb3dldmVyLCB3aGVuIGF0dGVtcHRpbmcg dG8gcmV0cmlldmUgYSBVVFR5cGUKKyAgICAgICAgZm9yICIqLyoiLCB0aGUgc3lzdGVtIGR5bmFt aWNhbGx5IGdlbmVyYXRlcyBhIHR5cGUsIHNpbmNlIHRoZSBzdHJpbmcgaXMKKyAgICAgICAgdW5y ZWdpc3RlcmVkLiBUaGVuLCBzaW5jZSBubyBmaWxlcyBjb25mb3JtIHRvIHRoZSBkeW5hbWljIHR5 cGUsIGFsbAorICAgICAgICBmaWxlcyBpbiB0aGUgZG9jdW1lbnQgcGlja2VyIGFyZSBncmV5ZWQg b3V0LCBhbmQgdGhlIHVzZXIgaXMgdW5hYmxlCisgICAgICAgIHRvIGFjY2VzcyB0aGUgIlBob3Rv IExpYnJhcnkiIGFuZCAiVGFrZSBQaG90byBvciBWaWRlbyIgaXRlbXMuCisKKyAgICAgICAgVG8g Zml4LCByZXR1cm4gYW4gZW1wdHkgc2V0IG9mIHR5cGUgaWRlbnRpZmllcnMgd2hlbmV2ZXIgIiov KiIgaXMKKyAgICAgICAgcHJlc2VudCBpbiB0aGUgbGlzdCBvZiBNSU1FIHR5cGVzLCBlbnN1cmlu ZyB0aGVyZSBhcmUgbm8gcmVzdHJpY3Rpb25zCisgICAgICAgIG9uIHRoZSB0eXBlcyBvZiBmaWxl cyB0aGF0IGNhbiBiZSBzZWxlY3RlZC4KKworICAgICAgICBOb3RlIHRoYXQgdGhlIHNhbWUgaXNz dWUgZG9lcyBub3Qgb2NjdXIgb24gbWFjT1MsIHNpbmNlIGFsbCBNSU1FIHR5cGVzCisgICAgICAg IGFyZSBtYXBwZWQgdG8gYSBzZXQgb2YgZmlsZSBleHRlbnNpb25zLCByYXRoZXIgdGhhbiBVVFR5 cGVzLiBGdXJ0aGVybW9yZSwKKyAgICAgICAgb24gbWFjT1MsIHRoZSBlbWJlZGRpbmcgYXBwLCBu b3QgV2ViS2l0LCBpcyByZXNwb25zaWJsZSBmb3IgZGlzcGxheWluZworICAgICAgICB0aGUgZmls ZSBwaWNrZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBh bmVsLm1tOgorCiAyMDIxLTA4LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dLMl0gSW1wbGVtZW50IHByb2Nlc3Mtc3dhcHBpbmcgYmFzZWQgb24gQ3Jvc3Mt T3JpZ2luLU9wZW5lci1Qb2xpY3kgSFRUUCBoZWFkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQppbmRleCBlNzI0NzI0 MTI3MDIxODBhZmZiMjMyYzFmYTkzMzlmMzc2ZTgyZGMxLi5mMWNlNjdmZTMxMmI4NTk4ZTBmODdm ZmVkNTdmOGJhN2NkYTNmN2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCkBAIC0zNTUsNiArMzU1LDkgQEAgc3Rh dGljIE5TU2V0PE5TU3RyaW5nICo+ICpVVElzRm9yTUlNRVR5cGVzKE5TQXJyYXkgKm1pbWVUeXBl cykKIHsKICAgICBOU011dGFibGVTZXQgKm1lZGlhVHlwZXMgPSBbTlNNdXRhYmxlU2V0IHNldF07 CiAgICAgZm9yIChOU1N0cmluZyAqbWltZVR5cGUgaW4gbWltZVR5cGVzKSB7CisgICAgICAgIGlm IChbbWltZVR5cGUgaXNFcXVhbFRvU3RyaW5nOkAiKi8qIl0pCisgICAgICAgICAgICByZXR1cm4g W05TU2V0IHNldF07CisKICAgICAgICAgaWYgKFttaW1lVHlwZSBjYXNlSW5zZW5zaXRpdmVDb21w YXJlOkAiaW1hZ2UvKiJdID09IE5TT3JkZXJlZFNhbWUpCiAgICAgICAgICAgICBbbWVkaWFUeXBl cyBhZGRPYmplY3Q6VVRUeXBlSW1hZ2UuaWRlbnRpZmllcl07CiAgICAgICAgIGVsc2UgaWYgKFtt aW1lVHlwZSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAidmlkZW8vKiJdID09IE5TT3JkZXJlZFNh bWUpCkBAIC0zNjgsNyArMzcxLDYgQEAgc3RhdGljIE5TU2V0PE5TU3RyaW5nICo+ICpVVElzRm9y TUlNRVR5cGVzKE5TQXJyYXkgKm1pbWVUeXBlcykKICAgICAgICAgICAgIGlmICh1dGkpCiAgICAg ICAgICAgICAgICAgW21lZGlhVHlwZXMgYWRkT2JqZWN0OnV0aS5pZGVudGlmaWVyXTsKICAgICAg ICAgfQotCiAgICAgfQogICAgIHJldHVybiBtZWRpYVR5cGVzOwogfQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFmNzk3NmQ4 ZDMwMWNjMjU2ODU5YzU0MDMwMzVmZDlhN2Q0MTIwOTMuLjA0ODAwYjZkMThjYjA1ODRjYzhmYTM5 MWZlNDUzNTVkMjcyOWIwMzQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMS0wOC0yNSAgQWRp dHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVW5hYmxl IHRvIHNlbGVjdCBmaWxlcyB3aGVuIHRoZSBhY2NlcHQgYXR0cmlidXRlIGlzIHNldCB0byAiKi8q IgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDU2 CisgICAgICAgIHJkYXI6Ly84MjM0NjMxNQorCisgICAgICAgIFJldmlld2VkIGJ5IENocmlzIER1 bWV6LgorCisgICAgICAgIFVwZGF0ZWQgdGVzdHMgdG8gdmVyaWZ5IHRoYXQgc2V0dGluZyB0aGUg YWNjZXB0IGF0dHJpYnV0ZSB0byAiKi8qIiBkb2VzCisgICAgICAgIG5vdCBpbXBvc2UgYW55IHJl c3RyaWN0aW9ucyBvbiB0aGUgdHlwZXMgb2YgZmlsZXMgdGhhdCBjYW4gYmUgc2VsZWN0ZWQsCisg ICAgICAgIGFuZCBnaXZlcyB0aGUgdXNlciBhY2Nlc3MgdG8gYWxsIG1lbnUgb3B0aW9ucy4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWFjY2VwdC1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtYWNjZXB0 Lmh0bWw6CisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGZhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWw6 CisKIDIwMjEtMDgtMjQgIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIyNzY1OTgpOiBbIGlPUyBdIGZhc3QvZm9ybXMvaW9zL2FjY2Vz c29yeS1iYXItbmF2aWdhdGlvbi5odG1sIGlzIGEgY29uc3RhbnQgdGltZW91dApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtYWNjZXB0LWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVs LWFjY2VwdC1leHBlY3RlZC50eHQKaW5kZXggNjk4MzU4ZDcxMTEwNDU1NTQ1YWE1ZTgzMWFjMTgz OWJjZTAwNzI1My4uNWVjZWVhNWVlZGMzM2Q2ZTBlNzRmMTYxNTdhNDZlMTE5YjYwYjczZSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwtYWNj ZXB0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVw bG9hZC1wYW5lbC1hY2NlcHQtZXhwZWN0ZWQudHh0CkBAIC02LDYgKzYsOSBAQCBPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURQogKiBhY2NlcHQgPQogUEFTUyBhcmVBcnJheXNFcXVhbChpdGVtcywgW10p IGlzIHRydWUKIAorKiBhY2NlcHQgPSAqLyoKK1BBU1MgYXJlQXJyYXlzRXF1YWwoaXRlbXMsIFtd KSBpcyB0cnVlCisKICogYWNjZXB0ID0gaW1hZ2UvKgogUEFTUyBhcmVBcnJheXNFcXVhbChpdGVt cywgWyJwdWJsaWMuaW1hZ2UiXSkgaXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC1hY2NlcHQuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWFjY2VwdC5odG1sCmluZGV4IGE1YmZl YzM2MGQzMGI2NDJiYWY5ZDJkODY4ZjY5MjExY2YxMmM1MTkuLjIwYmEzNDk0MWEwN2IyNDUwMTVm NmJhYTU4NjljNjA1NzljZWU1ZjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv aW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWFjY2VwdC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLWFjY2VwdC5odG1sCkBAIC0yOSw2ICsyOSw3IEBA IGFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBhc3luYyAoKSA9PiB7CiAgICAgZGVzY3JpcHRpb24o IlRlc3RzIHRoYXQgdGhlIGFjY2VwdCBhdHRyaWJ1dGUgZm9yIGZpbGUgaW5wdXRzIGlzIG1hcHBl ZCB0byB0aGUgY29ycmVjdCBzZXQgb2YgdHlwZSBpZGVudGlmaWVycyBvbiBpT1MuIik7CiAKICAg ICBhd2FpdCBydW5UZXN0KCIiLCAnW10nKTsKKyAgICBhd2FpdCBydW5UZXN0KCIqLyoiLCAnW10n KTsKICAgICBhd2FpdCBydW5UZXN0KCJpbWFnZS8qIiwgJ1sicHVibGljLmltYWdlIl0nKTsKICAg ICBhd2FpdCBydW5UZXN0KCJ2aWRlby8qIiwgJ1sicHVibGljLm1vdmllIl0nKTsKICAgICBhd2Fp dCBydW5UZXN0KCJpbWFnZS8qLCB2aWRlby8qIiwgJ1sicHVibGljLmltYWdlIiwgInB1YmxpYy5t b3ZpZSJdJyk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVw bG9hZC1wYW5lbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxl LXVwbG9hZC1wYW5lbC1leHBlY3RlZC50eHQKaW5kZXggMmQwM2QxMjAwNzBiMGJhOTkyM2ZkZDA2 MTFiNjczNjg3NWM1NTYxZC4uYzM1NjA5ZmZiNWZiOTU4N2IxNTM3Nzk0YzI1NDk5YmFiZTNjNGIy ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFu ZWwtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBs b2FkLXBhbmVsLWV4cGVjdGVkLnR4dApAQCAtNiw2ICs2LDkgQEAgT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09N UExFVEUKICogYWNjZXB0ID0KIFBBU1MgYXJlQXJyYXlzRXF1YWwoaXRlbXMsIFsiUGhvdG8gTGli cmFyeSIsICJUYWtlIFBob3RvIG9yIFZpZGVvIiwgIkNob29zZSBGaWxlIl0pIGlzIHRydWUKIAor KiBhY2NlcHQgPSAqLyoKK1BBU1MgYXJlQXJyYXlzRXF1YWwoaXRlbXMsIFsiUGhvdG8gTGlicmFy eSIsICJUYWtlIFBob3RvIG9yIFZpZGVvIiwgIkNob29zZSBGaWxlIl0pIGlzIHRydWUKKwogKiBh Y2NlcHQgPSBpbWFnZS8qCiBQQVNTIGFyZUFycmF5c0VxdWFsKGl0ZW1zLCBbIlBob3RvIExpYnJh cnkiLCAiVGFrZSBQaG90byIsICJDaG9vc2UgRmlsZSJdKSBpcyB0cnVlCiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC5odG1sCmluZGV4IGYzODRl NmQ4NTk0OTJlZDA0OTlmYjI2YzA3ZWEyNTI4NzA1ZTlmMWMuLjUxY2I1NzNmM2FkOGFlYTQzYWQ4 Y2IxNjIyZGU5OTY4ZDRhYmM5MWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv aW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9p b3MvZmlsZS11cGxvYWQtcGFuZWwuaHRtbApAQCAtNjIsNiArNjIsNyBAQCBhc3luYyBmdW5jdGlv biBydW5UZXN0cygpCiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5zdHls ZSA9ICJkaXNwbGF5OiBub25lIjsKIAogICAgIGF3YWl0IHJ1bkFjY2VwdFRlc3QoIiIsICdbIlBo b3RvIExpYnJhcnkiLCAiVGFrZSBQaG90byBvciBWaWRlbyIsICJDaG9vc2UgRmlsZSJdJyk7Cisg ICAgYXdhaXQgcnVuQWNjZXB0VGVzdCgiKi8qIiwgJ1siUGhvdG8gTGlicmFyeSIsICJUYWtlIFBo b3RvIG9yIFZpZGVvIiwgIkNob29zZSBGaWxlIl0nKTsKICAgICBhd2FpdCBydW5BY2NlcHRUZXN0 KCJpbWFnZS8qIiwgJ1siUGhvdG8gTGlicmFyeSIsICJUYWtlIFBob3RvIiwgIkNob29zZSBGaWxl Il0nKTsKICAgICBhd2FpdCBydW5BY2NlcHRUZXN0KCJ2aWRlby8qIiwgJ1siUGhvdG8gTGlicmFy eSIsICJUYWtlIFZpZGVvIiwgIkNob29zZSBGaWxlIl0nKTsKICAgICBhd2FpdCBydW5BY2NlcHRU ZXN0KCJpbWFnZS8qLCB2aWRlby8qIiwgJ1siUGhvdG8gTGlicmFyeSIsICJUYWtlIFBob3RvIG9y IFZpZGVvIiwgIkNob29zZSBGaWxlIl0nKTsK