229451 2021-08-24 10:20:46 -0700 Add new experimental feature flag for sanitizing links 2021-08-26 09:42:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham risul_islam bfulgham katherine_cheney risul_islam webkit-bug-importer oldest_to_newest 1786790 0 bfulgham 2021-08-24 10:20:46 -0700 Add a new experimental feature flag to support development of a link sanitizer for private browsing mode. 1786792 1 webkit-bug-importer 2021-08-24 10:21:14 -0700 <rdar://problem/82298037> 1786857 2 436313 risul_islam 2021-08-24 11:45:00 -0700 Created attachment 436313 Patch 1786889 3 436313 katherine_cheney 2021-08-24 12:36:13 -0700 Comment on attachment 436313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:643 > + humanReadableName: "Link Sanitizer enabled" I think this should just be "Link sanitizer"... > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644 > + humanReadableDescription: "Sanitize the links" ...then this should be "Enable link sanitizer" to better align with other examples in this file. > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 > + default: true r- because this feature should be off by default, so default values should be false. 1787201 4 436313 risul_islam 2021-08-25 10:12:21 -0700 Comment on attachment 436313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644 >> + humanReadableDescription: "Sanitize the links" > > ...then this should be "Enable link sanitizer" to better align with other examples in this file. Onto these. >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 >> + default: true > > r- because this feature should be off by default, so default values should be false. Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore? 1787215 5 436313 bfulgham 2021-08-25 10:46:53 -0700 Comment on attachment 436313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review >>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 >>> + default: true >> >> r- because this feature should be off by default, so default values should be false. > > Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore? Set all of them to 'false'. 1787249 6 436409 risul_islam 2021-08-25 12:20:44 -0700 Created attachment 436409 Patch 1787644 7 ews-feeder 2021-08-26 09:42:05 -0700 Committed r281630 (240986@main): <https://commits.webkit.org/240986@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436409. 436313 2021-08-24 11:45:00 -0700 2021-08-25 12:20:43 -0700 Patch bug-229451-20210824114459.patch text/plain 1469 risul_islam U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRiMmExZGEyMDk2ZTExZDQ5NmRiNWEz ZjI5NGQ0Zjg4MGJjOGU1YjMuLjEzNTA5YjYwMzIxYWNhYmRkYzkzZjQ0Y2YxOTM2MDg1OWJkMDg2 NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDgtMjQgIFJpc3VsIElzbGFtICA8cmlzdWxf aXNsYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBuZXcgZXhwZXJpbWVudGFsIGZlYXR1cmUg ZmxhZyBmb3Igc2FuaXRpemluZyBsaW5rcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhw ZXJpbWVudGFsLnlhbWw6CisKIDIwMjEtMDgtMDUgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgR0NDIDExIGJ1aWxkcyBzaG91bGQgdXNlIC1Xbm8t YXJyYXktYm91bmRzLCAtV25vLW5vbm51bGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvU2NyaXB0 cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sIGIvU291cmNlL1dU Ri9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKaW5k ZXggZmIwODY0OWI2Yzg2MmQ2YjdmNzllYTA4N2EzZGU1NmI4YTUyZGFiZS4uMzE3ZTRmZGQ1ZTE1 OWMxZDc0OWQ1MThkNDQ0YTU5ZWEzNDE3Y2EyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9TY3Jp cHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKKysrIGIvU291 cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlh bWwKQEAgLTYzOCw2ICs2MzgsMTggQEAgTGlua1ByZWxvYWRSZXNwb25zaXZlSW1hZ2VzRW5hYmxl ZDoKICAgICBXZWJDb3JlOgogICAgICAgZGVmYXVsdDogZmFsc2UKIAorTGlua1Nhbml0aXplckVu YWJsZWQ6CisgIHR5cGU6IGJvb2wKKyAgaHVtYW5SZWFkYWJsZU5hbWU6ICJMaW5rIFNhbml0aXpl ciBlbmFibGVkIgorICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJTYW5pdGl6ZSB0aGUgbGlu a3MiCisgIGRlZmF1bHRWYWx1ZToKKyAgICBXZWJLaXRMZWdhY3k6CisgICAgICBkZWZhdWx0OiB0 cnVlCisgICAgV2ViS2l0OgorICAgICAgZGVmYXVsdDogdHJ1ZQorICAgIFdlYkNvcmU6CisgICAg ICBkZWZhdWx0OiB0cnVlCisKIE1hc2tXZWJHTFN0cmluZ3NFbmFibGVkOgogICB0eXBlOiBib29s CiAgIGh1bWFuUmVhZGFibGVOYW1lOiAiTWFzayBXZWJHTCBTdHJpbmdzIgo= 436409 2021-08-25 12:20:44 -0700 2021-08-26 09:42:05 -0700 Patch bug-229451-20210825122043.patch text/plain 1467 risul_islam U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRiMmExZGEyMDk2ZTExZDQ5NmRiNWEz ZjI5NGQ0Zjg4MGJjOGU1YjMuLjMzOGQyYTU3MmZkNGRhNDcxY2VhMWIzM2E4ZGY0Yjk3MmYxMmFl ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDgtMjUgIFJpc3VsIElzbGFtICA8cmlzdWxf aXNsYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBuZXcgZXhwZXJpbWVudGFsIGZlYXR1cmUg ZmxhZyBmb3Igc2FuaXRpemluZyBsaW5rcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhw ZXJpbWVudGFsLnlhbWw6CisKIDIwMjEtMDgtMDUgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgR0NDIDExIGJ1aWxkcyBzaG91bGQgdXNlIC1Xbm8t YXJyYXktYm91bmRzLCAtV25vLW5vbm51bGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvU2NyaXB0 cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sIGIvU291cmNlL1dU Ri9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKaW5k ZXggZmIwODY0OWI2Yzg2MmQ2YjdmNzllYTA4N2EzZGU1NmI4YTUyZGFiZS4uM2FmOGU5ZmVhNjM2 ODAwNmNmZDI0ZjU0MzE4OTVjNzE5N2FhN2UzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9TY3Jp cHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKKysrIGIvU291 cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlh bWwKQEAgLTYzOCw2ICs2MzgsMTggQEAgTGlua1ByZWxvYWRSZXNwb25zaXZlSW1hZ2VzRW5hYmxl ZDoKICAgICBXZWJDb3JlOgogICAgICAgZGVmYXVsdDogZmFsc2UKIAorTGlua1Nhbml0aXplckVu YWJsZWQ6CisgIHR5cGU6IGJvb2wKKyAgaHVtYW5SZWFkYWJsZU5hbWU6ICJMaW5rIFNhbml0aXpl ciIKKyAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5hYmxlIGxpbmsgc2FuaXRpemVyIgor ICBkZWZhdWx0VmFsdWU6CisgICAgV2ViS2l0TGVnYWN5OgorICAgICAgZGVmYXVsdDogZmFsc2UK KyAgICBXZWJLaXQ6CisgICAgICBkZWZhdWx0OiBmYWxzZQorICAgIFdlYkNvcmU6CisgICAgICBk ZWZhdWx0OiBmYWxzZQorCiBNYXNrV2ViR0xTdHJpbmdzRW5hYmxlZDoKICAgdHlwZTogYm9vbAog ICBodW1hblJlYWRhYmxlTmFtZTogIk1hc2sgV2ViR0wgU3RyaW5ncyIK