229420 2021-08-23 13:54:47 -0700 Disable peephole optimizations in the byte code generator after rewriting instructions for for-in 2021-08-23 20:00:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1786540 0 saam 2021-08-23 13:54:47 -0700 ... 1786545 1 saam 2021-08-23 14:00:51 -0700 <rdar://82020528> 1786550 2 436234 saam 2021-08-23 14:09:48 -0700 Created attachment 436234 patch 1786655 3 ews-feeder 2021-08-23 20:00:04 -0700 Committed r281485 (240859@main): <https://commits.webkit.org/240859@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436234. 436234 2021-08-23 14:09:48 -0700 2021-08-23 20:00:05 -0700 patch a-backup.diff text/plain 3798 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODE0NjgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERpc2FibGUgcGVlcGhvbGUgb3B0aW1pemF0aW9ucyBpbiB0aGUgYnl0 ZSBjb2RlIGdlbmVyYXRvciBhZnRlciByZXdyaXRpbmcgaW5zdHJ1Y3Rpb25zIGZvciBmb3ItaW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTQyMAor ICAgICAgICA8cmRhcjovLzgyMDIwNTI4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2Zvci1pbi1kaXNhYmxlLWJ5dGVjb2RlLWdlbmVy YXRvci1wZWVwaG9sZS1vcHRpbWl6YXRpb25zLWFmdGVyLXJld3JpdGUuanM6IEFkZGVkLgorICAg ICAgICAoZm9vKToKKwogMjAyMS0wOC0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUu Y29tPgogCiAgICAgICAgIFtKU0NdIFJlbW92ZSBhbHJlYWR5LXNoaXBwZWQgd2FzbSBvcHRpb24g ZmxhZ3MKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1kaXNhYmxlLWJ5dGVjb2RlLWdlbmVy YXRvci1wZWVwaG9sZS1vcHRpbWl6YXRpb25zLWFmdGVyLXJld3JpdGUuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSlNUZXN0cy9zdHJlc3MvZm9yLWluLWRpc2FibGUtYnl0ZWNvZGUtZ2VuZXJhdG9yLXBlZXBo b2xlLW9wdGltaXphdGlvbnMtYWZ0ZXItcmV3cml0ZS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rl c3RzL3N0cmVzcy9mb3ItaW4tZGlzYWJsZS1ieXRlY29kZS1nZW5lcmF0b3ItcGVlcGhvbGUtb3B0 aW1pemF0aW9ucy1hZnRlci1yZXdyaXRlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOSBA QAorZnVuY3Rpb24gZm9vKCkgeworICAgIGZvciAobGV0IHggaW4gW10pIHsKKyAgICAgICAgeCBp biB1bmRlZmluZWQ7CisgICAgICAgIHggPSAwOworICAgICAgICBbXVt4XTsKKyAgICB9Cit9Citm b28oKTsKKwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODE0NTQpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjEtMDgtMjMgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisK KyAgICAgICAgRGlzYWJsZSBwZWVwaG9sZSBvcHRpbWl6YXRpb25zIGluIHRoZSBieXRlIGNvZGUg Z2VuZXJhdG9yIGFmdGVyIHJld3JpdGluZyBpbnN0cnVjdGlvbnMgZm9yIGZvci1pbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDIwCisgICAgICAg IDxyZGFyOi8vODIwMjA1Mjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGZpbmFsIGluc3RydWN0aW9uIGluIGEgZm9yLWluIGxvb3AgbWlnaHQg YmUgdGhlIGdldCBieSB2YWwgdGhhdAorICAgICAgICB3ZSdyZSByZXdyaXRpbmcgYmVjYXVzZSB0 aGVyZSB3YXMgYW4gZXNjYXBlLiBXZSB3b24ndCBldmVyIGFjdHVhbGx5CisgICAgICAgIGRvIHBl ZXBob2xlIG9wdGltaXphdGlvbnMgb24gdGhpcyBnZXRfYnlfdmFsIHRvZGF5LCBidXQgaXQgYnJl YWtzCisgICAgICAgIHNvbWUgYm9va2tlZXBpbmcgdGhhdCB0aGUgYnl0ZWNvZGUgZ2VuZXJhdG9y IGRvZXMuIFRoaXMgcGF0Y2ggbWFrZXMKKyAgICAgICAgc3VyZSB0aGUgYm9va2tlZXBpbmcgaXMg dXAgdG8gZGF0ZS4KKworICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5j cHA6CisgICAgICAgIChKU0M6OkZvckluQ29udGV4dDo6ZmluYWxpemUpOgorCiAyMDIxLTA4LTIz ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gZW1p dEFycmF5UHJvZmlsaW5nU2l0ZVdpdGhDZWxsIHNob3VsZCBub3QgbG9hZCBpbmRleGluZ1R5cGUg dW5uZWNlc3NhcmlseQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9C eXRlY29kZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHJldmlzaW9uIDI4MTQ1NCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MzY5LDkgKzUzNjksNiBAQCB2b2lkIEZvckluQ29udGV4dDo6 ZmluYWxpemUoQnl0ZWNvZGVHZW5lCiAgICAgaWYgKCFlc2NhcGVkKQogICAgICAgICByZXR1cm47 CiAKLSAgICBPcGNvZGVJRCBsYXN0T3Bjb2RlSUQgPSBnZW5lcmF0b3IubV9sYXN0T3Bjb2RlSUQ7 Ci0gICAgSW5zdHJ1Y3Rpb25TdHJlYW06Ok11dGFibGVSZWYgbGFzdEluc3RydWN0aW9uID0gZ2Vu ZXJhdG9yLm1fbGFzdEluc3RydWN0aW9uOwotCiAgICAgZm9yIChjb25zdCBhdXRvJiBpbnN0VHVw bGUgOiBtX2dldEluc3RzKQogICAgICAgICByZXdyaXRlT3A8T3BFbnVtZXJhdG9yR2V0QnlWYWws IE9wR2V0QnlWYWw+KGdlbmVyYXRvciwgaW5zdFR1cGxlKTsKIApAQCAtNTM5MCwxOSArNTM4Nywx NSBAQCB2b2lkIEZvckluQ29udGV4dDo6ZmluYWxpemUoQnl0ZWNvZGVHZW5lCiAKICAgICAgICAg Z2VuZXJhdG9yLm1fd3JpdGVyLnNlZWsoYnJhbmNoSW5zdEluZGV4KTsKIAotICAgICAgICBnZW5l cmF0b3IuZGlzYWJsZVBlZXBob2xlT3B0aW1pemF0aW9uKCk7Ci0KICAgICAgICAgT3BKbXA6OmVt aXQoJmdlbmVyYXRvciwgQm91bmRMYWJlbChzdGF0aWNfY2FzdDxpbnQ+KG5ld0JyYW5jaFRhcmdl dCkgLSBzdGF0aWNfY2FzdDxpbnQ+KGJyYW5jaEluc3RJbmRleCkpKTsKIAogICAgICAgICB3aGls ZSAoZ2VuZXJhdG9yLm1fd3JpdGVyLnBvc2l0aW9uKCkgPCBlbmQpCiAgICAgICAgICAgICBPcE5v cDo6ZW1pdDxPcGNvZGVTaXplOjpOYXJyb3c+KCZnZW5lcmF0b3IpOwogICAgIH0KIAorICAgIGdl bmVyYXRvci5kaXNhYmxlUGVlcGhvbGVPcHRpbWl6YXRpb24oKTsgLy8gV2UgbWlnaHQndmUganVz dCBjaGFuZ2VkIHRoZSBsYXN0IGJ5dGVjb2RlIHRoYXQgd2FzIGVtaXR0ZWQuCisKICAgICBnZW5l cmF0b3IubV93cml0ZXIuc2VlayhnZW5lcmF0b3IubV93cml0ZXIuc2l6ZSgpKTsKLSAgICBpZiAo Z2VuZXJhdG9yLm1fbGFzdEluc3RydWN0aW9uLm9mZnNldCgpICsgZ2VuZXJhdG9yLm1fbGFzdElu c3RydWN0aW9uLT5zaXplKCkgIT0gZ2VuZXJhdG9yLm1fd3JpdGVyLnNpemUoKSkgewotICAgICAg ICBnZW5lcmF0b3IubV9sYXN0T3Bjb2RlSUQgPSBsYXN0T3Bjb2RlSUQ7Ci0gICAgICAgIGdlbmVy YXRvci5tX2xhc3RJbnN0cnVjdGlvbiA9IGxhc3RJbnN0cnVjdGlvbjsKLSAgICB9CiB9CiAKIHZv aWQgU3RhdGljUHJvcGVydHlBbmFseXNpczo6cmVjb3JkKCkK