229418 2021-08-23 13:40:17 -0700 Build error preprocessing sandbox 2022-11-11 18:45:44 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247836 InRadar P2 Normal --- 1 pvollan pvollan ap bfulgham webkit-bug-importer oldest_to_newest 1786532 0 pvollan 2021-08-23 13:40:17 -0700 In some cases there are build errors when preprocessing the WebContent sandbox. 1786533 1 pvollan 2021-08-23 13:40:52 -0700 <rdar://81480311> 1786534 2 436231 pvollan 2021-08-23 13:44:14 -0700 Created attachment 436231 Patch 1786543 3 436231 ap 2021-08-23 13:59:52 -0700 Comment on attachment 436231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436231&action=review > Source/WebKit/Scripts/generate-derived-sources.sh:12 > +if [ ! -z ${JAVASCRIPTCORE_PRIVATE_HEADERS_DIR} ]; then -z is "the length of string is zero", can you elaborate on the logic of this check? I expected this to check for sandbox-profiles-ios argument that's passed when building the profiles. 1786564 4 pvollan 2021-08-23 14:33:16 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 436231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436231&action=review > > > Source/WebKit/Scripts/generate-derived-sources.sh:12 > > +if [ ! -z ${JAVASCRIPTCORE_PRIVATE_HEADERS_DIR} ]; then > > -z is "the length of string is zero", can you elaborate on the logic of this > check? > Yes, this checks that the env variable exists (does not have zero length) before using it. If the env variable does not exist, the ln command will fail. > I expected this to check for sandbox-profiles-ios argument that's passed > when building the profiles. I think the above test will cover more cases, in case this should happen under other circumstances. Also, it will continue to work if we should rename the argument. Thanks for reviewing! 1786571 5 ap 2021-08-23 14:49:29 -0700 My concern is that we will get a way more confusing error from make if this happens under other circumstances. So I'd prefer it to be as focused as possible, so that the check is only true when we know it should be true - not when it happens to be true. 1786608 6 pvollan 2021-08-23 16:47:19 -0700 (In reply to Alexey Proskuryakov from comment #5) > My concern is that we will get a way more confusing error from make if this > happens under other circumstances. > > So I'd prefer it to be as focused as possible, so that the check is only > true when we know it should be true - not when it happens to be true. That makes sense, I will update the patch. Thanks for reviewing! 1786779 7 436301 pvollan 2021-08-24 10:02:25 -0700 Created attachment 436301 Patch 1787278 8 436301 pvollan 2021-08-25 13:29:54 -0700 Comment on attachment 436301 Patch Thanks for reviewing! 1787280 9 ews-feeder 2021-08-25 13:33:51 -0700 Committed r281577 (240941@main): <https://commits.webkit.org/240941@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436301. 1787328 10 pvollan 2021-08-25 14:45:58 -0700 Reopening to attach new patch. 1787329 11 436428 pvollan 2021-08-25 14:45:59 -0700 Created attachment 436428 Patch 1787335 12 436428 pvollan 2021-08-25 14:49:39 -0700 Comment on attachment 436428 Patch Thanks for reviewing! 1787358 13 ews-feeder 2021-08-25 15:46:05 -0700 Committed r281595 (240957@main): <https://commits.webkit.org/240957@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436428. 436231 2021-08-23 13:44:14 -0700 2021-08-24 10:02:24 -0700 Patch bug-229418-20210823134414.patch text/plain 1343 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODE0NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTIzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBCdWlsZCBlcnJvciBwcmVwcm9j ZXNzaW5nIHNhbmRib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyOTQxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENoZWNrIGV4aXN0YW5jZSBvZiBlbnYgdmFyaWFibGUgYmVmb3JlIHVzZS4KKworICAg ICAgICAqIFNjcmlwdHMvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoOgorCiAyMDIxLTA4LTIz ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT04gKHIyNzExNDYpOiBlZGl0aW5nL3NlbGVjdGlvbi9pb3Mvc2Nyb2xsaW5nLXRvLWZvY3Vz ZWQtZWxlbWVudC1pbnNpZGUtaWZyYW1lLmh0bWwgaXMgZmFpbGluZwpJbmRleDogU291cmNlL1dl YktpdC9TY3JpcHRzL2dlbmVyYXRlLWRlcml2ZWQtc291cmNlcy5zaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoCShyZXZpc2lv biAyODA3ODQpCisrKyBTb3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtZGVyaXZlZC1zb3Vy Y2VzLnNoCSh3b3JraW5nIGNvcHkpCkBAIC05LDcgKzksOSBAQCBjZCAiJHtCVUlMVF9QUk9EVUNU U19ESVJ9L0Rlcml2ZWRTb3VyY2VzCiAKIGV4cG9ydCBXZWJLaXQyPSIke1NSQ1JPT1R9IgogCi0v YmluL2xuIC1zZmggIiR7SkFWQVNDUklQVENPUkVfUFJJVkFURV9IRUFERVJTX0RJUn0iIEphdmFT Y3JpcHRDb3JlUHJpdmF0ZUhlYWRlcnMKK2lmIFsgISAteiAke0pBVkFTQ1JJUFRDT1JFX1BSSVZB VEVfSEVBREVSU19ESVJ9IF07IHRoZW4KKyAgICAvYmluL2xuIC1zZmggIiR7SkFWQVNDUklQVENP UkVfUFJJVkFURV9IRUFERVJTX0RJUn0iIEphdmFTY3JpcHRDb3JlUHJpdmF0ZUhlYWRlcnMKK2Zp CiBleHBvcnQgSmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVI9IkphdmFTY3JpcHRDb3JlUHJpdmF0 ZUhlYWRlcnMiCiAKIGlmIFsgISAkQ0MgXTsgdGhlbgo= 436301 2021-08-24 10:02:25 -0700 2021-08-25 14:47:36 -0700 Patch bug-229418-20210824100224.patch text/plain 1453 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODE0NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTIzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBCdWlsZCBlcnJvciBwcmVwcm9j ZXNzaW5nIHNhbmRib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyOTQxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFNraXAgdW5uZWVkZWQgY29tbWFuZHMgd2hlbiBwcmVwcm9jZXNzaW5nIHNhbmRib3gg b24gaU9TLgorCisgICAgICAgICogU2NyaXB0cy9nZW5lcmF0ZS1kZXJpdmVkLXNvdXJjZXMuc2g6 CisKIDIwMjEtMDgtMjMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjI3MTE0Nik6IGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9zY3Jv bGxpbmctdG8tZm9jdXNlZC1lbGVtZW50LWluc2lkZS1pZnJhbWUuaHRtbCBpcyBmYWlsaW5nCklu ZGV4OiBTb3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2NyaXB0cy9nZW5lcmF0ZS1kZXJpdmVkLXNvdXJj ZXMuc2gJKHJldmlzaW9uIDI4MDc4NCkKKysrIFNvdXJjZS9XZWJLaXQvU2NyaXB0cy9nZW5lcmF0 ZS1kZXJpdmVkLXNvdXJjZXMuc2gJKHdvcmtpbmcgY29weSkKQEAgLTksOCArOSwxMSBAQCBjZCAi JHtCVUlMVF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzCiAKIGV4cG9ydCBXZWJLaXQyPSIk e1NSQ1JPT1R9IgogCi0vYmluL2xuIC1zZmggIiR7SkFWQVNDUklQVENPUkVfUFJJVkFURV9IRUFE RVJTX0RJUn0iIEphdmFTY3JpcHRDb3JlUHJpdmF0ZUhlYWRlcnMKLWV4cG9ydCBKYXZhU2NyaXB0 Q29yZV9TQ1JJUFRTX0RJUj0iSmF2YVNjcmlwdENvcmVQcml2YXRlSGVhZGVycyIKKworaWYgWyAk MSAhPSAic2FuZGJveC1wcm9maWxlcy1pb3MiIF07IHRoZW4KKyAgICAvYmluL2xuIC1zZmggIiR7 SkFWQVNDUklQVENPUkVfUFJJVkFURV9IRUFERVJTX0RJUn0iIEphdmFTY3JpcHRDb3JlUHJpdmF0 ZUhlYWRlcnMKKyAgICBleHBvcnQgSmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVI9IkphdmFTY3Jp cHRDb3JlUHJpdmF0ZUhlYWRlcnMiCitmaQogCiBpZiBbICEgJENDIF07IHRoZW4KICAgICBleHBv cnQgQ0M9ImB4Y3J1biAtZmluZCBjbGFuZ2AiCg== 436428 2021-08-25 14:45:59 -0700 2021-08-25 15:46:05 -0700 Patch bug-229418-20210825144558.patch text/plain 1261 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODE1ODgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTI1ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBCdWlsZCBlcnJvciBwcmVwcm9j ZXNzaW5nIHNhbmRib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyOTQxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1aWxkIGZpeCBhZnRlciBodHRwczovL2NvbW1pdHMud2Via2l0Lm9yZy8yNDA5NDFA bWFpbi4KKworICAgICAgICAqIFNjcmlwdHMvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoOgor CiAyMDIxLTA4LTI1ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBDcmFzaCB3aGVuIHRhcHBpbmcgPHNlbGVjdD4gZWxlbWVudCBhbmQgY2FsbGlu ZyB3aW5kb3cub3BlbigpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtZGVy aXZlZC1zb3VyY2VzLnNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2NyaXB0cy9nZW5l cmF0ZS1kZXJpdmVkLXNvdXJjZXMuc2gJKHJldmlzaW9uIDI4MTU4OCkKKysrIFNvdXJjZS9XZWJL aXQvU2NyaXB0cy9nZW5lcmF0ZS1kZXJpdmVkLXNvdXJjZXMuc2gJKHdvcmtpbmcgY29weSkKQEAg LTEwLDcgKzEwLDcgQEAgY2QgIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcwog ZXhwb3J0IFdlYktpdDI9IiR7U1JDUk9PVH0iCiAKIAotaWYgWyAkMSAhPSAic2FuZGJveC1wcm9m aWxlcy1pb3MiIF07IHRoZW4KK2lmIFsgLXogJDEgXSB8fCBbICQxICE9ICJzYW5kYm94LXByb2Zp bGVzLWlvcyIgXTsgdGhlbgogICAgIC9iaW4vbG4gLXNmaCAiJHtKQVZBU0NSSVBUQ09SRV9QUklW QVRFX0hFQURFUlNfRElSfSIgSmF2YVNjcmlwdENvcmVQcml2YXRlSGVhZGVycwogICAgIGV4cG9y dCBKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUj0iSmF2YVNjcmlwdENvcmVQcml2YXRlSGVhZGVy cyIKIGZpCg==