229416 2021-08-23 12:37:29 -0700 [GTK] Add webkit_web_view_try_close stay event 2021-08-23 23:39:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 jan.brummer webkit-unassigned berto cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1786512 0 jan.brummer 2021-08-23 12:37:29 -0700 [GTK] Add webkit_web_view_try_close stay event 1786513 1 436225 jan.brummer 2021-08-23 12:37:56 -0700 Created attachment 436225 Patch 1786515 2 ews-watchlist 2021-08-23 12:38:43 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1786516 3 436225 mcatanzaro 2021-08-23 12:50:24 -0700 Comment on attachment 436225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436225&action=review API looks good. We can bikeshed about the naming. I think I would call it: WebKitWebView::close-rejected, UIClient::closeRejected, webkitWebViewCloseRejected. But your naming is fine too. I wonder if others have suggestions? r- for now because it needs an API test. > Source/WebKit/ChangeLog:8 > + No new tests (OOPS!). You'll need to replace this line with an explanation of why the new API is required. > Source/WebKit/UIProcess/API/APIUIClient.h:89 > + virtual void stayOnPage(WebKit::WebPageProxy*) { } Technically we need an owner to approve this line of the diff, but that shouldn't be a problem since it's only one line and obviously OK. 1786672 4 436225 cgarcia 2021-08-23 23:39:42 -0700 Comment on attachment 436225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436225&action=review >> Source/WebKit/UIProcess/API/APIUIClient.h:89 >> + virtual void stayOnPage(WebKit::WebPageProxy*) { } > > Technically we need an owner to approve this line of the diff, but that shouldn't be a problem since it's only one line and obviously OK. This name sounds like the user needs to take an action, but it's just a notification. I would use something like didNotClose, didCancelClose or something like that. > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:176 > + STAY_ON_PAGE, And same for the glib api signal. > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1685 > + * Emitted when try closing a #WebKitWebView is aborted. We should document here why close can fail. And you also need to update the webkit_web_view_try_close() doc that says that nothing happens when user cancels the close. > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2530 > + g_signal_emit(webView, signals[STAY_ON_PAGE], 0, NULL); NULL -> nullptr 436225 2021-08-23 12:37:56 -0700 2021-08-23 12:50:24 -0700 Patch bug-229416-20210823213755.patch text/plain 6533 jan.brummer U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRiNjdjYzQ5NDI3ZGJlZTEy OTQzMDhiNjJlYzMxYzU2ZWQ4OTEwYWQuLmZlZTgyOWE5NGIxZmFjZjFlZjhjNjYxN2I3NTBkZWJm NTllOTU4N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDgtMjMgIEphbi1NaWNo YWVsIEJydW1tZXIgIDxqYW4uYnJ1bW1lckB0YWJvcy5vcmc+CisKKyAgICAgICAgW0dUS10gQWRk IHdlYmtpdF93ZWJfdmlld190cnlfY2xvc2Ugc3RheSBldmVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NDE2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSVVJQ2xpZW50Lmg6CisgICAgICAgIChBUEk6OlVJQ2xp ZW50OjpzdGF5T25QYWdlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlD bGllbnQuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNw cDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KToKKyAgICAgICAgKHdlYmtp dFdlYlZpZXdTdGF5T25QYWdlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 V2ViVmlld1ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojp0cnlDbG9zZSk6CisgICAgICAgICogVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorCiAyMDIxLTA4LTE5ICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBhIFJlZjw+IGFyZ3VtZW50IHRvIGtl ZXAgV2ViUGFnZSBhbGl2ZSBpbiBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6ZGlzcGF0 Y2hBZnRlckVuc3VyaW5nVXBkYXRlZFNjcm9sbFBvc2l0aW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElVSUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0FQSVVJQ2xpZW50LmgKaW5kZXggNjJhOWJmY2U2NjIyOWFmZjAzZDBjZGZiYTIx NmEzMDliZDIxYzMzNC4uZWY5Y2Q0ZDgyNGUxYzAwYzlhMjhlZjhmZTYzZDY1NjViMjU3MTI0MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSVVJQ2xpZW50LmgKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSVVJQ2xpZW50LmgKQEAgLTg2LDYgKzg2 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRFeGl0RnVsbHNjcmVlbihXZWJLaXQ6 OldlYlBhZ2VQcm94eSopIHsgfQogICAgIHZpcnR1YWwgdm9pZCBoYXNWaWRlb0luUGljdHVyZUlu UGljdHVyZURpZENoYW5nZShXZWJLaXQ6OldlYlBhZ2VQcm94eSosIGJvb2wpIHsgfQogICAgIHZp cnR1YWwgdm9pZCBjbG9zZShXZWJLaXQ6OldlYlBhZ2VQcm94eSopIHsgfQorICAgIHZpcnR1YWwg dm9pZCBzdGF5T25QYWdlKFdlYktpdDo6V2ViUGFnZVByb3h5KikgeyB9CiAKICAgICB2aXJ0dWFs IGJvb2wgdGFrZUZvY3VzKFdlYktpdDo6V2ViUGFnZVByb3h5KiwgV0tGb2N1c0RpcmVjdGlvbikg eyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIHZvaWQgZm9jdXMoV2ViS2l0OjpXZWJQYWdl UHJveHkqKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFVJQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFVJQ2xpZW50LmNwcAppbmRleCA2YzFjZjQ1NDQzNjMzZTRjNTQ4YzE0NjY1N2JkNTJhNTc0 MzYyYWIzLi5mZTZlZDhkNDg2NDFhYzVlNzlmN2E0NWVmYzM0ZmFkN2RhNTExZWM4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGllbnQuY3Bw CkBAIC04MSw2ICs4MSwxMSBAQCBwcml2YXRlOgogICAgICAgICB3ZWJraXRXZWJWaWV3Q2xvc2VQ YWdlKG1fd2ViVmlldyk7CiAgICAgfQogCisgICAgdm9pZCBzdGF5T25QYWdlKFdlYlBhZ2VQcm94 eSopIGZpbmFsCisgICAgeworICAgICAgICB3ZWJraXRXZWJWaWV3U3RheU9uUGFnZShtX3dlYlZp ZXcpOworICAgIH0KKwogICAgIHZvaWQgcnVuSmF2YVNjcmlwdEFsZXJ0KFdlYlBhZ2VQcm94eSYg cGFnZSwgY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBXZWJGcmFtZVByb3h5KiwgV2ViS2l0OjpGcmFt ZUluZm9EYXRhJiYsIEZ1bmN0aW9uPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikgZmluYWwK ICAgICB7CiAgICAgICAgIHBhZ2UubWFrZVZpZXdCbGFua0lmVW5wYWludGVkU2luY2VMYXN0TG9h ZENvbW1pdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv V2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRXZWJWaWV3LmNwcAppbmRleCA1NTQzNGQ4YTA5ZmNmYWI3OTU0ZjJhN2VkYzI3OTk2ZGU0MDk1 NmRkLi44NjU0NGM2YTdjMmExYmQxMTNjNDk0YzM3NDBkZTc2Y2ZjMWRhMTUwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcApAQCAt MTczLDYgKzE3Myw4IEBAIGVudW0gewogCiAgICAgVVNFUl9NRVNTQUdFX1JFQ0VJVkVELAogCisg ICAgU1RBWV9PTl9QQUdFLAorCiAgICAgTEFTVF9TSUdOQUwKIH07CiAKQEAgLTE2NzYsNiArMTY3 OCwyMyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJW aWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgICAgICAgICAgICAgICAgIGdfY2Nsb3N1cmVf bWFyc2hhbF9WT0lEX19WT0lELAogICAgICAgICAgICAgICAgICAgICAgR19UWVBFX05PTkUsIDAp OwogCisgICAgLyoqCisgICAgICogV2ViS2l0V2ViVmlldzo6c3RheS1vbi1wYWdlOgorICAgICAq IEB3ZWJfdmlldzogdGhlICNXZWJLaXRXZWJWaWV3IG9uIHdoaWNoIHRoZSBzaWduYWwgaXMgZW1p dHRlZAorICAgICAqCisgICAgICogRW1pdHRlZCB3aGVuIHRyeSBjbG9zaW5nIGEgI1dlYktpdFdl YlZpZXcgaXMgYWJvcnRlZC4KKyAgICAgKgorICAgICAqIFNpbmNlOiAyLjM0CisgICAgICovCisg ICAgc2lnbmFsc1tTVEFZX09OX1BBR0VdID0KKyAgICAgICAgZ19zaWduYWxfbmV3KCJzdGF5LW9u LXBhZ2UiLAorICAgICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1Mod2ViVmlld0NsYXNzKSwKKyAg ICAgICAgICAgIEdfU0lHTkFMX1JVTl9MQVNULAorICAgICAgICAgICAgR19TVFJVQ1RfT0ZGU0VU KFdlYktpdFdlYlZpZXdDbGFzcywgY2xvc2UpLAorICAgICAgICAgICAgMCwgMCwKKyAgICAgICAg ICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19WT0lELAorICAgICAgICAgICAgR19UWVBFX05P TkUsIDApOworCiAgICAgLyoqCiAgICAgICogV2ViS2l0V2ViVmlldzo6c2NyaXB0LWRpYWxvZzoK ICAgICAgKiBAd2ViX3ZpZXc6IHRoZSAjV2ViS2l0V2ViVmlldyBvbiB3aGljaCB0aGUgc2lnbmFs IGlzIGVtaXR0ZWQKQEAgLTI1MDYsNiArMjUyNSwxMSBAQCB2b2lkIHdlYmtpdFdlYlZpZXdDbG9z ZVBhZ2UoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICBnX3NpZ25hbF9lbWl0KHdlYlZpZXcs IHNpZ25hbHNbQ0xPU0VdLCAwLCBOVUxMKTsKIH0KIAordm9pZCB3ZWJraXRXZWJWaWV3U3RheU9u UGFnZShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQoreworICAgIGdfc2lnbmFsX2VtaXQod2ViVmll dywgc2lnbmFsc1tTVEFZX09OX1BBR0VdLCAwLCBOVUxMKTsKK30KKwogdm9pZCB3ZWJraXRXZWJW aWV3UnVuSmF2YVNjcmlwdEFsZXJ0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IENTdHJp bmcmIG1lc3NhZ2UsIEZ1bmN0aW9uPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKIHsKICAg ICBBU1NFUlQoIXdlYlZpZXctPnByaXYtPmN1cnJlbnRTY3JpcHREaWFsb2cpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlld1ByaXZhdGUu aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXdQcml2YXRl LmgKaW5kZXggZmJhYjFhZmU5Y2EwOWY1ZTZhNjc5M2Y1MDY1ZjA4ZmM3NmJmZWRhZi4uMGQ0Y2I5 ZTU3ZTllM2I2ZTE2NTQ1ZTI5NjhiMmJmMGM1OGNjMDgzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3UHJpdmF0ZS5oCkBAIC01 Niw2ICs1Niw3IEBAIFJlZlB0cjxXZWJLaXQ6OldlYlBhZ2VQcm94eT4gd2Via2l0V2ViVmlld0Ny ZWF0ZU5ld1BhZ2UoV2ViS2l0V2ViVmlldyosIGNvbnN0IFdlCiB2b2lkIHdlYmtpdFdlYlZpZXdS ZWFkeVRvU2hvd1BhZ2UoV2ViS2l0V2ViVmlldyopOwogdm9pZCB3ZWJraXRXZWJWaWV3UnVuQXNN b2RhbChXZWJLaXRXZWJWaWV3Kik7CiB2b2lkIHdlYmtpdFdlYlZpZXdDbG9zZVBhZ2UoV2ViS2l0 V2ViVmlldyopOwordm9pZCB3ZWJraXRXZWJWaWV3U3RheU9uUGFnZShXZWJLaXRXZWJWaWV3Kik7 CiB2b2lkIHdlYmtpdFdlYlZpZXdSdW5KYXZhU2NyaXB0QWxlcnQoV2ViS2l0V2ViVmlldyosIGNv bnN0IENTdHJpbmcmIG1lc3NhZ2UsIEZ1bmN0aW9uPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxl cik7CiB2b2lkIHdlYmtpdFdlYlZpZXdSdW5KYXZhU2NyaXB0Q29uZmlybShXZWJLaXRXZWJWaWV3 KiwgY29uc3QgQ1N0cmluZyYgbWVzc2FnZSwgRnVuY3Rpb248dm9pZChib29sKT4mJiBjb21wbGV0 aW9uSGFuZGxlcik7CiB2b2lkIHdlYmtpdFdlYlZpZXdSdW5KYXZhU2NyaXB0UHJvbXB0KFdlYktp dFdlYlZpZXcqLCBjb25zdCBDU3RyaW5nJiBtZXNzYWdlLCBjb25zdCBDU3RyaW5nJiBkZWZhdWx0 VGV4dCwgRnVuY3Rpb248dm9pZChjb25zdCBTdHJpbmcmKT4mJiBjb21wbGV0aW9uSGFuZGxlcik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBmMTkwOTIyNTA5 YzdkYWI0YmMxZDJkZTIzZDQzZmRjYjRlODIyMGVjLi4wMzlmY2E1YmQ4OWNmNTRiN2QyNzZlZGQ1 MmFlYWU0ZGEyZjk1YWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKQEAgLTEyMzYsNiArMTIzNiw4IEBAIGJvb2wgV2ViUGFnZVByb3h5Ojp0cnlDbG9zZSgpCiAg ICAgICAgIG1fdHJ5Q2xvc2VUaW1lb3V0VGltZXIuc3RvcCgpOwogICAgICAgICBpZiAoc2hvdWxk Q2xvc2UpCiAgICAgICAgICAgICBjbG9zZVBhZ2UoKTsKKyAgICAgICAgZWxzZQorICAgICAgICAg ICAgbV91aUNsaWVudC0+c3RheU9uUGFnZSh0aGlzKTsKICAgICB9KTsKICAgICByZXR1cm4gZmFs c2U7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IDNiZGNkZmRl MTU3MmEwNWUyNDQyNjk3NjYyNDMzZmYyZTk2ODA0YTUuLmZiYjAxNWYwMWM4YWQyZWM2OTQxMTg0 NTA2MDkzMGFiMGIxMzhhZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5o CkBAIC02MzYsNiArNjM2LDcgQEAgcHVibGljOgogICAgIHZvaWQgZGlkRXhjZWVkQmFja2dyb3Vu ZENQVUxpbWl0V2hpbGVJbkZvcmVncm91bmQoKTsKIAogICAgIHZvaWQgY2xvc2VQYWdlKCk7Cisg ICAgdm9pZCBzdGF5T25QYWdlKCk7CiAKICAgICB2b2lkIGFkZFBsYXRmb3JtTG9hZFBhcmFtZXRl cnMoV2ViUHJvY2Vzc1Byb3h5JiwgTG9hZFBhcmFtZXRlcnMmKTsKICAgICBSZWZQdHI8QVBJOjpO YXZpZ2F0aW9uPiBsb2FkUmVxdWVzdChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiwgV2ViQ29y ZTo6U2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeSA9IFdlYkNvcmU6OlNob3VsZE9wZW5FeHRl cm5hbFVSTHNQb2xpY3k6OlNob3VsZEFsbG93RXh0ZXJuYWxTY2hlbWVzQnV0Tm90QXBwTGlua3Ms IEFQSTo6T2JqZWN0KiB1c2VyRGF0YSA9IG51bGxwdHIpOwo=