229412 2021-08-23 11:15:15 -0700 compileEnumeratorHasProperty uses flushRegisters incorrectly 2021-08-24 09:54:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tsavell tzagallo webkit-bug-importer oldest_to_newest 1786479 0 saam 2021-08-23 11:15:15 -0700 ... 1786480 1 saam 2021-08-23 11:17:39 -0700 <rdar://82020767> 1786489 2 436214 saam 2021-08-23 11:38:44 -0700 Created attachment 436214 patch 1786491 3 436214 keith_miller 2021-08-23 11:49:48 -0700 Comment on attachment 436214 patch View in context: https://bugs.webkit.org/attachment.cgi?id=436214&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:13723 > + addSlowPathGenerator(slowPathCall(slowCase, this, slowPathFunction, resultRegs, TrustedImmPtr::weakPointer(m_graph, m_graph.globalObjectFor(node->origin.semantic)), baseRegs, propertyNameRegs, indexGPR, modeGPR)); I don't think this is really a slow path. For example, in an indexed for-in loop you'll always take this call. Maybe this should be a silent spill/fill or flush? If you do change it to silent spill/fill can you also fix compileEnumeratorNextUpdatePropertyName to do the same. 1786499 4 436221 saam 2021-08-23 12:13:24 -0700 Created attachment 436221 patch 1786500 5 436221 keith_miller 2021-08-23 12:14:39 -0700 Comment on attachment 436221 patch r=me 1786570 6 ews-feeder 2021-08-23 14:44:27 -0700 Committed r281473 (240852@main): <https://commits.webkit.org/240852@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436221. 1786769 7 tsavell 2021-08-24 09:50:14 -0700 It looks like the new tests added in https://trac.webkit.org/changeset/281473/webkit are constant failing on Debug History example: https://results.webkit.org/?suite=javascriptcore-tests&test=stress%2Ffor-in-in-by-val-shouldnt-flush-registers.js.no-llint build: https://build.webkit.org/#/builders/100/builds/736 1786772 8 keith_miller 2021-08-24 09:54:28 -0700 (In reply to Truitt Savell from comment #7) > It looks like the new tests added in > https://trac.webkit.org/changeset/281473/webkit > are constant failing on Debug > > History example: > https://results.webkit.org/?suite=javascriptcore-tests&test=stress%2Ffor-in- > in-by-val-shouldnt-flush-registers.js.no-llint > > build: > https://build.webkit.org/#/builders/100/builds/736 Seems like a missing exception check. I'll fix. 436214 2021-08-23 11:38:44 -0700 2021-08-23 12:13:24 -0700 patch a-backup.diff text/plain 5527 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODE0NTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDIxLTA4LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIGNvbXBpbGVFbnVtZXJhdG9ySGFzUHJvcGVydHkgdXNlcyBmbHVzaFJl Z2lzdGVycyBpbmNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI5NDEyCisgICAgICAgIDxyZGFyOi8vODIwMjA3Njc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZm9yLWluLWhh cy1vd24tcHJvcGVydHktc2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpzOiBBZGRlZC4KKyAgICAg ICAgKGZvbyk6CisgICAgICAgICogc3RyZXNzL2Zvci1pbi1pbi1ieS12YWwtc2hvdWxkbnQtZmx1 c2gtcmVnaXN0ZXJzLmpzOiBBZGRlZC4KKyAgICAgICAgKGEudG9TdHJpbmcpOgorCiAyMDIxLTA4 LTIyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10g UmVtb3ZlIGFscmVhZHktc2hpcHBlZCB3YXNtIG9wdGlvbiBmbGFncwpJbmRleDogSlNUZXN0cy9z dHJlc3MvZm9yLWluLWhhcy1vd24tcHJvcGVydHktc2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1oYXMtb3duLXByb3BlcnR5LXNo b3VsZG50LWZsdXNoLXJlZ2lzdGVycy5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVz cy9mb3ItaW4taGFzLW93bi1wcm9wZXJ0eS1zaG91bGRudC1mbHVzaC1yZWdpc3RlcnMuanMJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwxMSBAQAorZnVuY3Rpb24gZm9vKG8pIHsKKyAgICBmb3Ig KGxldCBwIGluIG8pIHsKKyAgICAgICAgby5oYXNPd25Qcm9wZXJ0eShwKTsKKyAgICAgICAgby5f X3Byb3RvX18gPSB1bmRlZmluZWQ7CisgICAgfQorfQorCitmb3IgKGxldCBpID0gMDsgaSA8IDEw MDAwMDsgKytpKSB7CisgICAgZm9vKHtmOjQyfSk7Cit9CisKSW5kZXg6IEpTVGVzdHMvc3RyZXNz L2Zvci1pbi1pbi1ieS12YWwtc2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1pbi1ieS12YWwtc2hvdWxkbnQtZmx1c2gtcmVnaXN0 ZXJzLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1pbi1ieS12YWwt c2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTMg QEAKK2NvbnN0IGEgPSBbdW5kZWZpbmVkXTsKK2EudG9TdHJpbmcgPSAoKT0+e307CisKK2Z1bmN0 aW9uIGZvbygpIHsKKyAgICBmb3IgKGxldCB4IGluIGEpIHsKKyAgICAgIHggaW4gYTsKKyAgICAg ICt4OworICAgIH0KK30KKworZm9yIChsZXQgaT0wOyBpPDEwMDAwOyBpKyspIHsKKyAgZm9vKCk7 Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MTQ1NCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwy MCBAQAorMjAyMS0wOC0yMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAg ICAgICBjb21waWxlRW51bWVyYXRvckhhc1Byb3BlcnR5IHVzZXMgZmx1c2hSZWdpc3RlcnMgaW5j b3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyOTQxMgorICAgICAgICA8cmRhcjovLzgyMDIwNzY3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgY2FsbGluZyBmbHVzaFJlZ2lzdGVy cygpIGluc2lkZSBjb2RlIHRoYXQgaXNuJ3QgYWx3YXlzIHJ1bnMgaW5zaWRlIHRoZQorICAgICAg ICBFbnVtZXJhdG9ySW5CeVZhbC9FbnVtZXJhdG9ySGFzT3duUHJvcGVydHkgbm9kZXMuIFRoYXQg aXMgYSB2aW9sYXRpb24gb2YgaG93CisgICAgICAgIGZsdXNoUmVnaXN0ZXJzKCkgbXVzdCBiZSB1 c2VkLCBzaW5jZSBmbHVzaFJlZ2lzdGVycygpIHVwZGF0ZXMgZ2xvYmFsIHJlZ2lzdGVyCisgICAg ICAgIGFsbG9jYXRpb24gc3RhdGUsIGFuZCB0aGVyZWZvcmUgbXVzdCBydW4gZWFjaCB0aW1lIGEg bm9kZSBpcyBydW4uIEluc3RlYWQsIHdlCisgICAgICAgIHVzZSBhIHNsb3cgcGF0aCBjYWxsIGdl bmVyYXRvciwgd2hpY2ggZG9lcyBzaWxlbnQgc3BpbGwvc2lsZW50IGZpbGwuCisKKyAgICAgICAg KiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0 aXZlSklUOjpjb21waWxlRW51bWVyYXRvckhhc1Byb3BlcnR5KToKKwogMjAyMS0wOC0yMyAgWXVz dWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIGVtaXRBcnJh eVByb2ZpbGluZ1NpdGVXaXRoQ2VsbCBzaG91bGQgbm90IGxvYWQgaW5kZXhpbmdUeXBlIHVubmVj ZXNzYXJpbHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK SVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3Vs YXRpdmVKSVQuY3BwCShyZXZpc2lvbiAyODE0NTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM2OTUsMzMgKzEz Njk1LDM2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVFbnVtZXJhdG9ySGEKICAgICAg ICAgSlNWYWx1ZVJlZ3NUZW1wb3JhcnkgcmVzdWx0KHRoaXMpOwogICAgICAgICBKU1ZhbHVlUmVn cyByZXN1bHRSZWdzID0gcmVzdWx0LnJlZ3MoKTsKIAotICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6 SnVtcExpc3Qgb3BlcmF0aW9uQ2FzZXM7CisgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpKdW1wTGlz dCBzbG93Q2FzZTsKIAogICAgICAgICBpZiAobV9zdGF0ZS5mb3JOb2RlKGJhc2VFZGdlKS5tX3R5 cGUgJiB+U3BlY0NlbGwpCi0gICAgICAgICAgICBvcGVyYXRpb25DYXNlcy5hcHBlbmQobV9qaXQu YnJhbmNoSWZOb3RDZWxsKGJhc2UpKTsKKyAgICAgICAgICAgIHNsb3dDYXNlLmFwcGVuZChtX2pp dC5icmFuY2hJZk5vdENlbGwoYmFzZSkpOwogCiAgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGRu J3QgZ2VuZXJhdGUgdGhpcyBjb2RlIGlmIHdlIGtub3cgYmFzZSBpcyBub3QgYSBjZWxsLgotICAg ICAgICBvcGVyYXRpb25DYXNlcy5hcHBlbmQobV9qaXQuYnJhbmNoVGVzdDMyKE1hY3JvQXNzZW1i bGVyOjpaZXJvLCBtb2RlR1BSLCBUcnVzdGVkSW1tMzIoSlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9y OjpPd25TdHJ1Y3R1cmVNb2RlKSkpOworICAgICAgICBzbG93Q2FzZS5hcHBlbmQobV9qaXQuYnJh bmNoVGVzdDMyKE1hY3JvQXNzZW1ibGVyOjpaZXJvLCBtb2RlR1BSLCBUcnVzdGVkSW1tMzIoSlNQ cm9wZXJ0eU5hbWVFbnVtZXJhdG9yOjpPd25TdHJ1Y3R1cmVNb2RlKSkpOwogCiAgICAgICAgIG1f aml0LmxvYWQzMihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlQ2VsbEdQUiwgSlNDZWxsOjpz dHJ1Y3R1cmVJRE9mZnNldCgpKSwgcmVzdWx0UmVncy5wYXlsb2FkR1BSKCkpOwotICAgICAgICBv cGVyYXRpb25DYXNlcy5hcHBlbmQobV9qaXQuYnJhbmNoMzIoTWFjcm9Bc3NlbWJsZXI6Ok5vdEVx dWFsLCByZXN1bHRSZWdzLnBheWxvYWRHUFIoKSwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoZW51 bWVyYXRvckdQUiwgSlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9yOjpjYWNoZWRTdHJ1Y3R1cmVJRE9m ZnNldCgpKSkpOworICAgICAgICBzbG93Q2FzZS5hcHBlbmQobV9qaXQuYnJhbmNoMzIoTWFjcm9B c3NlbWJsZXI6Ok5vdEVxdWFsLCByZXN1bHRSZWdzLnBheWxvYWRHUFIoKSwgTWFjcm9Bc3NlbWJs ZXI6OkFkZHJlc3MoZW51bWVyYXRvckdQUiwgSlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9yOjpjYWNo ZWRTdHJ1Y3R1cmVJRE9mZnNldCgpKSkpOwogCiAgICAgICAgIG1vdmVUcnVlVG8ocmVzdWx0UmVn cy5wYXlsb2FkR1BSKCkpOwotICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBkb25lID0gbV9q aXQuanVtcCgpOwotCi0gICAgICAgIG9wZXJhdGlvbkNhc2VzLmxpbmsoJm1faml0KTsKIAotICAg ICAgICBmbHVzaFJlZ2lzdGVycygpOwogI2lmIFVTRShKU1ZBTFVFMzJfNjQpCisgICAgICAgIE1h Y3JvQXNzZW1ibGVyOjpKdW1wIGRvbmUgPSBtX2ppdC5qdW1wKCk7CisKKyAgICAgICAgc2xvd0Nh c2UubGluaygmbV9qaXQpOwogICAgICAgICBtX2ppdC5tb3ZlKFRydXN0ZWRJbW0zMihKU1ZhbHVl OjpDZWxsVGFnKSwgcmVzdWx0UmVncy50YWdHUFIoKSk7CiAgICAgICAgIGF1dG8gYmFzZVJlZ3Mg PSBKU1ZhbHVlUmVncyhiYXNlQ2VsbEdQUiwgcmVzdWx0UmVncy50YWdHUFIoKSk7CisgICAgICAg IHNsb3dDYXNlLmNsZWFyKCk7CisgICAgICAgIHNsb3dDYXNlLmFwcGVuZChtX2ppdC5qdW1wKCkp OwogI2Vsc2UKICAgICAgICAgYXV0byBiYXNlUmVncyA9IGJhc2U7CiAjZW5kaWYKLSAgICAgICAg Y2FsbE9wZXJhdGlvbihzbG93UGF0aEZ1bmN0aW9uLCByZXN1bHRSZWdzLCBUcnVzdGVkSW1tUHRy Ojp3ZWFrUG9pbnRlcihtX2dyYXBoLCBtX2dyYXBoLmdsb2JhbE9iamVjdEZvcihub2RlLT5vcmln aW4uc2VtYW50aWMpKSwgYmFzZVJlZ3MsIHByb3BlcnR5TmFtZVJlZ3MsIGluZGV4R1BSLCBtb2Rl R1BSKTsKLSAgICAgICAgbV9qaXQuZXhjZXB0aW9uQ2hlY2soKTsKIAorICAgICAgICBhZGRTbG93 UGF0aEdlbmVyYXRvcihzbG93UGF0aENhbGwoc2xvd0Nhc2UsIHRoaXMsIHNsb3dQYXRoRnVuY3Rp b24sIHJlc3VsdFJlZ3MsIFRydXN0ZWRJbW1QdHI6OndlYWtQb2ludGVyKG1fZ3JhcGgsIG1fZ3Jh cGguZ2xvYmFsT2JqZWN0Rm9yKG5vZGUtPm9yaWdpbi5zZW1hbnRpYykpLCBiYXNlUmVncywgcHJv cGVydHlOYW1lUmVncywgaW5kZXhHUFIsIG1vZGVHUFIpKTsKKworI2lmIFVTRShKU1ZBTFVFMzJf NjQpCiAgICAgICAgIGRvbmUubGluaygmbV9qaXQpOworI2VuZGlmCiAKICAgICAgICAgYmxlc3Nl ZEJvb2xlYW5SZXN1bHQocmVzdWx0UmVncy5wYXlsb2FkR1BSKCksIG5vZGUpOwogICAgIH07Cg== 436221 2021-08-23 12:13:24 -0700 2021-08-23 14:44:28 -0700 patch a-backup.diff text/plain 3695 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODE0NTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDIxLTA4LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIGNvbXBpbGVFbnVtZXJhdG9ySGFzUHJvcGVydHkgdXNlcyBmbHVzaFJl Z2lzdGVycyBpbmNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI5NDEyCisgICAgICAgIDxyZGFyOi8vODIwMjA3Njc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZm9yLWluLWhh cy1vd24tcHJvcGVydHktc2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpzOiBBZGRlZC4KKyAgICAg ICAgKGZvbyk6CisgICAgICAgICogc3RyZXNzL2Zvci1pbi1pbi1ieS12YWwtc2hvdWxkbnQtZmx1 c2gtcmVnaXN0ZXJzLmpzOiBBZGRlZC4KKyAgICAgICAgKGEudG9TdHJpbmcpOgorCiAyMDIxLTA4 LTIyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10g UmVtb3ZlIGFscmVhZHktc2hpcHBlZCB3YXNtIG9wdGlvbiBmbGFncwpJbmRleDogSlNUZXN0cy9z dHJlc3MvZm9yLWluLWhhcy1vd24tcHJvcGVydHktc2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1oYXMtb3duLXByb3BlcnR5LXNo b3VsZG50LWZsdXNoLXJlZ2lzdGVycy5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVz cy9mb3ItaW4taGFzLW93bi1wcm9wZXJ0eS1zaG91bGRudC1mbHVzaC1yZWdpc3RlcnMuanMJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwxMSBAQAorZnVuY3Rpb24gZm9vKG8pIHsKKyAgICBmb3Ig KGxldCBwIGluIG8pIHsKKyAgICAgICAgby5oYXNPd25Qcm9wZXJ0eShwKTsKKyAgICAgICAgby5f X3Byb3RvX18gPSB1bmRlZmluZWQ7CisgICAgfQorfQorCitmb3IgKGxldCBpID0gMDsgaSA8IDEw MDAwMDsgKytpKSB7CisgICAgZm9vKHtmOjQyfSk7Cit9CisKSW5kZXg6IEpTVGVzdHMvc3RyZXNz L2Zvci1pbi1pbi1ieS12YWwtc2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1pbi1ieS12YWwtc2hvdWxkbnQtZmx1c2gtcmVnaXN0 ZXJzLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2Zvci1pbi1pbi1ieS12YWwt c2hvdWxkbnQtZmx1c2gtcmVnaXN0ZXJzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTMg QEAKK2NvbnN0IGEgPSBbdW5kZWZpbmVkXTsKK2EudG9TdHJpbmcgPSAoKT0+e307CisKK2Z1bmN0 aW9uIGZvbygpIHsKKyAgICBmb3IgKGxldCB4IGluIGEpIHsKKyAgICAgIHggaW4gYTsKKyAgICAg ICt4OworICAgIH0KK30KKworZm9yIChsZXQgaT0wOyBpPDEwMDAwOyBpKyspIHsKKyAgZm9vKCk7 Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MTQ1NCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwy MCBAQAorMjAyMS0wOC0yMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAg ICAgICBjb21waWxlRW51bWVyYXRvckhhc1Byb3BlcnR5IHVzZXMgZmx1c2hSZWdpc3RlcnMgaW5j b3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyOTQxMgorICAgICAgICA8cmRhcjovLzgyMDIwNzY3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgY2FsbGluZyBmbHVzaFJlZ2lzdGVy cygpIGluc2lkZSBjb2RlIHRoYXQgaXNuJ3QgYWx3YXlzIHJ1bnMgaW5zaWRlIHRoZQorICAgICAg ICBFbnVtZXJhdG9ySW5CeVZhbC9FbnVtZXJhdG9ySGFzT3duUHJvcGVydHkgbm9kZXMuIFRoYXQg aXMgYSB2aW9sYXRpb24gb2YgaG93CisgICAgICAgIGZsdXNoUmVnaXN0ZXJzKCkgbXVzdCBiZSB1 c2VkLCBzaW5jZSBmbHVzaFJlZ2lzdGVycygpIHVwZGF0ZXMgZ2xvYmFsIHJlZ2lzdGVyCisgICAg ICAgIGFsbG9jYXRpb24gc3RhdGUsIGFuZCB0aGVyZWZvcmUgbXVzdCBydW4gZWFjaCB0aW1lIGEg bm9kZSBpcyBydW4uIFRvIGZpeCwgd2UKKyAgICAgICAgbW92ZSBmbHVzaFJlZ2lzdGVycygpIGJl Zm9yZSB0aGUgY29kZSBzdGFydHMgZW1pdHRpbmcgYnJhbmNoZXMuCisKKyAgICAgICAgKiBkZmcv REZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklU Ojpjb21waWxlRW51bWVyYXRvckhhc1Byb3BlcnR5KToKKwogMjAyMS0wOC0yMyAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIGVtaXRBcnJheVByb2Zp bGluZ1NpdGVXaXRoQ2VsbCBzaG91bGQgbm90IGxvYWQgaW5kZXhpbmdUeXBlIHVubmVjZXNzYXJp bHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK SVQuY3BwCShyZXZpc2lvbiAyODE0NTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM2OTIsNiArMTM2OTIsOCBA QCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlRW51bWVyYXRvckhhCiAgICAgICAgIEdQUlJl ZyBtb2RlR1BSID0gbW9kZS5ncHIoKTsKICAgICAgICAgR1BSUmVnIGVudW1lcmF0b3JHUFIgPSBl bnVtZXJhdG9yLmdwcigpOwogCisgICAgICAgIGZsdXNoUmVnaXN0ZXJzKCk7CisKICAgICAgICAg SlNWYWx1ZVJlZ3NUZW1wb3JhcnkgcmVzdWx0KHRoaXMpOwogICAgICAgICBKU1ZhbHVlUmVncyBy ZXN1bHRSZWdzID0gcmVzdWx0LnJlZ3MoKTsKIApAQCAtMTM3MTEsNyArMTM3MTMsNiBAQCB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlRW51bWVyYXRvckhhCiAKICAgICAgICAgb3BlcmF0aW9u Q2FzZXMubGluaygmbV9qaXQpOwogCi0gICAgICAgIGZsdXNoUmVnaXN0ZXJzKCk7CiAjaWYgVVNF KEpTVkFMVUUzMl82NCkKICAgICAgICAgbV9qaXQubW92ZShUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6 Q2VsbFRhZyksIHJlc3VsdFJlZ3MudGFnR1BSKCkpOwogICAgICAgICBhdXRvIGJhc2VSZWdzID0g SlNWYWx1ZVJlZ3MoYmFzZUNlbGxHUFIsIHJlc3VsdFJlZ3MudGFnR1BSKCkpOwo=