229405 2021-08-23 03:49:40 -0700 RemoteGraphicsContextGL refers to GraphicsContextGLOpenGL::SimulatedEventForTesting 2022-09-28 01:12:13 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229404 1 kkinnunen kkinnunen dino kbr kkinnunen webkit-bug-importer oldest_to_newest 1786381 0 kkinnunen 2021-08-23 03:49:40 -0700 RemoteGraphicsContextGL refers to GraphicsContextOpenGL::SimulatedEventForTesting SimulatedEventForTesting is defined in the base class GraphicsContextGL. Using GraphicsContextOpenGL is problematic in case we try to move the ANGLE implementation out from GraphicsContextOpenGL. 1786382 1 436179 kkinnunen 2021-08-23 03:52:53 -0700 Created attachment 436179 Patch 1786636 2 436179 kbr 2021-08-23 18:07:15 -0700 Comment on attachment 436179 Patch Looks good. r+ 1787549 3 ews-feeder 2021-08-26 05:30:53 -0700 Committed r281620 (240976@main): <https://commits.webkit.org/240976@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436179. 1787550 4 webkit-bug-importer 2021-08-26 05:31:19 -0700 <rdar://problem/82385242> 1898655 5 kkinnunen 2022-09-15 01:23:44 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/4374 1901715 6 ews-feeder 2022-09-28 01:12:11 -0700 Committed 254947@main (d257ea20c599): <https://commits.webkit.org/254947@main> Reviewed commits have been landed. Closing PR #4374 and removing active labels. 436179 2021-08-23 03:52:53 -0700 2021-08-26 05:30:54 -0700 Patch bug-229405-20210823135252.patch text/plain 3987 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI3Y2E2OTVkMTZjYTIxNjZj ZGFhZGI5ZmQ3MGZmZDA3ZmExMjExN2MuLjM1NmVhZjRmYWE2N2NlMjA4NTQ4NGNlNDE2NjE5MWY3 NGFhODRlODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDgtMjMgIEtpbW1vIEtp bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdGVHcmFwaGljc0Nv bnRleHRHTCByZWZlcnMgdG8gR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OlNpbXVsYXRlZEV2ZW50 Rm9yVGVzdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI5NDA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW5zdGVhZCwgcmVmZXIgdmlhIHRoZSBkZWZpbmluZyBiYXNlIGNsYXNzLCBpLmUuIHVzZQor ICAgICAgICBHcmFwaGljc0NvbnRleHRHTDo6U2ltdWxhdGVkRXZlbnRGb3JUZXN0aW5nLgorICAg ICAgICBGaXhlcyBwcm9ibGVtcyBpZiB3ZSB0cnkgdG8gbW92ZSBBTkdMRSBpbXBsZW1lbnRhdGlv biBvdXQgb2YKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCByZWZhY3Rvci4KKworICAgICAgICAqIEdQVVByb2Nlc3MvZ3JhcGhpY3MvUmVt b3RlR3JhcGhpY3NDb250ZXh0R0wuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVHcmFwaGlj c0NvbnRleHRHTDo6c2ltdWxhdGVFdmVudEZvclRlc3RpbmcpOgorICAgICAgICAqIEdQVVByb2Nl c3MvZ3JhcGhpY3MvUmVtb3RlR3JhcGhpY3NDb250ZXh0R0wuaDoKKwogMjAyMS0wOC0yMiAgS2F0 ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBvcnQg Y29ycmVjdCBibG9ja2VkIFVSSSBpbiBDU1AgdmlvbGF0aW9uIHJlcG9ydApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZUdyYXBoaWNzQ29udGV4dEdM LmNwcCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVHcmFwaGljc0Nv bnRleHRHTC5jcHAKaW5kZXggN2QyYTU3MjMzZWQ2MTI0NTA2MTc4OTU1NzFkMjUwMjI3N2FlNTI4 ZC4uZTYyNzE5ZGQxMjY4OGMzMzZmOWM5NjI1ZDNjMjVkODAzMzI0MTFiNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZUdyYXBoaWNzQ29udGV4dEdM LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlR3JhcGhp Y3NDb250ZXh0R0wuY3BwCkBAIC0yODMsMTEgKzI4MywxMSBAQCB2b2lkIFJlbW90ZUdyYXBoaWNz Q29udGV4dEdMOjpjb3B5VGV4dHVyZUZyb21NZWRpYShXZWJDb3JlOjpNZWRpYVBsYXllcklkZW50 aWZpZQogI2VuZGlmCiB9CiAKLXZvaWQgUmVtb3RlR3JhcGhpY3NDb250ZXh0R0w6OnNpbXVsYXRl RXZlbnRGb3JUZXN0aW5nKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpTaW11bGF0 ZWRFdmVudEZvclRlc3RpbmcgZXZlbnQpCit2b2lkIFJlbW90ZUdyYXBoaWNzQ29udGV4dEdMOjpz aW11bGF0ZUV2ZW50Rm9yVGVzdGluZyhXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRHTDo6U2ltdWxh dGVkRXZlbnRGb3JUZXN0aW5nIGV2ZW50KQogewogICAgIGFzc2VydElzQ3VycmVudChtX3N0cmVh bVRocmVhZCk7CiAgICAgLy8gRklYTUU6IG9ubHkgcnVuIHRoaXMgaW4gdGVzdGluZyBtb2RlLiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNTQ0Ci0gICAgaWYgKGV2 ZW50ID09IFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpTaW11bGF0ZWRFdmVudEZv clRlc3Rpbmc6OlRpbWVvdXQpIHsKKyAgICBpZiAoZXZlbnQgPT0gV2ViQ29yZTo6R3JhcGhpY3ND b250ZXh0R0w6OlNpbXVsYXRlZEV2ZW50Rm9yVGVzdGluZzo6VGltZW91dCkgewogICAgICAgICAv LyBTaW11bGF0ZSB0aGUgdGltZW91dCBieSBqdXN0IGRpc2NhcmRpbmcgdGhlIGNvbnRleHQuIFRo ZSBzdWJzZXF1ZW50IG1lc3NhZ2VzIGFjdCBsaWtlCiAgICAgICAgIC8vIHVuYXV0aG9yaXplZCBv ciBvbGQgbWVzc2FnZXMgZnJvbSBXZWIgcHJvY2VzcywgdGhleSBhcmUgc2tpcHBlZC4KICAgICAg ICAgY2FsbE9uTWFpblJ1bkxvb3AoW2dwdUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MgPSBtX2dwdUNv bm5lY3Rpb25Ub1dlYlByb2Nlc3MsIGlkZW50aWZpZXIgPSBtX2dyYXBoaWNzQ29udGV4dEdMSWRl bnRpZmllcl0oKSB7CkBAIC0yOTYsNyArMjk2LDcgQEAgdm9pZCBSZW1vdGVHcmFwaGljc0NvbnRl eHRHTDo6c2ltdWxhdGVFdmVudEZvclRlc3RpbmcoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0R0wK ICAgICAgICAgfSk7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgaWYgKGV2ZW50ID09IFdl YkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpTaW11bGF0ZWRFdmVudEZvclRlc3Rpbmc6 OkNvbnRleHRDaGFuZ2UpIHsKKyAgICBpZiAoZXZlbnQgPT0gV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0R0w6OlNpbXVsYXRlZEV2ZW50Rm9yVGVzdGluZzo6Q29udGV4dENoYW5nZSkgewogI2lmIFBM QVRGT1JNKE1BQykKICAgICAgICAgY2FsbE9uTWFpblJ1bkxvb3AoW3dlYWtDb25uZWN0aW9uID0g bV9ncHVDb25uZWN0aW9uVG9XZWJQcm9jZXNzXSgpIHsKICAgICAgICAgICAgIGlmIChhdXRvIGNv bm5lY3Rpb24gPSB3ZWFrQ29ubmVjdGlvbi5nZXQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVHcmFwaGljc0NvbnRleHRHTC5oIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZUdyYXBoaWNzQ29udGV4dEdMLmgKaW5k ZXggMDIzZWEwOTY2YmQzNTMyZDhlZjU0YjVlZjQ1MGRmZDQyYzc1YzM3Yi4uMTNlNDdmYmI5Yzg5 NzBmNWQzMDQ1YTZmZjdlMGM4N2NmMjM3NTBkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9H UFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZUdyYXBoaWNzQ29udGV4dEdMLmgKKysrIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZUdyYXBoaWNzQ29udGV4dEdMLmgKQEAg LTEwMSw3ICsxMDEsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBwYWludFJlbmRlcmluZ1Jlc3Vs dHNUb0NhbnZhcyhXZWJDb3JlOjpSZW5kZXJpbmdSZXNvdXJjZUlkZW50aWZpZXIsIENvbXBsZXRp b25IYW5kbGVyPHZvaWQoKT4mJik7CiAgICAgdm9pZCBwYWludENvbXBvc2l0ZWRSZXN1bHRzVG9D YW52YXMoV2ViQ29yZTo6UmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyLCBDb21wbGV0aW9uSGFu ZGxlcjx2b2lkKCk+JiYpOwogICAgIHZvaWQgY29weVRleHR1cmVGcm9tTWVkaWEoV2ViQ29yZTo6 TWVkaWFQbGF5ZXJJZGVudGlmaWVyLCB1aW50MzJfdCB0ZXh0dXJlLCB1aW50MzJfdCB0YXJnZXQs IGludDMyX3QgbGV2ZWwsIHVpbnQzMl90IGludGVybmFsRm9ybWF0LCB1aW50MzJfdCBmb3JtYXQs IHVpbnQzMl90IHR5cGUsIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSwgYm9vbCBmbGlwWSwgQ29tcGxl dGlvbkhhbmRsZXI8dm9pZChib29sKT4mJik7Ci0gICAgdm9pZCBzaW11bGF0ZUV2ZW50Rm9yVGVz dGluZyhXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRHTE9wZW5HTDo6U2ltdWxhdGVkRXZlbnRGb3JU ZXN0aW5nKTsKKyAgICB2b2lkIHNpbXVsYXRlRXZlbnRGb3JUZXN0aW5nKFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dEdMOjpTaW11bGF0ZWRFdmVudEZvclRlc3RpbmcpOwogCiAjaW5jbHVkZSAiUmVt b3RlR3JhcGhpY3NDb250ZXh0R0xGdW5jdGlvbnNHZW5lcmF0ZWQuaCIgLy8gTk9MSU5UCiAK