229404 webglcleanup 2021-08-23 03:35:13 -0700 WebGL has a lot of #if USE(ANGLE) blocks, making it hard to maintain 2024-01-17 02:07:41 -0800 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 229402 229405 221664 1 kkinnunen webkit-unassigned alex dino djg don.olmstead estea fujii kbr kkinnunen mmaxfield webkit-bug-importer zan oldest_to_newest 1786378 0 kkinnunen 2021-08-23 03:35:13 -0700 WebGL has a lot of #if USE(ANGLE) blocks, making it hard to maintain There are 3 major implementations for WebGL: - OpenGL - OpenGL ES - ANGLE The WebGL layer should not #ifdef around these variations, rather the differences should be abstracted somehow so that the WebGL implementation is easier to maintain correctly. 1786379 1 kkinnunen 2021-08-23 03:40:24 -0700 In my personal opinion, it is only viable to run WebGL correctly with the ANGLE implementation. The simplest option to fix this bug, option A, would be to: 1) remove all WebGL-related code that is not inside #if USE(ANGLE). The other option, option B, would be to: 1) Move GCGL ANGLE implementation to GraphicsContextGLANGLE 2) Move #if !USE(ANGLE) code from WebGL to GraphicsContextGLOpenGL However, option B has the problem that TextureMapper uses GraphicsContextGLOpenGL, and it's not entirely clear to me if it's expected to work on ANGLE and OpenGL or just on OpenGL. If it's the latter, then the task is a bit simpler. If the former, then it's more work. 1786380 2 kkinnunen 2021-08-23 03:42:34 -0700 Hironori, would you have idea what is expected of TextureMapper, and/or who could give opinion on whether or not WebGL should work for non-Cocoa WebKit without ANGLE. 1786395 3 fujii 2021-08-23 05:19:46 -0700 WinCairo finished USE_ANGLE migration. As far as I know, Igalia is working on the migration for GTK and WPE ports. (Bug 225563 comment 6). WebGL should work for them without ANGLE until Igalia finishes the migration. WinCairo is using TextureMapper with ANGLE and GraphicsLayerTextureMapper. GTK and WPE ports are using TextureMapper with OpenGL and GLES and CoordinatedGraphicsLayer. 1788471 4 webkit-bug-importer 2021-08-30 03:36:16 -0700 <rdar://problem/82517622> 1817512 5 alex 2021-11-23 13:28:09 -0800 (In reply to Fujii Hironori from comment #3) > WinCairo finished USE_ANGLE migration. As far as I know, Igalia is working > on the migration for GTK and WPE ports. (Bug 225563 comment 6). > WebGL should work for them without ANGLE until Igalia finishes the > migration. > > WinCairo is using TextureMapper with ANGLE and GraphicsLayerTextureMapper. > GTK and WPE ports are using TextureMapper with OpenGL and GLES and > CoordinatedGraphicsLayer. Yes, we are currently working in a solution with ANGLE as the WebGL backend. We started checking and updating the current code. 1891917 6 kkinnunen 2022-08-17 04:18:17 -0700 Ping, any progress on removing non-ANGLE WebGL codepaths? Any place you would need help with that I would be able to contribute? 1891926 7 zan 2022-08-17 04:57:40 -0700 The desire is to make the switch after next release branching. That event is a matter of 1-2 weeks. In addition to that there's certain testing environment issues that still need resolving under the GTK port, but that's possibly addressable after turning ANGLE on. 1892036 8 don.olmstead 2022-08-17 13:36:40 -0700 Could we have a discussion on this plan before moving forward? 1892501 9 mmaxfield 2022-08-19 14:31:25 -0700 This is being discussed in the #angle channel of the open source webkit slack workspace. 2005559 10 kkinnunen 2024-01-17 02:07:41 -0800 Thhe ANGLE ifdef blocks are gone