22938 2008-12-19 13:09:19 -0800 [Transforms] WebView background is not painted correctly if the document has a transform 2008-12-19 14:44:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser hyatt oldest_to_newest 103014 0 simon.fraser 2008-12-19 13:09:19 -0800 If the document has a transform, via something like: html { -webkit-transform: translateY(100px) rotate(20deg); } then the exposed area of the viewport that is not covered by the document is unpainted, and full of pixel crap. 103015 1 26152 simon.fraser 2008-12-19 13:10:08 -0800 Created attachment 26152 Testcase 103026 2 26156 simon.fraser 2008-12-19 13:49:48 -0800 Created attachment 26156 Patch, testcase, changelog 103029 3 26156 darin 2008-12-19 14:03:34 -0800 Comment on attachment 26156 Patch, testcase, changelog Where did the null check of view() go? Removing that could lead to crashes. If it was redundant, then it's OK to remove it, but the change log should explain that. 103032 4 simon.fraser 2008-12-19 14:16:26 -0800 Oops that was a mistake. New patch coming. 103033 5 26158 simon.fraser 2008-12-19 14:22:02 -0800 Created attachment 26158 Fixed patch - restore the !view() check 103036 6 26158 darin 2008-12-19 14:31:48 -0800 Comment on attachment 26158 Fixed patch - restore the !view() check > + // If painting will entirely fill the view, no need to fill the background Comments in sentence style should end in a period. > + if (elt || > + (firstChild() && (firstChild()->style()->visibility() == VISIBLE && !firstChild()->style()->hasTransform())) || > + !view()) > return; You have an extra set of parentheses in there that I don't think add clarity. You don't need the ones after "firstChild() &&". Our typical format for long if statements like this is to start lines with operators, and also (maybe not a good format) to indent an extra level so the expression doesn't line up with the return statement. if (elt || (firstChild() && firstChild()->style()->visibility() == VISIBLE && !firstChild()->style()->hasTransform()) || !view()) return; But I think the best way to clean this up is with a helper function. static inline bool isVisibleWithNoTransform(RenderObject* object) { return object && object->style()->visibility() == VISIBLE && ! object >style()->hasTransform(); } [...] if (elt || isVisibleWithNoTransform(firstChild()) || !view()) return; [...] I think it's worth it to keep this code readable. > - // This code typically only executes if the root element's visibility has been set to hidden. > + // This code typically only executes if the root element's visibility has been set to hidden, > + // or there is a transform on the <html> Comments in sentence style should end in a period. r=me -- please consider my refinement suggestions. 103039 7 simon.fraser 2008-12-19 14:44:27 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/transforms/transformed-document-element.html A LayoutTests/platform/mac/fast/transforms/transformed-document-element-expected.checksum A LayoutTests/platform/mac/fast/transforms/transformed-document-element-expected.png A LayoutTests/platform/mac/fast/transforms/transformed-document-element-expected.txt M WebCore/ChangeLog M WebCore/rendering/RenderView.cpp Committed r39413 26152 2008-12-19 13:10:08 -0800 2008-12-19 13:10:08 -0800 Testcase transformed_document.html text/html 1122 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+VHJhbnNmb3JtIG9uIERvY3Vt ZW50PC90aXRsZT4KICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgogICAg aHRtbCB7CiAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGVZKDEwMHB4KSByb3RhdGUo MjBkZWcpOwogICAgfQogICAgYm9keSB7CiAgICAgIGJhY2tncm91bmQtY29sb3I6IGdyYXk7CiAg ICB9CiAgICAuY29udGFpbmVyIHsKICAgICAgaGVpZ2h0OiAyMDBweDsKICAgICAgd2lkdGg6IDIw MHB4OwogICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgICAtd2Via2l0LXRyYW5zZm9y bTogcm90YXRlKC0xNmRlZyk7CiAgICB9CiAgICAuY29udGFpbmVyOmhvdmVyIHsKICAgICAgYmFj a2dyb3VuZC1jb2xvcjogZ3JlZW47CiAgICB9CiAgPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KCkxv cmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBhZGlwaXNpY2luZyBlbGl0LCBz ZWQgZG8gZWl1c21vZCB0ZW1wb3IgaW5jaWRpZHVudCB1dCBsYWJvcmUgZXQgZG9sb3JlIG1hZ25h IGFsaXF1YS4gVXQgZW5pbSBhZCBtaW5pbSB2ZW5pYW0sIHF1aXMgbm9zdHJ1ZCBleGVyY2l0YXRp b24gdWxsYW1jbyBsYWJvcmlzIG5pc2kgdXQgYWxpcXVpcCBleCBlYSBjb21tb2RvIGNvbnNlcXVh dC4gRHVpcyBhdXRlIGlydXJlIGRvbG9yIGluIHJlcHJlaGVuZGVyaXQgaW4gdm9sdXB0YXRlIHZl bGl0IGVzc2UgY2lsbHVtIGRvbG9yZSBldSBmdWdpYXQgbnVsbGEgcGFyaWF0dXIuIEV4Y2VwdGV1 ciBzaW50IG9jY2FlY2F0IGN1cGlkYXRhdCBub24gcHJvaWRlbnQsIHN1bnQgaW4gY3VscGEgcXVp IG9mZmljaWEgZGVzZXJ1bnQgbW9sbGl0IGFuaW0gaWQgZXN0IGxhYm9ydW0uCgo8ZGl2IGNsYXNz PSJjb250YWluZXIiPiAgCjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 26156 2008-12-19 13:49:48 -0800 2008-12-19 14:22:02 -0800 Patch, testcase, changelog 22938_patch.txt text/plain 5221 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhODdmZDdkLi5kOWRkNmZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTIt MTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyOTM4CisgICAgICAgIAorICAgICAgICBUZXN0IGZvciBwYWlu dGluZyB3aXRoIGEgdHJhbnNmb3JtZWQgPGh0bWw+IGVsZW1lbnQuCisKKyAgICAgICAgKiBmYXN0 L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50 LWVsZW1lbnQtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21h Yy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC5w bmc6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNm b3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDA4LTEyLTE5 ICBQYW1lbGEgR3JlZW5lICA8cGFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90 cmFuc2Zvcm1lZC1kb2N1bWVudC1lbGVtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RyYW5z Zm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjgxYTYxZjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC5odG1sCkBAIC0w LDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAx IFRyYW5zaXRpb25hbC8vRU4iCisgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2Uu ZHRkIj4KKworPGh0bWwgbGFuZz0iZW4iPgorPGhlYWQ+CisgIDxtZXRhIGh0dHAtZXF1aXY9IkNv bnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KKyAgPHRpdGxl PlRyYW5zZm9ybSBvbiBEb2N1bWVudDwvdGl0bGU+Cis8L2hlYWQ+Cis8Ym9keSBzdHlsZT0iYmFj a2dyb3VuZC1jb2xvcjogZ3JheSI+Cis8cD5UaGUgcG9ydGlvbnMgb2YgdGhlIHZpZXcgZXhwb3Nl ZCBieSB0aGUgdHJhbnNmb3JtZWQgZG9jdW1lbnQgc2hvdWxkIGJlIHBhaW50ZWQgd2hpdGU8L3A+ Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgorICAvLyBk byB0aGlzIGR5bmFtaWNhbGx5IHRvIGF2b2lkIHBpeGVscyBmcm9tIHRoZSBwcmV2aW91cyB0ZXN0 IGluIHBvdGVudGlhbGx5IHVucGFpbnRlZCBhcmVhcworICBkb2N1bWVudC5kb2N1bWVudEVsZW1l bnQuc3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5zbGF0ZVkoMjAwcHgpIHJvdGF0ZSgyMGRl ZyknOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1l bnQtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFu c2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1lbnQtZXhwZWN0ZWQuY2hlY2tzdW0KbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNzQyMWM1ZQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQt ZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC5jaGVja3N1bQpAQCAtMCwwICsxIEBACis3ZGZjYmI5 OWRmNzk1MzhkYjg2MGQ3ZDkyMjk1NmFmOQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNm b3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1lbnQtZXhwZWN0 ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmFlM2YzNWYKQmluYXJ5 IGZpbGVzIC9kZXYvbnVsbCBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFu c2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1lbnQtZXhwZWN0ZWQucG5nIGRpZmZlcgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvdHJhbnNmb3Jtcy90cmFu c2Zvcm1lZC1kb2N1bWVudC1lbGVtZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWE2Yjc1NQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMv dHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBA CitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDUwCisgIFJlbmRlckJsb2NrIHtIVE1M fSBhdCAoMCwwKSBzaXplIDgwMHg1MAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDE2KSBz aXplIDc4NHgxOCBbYmdjb2xvcj0jODA4MDgwXQorICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgw LDApIHNpemUgNzg0eDE4CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXpl IDU1M3gxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDU1MzogIlRoZSBwb3J0 aW9ucyBvZiB0aGUgdmlldyBleHBvc2VkIGJ5IHRoZSB0cmFuc2Zvcm1lZCBkb2N1bWVudCBzaG91 bGQgYmUgcGFpbnRlZCB3aGl0ZSIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggODhkYWI3Ny4uYjkwODczNSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAw OC0xMi0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MzgKKyAgICAgICAgCisgICAgICAgIFdoZW4gdGhl IGRvY3VtZW50IGVsZW1lbnQgaXMgdHJhbnNmb3JtZWQsIHdlIG5lZWQgdG8gcGFpbnQKKyAgICAg ICAgdGhlIHZpZXcgYmFja2dyb3VuZCB0byBhdm9pZCB1bnBhaW50ZWQgYXJlYXMuCisgICAgICAg IAorICAgICAgICBUZXN0OiBmYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxl bWVudC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJWaWV3OjpwYWludEJveERlY29yYXRpb25zKToKKwogMjAwOC0xMi0x OSAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3 eCBidWlsZCBmaXhlcyBhZnRlciByZWNlbnQgY2hhbmdlcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5j cHAKaW5kZXggODI2MmRiNi4uZTJkNzYxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVmlldy5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAg LTE4NSwxMCArMTg1LDEzIEBAIHZvaWQgUmVuZGVyVmlldzo6cGFpbnRCb3hEZWNvcmF0aW9ucyhQ YWludEluZm8mIHBhaW50SW5mbywgaW50IHR4LCBpbnQgdHkpCiAgICAgICAgIH0KICAgICB9CiAK LSAgICBpZiAoZWx0IHx8IChmaXJzdENoaWxkKCkgJiYgZmlyc3RDaGlsZCgpLT5zdHlsZSgpLT52 aXNpYmlsaXR5KCkgPT0gVklTSUJMRSkgfHwgIXZpZXcoKSkKKyAgICAvLyBJZiBwYWludGluZyB3 aWxsIGVudGlyZWx5IGZpbGwgdGhlIHZpZXcsIG5vIG5lZWQgdG8gZmlsbCB0aGUgYmFja2dyb3Vu ZAorICAgIGlmIChlbHQgfHwgKGZpcnN0Q2hpbGQoKSAmJiAoZmlyc3RDaGlsZCgpLT5zdHlsZSgp LT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSAmJgorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIWZpcnN0Q2hpbGQoKS0+c3R5bGUoKS0+aGFzVHJhbnNmb3JtKCkpKSkKICAgICAgICAg cmV0dXJuOwogCi0gICAgLy8gVGhpcyBjb2RlIHR5cGljYWxseSBvbmx5IGV4ZWN1dGVzIGlmIHRo ZSByb290IGVsZW1lbnQncyB2aXNpYmlsaXR5IGhhcyBiZWVuIHNldCB0byBoaWRkZW4uCisgICAg Ly8gVGhpcyBjb2RlIHR5cGljYWxseSBvbmx5IGV4ZWN1dGVzIGlmIHRoZSByb290IGVsZW1lbnQn cyB2aXNpYmlsaXR5IGhhcyBiZWVuIHNldCB0byBoaWRkZW4sCisgICAgLy8gb3IgdGhlcmUgaXMg YSB0cmFuc2Zvcm0gb24gdGhlIDxodG1sPgogICAgIC8vIE9ubHkgZmlsbCB3aXRoIHRoZSBiYXNl IGJhY2tncm91bmQgY29sb3IgKHR5cGljYWxseSB3aGl0ZSkgaWYgd2UncmUgdGhlIHJvb3QgZG9j dW1lbnQsIAogICAgIC8vIHNpbmNlIGlmcmFtZXMvZnJhbWVzIHdpdGggbm8gYmFja2dyb3VuZCBp biB0aGUgY2hpbGQgZG9jdW1lbnQgc2hvdWxkIHNob3cgdGhlIHBhcmVudCdzIGJhY2tncm91bmQu CiAgICAgaWYgKHZpZXcoKS0+aXNUcmFuc3BhcmVudCgpKSAvLyBGSVhNRTogVGhpcyBuZWVkcyB0 byBiZSBkeW5hbWljLiAgV2Ugc2hvdWxkIGJlIGFibGUgdG8gZ28gYmFjayB0byBibGl0dGluZyBp ZiB3ZSBldmVyIHN0b3AgYmVpbmcgdHJhbnNwYXJlbnQuCg== 26158 2008-12-19 14:22:02 -0800 2008-12-19 14:31:48 -0800 Fixed patch - restore the !view() check 22938_patch.txt text/plain 5216 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhODdmZDdkLi5kOWRkNmZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTIt MTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyOTM4CisgICAgICAgIAorICAgICAgICBUZXN0IGZvciBwYWlu dGluZyB3aXRoIGEgdHJhbnNmb3JtZWQgPGh0bWw+IGVsZW1lbnQuCisKKyAgICAgICAgKiBmYXN0 L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50 LWVsZW1lbnQtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21h Yy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC5w bmc6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNm b3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDA4LTEyLTE5 ICBQYW1lbGEgR3JlZW5lICA8cGFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90 cmFuc2Zvcm1lZC1kb2N1bWVudC1lbGVtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RyYW5z Zm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjgxYTYxZjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC5odG1sCkBAIC0w LDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAx IFRyYW5zaXRpb25hbC8vRU4iCisgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2Uu ZHRkIj4KKworPGh0bWwgbGFuZz0iZW4iPgorPGhlYWQ+CisgIDxtZXRhIGh0dHAtZXF1aXY9IkNv bnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KKyAgPHRpdGxl PlRyYW5zZm9ybSBvbiBEb2N1bWVudDwvdGl0bGU+Cis8L2hlYWQ+Cis8Ym9keSBzdHlsZT0iYmFj a2dyb3VuZC1jb2xvcjogZ3JheSI+Cis8cD5UaGUgcG9ydGlvbnMgb2YgdGhlIHZpZXcgZXhwb3Nl ZCBieSB0aGUgdHJhbnNmb3JtZWQgZG9jdW1lbnQgc2hvdWxkIGJlIHBhaW50ZWQgd2hpdGU8L3A+ Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgorICAvLyBk byB0aGlzIGR5bmFtaWNhbGx5IHRvIGF2b2lkIHBpeGVscyBmcm9tIHRoZSBwcmV2aW91cyB0ZXN0 IGluIHBvdGVudGlhbGx5IHVucGFpbnRlZCBhcmVhcworICBkb2N1bWVudC5kb2N1bWVudEVsZW1l bnQuc3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5zbGF0ZVkoMjAwcHgpIHJvdGF0ZSgyMGRl ZyknOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1l bnQtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFu c2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1lbnQtZXhwZWN0ZWQuY2hlY2tzdW0KbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNzQyMWM1ZQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQt ZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC5jaGVja3N1bQpAQCAtMCwwICsxIEBACis3ZGZjYmI5 OWRmNzk1MzhkYjg2MGQ3ZDkyMjk1NmFmOQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNm b3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1lbnQtZXhwZWN0 ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmFlM2YzNWYKQmluYXJ5 IGZpbGVzIC9kZXYvbnVsbCBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90cmFu c2Zvcm1zL3RyYW5zZm9ybWVkLWRvY3VtZW50LWVsZW1lbnQtZXhwZWN0ZWQucG5nIGRpZmZlcgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvdHJhbnNmb3Jtcy90cmFu c2Zvcm1lZC1kb2N1bWVudC1lbGVtZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWE2Yjc1NQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RyYW5zZm9ybXMv dHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxlbWVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBA CitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDUwCisgIFJlbmRlckJsb2NrIHtIVE1M fSBhdCAoMCwwKSBzaXplIDgwMHg1MAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDE2KSBz aXplIDc4NHgxOCBbYmdjb2xvcj0jODA4MDgwXQorICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgw LDApIHNpemUgNzg0eDE4CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXpl IDU1M3gxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDU1MzogIlRoZSBwb3J0 aW9ucyBvZiB0aGUgdmlldyBleHBvc2VkIGJ5IHRoZSB0cmFuc2Zvcm1lZCBkb2N1bWVudCBzaG91 bGQgYmUgcGFpbnRlZCB3aGl0ZSIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggODhkYWI3Ny4uYjkwODczNSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAw OC0xMi0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MzgKKyAgICAgICAgCisgICAgICAgIFdoZW4gdGhl IGRvY3VtZW50IGVsZW1lbnQgaXMgdHJhbnNmb3JtZWQsIHdlIG5lZWQgdG8gcGFpbnQKKyAgICAg ICAgdGhlIHZpZXcgYmFja2dyb3VuZCB0byBhdm9pZCB1bnBhaW50ZWQgYXJlYXMuCisgICAgICAg IAorICAgICAgICBUZXN0OiBmYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtZWQtZG9jdW1lbnQtZWxl bWVudC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJWaWV3OjpwYWludEJveERlY29yYXRpb25zKToKKwogMjAwOC0xMi0x OSAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3 eCBidWlsZCBmaXhlcyBhZnRlciByZWNlbnQgY2hhbmdlcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5j cHAKaW5kZXggODI2MmRiNi4uMjBhMTkyOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVmlldy5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAg LTE4NSwxMCArMTg1LDE0IEBAIHZvaWQgUmVuZGVyVmlldzo6cGFpbnRCb3hEZWNvcmF0aW9ucyhQ YWludEluZm8mIHBhaW50SW5mbywgaW50IHR4LCBpbnQgdHkpCiAgICAgICAgIH0KICAgICB9CiAK LSAgICBpZiAoZWx0IHx8IChmaXJzdENoaWxkKCkgJiYgZmlyc3RDaGlsZCgpLT5zdHlsZSgpLT52 aXNpYmlsaXR5KCkgPT0gVklTSUJMRSkgfHwgIXZpZXcoKSkKKyAgICAvLyBJZiBwYWludGluZyB3 aWxsIGVudGlyZWx5IGZpbGwgdGhlIHZpZXcsIG5vIG5lZWQgdG8gZmlsbCB0aGUgYmFja2dyb3Vu ZAorICAgIGlmIChlbHQgfHwKKyAgICAgICAgKGZpcnN0Q2hpbGQoKSAmJiAoZmlyc3RDaGlsZCgp LT5zdHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSAmJiAhZmlyc3RDaGlsZCgpLT5zdHls ZSgpLT5oYXNUcmFuc2Zvcm0oKSkpIHx8CisgICAgICAgICF2aWV3KCkpCiAgICAgICAgIHJldHVy bjsKIAotICAgIC8vIFRoaXMgY29kZSB0eXBpY2FsbHkgb25seSBleGVjdXRlcyBpZiB0aGUgcm9v dCBlbGVtZW50J3MgdmlzaWJpbGl0eSBoYXMgYmVlbiBzZXQgdG8gaGlkZGVuLgorICAgIC8vIFRo aXMgY29kZSB0eXBpY2FsbHkgb25seSBleGVjdXRlcyBpZiB0aGUgcm9vdCBlbGVtZW50J3Mgdmlz aWJpbGl0eSBoYXMgYmVlbiBzZXQgdG8gaGlkZGVuLAorICAgIC8vIG9yIHRoZXJlIGlzIGEgdHJh bnNmb3JtIG9uIHRoZSA8aHRtbD4KICAgICAvLyBPbmx5IGZpbGwgd2l0aCB0aGUgYmFzZSBiYWNr Z3JvdW5kIGNvbG9yICh0eXBpY2FsbHkgd2hpdGUpIGlmIHdlJ3JlIHRoZSByb290IGRvY3VtZW50 LCAKICAgICAvLyBzaW5jZSBpZnJhbWVzL2ZyYW1lcyB3aXRoIG5vIGJhY2tncm91bmQgaW4gdGhl IGNoaWxkIGRvY3VtZW50IHNob3VsZCBzaG93IHRoZSBwYXJlbnQncyBiYWNrZ3JvdW5kLgogICAg IGlmICh2aWV3KCktPmlzVHJhbnNwYXJlbnQoKSkgLy8gRklYTUU6IFRoaXMgbmVlZHMgdG8gYmUg ZHluYW1pYy4gIFdlIHNob3VsZCBiZSBhYmxlIHRvIGdvIGJhY2sgdG8gYmxpdHRpbmcgaWYgd2Ug ZXZlciBzdG9wIGJlaW5nIHRyYW5zcGFyZW50Lgo=