22936 2008-12-19 10:02:34 -0800 Uninitialized memory read error in SimpleFontData::unitsPerEm() is reported by Purify 2009-01-12 11:16:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=5307 P2 Normal --- 1 dglazkov dglazkov oldest_to_newest 102997 0 dglazkov 2008-12-19 10:02:34 -0800 The easy fix is to initialize m_unitsPerEm on creation. 102998 1 26146 dglazkov 2008-12-19 10:04:54 -0800 Created attachment 26146 Initialize m_unitsPerEm in SimpleFontData constructor 103018 2 darin 2008-12-19 13:19:59 -0800 Why is 0 an acceptable value for this? 103025 3 dglazkov 2008-12-19 13:42:16 -0800 It's not -- apologies. There's at least one place where this can cause a div/0 error -- SVGInlineTextBox.cpp(490) Actually, looking at SVGFontFaceElement.cpp(136) , it appears that the default value is 1000? WDYT? 103038 4 26160 dglazkov 2008-12-19 14:40:46 -0800 Created attachment 26160 Initialize m_unitsPerEm in SimpleFontData constructor v2 Darin, thanks again for making me look. I updated the patch to use the value, provided by SVGFontFaceElement::unitsPerEm(), which is what would be used if the font did not have the units_per_em attribute. 104111 5 26160 darin 2009-01-02 10:46:29 -0800 Comment on attachment 26160 Initialize m_unitsPerEm in SimpleFontData constructor v2 > + const unsigned cDefaultUnitsPerEm = 1000; > + > class CSSFontFaceRule; > class CSSMutableStyleDeclaration; > class SVGFontElement; We'd normally put our own declarations after any forward declarations of things defined in other files. So this would go after the "class XXX" declarations. We also don't use the "c" prefix for constants consistently. We're leaning more towards just normal local-variable-style naming for constants. r=me despite those quibbles 104611 6 26469 dglazkov 2009-01-06 13:03:32 -0800 Created attachment 26469 Initialize m_unitsPerEm in SimpleFontData constructor v3 For ease of landing and cleaner conscience, I updated the patch (v3) to address the quibbles and rebased it against trunk. 105343 7 dglazkov 2009-01-12 11:16:26 -0800 Landed in changeset 39828. http://trac.webkit.org/changeset/39828 26146 2008-12-19 10:04:54 -0800 2008-12-19 14:40:46 -0800 Initialize m_unitsPerEm in SimpleFontData constructor sfdfix.patch text/plain 1152 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjkwMGQ1Yi4uYmE0ZmVjOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0xMi0xOSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjkzNgorCisgICAgICAgIEZpeCB1bmluaXRpYWxpemVkIG1lbW9yeSByZWFkIGVycm9y LCByZXBvcnRlZCBieSBQdXJpZnkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1w bGVGb250RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVGb250RGF0YTo6U2ltcGxl Rm9udERhdGEpOiBBZGRlZCBpbml0aWFsaXplciBmb3IKKyAgICAgICAgICAgIG1fdW5pdHNQZXJF bS4KKwogMjAwOC0xMi0xOSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuY3BwCmluZGV4IDczNjU2N2UuLmY5Yzc1ZDAgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuY3BwCkBAIC00MSw3 ICs0MSw4IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFNpbXBsZUZvbnREYXRhOjpTaW1wbGVG b250RGF0YShjb25zdCBGb250UGxhdGZvcm1EYXRhJiBmLCBib29sIGN1c3RvbUZvbnQsIGJvb2wg bG9hZGluZywgU1ZHRm9udERhdGEqIHN2Z0ZvbnREYXRhKQotICAgIDogbV9mb250KGYpCisgICAg OiBtX3VuaXRzUGVyRW0oMCkKKyAgICAsIG1fZm9udChmKQogICAgICwgbV90cmVhdEFzRml4ZWRQ aXRjaChmYWxzZSkKICNpZiBFTkFCTEUoU1ZHX0ZPTlRTKQogICAgICwgbV9zdmdGb250RGF0YShz dmdGb250RGF0YSkK 26160 2008-12-19 14:40:46 -0800 2009-01-02 10:46:29 -0800 Initialize m_unitsPerEm in SimpleFontData constructor v2 sfdfix.patch text/plain 2277 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjkwMGQ1Yi4uZTVhMmU3NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOC0xMi0xOSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjkzNgorCisgICAgICAgIEZpeCB1bmluaXRpYWxpemVkIG1lbW9yeSByZWFkIGVycm9y LCByZXBvcnRlZCBieSBQdXJpZnkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1w bGVGb250RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVGb250RGF0YTo6U2ltcGxl Rm9udERhdGEpOiBBZGRlZCBpbml0aWFsaXplciBmb3IKKyAgICAgICAgICAgIG1fdW5pdHNQZXJF bSB1c2luZyBjRGVmYXVsdFVuaXRzUGVyRW0gY29uc3RhbnQuCisgICAgICAgICogc3ZnL1NWR0Zv bnRGYWNlRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdGb250RmFjZUVsZW1lbnQ6 OnVuaXRzUGVyRW0pOiBSZXBsYWNlZCBsaXRlcmFsIHZhbHVlIHdpdGgKKyAgICAgICAgICAgIHRo ZSBjb25zdGFudC4KKyAgICAgICAgKiBzdmcvU1ZHRm9udEZhY2VFbGVtZW50Lmg6IEFkZGVkIGNE ZWZhdWx0VW5pdHNQZXJFbSBjb25zdGFudC4KKwogMjAwOC0xMi0xOSAgR3VzdGF2byBOb3Jvbmhh IFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJl eXRoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnRE YXRhLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuY3BwCmlu ZGV4IDczNjU2N2UuLmNmNDQ3YTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvU2ltcGxlRm9udERhdGEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2lt cGxlRm9udERhdGEuY3BwCkBAIC00MSw3ICs0MSw4IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IFNpbXBsZUZvbnREYXRhOjpTaW1wbGVGb250RGF0YShjb25zdCBGb250UGxhdGZvcm1EYXRhJiBm LCBib29sIGN1c3RvbUZvbnQsIGJvb2wgbG9hZGluZywgU1ZHRm9udERhdGEqIHN2Z0ZvbnREYXRh KQotICAgIDogbV9mb250KGYpCisgICAgOiBtX3VuaXRzUGVyRW0oY0RlZmF1bHRVbml0c1BlckVt KQorICAgICwgbV9mb250KGYpCiAgICAgLCBtX3RyZWF0QXNGaXhlZFBpdGNoKGZhbHNlKQogI2lm IEVOQUJMRShTVkdfRk9OVFMpCiAgICAgLCBtX3N2Z0ZvbnREYXRhKHN2Z0ZvbnREYXRhKQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmNwcCBiL1dlYkNvcmUvc3Zn L1NWR0ZvbnRGYWNlRWxlbWVudC5jcHAKaW5kZXggMjFmZDI3Ny4uZmU0MTljOSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL3N2Zy9T VkdGb250RmFjZUVsZW1lbnQuY3BwCkBAIC0xMzMsNyArMTMzLDcgQEAgdW5zaWduZWQgU1ZHRm9u dEZhY2VFbGVtZW50Ojp1bml0c1BlckVtKCkgY29uc3QKIHsKICAgICBjb25zdCBBdG9taWNTdHJp bmcmIHZhbHVlID0gZ2V0QXR0cmlidXRlKHVuaXRzX3Blcl9lbUF0dHIpOwogICAgIGlmICh2YWx1 ZS5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiAxMDAwOworICAgICAgICByZXR1cm4gY0RlZmF1 bHRVbml0c1BlckVtOwogCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPihjZWlsZih2 YWx1ZS50b0Zsb2F0KCkpKTsKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNl RWxlbWVudC5oIGIvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmgKaW5kZXggM2MyOGE4 OS4uN2MxNTAxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmgK KysrIGIvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmgKQEAgLTI3LDYgKzI3LDggQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCisgICAgY29uc3QgdW5zaWduZWQgY0RlZmF1bHRVbml0 c1BlckVtID0gMTAwMDsKKwogICAgIGNsYXNzIENTU0ZvbnRGYWNlUnVsZTsKICAgICBjbGFzcyBD U1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbjsKICAgICBjbGFzcyBTVkdGb250RWxlbWVudDsK 26469 2009-01-06 13:03:32 -0800 2009-01-06 13:03:32 -0800 Initialize m_unitsPerEm in SimpleFontData constructor v3 sfdfix.patch text/plain 2364 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWJkODJhYy4uNmMxOThjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOC0wMS0wNiAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjkzNgorCisgICAgICAgIEZpeCB1bmluaXRpYWxpemVkIG1lbW9yeSByZWFkIGVycm9y LCByZXBvcnRlZCBieSBQdXJpZnkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1w bGVGb250RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVGb250RGF0YTo6U2ltcGxl Rm9udERhdGEpOiBBZGRlZCBpbml0aWFsaXplciBmb3IKKyAgICAgICAgICAgIG1fdW5pdHNQZXJF bSB1c2luZyBjRGVmYXVsdFVuaXRzUGVyRW0gY29uc3RhbnQuCisgICAgICAgICogc3ZnL1NWR0Zv bnRGYWNlRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdGb250RmFjZUVsZW1lbnQ6 OnVuaXRzUGVyRW0pOiBSZXBsYWNlZCBsaXRlcmFsIHZhbHVlIHdpdGgKKyAgICAgICAgICAgIHRo ZSBjb25zdGFudC4KKyAgICAgICAgKiBzdmcvU1ZHRm9udEZhY2VFbGVtZW50Lmg6IEFkZGVkIGNE ZWZhdWx0VW5pdHNQZXJFbSBjb25zdGFudC4KKwogMjAwOS0wMS0wNiAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuY3BwCmluZGV4IDcz NjU2N2UuLmVlNzY5NzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2lt cGxlRm9udERhdGEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9u dERhdGEuY3BwCkBAIC00MSw3ICs0MSw4IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFNpbXBs ZUZvbnREYXRhOjpTaW1wbGVGb250RGF0YShjb25zdCBGb250UGxhdGZvcm1EYXRhJiBmLCBib29s IGN1c3RvbUZvbnQsIGJvb2wgbG9hZGluZywgU1ZHRm9udERhdGEqIHN2Z0ZvbnREYXRhKQotICAg IDogbV9mb250KGYpCisgICAgOiBtX3VuaXRzUGVyRW0oZGVmYXVsdFVuaXRzUGVyRW0pCisgICAg LCBtX2ZvbnQoZikKICAgICAsIG1fdHJlYXRBc0ZpeGVkUGl0Y2goZmFsc2UpCiAjaWYgRU5BQkxF KFNWR19GT05UUykKICAgICAsIG1fc3ZnRm9udERhdGEoc3ZnRm9udERhdGEpCmRpZmYgLS1naXQg YS9XZWJDb3JlL3N2Zy9TVkdGb250RmFjZUVsZW1lbnQuY3BwIGIvV2ViQ29yZS9zdmcvU1ZHRm9u dEZhY2VFbGVtZW50LmNwcAppbmRleCAyMWZkMjc3Li5kNGU4OWU4IDEwMDY0NAotLS0gYS9XZWJD b3JlL3N2Zy9TVkdGb250RmFjZUVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvc3ZnL1NWR0ZvbnRG YWNlRWxlbWVudC5jcHAKQEAgLTEzMyw3ICsxMzMsNyBAQCB1bnNpZ25lZCBTVkdGb250RmFjZUVs ZW1lbnQ6OnVuaXRzUGVyRW0oKSBjb25zdAogewogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgdmFs dWUgPSBnZXRBdHRyaWJ1dGUodW5pdHNfcGVyX2VtQXR0cik7CiAgICAgaWYgKHZhbHVlLmlzRW1w dHkoKSkKLSAgICAgICAgcmV0dXJuIDEwMDA7CisgICAgICAgIHJldHVybiBkZWZhdWx0VW5pdHNQ ZXJFbTsKIAogICAgIHJldHVybiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oY2VpbGYodmFsdWUudG9G bG9hdCgpKSk7CiB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdGb250RmFjZUVsZW1lbnQu aCBiL1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5oCmluZGV4IDNjMjhhODkuLjkwNTVm NWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5oCisrKyBiL1dl YkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5oCkBAIC0zMSw2ICszMSw4IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICBjbGFzcyBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbjsKICAgICBj bGFzcyBTVkdGb250RWxlbWVudDsKIAorICAgIGNvbnN0IHVuc2lnbmVkIGRlZmF1bHRVbml0c1Bl ckVtID0gMTAwMDsKKwogICAgIGNsYXNzIFNWR0ZvbnRGYWNlRWxlbWVudCA6IHB1YmxpYyBTVkdF bGVtZW50IHsKICAgICBwdWJsaWM6CiAgICAgICAgIFNWR0ZvbnRGYWNlRWxlbWVudChjb25zdCBR dWFsaWZpZWROYW1lJiwgRG9jdW1lbnQqKTsK