22935 2008-12-19 08:27:17 -0800 navigate elements with directional pad 2009-01-06 11:05:13 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED INVALID P2 Normal --- 1 caryclark webkit-unassigned tonikitoo oldest_to_newest 102982 0 caryclark 2008-12-19 08:27:17 -0800 A mobile device may have only a directional pad to navigate between links. Allow input and select elements to navigate between entries and radio buttons using the directional pad. Also, if dpad navigation is enabled, allow 'Enter' to set the radio's state. 102983 1 26143 caryclark 2008-12-19 08:29:36 -0800 Created attachment 26143 add directional navigation to elements 104131 2 26143 darin 2009-01-02 11:17:13 -0800 Comment on attachment 26143 add directional navigation to elements > +#if !defined(ENABLE_DPAD_NAVIGATION) > +#define ENABLE_DPAD_NAVIGATION 0 > +#endif I don't think DPAD is an abbreviation for "directional pad" that everyone looking at WebKit would recognize, so please use ENABLE_DIRECTIONAL_PAD_NAVIGATION. > @@ -196,6 +196,7 @@ bool HTMLInputElement::isKeyboardFocusab > if (name().isEmpty()) > return false; > > +if !ENABLE(DPAD_NAVIGATION) > // Never allow keyboard tabbing to leave you in the same radio group. Always > // skip any other elements in the group. > Node* currentFocusedNode = document()->focusedNode(); > @@ -205,6 +206,7 @@ bool HTMLInputElement::isKeyboardFocusab > focusedInput->name() == name()) > return false; > } > +#endif > > // Allow keyboard focus if we're checked or if nothing in the group is checked. > return checked() || !checkedRadioButtons(this).checkedButtonForGroup(name()); I don't understand the connection between a "directional pad" and this change, and the change log comments don't make it clear either. Is the tab key considered to be input from the directional pad? If so, is that the best design? Maybe this should not be a compile time setting, but rather a different event, related to the tab key but not identical. The reason isKeyboardFocusable gets a KeyboardEvent argument is so that different types of keyboard navigation can support different rules about what's skipped. I don't think this change is designed correctly. > +#if ENABLE(DPAD_NAVIGATION) > + if (!checked()) // allow enter to set state of radio > + clickElement = true; > + break; > +#else > break; // Don't do anything for enter on a radio button. > +#endif Same comment here. I think the directional pad Enter event should contain something in it that makes it different at runtime. Just compiling in different behavior for all Enter events doesn't seem like the right design. Looking at the other two changes, I have exactly the same thought. This patch seems to be a set of behavior changes at compile time that should instead be tied to some difference in the directional pad events. Or maybe you could convince me otherwise. review- for now 104577 3 caryclark 2009-01-06 11:05:13 -0800 this code is obsolete in the android tree and has been removed; please ignore this patch request 26143 2008-12-19 08:29:36 -0800 2009-01-02 11:17:13 -0800 add directional navigation to elements patchForBug22935.txt text/plain 4643 caryclark SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NDAzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMTItMTkgIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgb3B0aW9uIHRvIGVuYWJsZSBuYXZpZ2F0aW9uIHVzaW5n IGEgZGlyZWN0aW9uYWwKKyAgICAgICAgKGZvdXItd2F5KSBwYWQsIGNvbW1vbiB0byBtYW55IG1v YmlsZSBkZXZpY2VzLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDgtMTItMTkg IEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2VsZmlzaC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYv UGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAko cmV2aXNpb24gMzk0MDIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2lu ZyBjb3B5KQpAQCAtNDI3LDYgKzQyNywxMCBAQAogI2RlZmluZSBFTkFCTEVfVEVYVF9DQVJFVCAx CiAjZW5kaWYKIAorI2lmICFkZWZpbmVkKEVOQUJMRV9EUEFEX05BVklHQVRJT04pCisjZGVmaW5l IEVOQUJMRV9EUEFEX05BVklHQVRJT04gMAorI2VuZGlmCisKICNpZiAhZGVmaW5lZChFTkFCTEVf SklUKQogLyogeDg2LTY0IHN1cHBvcnQgaXMgdW5kZXIgZGV2ZWxvcG1lbnQuICovCiAjaWYgUExB VEZPUk0oWDg2XzY0KSAmJiBQTEFURk9STShNQUMpCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMzk0MDMpCisrKyBXZWJD b3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDA4LTEyLTE5 ICBDYXJ5IENsYXJrICA8Y2FyeWNsYXJrQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERF RCBPUiBDSEFOR0VECisKKyAgICAgICAgQSBtb2JpbGUgZGV2aWNlIG1heSBoYXZlIG9ubHkgYSBk aXJlY3Rpb25hbCBwYWQgdG8gbmF2aWdhdGUgYmV0d2VlbgorICAgICAgICBsaW5rcy4gQWxsb3cg aW5wdXQgYW5kIHNlbGVjdCBlbGVtZW50cyB0byBuYXZpZ2F0ZSBiZXR3ZWVuIGVudHJpZXMKKyAg ICAgICAgYW5kIHJhZGlvIGJ1dHRvbnMgdXNpbmcgdGhlIGRpcmVjdGlvbmFsIHBhZC4gQWxzbywg aWYgZHBhZAorICAgICAgICBuYXZpZ2F0aW9uIGlzIGVuYWJsZWQsIGFsbG93ICdFbnRlcicgdG8g c2V0IHRoZSByYWRpbydzIHN0YXRlLgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmlzS2V5Ym9hcmRGb2N1 c2FibGUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcik6CisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RXZlbnRIYW5kbGVy KToKKwogMjAwOC0xMi0xOSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAg ICAgV2luZG93cyBidWlsZCBmaXggb24gb2xkZXIgdmVyc2lvbnMgb2YgQ0ZOZXR3b3JrIGFmdGVy IHIzOTM5MwpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gMzk0MDIp CisrKyBXZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE5Niw2ICsxOTYsNyBAQCBib29sIEhUTUxJbnB1dEVsZW1lbnQ6OmlzS2V5Ym9hcmRGb2N1c2Fi CiAgICAgICAgIGlmIChuYW1lKCkuaXNFbXB0eSgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwogCitpZiAhRU5BQkxFKERQQURfTkFWSUdBVElPTikKICAgICAgICAgLy8gTmV2ZXIgYWxsb3cg a2V5Ym9hcmQgdGFiYmluZyB0byBsZWF2ZSB5b3UgaW4gdGhlIHNhbWUgcmFkaW8gZ3JvdXAuICBB bHdheXMKICAgICAgICAgLy8gc2tpcCBhbnkgb3RoZXIgZWxlbWVudHMgaW4gdGhlIGdyb3VwLgog ICAgICAgICBOb2RlKiBjdXJyZW50Rm9jdXNlZE5vZGUgPSBkb2N1bWVudCgpLT5mb2N1c2VkTm9k ZSgpOwpAQCAtMjA1LDYgKzIwNiw3IEBAIGJvb2wgSFRNTElucHV0RWxlbWVudDo6aXNLZXlib2Fy ZEZvY3VzYWIKICAgICAgICAgICAgICAgICBmb2N1c2VkSW5wdXQtPm5hbWUoKSA9PSBuYW1lKCkp CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CisjZW5kaWYKICAgICAg ICAgCiAgICAgICAgIC8vIEFsbG93IGtleWJvYXJkIGZvY3VzIGlmIHdlJ3JlIGNoZWNrZWQgb3Ig aWYgbm90aGluZyBpbiB0aGUgZ3JvdXAgaXMgY2hlY2tlZC4KICAgICAgICAgcmV0dXJuIGNoZWNr ZWQoKSB8fCAhY2hlY2tlZFJhZGlvQnV0dG9ucyh0aGlzKS5jaGVja2VkQnV0dG9uRm9yR3JvdXAo bmFtZSgpKTsKQEAgLTEyNzYsNyArMTI3OCwxMyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OmRl ZmF1bHRFdmVudEhhbmRsCiAgICAgICAgICAgICAgICAgICAgIGNsaWNrRWxlbWVudCA9IHRydWU7 CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIGNhc2UgUkFESU86 CisjaWYgRU5BQkxFKERQQURfTkFWSUdBVElPTikKKyAgICAgICAgICAgICAgICAgICAgaWYgKCFj aGVja2VkKCkpIC8vIGFsbG93IGVudGVyIHRvIHNldCBzdGF0ZSBvZiByYWRpbworICAgICAgICAg ICAgICAgICAgICAgICAgY2xpY2tFbGVtZW50ID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAg YnJlYWs7CisjZWxzZQogICAgICAgICAgICAgICAgICAgICBicmVhazsgLy8gRG9uJ3QgZG8gYW55 dGhpbmcgZm9yIGVudGVyIG9uIGEgcmFkaW8gYnV0dG9uLgorI2VuZGlmCiAgICAgICAgICAgICB9 CiAgICAgICAgIH0gZWxzZSBpZiAoY2hhckNvZGUgPT0gJyAnKSB7CiAgICAgICAgICAgICBzd2l0 Y2ggKGlucHV0VHlwZSgpKSB7CkBAIC0xMzIyLDYgKzEzMzAsNyBAQCB2b2lkIEhUTUxJbnB1dEVs ZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAorI2lm ICFFTkFCTEUoRFBBRF9OQVZJR0FUSU9OKQogICAgICAgICBpZiAoaW5wdXRUeXBlKCkgPT0gUkFE SU8gJiYgKGtleSA9PSAiVXAiIHx8IGtleSA9PSAiRG93biIgfHwga2V5ID09ICJMZWZ0IiB8fCBr ZXkgPT0gIlJpZ2h0IikpIHsKICAgICAgICAgICAgIC8vIExlZnQgYW5kIHVwIG1lYW4gInByZXZp b3VzIHJhZGlvIGJ1dHRvbiIuCiAgICAgICAgICAgICAvLyBSaWdodCBhbmQgZG93biBtZWFuICJu ZXh0IHJhZGlvIGJ1dHRvbiIuCkBAIC0xMzU2LDYgKzEzNjUsNyBAQCB2b2lkIEhUTUxJbnB1dEVs ZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsCiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg fQogICAgICAgICB9CisjZW5kaWYKICAgICB9CiAKICAgICBpZiAoZXZ0LT50eXBlKCkgPT0gZXZl bnROYW1lcygpLmtleXVwRXZlbnQgJiYgZXZ0LT5pc0tleWJvYXJkRXZlbnQoKSkgewpJbmRleDog V2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiAzOTQwMikKKysrIFdlYkNvcmUv aHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzMyw2ICs2MzMs MTEgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RQogICAgICAgICAg ICAgbWVudUxpc3QtPnNob3dQb3B1cCgpOwogICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7CiAg ICAgICAgIH0KKyNlbGlmIEVOQUJMRShEUEFEX05BVklHQVRJT04pCisgICAgICAgIGlmIChrZXlJ ZGVudGlmaWVyID09ICJFbnRlciIgJiYgdXNlc01lbnVMaXN0KCkpIHsKKyAgICAgICAgICAgIG1l bnVMaXN0LT5zaG93UG9wdXAoKTsKKyAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOworICAgICAg ICB9CiAjZWxzZQogICAgICAgICBpbnQgbGlzdEluZGV4ID0gb3B0aW9uVG9MaXN0SW5kZXgoc2Vs ZWN0ZWRJbmRleCgpKTsKICAgICAgICAgaWYgKGtleUlkZW50aWZpZXIgPT0gIkRvd24iIHx8IGtl eUlkZW50aWZpZXIgPT0gIlJpZ2h0Iikgewo=