229348 2021-08-20 13:19:09 -0700 Improve diagnostics for missing files in DerivedSources.make 2021-08-26 10:26:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 229487 1 ap ap aakash_jain commit-queue darin ddkilzer webkit-bug-importer oldest_to_newest 1785961 0 ap 2021-08-20 13:19:09 -0700 We are seeing mysterious build failures in certain scenarios which looks like this: make: *** No rule to make target `UserAgentScripts.h', needed by `all'. Stop. The theory is that some files that should be present in the file system aren't, but the error is not clear enough. Let's add better diagnostics to isolate the issue. cf. rdar://81042866 1785962 1 webkit-bug-importer 2021-08-20 13:19:23 -0700 <rdar://problem/82182815> 1785967 2 436022 ap 2021-08-20 13:31:24 -0700 Created attachment 436022 proposed patch In testing, this patch appears to resolve the build failures instead of providing diagnostics, which is not quite satisfactory, and the theory may be incorrect. I don't see how to further diagnose the issue, and in any case, we'll have better diagnostics if the build fails again in the future, so it's an improvement either way. 1786854 3 aakash_jain 2021-08-24 11:37:45 -0700 rs=me 1787050 4 436022 ap 2021-08-24 18:24:14 -0700 Comment on attachment 436022 proposed patch Landing with review from Aakash and me (as it's not my patch). 1787056 5 ews-feeder 2021-08-24 18:57:28 -0700 Committed r281540 (240907@main): <https://commits.webkit.org/240907@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436022. 1787090 6 commit-queue 2021-08-24 23:20:05 -0700 Re-opened since this is blocked by bug 229487 1787666 7 ap 2021-08-26 10:26:35 -0700 We no longer think that it's going to work. The script that verifies xcfilelists by running make in debug mode thinks that these fake outputs are real, and modifying it feels like it would be too much of a hack. 436022 2021-08-20 13:31:24 -0700 2021-08-24 18:57:28 -0700 proposed patch DerivedSourcesLogging.txt text/plain 2463 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MTMzMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA4LTIwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgZGlhZ25vc3Rp Y3MgZm9yIG1pc3NpbmcgZmlsZXMgaW4gRGVyaXZlZFNvdXJjZXMubWFrZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MzQ4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGF0Y2ggYnkgQWxleGVpIEtvbG9t aWV0cy4KKworICAgICAgICBXZSBhcmUgc2VlaW5nIGZsYWt5IGJ1aWxkIGZhaWx1cmVzIGluIGNl cnRhaW4gc2NlbmFyaW9zIChyZGFyOi8vODEwNDI4NjYpLCB3aGljaAorICAgICAgICBsb29rIGxp a2UgdGhpczoKKworICAgICAgICBtYWtlOiAqKiogTm8gcnVsZSB0byBtYWtlIHRhcmdldCBgVXNl ckFnZW50U2NyaXB0cy5oJywgbmVlZGVkIGJ5IGBhbGwnLiAgU3RvcC4KKworICAgICAgICBUaGUg dGhlb3J5IGlzIHRoYXQgc29tZSBmaWxlcyB0aGF0IHNob3VsZCBiZSBwcmVzZW50IGluIHRoZSBm aWxlIHN5c3RlbSBhcmVuJ3QsCisgICAgICAgIGJ1dCB0aGUgZXJyb3IgaXMgbm90IGNsZWFyIGVu b3VnaC4gTGV0J3MgYWRkIGJldHRlciBkaWFnbm9zdGljcyB0byBpc29sYXRlIHRoZSBpc3N1ZS4K KworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLm1ha2U6CisKIDIwMjEtMDgtMjAgIENhcmxvcyBB bGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMjc0MTY2KTogW0dUS10gSXQgYnJva2UgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIGNh dXNpbmcgYWxsIHRlc3RzIHRvIHVzZSBsb3Qgb2YgbWVtb3J5CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9EZXJpdmVkU291cmNlcy5tYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0Rlcml2 ZWRTb3VyY2VzLm1ha2UJKHJldmlzaW9uIDI4MTMzMykKKysrIFNvdXJjZS9XZWJDb3JlL0Rlcml2 ZWRTb3VyY2VzLm1ha2UJKHdvcmtpbmcgY29weSkKQEAgLTE2NDAsNiArMTY0MCw5IEBAIFVTRVJf QUdFTlRfU0NSSVBUU19GSUxFU19QQVRURVJOUyA9ICQoc3UKIAogYWxsIDogJChVU0VSX0FHRU5U X1NDUklQVFNfRklMRVMpCiAKKyQoSmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVIpL21ha2UtanMt ZmlsZS1hcnJheXMucHkgOgorCSQoZXJyb3IgJEAgaXMgbm90IGZvdW5kLCBleHBlY3RlZCB0byBl eGlzdCBpbiAkKHJlYWxwYXRoICQoZGlyICRAKSkpCisKICQoVVNFUl9BR0VOVF9TQ1JJUFRTX0ZJ TEVTX1BBVFRFUk5TKSA6ICQoSmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVIpL21ha2UtanMtZmls ZS1hcnJheXMucHkgJChVU0VSX0FHRU5UX1NDUklQVFMpCiAJJChQWVRIT04pICQoSmF2YVNjcmlw dENvcmVfU0NSSVBUU19ESVIpL21ha2UtanMtZmlsZS1hcnJheXMucHkgLW4gV2ViQ29yZSAtLWZh aWwtaWYtbm9uLWFzY2lpICQoVVNFUl9BR0VOVF9TQ1JJUFRTX0ZJTEVTKSAkKFVTRVJfQUdFTlRf U0NSSVBUUykKIApAQCAtMTk3Myw2ICsxOTc2LDEyIEBAIFdlYkNvcmVfQlVJTFRJTlNfV1JBUFBF UlNfUEFUVEVSTlMgPSAkKHMKICMgQWRkaW5nL3JlbW92aW5nIHNjcmlwdHMgc2hvdWxkIHRyaWdn ZXIgcmVnZW5lcmF0aW9uLCBidXQgY2hhbmdpbmcgd2hpY2ggYnVpbHRpbnMgYXJlCiAjIGdlbmVy YXRlZCBzaG91bGQgbm90IGFmZmVjdCBvdGhlciBidWlsdGlucyB3aGVuIG5vdCBwYXNzaW5nICct LWNvbWJpbmVkJyB0byB0aGUgZ2VuZXJhdG9yLgogCiskKEphdmFTY3JpcHRDb3JlX1NDUklQVFNf RElSKS9VcGRhdGVDb250ZW50cy5weSA6CisJJChlcnJvciAkQCBpcyBub3QgZm91bmQsIGV4cGVj dGVkIHRvIGV4aXN0IGluICQocmVhbHBhdGggJChkaXIgJEApKSkKKworJChCVUlMVElOU19HRU5F UkFUT1JfU0NSSVBUUykgOgorCSQoZXJyb3IgJEAgaXMgbm90IGZvdW5kLCBleHBlY3RlZCB0byBl eGlzdCBpbiAkKHJlYWxwYXRoICQoZGlyICRAKSkpCisKIFdlYkNvcmVfQlVJTFRJTlNfU09VUkNF U19MSVNUIDogJChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUikvVXBkYXRlQ29udGVudHMucHkg JChXZWJDb3JlKS9EZXJpdmVkU291cmNlcy5tYWtlCiAJJChQWVRIT04pICQoSmF2YVNjcmlwdENv cmVfU0NSSVBUU19ESVIpL1VwZGF0ZUNvbnRlbnRzLnB5ICckKFdlYkNvcmVfQlVJTFRJTlNfU09V UkNFUyknICRACiAK