229329 2021-08-20 02:30:13 -0700 Remove assertIsTagged and assertIsNullOrTagged. 2021-08-20 08:53:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1785751 0 mark.lam 2021-08-20 02:30:13 -0700 These assertion utility functions relies on tagged pointers always having non-zero PAC bits. This is an incorrect assumption. A tagged pointer can have PAC bits that are completely zero. Hence, these assert functions cannot be made to work reliably. We should remove them to prevent them from being used, and potentially resulting in flaky assertion failures that will hard to debug later. 1785752 1 webkit-bug-importer 2021-08-20 02:30:40 -0700 <rdar://problem/82162851> 1785760 2 435963 mark.lam 2021-08-20 02:45:09 -0700 Created attachment 435963 proposed patch. 1785761 3 435963 ysuzuki 2021-08-20 02:50:57 -0700 Comment on attachment 435963 proposed patch. r=me 1785837 4 435963 mark.lam 2021-08-20 08:25:05 -0700 Comment on attachment 435963 proposed patch. Thanks for the review. Landing now. 1785850 5 ews-feeder 2021-08-20 08:53:22 -0700 Committed r281317 (240734@main): <https://commits.webkit.org/240734@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435963. 435963 2021-08-20 02:45:09 -0700 2021-08-20 08:53:23 -0700 proposed patch. bug-229329.patch text/plain 2783 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyODEzMDMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDIxLTA4LTIwICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYXNzZXJ0SXNUYWdnZWQgYW5kIGFzc2VydElz TnVsbE9yVGFnZ2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI5MzI5CisgICAgICAgIHJkYXI6Ly84MjE2Mjg1MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXNlIGFzc2VydGlvbiB1dGlsaXR5IGZ1 bmN0aW9ucyByZWx5IG9uIHRhZ2dlZCBwb2ludGVycyBhbHdheXMgaGF2aW5nIG5vbi16ZXJvCisg ICAgICAgIFBBQyBiaXRzLiAgVGhpcyBpcyBhbiBpbmNvcnJlY3QgYXNzdW1wdGlvbi4gIEEgdGFn Z2VkIHBvaW50ZXIgY2FuIGhhdmUgUEFDIGJpdHMKKyAgICAgICAgdGhhdCBhcmUgY29tcGxldGVs eSB6ZXJvLiAgSGVuY2UsIHRoZXNlIGFzc2VydCBmdW5jdGlvbnMgY2Fubm90IGJlIG1hZGUgdG8g d29yaworICAgICAgICByZWxpYWJseS4gIFdlIHNob3VsZCByZW1vdmUgdGhlbSB0byBwcmV2ZW50 IHRoZW0gZnJvbSBiZWluZyB1c2VkLCBhbmQgcG90ZW50aWFsbHkKKyAgICAgICAgcmVzdWx0aW5n IGluIGZsYWt5IGFzc2VydGlvbiBmYWlsdXJlcyB0aGF0IHdpbGwgYmUgaGFyZCB0byBkZWJ1ZyBs YXRlci4KKworICAgICAgICBOb3RlOiBhc3NlcnRJc05vdFRhZ2dlZCBpcyBmaW5lIHRvIGtlZXAu ICBJdCBhc3NlcnRzIHRoYXQgUEFDIGJpdHMgb2YgYSBwb2ludGVyCisgICAgICAgIGFyZSBhbGwg MC4gIEFzIGEgcmVzdWx0LCB0aGlzIGFzc2VydGlvbiBjYW4gaGF2ZSBmYWxzZSBwb3NpdGl2ZXMg d2hlcmUgaXQgbWF5IHRoaW5rCisgICAgICAgIGEgdGFnZ2VkIHBvaW50ZXIgaXMgYW4gdW50YWdn ZWQgcG9pbnRlci4gIEhvd2V2ZXIsIHRoaXMgaXMgcmFyZSBiZWNhdXNlIGl0IGlzIG5vdAorICAg ICAgICBjb21tb24gdG8gaGF2ZSAwIFBBQyBiaXRzIGluIHRhZ2dlZCBwb2ludGVycy4gIEZhbHNl IHBvc2l0aXZlcyBvbiB0aGlzIGFzc2VydGlvbgorICAgICAgICB3b24ndCByZXN1bHQgaW4gZmxh a3kgdGVzdCBmYWlsdXJlcyB0aGF0IHdpbGwgd2FzdGUgb3VyIHRpbWUgbGF0ZXIuICBIZW5jZSwK KyAgICAgICAga2VlcGluZyB0aGUgYXNzZXJ0aW9uIHdpbGwgZG8gbW9yZSBnb29kIChpdCB3aWxs IHRlbmQgdG8gaGVscCB1cyBmaW5kIGJ1Z3MpIHRoYW4KKyAgICAgICAgYmFkIChpdCB3aWxsIHJh cmVseSBsZXQgZmFsc2UgcG9zaXRpdmVzIHRocnUpLiAgQXMgYSByZXN1bHQsIEknbSBvcHRpbmcg dG8gbm90CisgICAgICAgIHJlbW92ZSBpdC4KKworICAgICAgICAqIHd0Zi9QdHJUYWcuaDoKKyAg ICAgICAgKFdURjo6YXNzZXJ0SXNUYWdnZWQpOiBEZWxldGVkLgorICAgICAgICAoV1RGOjphc3Nl cnRJc051bGxPclRhZ2dlZCk6IERlbGV0ZWQuCisKIDIwMjEtMDgtMTkgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFs6aGFzKCkgcHNldWRvLWNsYXNzXSBCYXNp YyBzdXBwb3J0CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QdHJUYWcuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV1RGL3d0Zi9QdHJUYWcuaAkocmV2aXNpb24gMjgxMjk3KQorKysgU291cmNlL1dURi93 dGYvUHRyVGFnLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxOCwyMCArMzE4LDYgQEAgdm9pZCBhc3Nl cnRJc05vdFRhZ2dlZChQdHJUeXBlIHZhbHVlKQogICAgIFdURl9QVFJUQUdfQVNTRVJUKFB0clRh Z0FjdGlvbjo6RGVidWdBc3NlcnQsIHB0ciwgTm9QdHJUYWcsIHB0ciA9PSByZW1vdmVDb2RlUHRy VGFnKHB0cikpOwogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBQdHJUeXBlPgotdm9pZCBhc3NlcnRJ c1RhZ2dlZChQdHJUeXBlIHZhbHVlKQotewotICAgIHZvaWQqIHB0ciA9IGJpdHdpc2VfY2FzdDx2 b2lkKj4odmFsdWUpOwotICAgIFdURl9QVFJUQUdfQVNTRVJUKFB0clRhZ0FjdGlvbjo6RGVidWdB c3NlcnQsIHB0ciwgQW55UHRyVGFnLCBwdHIgIT0gcmVtb3ZlQ29kZVB0clRhZyhwdHIpKTsKLX0K LQotdGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZT4KLXZvaWQgYXNzZXJ0SXNOdWxsT3JUYWdnZWQo UHRyVHlwZSBwdHIpCi17Ci0gICAgaWYgKHB0cikKLSAgICAgICAgYXNzZXJ0SXNUYWdnZWQocHRy KTsKLX0KLQogdGVtcGxhdGU8UHRyVGFnIHRhZywgdHlwZW5hbWUgUHRyVHlwZT4KIGJvb2wgaXNU YWdnZWRXaXRoKFB0clR5cGUgdmFsdWUpCiB7CkBAIC01NzgsOCArNTY0LDYgQEAgdXNpbmcgV1RG Ojp1bnRhZ0ludDsKIHVzaW5nIFdURjo6YXNzZXJ0SXNDRnVuY3Rpb25QdHI7CiB1c2luZyBXVEY6 OmFzc2VydElzTnVsbE9yQ0Z1bmN0aW9uUHRyOwogdXNpbmcgV1RGOjphc3NlcnRJc05vdFRhZ2dl ZDsKLXVzaW5nIFdURjo6YXNzZXJ0SXNUYWdnZWQ7Ci11c2luZyBXVEY6OmFzc2VydElzTnVsbE9y VGFnZ2VkOwogdXNpbmcgV1RGOjppc1RhZ2dlZFdpdGg7CiB1c2luZyBXVEY6OmFzc2VydElzVGFn Z2VkV2l0aDsKIHVzaW5nIFdURjo6YXNzZXJ0SXNOdWxsT3JUYWdnZWRXaXRoOwo=