229328 2021-08-20 02:04:57 -0700 Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE. 2021-08-20 08:56:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1785741 0 mark.lam 2021-08-20 02:04:57 -0700 If ptrTagName and tagForPtr are defined, make them WTF_EXPORT_PRIVATE instead of static functions. This allows us to call them from the debugger during interactive debugging sessions. 1785744 1 435956 mark.lam 2021-08-20 02:09:17 -0700 Created attachment 435956 proposed patch. 1785745 2 webkit-bug-importer 2021-08-20 02:09:48 -0700 <rdar://problem/82162395> 1785749 3 435956 ysuzuki 2021-08-20 02:16:42 -0700 Comment on attachment 435956 proposed patch. r=me 1785834 4 435956 mark.lam 2021-08-20 08:24:12 -0700 Comment on attachment 435956 proposed patch. Thanks for the review. Landing now. 1785852 5 ews-feeder 2021-08-20 08:56:14 -0700 Committed r281318 (240735@main): <https://commits.webkit.org/240735@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435956. 435956 2021-08-20 02:09:17 -0700 2021-08-20 08:56:15 -0700 proposed patch. bug-229328.patch text/plain 2127 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyODEzMDApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA4LTIwICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHB0clRhZ05hbWUgYW5kIHRhZ0ZvclB0ciBXVEZf RVhQT1JUX1BSSVZBVEUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjkzMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJZiBwdHJUYWdOYW1lIGFuZCB0YWdGb3JQdHIgYXJlIGRlZmluZWQsIG1ha2UgdGhl bSBXVEZfRVhQT1JUX1BSSVZBVEUgaW5zdGVhZCBvZgorICAgICAgICBzdGF0aWMgZnVuY3Rpb25z LiAgVGhpcyBhbGxvd3MgdXMgdG8gY2FsbCB0aGVtIGZyb20gdGhlIGRlYnVnZ2VyIGR1cmluZwor ICAgICAgICBpbnRlcmFjdGl2ZSBkZWJ1Z2dpbmcgc2Vzc2lvbnMuCisKKyAgICAgICAgKiB3dGYv UHRyVGFnLmNwcDoKKyAgICAgICAgKFdURjo6dGFnRm9yUHRyKToKKyAgICAgICAgKFdURjo6cHRy VGFnTmFtZSk6CisgICAgICAgICogd3RmL1B0clRhZy5oOgorCiAyMDIxLTA4LTE5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbOmhhcygpIHBzZXVkby1jbGFz c10gQmFzaWMgc3VwcG9ydApJbmRleDogU291cmNlL1dURi93dGYvUHRyVGFnLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QdHJUYWcuY3BwCShyZXZpc2lvbiAyODEyOTcpCisrKyBT b3VyY2UvV1RGL3d0Zi9QdHJUYWcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBA IG5hbWVzcGFjZSBXVEYgewogCiAjaWYgQ1BVKEFSTTY0RSkgJiYgRU5BQkxFKFBUUlRBR19ERUJV R0dJTkcpCiAKLXN0YXRpYyBjb25zdCBjaGFyKiB0YWdGb3JQdHIoY29uc3Qgdm9pZCogcHRyKQor Y29uc3QgY2hhciogdGFnRm9yUHRyKGNvbnN0IHZvaWQqIHB0cikKIHsKICAgICBQdHJUYWdMb29r dXAqIGxvb2t1cCA9IGdfd3RmQ29uZmlnLnB0clRhZ0xvb2t1cEhlYWQ7CiAgICAgd2hpbGUgKGxv b2t1cCkgewpAQCAtNTQsNyArNTQsNyBAQCBzdGF0aWMgY29uc3QgY2hhciogdGFnRm9yUHRyKGNv bnN0IHZvaWQqCiAgICAgcmV0dXJuICI8dW5rbm93biBQdHJUYWc+IjsKIH0KIAotc3RhdGljIGNv bnN0IGNoYXIqIHB0clRhZ05hbWUoUHRyVGFnIHRhZykKK2NvbnN0IGNoYXIqIHB0clRhZ05hbWUo UHRyVGFnIHRhZykKIHsKICAgICBQdHJUYWdMb29rdXAqIGxvb2t1cCA9IGdfd3RmQ29uZmlnLnB0 clRhZ0xvb2t1cEhlYWQ7CiAgICAgd2hpbGUgKGxvb2t1cCkgewpJbmRleDogU291cmNlL1dURi93 dGYvUHRyVGFnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUHRyVGFnLmgJKHJldmlz aW9uIDI4MTI5NykKKysrIFNvdXJjZS9XVEYvd3RmL1B0clRhZy5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNTcsNiArMTU3LDEwIEBAIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHJlZ2lzdGVyUHRyVGFn TG8KIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHJlcG9ydEJhZFRhZyhjb25zdCB2b2lkKiwgUHRy VGFnIGV4cGVjdGVkVGFnKTsKIAogI2lmIEVOQUJMRShQVFJUQUdfREVCVUdHSU5HKQorCitXVEZf RVhQT1JUX1BSSVZBVEUgY29uc3QgY2hhciogcHRyVGFnTmFtZShQdHJUYWcpOworV1RGX0VYUE9S VF9QUklWQVRFIGNvbnN0IGNoYXIqIHRhZ0ZvclB0cihjb25zdCB2b2lkKik7CisKIGNvbnN0ZXhw ciBib29sIGVuYWJsZVB0clRhZ0RlYnVnQXNzZXJ0ID0gdHJ1ZTsKICNkZWZpbmUgUkVQT1JUX0JB RF9UQUcoc3VjY2VzcywgcHRyLCBleHBlY3RlZFRhZykgZG8geyBcCiAgICAgICAgIGlmIChVTkxJ S0VMWSghc3VjY2VzcykpIFwK