229320 2021-08-19 18:45:49 -0700 MediaSession artwork URL is showing in logs. 2021-08-24 17:07:35 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1785668 0 jean-yves.avenard 2021-08-19 18:45:49 -0700 We show the MediaSession artwork URL if any is present in the log. We shouldn't 1785687 1 webkit-bug-importer 2021-08-19 21:47:21 -0700 <rdar://problem/82156288> 1785688 2 435939 jean-yves.avenard 2021-08-19 21:49:30 -0700 Created attachment 435939 Patch 1785858 3 435939 youennf 2021-08-20 09:10:14 -0700 Comment on attachment 435939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435939&action=review > Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:-393 > - I would tend to keep this logging but remove some information like title and src then. 1785865 4 435939 eric.carlson 2021-08-20 09:25:23 -0700 Comment on attachment 435939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435939&action=review > Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:392 > +#ifdef DEBUG `#ifndef LOG_DISABLED` would be better I think. >> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:-393 >> - > > I would tend to keep this logging but remove some information like title and src then. I agree, just drop the url when LOG_DISABLED 1786668 5 436264 jean-yves.avenard 2021-08-23 22:50:25 -0700 Created attachment 436264 Patch apply comment 1787015 6 ews-feeder 2021-08-24 17:07:33 -0700 Committed r281533 (240904@main): <https://commits.webkit.org/240904@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436264. 435939 2021-08-19 21:49:30 -0700 2021-08-23 22:50:20 -0700 Patch bug-229320-20210820144929.patch text/plain 2042 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU1OTE5NWFjZmQ1OWU2 OTA3YTEwNWNkM2E0YWQ1ODQ2Y2M1Yzk2ZS4uNTFlMGY3ZTkzOGQ1ZDc5MzUzMjdiYzU3ZGY3ZDkw Y2Q5Y2ZlMzYxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA4LTE5ICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFTZXNzaW9uIGFy dHdvcmsgVVJMIGlzIHNob3dpbmcgaW4gbG9ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTMyMAorICAgICAgICByZGFyOi8vODIxNTYyODgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGVuYWJs ZSBhcnR3b3JrIGxvZ2dpbmcgaW4gZGVidWcgYnVpbGRzLgorCisgICAgICAgICogcGxhdGZvcm0v YXVkaW8vY29jb2EvTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFTZXNzaW9uTWFuYWdlckNvY29hOjp1cGRhdGVOb3dQbGF5aW5nSW5mbyk6CisKIDIw MjEtMDgtMTIgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBu ZXh0dHJhY2sgYW5kIHByZXZpb3VzdHJhY2sgTWVkaWFTZXNzaW9uIGhhbmRsZXJzIG5vdCB3b3Jr aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9jb2NvYS9NZWRp YVNlc3Npb25NYW5hZ2VyQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9j b2NvYS9NZWRpYVNlc3Npb25NYW5hZ2VyQ29jb2EubW0KaW5kZXggYzk2MTFjM2IwNmMzY2FlZjJi YmI0MDFmMGM1ZTc3OWZmZDdmNDY3My4uOTRiOGNiOTVmMjZkNWZjMDkxZjY4N2EyNjI2ZDEyZjNm NjM5OTQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2Ev TWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL2NvY29hL01lZGlhU2Vzc2lvbk1hbmFnZXJDb2NvYS5tbQpAQCAtMzg4LDkgKzM4OCwx MSBAQCB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXJDb2NvYTo6dXBkYXRlTm93UGxheWluZ0luZm8o KQogCiAgICAgbV9oYXZlRXZlclJlZ2lzdGVyZWRBc05vd1BsYXlpbmdBcHBsaWNhdGlvbiA9IHRy dWU7CiAKLSAgICBpZiAobV9ub3dQbGF5aW5nTWFuYWdlci0+c2V0Tm93UGxheWluZ0luZm8oKm5v d1BsYXlpbmdJbmZvKSkKKyAgICBpZiAobV9ub3dQbGF5aW5nTWFuYWdlci0+c2V0Tm93UGxheWlu Z0luZm8oKm5vd1BsYXlpbmdJbmZvKSkgeworI2lmZGVmIERFQlVHCiAgICAgICAgIEFMV0FZU19M T0coTE9HSURFTlRJRklFUiwgInRpdGxlID0gXCIiLCBub3dQbGF5aW5nSW5mby0+dGl0bGUsICJc IiwgaXNQbGF5aW5nID0gIiwgbm93UGxheWluZ0luZm8tPmlzUGxheWluZywgIiwgZHVyYXRpb24g PSAiLCBub3dQbGF5aW5nSW5mby0+ZHVyYXRpb24sICIsIG5vdyA9ICIsIG5vd1BsYXlpbmdJbmZv LT5jdXJyZW50VGltZSwgIiwgaWQgPSAiLCBub3dQbGF5aW5nSW5mby0+dW5pcXVlSWRlbnRpZmll ci50b1VJbnQ2NCgpLCAiLCByZWdpc3RlcmVkID0gIiwgbV9yZWdpc3RlcmVkQXNOb3dQbGF5aW5n QXBwbGljYXRpb24sICIsIHNyYyA9IFwiIiwgbm93UGxheWluZ0luZm8tPmFydHdvcmsgPyBub3dQ bGF5aW5nSW5mby0+YXJ0d29yay0+c3JjIDogU3RyaW5nKCksICJcIiIpOwotCisjZW5kaWYKKyAg ICB9CiAgICAgaWYgKCFtX3JlZ2lzdGVyZWRBc05vd1BsYXlpbmdBcHBsaWNhdGlvbikgewogICAg ICAgICBtX3JlZ2lzdGVyZWRBc05vd1BsYXlpbmdBcHBsaWNhdGlvbiA9IHRydWU7CiAgICAgICAg IHByb3ZpZGVQcmVzZW50aW5nQXBwbGljYXRpb25QSURJZk5lY2Vzc2FyeSgpOwo= 436264 2021-08-23 22:50:25 -0700 2021-08-24 17:07:34 -0700 Patch bug-229320-20210824155024.patch text/plain 2583 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIyNmVhNjRjODJmNDQx YWQwZWQ5ZjA4ZTI2NTM3ZmY2ODI5NmQ1MC4uMjVlODYwZWExMzQ5NjMzMmQ5ODM2MjU0MDhiNjMw NjE4ZmJiOTQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA4LTE5ICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFTZXNzaW9uIGFy dHdvcmsgVVJMIGlzIHNob3dpbmcgaW4gbG9ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTMyMAorICAgICAgICByZGFyOi8vODIxNTYyODgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGVuYWJs ZSBhcnR3b3JrIGxvZ2dpbmcgaW4gZGVidWcgYnVpbGRzLgorCisgICAgICAgICogcGxhdGZvcm0v YXVkaW8vY29jb2EvTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFTZXNzaW9uTWFuYWdlckNvY29hOjp1cGRhdGVOb3dQbGF5aW5nSW5mbyk6CisKIDIw MjEtMDgtMjMgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBb Q29jb2FdIFNob3VsZCB2aWRlbyBzdG9wIGJlaW5nIGxpdmUsIHRpbWUgc2NydWJiZXIgd2lsbCBu b3Qgc2hvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2Ev TWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vY29jb2EvTWVkaWFTZXNzaW9uTWFuYWdlckNvY29hLm1tCmluZGV4IDJlZDk2Y2RhZWI5ZWY1 OGRiYzg1OTQ0OTk3NGRmYTQ2OTg2YWMwZTEuLjFiNjYzMmE1NDFlZDNhNDRiMDNkYTEzYzJkMTI3 MDk5NmIyN2E5N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2Nv Y29hL01lZGlhU2Vzc2lvbk1hbmFnZXJDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9jb2NvYS9NZWRpYVNlc3Npb25NYW5hZ2VyQ29jb2EubW0KQEAgLTM5Miw5ICsz OTIsMTYgQEAgdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyQ29jb2E6OnVwZGF0ZU5vd1BsYXlpbmdJ bmZvKCkKIAogICAgIG1faGF2ZUV2ZXJSZWdpc3RlcmVkQXNOb3dQbGF5aW5nQXBwbGljYXRpb24g PSB0cnVlOwogCi0gICAgaWYgKG1fbm93UGxheWluZ01hbmFnZXItPnNldE5vd1BsYXlpbmdJbmZv KCpub3dQbGF5aW5nSW5mbykpCi0gICAgICAgIEFMV0FZU19MT0coTE9HSURFTlRJRklFUiwgInRp dGxlID0gXCIiLCBub3dQbGF5aW5nSW5mby0+dGl0bGUsICJcIiwgaXNQbGF5aW5nID0gIiwgbm93 UGxheWluZ0luZm8tPmlzUGxheWluZywgIiwgZHVyYXRpb24gPSAiLCBub3dQbGF5aW5nSW5mby0+ ZHVyYXRpb24sICIsIG5vdyA9ICIsIG5vd1BsYXlpbmdJbmZvLT5jdXJyZW50VGltZSwgIiwgaWQg PSAiLCBub3dQbGF5aW5nSW5mby0+dW5pcXVlSWRlbnRpZmllci50b1VJbnQ2NCgpLCAiLCByZWdp c3RlcmVkID0gIiwgbV9yZWdpc3RlcmVkQXNOb3dQbGF5aW5nQXBwbGljYXRpb24sICIsIHNyYyA9 IFwiIiwgbm93UGxheWluZ0luZm8tPmFydHdvcmsgPyBub3dQbGF5aW5nSW5mby0+YXJ0d29yay0+ c3JjIDogU3RyaW5nKCksICJcIiIpOwotCisgICAgaWYgKG1fbm93UGxheWluZ01hbmFnZXItPnNl dE5vd1BsYXlpbmdJbmZvKCpub3dQbGF5aW5nSW5mbykpIHsKKyNpZmRlZiBMT0dfRElTQUJMRUQK KyAgICAgICAgU3RyaW5nIHNyYyA9ICJzcmMiOworICAgICAgICBTdHJpbmcgdGl0bGUgPSAidGl0 bGUiOworI2Vsc2UKKyAgICAgICAgU3RyaW5nIHNyYyA9IG5vd1BsYXlpbmdJbmZvLT5hcnR3b3Jr ID8gbm93UGxheWluZ0luZm8tPmFydHdvcmstPnNyYyA6IFN0cmluZygpOworICAgICAgICBTdHJp bmcgdGl0bGUgPSBub3dQbGF5aW5nSW5mby0+dGl0bGU7CisjZW5kaWYKKyAgICAgICAgQUxXQVlT X0xPRyhMT0dJREVOVElGSUVSLCAidGl0bGUgPSBcIiIsIHRpdGxlLCAiXCIsIGlzUGxheWluZyA9 ICIsIG5vd1BsYXlpbmdJbmZvLT5pc1BsYXlpbmcsICIsIGR1cmF0aW9uID0gIiwgbm93UGxheWlu Z0luZm8tPmR1cmF0aW9uLCAiLCBub3cgPSAiLCBub3dQbGF5aW5nSW5mby0+Y3VycmVudFRpbWUs ICIsIGlkID0gIiwgbm93UGxheWluZ0luZm8tPnVuaXF1ZUlkZW50aWZpZXIudG9VSW50NjQoKSwg IiwgcmVnaXN0ZXJlZCA9ICIsIG1fcmVnaXN0ZXJlZEFzTm93UGxheWluZ0FwcGxpY2F0aW9uLCAi LCBzcmMgPSBcIiIsIHNyYywgIlwiIik7CisgICAgfQogICAgIGlmICghbV9yZWdpc3RlcmVkQXNO b3dQbGF5aW5nQXBwbGljYXRpb24pIHsKICAgICAgICAgbV9yZWdpc3RlcmVkQXNOb3dQbGF5aW5n QXBwbGljYXRpb24gPSB0cnVlOwogICAgICAgICBwcm92aWRlUHJlc2VudGluZ0FwcGxpY2F0aW9u UElESWZOZWNlc3NhcnkoKTsK