229317 2021-08-19 17:56:03 -0700 Ancestors with opacity should not affect top layer elements 2021-08-20 13:51:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229350 84635 1 ntim ntim bfulgham changseok clopez esprehn+autocc ews-watchlist fred.wang glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer youennf zalan oldest_to_newest 1785652 0 ntim 2021-08-19 17:56:03 -0700 From: https://fullscreen.spec.whatwg.org/#new-stacking-layer Ancestor elements with overflow, opacity, masks, etc. cannot affect it. 1785654 1 ntim 2021-08-19 18:00:32 -0700 This needs a test too, unfortunately there's no WPT for this. 1785705 2 webkit-bug-importer 2021-08-19 23:23:53 -0700 <rdar://problem/82158248> 1785711 3 ntim 2021-08-19 23:56:31 -0700 https://github.com/web-platform-tests/wpt/pull/30104 1785712 4 435945 ntim 2021-08-20 00:00:53 -0700 Created attachment 435945 Patch 1785714 5 ews-watchlist 2021-08-20 00:01:55 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1785728 6 ews-feeder 2021-08-20 01:04:02 -0700 Committed r281299 (240723@main): <https://commits.webkit.org/240723@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435945. 1785926 7 435945 simon.fraser 2021-08-20 11:43:49 -0700 Comment on attachment 435945 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435945&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2435 > + // Top layer elements should not be affected by parent elements opacity > + if (m_owningLayer.establishesTopLayer()) > + return finalOpacity; This seems like the wrong way to fix this. Here we're in compositing code, but don't we want to reset opacity in style? If for some reason we end up not using compositing for top layers, we'll get bad rendering. 1785972 8 ntim 2021-08-20 13:51:25 -0700 (In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 435945 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435945&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:2435 > > + // Top layer elements should not be affected by parent elements opacity > > + if (m_owningLayer.establishesTopLayer()) > > + return finalOpacity; > > This seems like the wrong way to fix this. Here we're in compositing code, > but don't we want to reset opacity in style? If for some reason we end up > not using compositing for top layers, we'll get bad rendering. I filed https://bugs.webkit.org/show_bug.cgi?id=229350 435945 2021-08-20 00:00:53 -0700 2021-08-20 01:04:04 -0700 Patch bug-229317-20210820090052.patch text/plain 5030 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg5M2U4NGIzNDAxMzE5 MDYxYmY4NjZhZDhkZTY5YTY2NTYwNmY2MC4uN2I1M2IxNWMxMjQzMzcyMzgyNzhmZWYzMDRiMDJl YmMzMmJiNDM2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTE5ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJlIGFuY2VzdG9ycyB3aXRo IG9wYWNpdHkgZG9uJ3QgYWZmZWN0IHRvcCBsYXllciBlbGVtZW50cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MzE3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUtZGlh bG9nLWVsZW1lbnQvdG9wLWxheWVyLXBhcmVudC1vcGFjaXR5Lmh0bWwKKworICAgICAgICBBc3Nv Y2lhdGVkIFdQVCBQUjogaHR0cHM6Ly9naXRodWIuY29tL3dlYi1wbGF0Zm9ybS10ZXN0cy93cHQv cHVsbC8zMDEwNAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmNvbXBvc2l0aW5nT3BhY2l0 eSBjb25zdCk6CisKIDIwMjEtMDgtMTkgIFRpbSBOZ3V5ZW4gIDxudGltQGFwcGxlLmNvbT4KIAog ICAgICAgICBJbXBsZW1lbnQgdG9wIGxheWVyIHJlbmRlcmluZyBiaXRzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDZlOGFiOTFhZjVk MTA4MGNkN2FiODgyZGI1NzQ5MzRjMDJhMjMyNmYuLjY3NDhhYmUwZWRmYjMzMmM2MWU0MDljZWMw OWUwZWNjMWQ4Y2YxMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckJhY2tpbmcuY3BwCkBAIC0yNDI5LDYgKzI0MjksMTAgQEAgU2Nyb2xsaW5nTm9kZUlEIFJl bmRlckxheWVyQmFja2luZzo6c2Nyb2xsaW5nTm9kZUlERm9yQ2hpbGRyZW4oKSBjb25zdAogZmxv YXQgUmVuZGVyTGF5ZXJCYWNraW5nOjpjb21wb3NpdGluZ09wYWNpdHkoZmxvYXQgcmVuZGVyZXJP cGFjaXR5KSBjb25zdAogewogICAgIGZsb2F0IGZpbmFsT3BhY2l0eSA9IHJlbmRlcmVyT3BhY2l0 eTsKKworICAgIC8vIFRvcCBsYXllciBlbGVtZW50cyBzaG91bGQgbm90IGJlIGFmZmVjdGVkIGJ5 IHBhcmVudCBlbGVtZW50cyBvcGFjaXR5CisgICAgaWYgKG1fb3duaW5nTGF5ZXIuZXN0YWJsaXNo ZXNUb3BMYXllcigpKQorICAgICAgICByZXR1cm4gZmluYWxPcGFjaXR5OwogICAgIAogICAgIGZv ciAoYXV0byogY3VyciA9IG1fb3duaW5nTGF5ZXIucGFyZW50KCk7IGN1cnI7IGN1cnIgPSBjdXJy LT5wYXJlbnQoKSkgewogICAgICAgICAvLyBXZSBvbmx5IGNhcmUgYWJvdXQgcGFyZW50cyB0aGF0 IGFyZSBzdGFja2luZyBjb250ZXh0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4 IDA3YmQyNzQ2MDYwYTg1MDY0NGFiYjE0ZTE4M2E4NjNlZmI3OGNjZjMuLjRkZTk2YTA1NzRlODYz OGJhNzIxN2YyNjE1MTE2MTVkOTRiODdmMGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTE5ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5j b20+CisKKyAgICAgICAgRW5zdXJlIGFuY2VzdG9ycyB3aXRoIG9wYWNpdHkgZG9uJ3QgYWZmZWN0 IHRvcCBsYXllciBlbGVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI5MzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdDogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3Nl bWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUtZGlhbG9nLWVsZW1lbnQvdG9wLWxheWVy LXBhcmVudC1vcGFjaXR5Lmh0bWwKKworICAgICAgICBBc3NvY2lhdGVkIFdQVCBQUjogaHR0cHM6 Ly9naXRodWIuY29tL3dlYi1wbGF0Zm9ybS10ZXN0cy93cHQvcHVsbC8zMDEwNAorCisgICAgICAg ICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRz L3RoZS1kaWFsb2ctZWxlbWVudC90b3AtbGF5ZXItcGFyZW50LW9wYWNpdHktZXhwZWN0ZWQuaHRt bDogQWRkZWQuCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2lu dGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC90b3AtbGF5ZXItcGFyZW50LW9w YWNpdHkuaHRtbDogQWRkZWQuCisKIDIwMjEtMDgtMTkgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgogCiAgICAgICAgIFs6aGFzKCkgcHNldWRvLWNsYXNzXSBCYXNpYyBzdXBwb3J0 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC90 b3AtbGF5ZXItcGFyZW50LW9wYWNpdHktZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxl bWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXllci1wYXJlbnQtb3BhY2l0eS1leHBlY3Rl ZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmU2ODBmM2Y0M2ExMTI1MzI0MGU4MWM2NTlhN2RhODFhMjNlOGUy OTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ct ZWxlbWVudC90b3AtbGF5ZXItcGFyZW50LW9wYWNpdHktZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsx LDE5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHRpdGxlPlJlZmVyZW5jZTogVGVzdCB0 aGF0IHBhcmVudCBvcGFjaXR5IGRvZXMgbm90IGFmZmVjdCB0b3AgbGF5ZXIgZWxlbWVudHM8L3Rp dGxlPgorPG1ldGEgY2hhcnNldD0idXRmLTgiPgorPHN0eWxlPgorZGlhbG9nIHsKKyAgICB3aWR0 aDogMTAwcHg7CisgICAgaGVpZ2h0OiAxMDBweDsKKyAgICBiYWNrZ3JvdW5kOiBncmVlbjsKK30K Kzwvc3R5bGU+Cis8Ym9keT4KKzxwPlBBU1MgaWYgeW91IHNlZSBhIGdyZWVuIHNxdWFyZTwvcD4K KzxkaWFsb2c+PC9kaWFsb2c+Cis8c2NyaXB0PgorICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3Io ImRpYWxvZyIpLnNob3dNb2RhbCgpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv c2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC90b3AtbGF5 ZXItcGFyZW50LW9wYWNpdHkuaHRtbCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxlbWVudHMvdGhlLWRpYWxv Zy1lbGVtZW50L3RvcC1sYXllci1wYXJlbnQtb3BhY2l0eS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjkwOWVh NzNmZDk5MzAxNjkyYWI2MGEyOTI4NjAxZTJjMmI1ZDEzODcKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNz L2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC90b3AtbGF5ZXItcGFyZW50 LW9wYWNpdHkuaHRtbApAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PHRpdGxlPlRlc3QgdGhhdCBwYXJlbnQgb3BhY2l0eSBkb2VzIG5vdCBhZmZlY3QgdG9wIGxheWVy IGVsZW1lbnRzPC90aXRsZT4KKzxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzxsaW5rIHJlbD0iYXV0 aG9yIiB0aXRsZT0iVGltIE5ndXllbiIgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL250MW0iPgor PGxpbmsgcmVsPSJtYXRjaCIgaHJlZj0idG9wLWxheWVyLXBhcmVudC1vcGFjaXR5LXJlZi5odG1s Ij4KKzxsaW5rIHJlbD0iaGVscCIgaHJlZj0iaHR0cHM6Ly9mdWxsc2NyZWVuLnNwZWMud2hhdHdn Lm9yZy8jbmV3LXN0YWNraW5nLWxheWVyIj4KKzxsaW5rIHJlbD0iaGVscCIgaHJlZj0iaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTMxNyI+Cis8c3R5bGU+CisjcGFy ZW50IHsKKyAgICBvcGFjaXR5OiAwOworfQorZGlhbG9nIHsKKyAgICB3aWR0aDogMTAwcHg7Cisg ICAgaGVpZ2h0OiAxMDBweDsKKyAgICBiYWNrZ3JvdW5kOiBncmVlbjsKK30KKzwvc3R5bGU+Cis8 Ym9keT4KKzxwPlBBU1MgaWYgeW91IHNlZSBhIGdyZWVuIHNxdWFyZTwvcD4KKzxkaXYgaWQ9InBh cmVudCI+CisgICAgPGRpYWxvZz48L2RpYWxvZz4KKzwvZGl2PgorPHNjcmlwdD4KKyAgICBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCJkaWFsb2ciKS5zaG93TW9kYWwoKTsKKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo=