229312 2021-08-19 17:13:31 -0700 [build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests 2021-08-26 10:39:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229311 InRadar P2 Normal --- 1 clopez clopez aakash_jain ap bugs-noreply clopez jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1785636 0 clopez 2021-08-19 17:13:31 -0700 On bug 227744 a new tester was added, but this tester should only be running layout tests. It is not useful that this bots run other kind of tests like api tests, python tests or perl tests. 1785651 1 435930 clopez 2021-08-19 17:43:45 -0700 Created attachment 435930 Patch 1785818 2 435930 aakash_jain 2021-08-20 07:38:21 -0700 Comment on attachment 435930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review > Tools/CISupport/build-webkit-org/factories.py:218 > +class TestLayoutFactory(Factory): Nit: better to call it LayoutTestFactory (even though the naming might not be good earlier, we can improve it now) 1785819 3 435930 aakash_jain 2021-08-20 07:42:08 -0700 Comment on attachment 435930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review > Tools/CISupport/build-webkit-org/factories.py:225 > + self.addStep(RunDashboardTests()) Do you want to run dashboard tests on this queue? 1785869 4 clopez 2021-08-20 09:31:43 -0700 (In reply to Aakash Jain from comment #2) > Comment on attachment 435930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435930&action=review > > > Tools/CISupport/build-webkit-org/factories.py:218 > > +class TestLayoutFactory(Factory): > > Nit: better to call it LayoutTestFactory (even though the naming might not > be good earlier, we can improve it now) That would be inconsistent with the other factory naming.. all are named either "TestSomethingFactory" or "BuildAndTestSomethingFactory" 1785879 5 clopez 2021-08-20 09:53:54 -0700 (In reply to Aakash Jain from comment #3) > Comment on attachment 435930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435930&action=review > > > Tools/CISupport/build-webkit-org/factories.py:225 > > + self.addStep(RunDashboardTests()) > > Do you want to run dashboard tests on this queue? I think we do, for consistency, as far as I can see the dashboard tests runner simply calls run-webkit-tests over other directory than LayoutTests. So they seem to me like some kind of specialized layout tests. 1785918 6 clopez 2021-08-20 11:25:38 -0700 Committed r281327 (240744@main): <https://commits.webkit.org/240744@main> 1785919 7 webkit-bug-importer 2021-08-20 11:26:20 -0700 <rdar://problem/82178321> 1787670 8 aakash_jain 2021-08-26 10:39:47 -0700 buildbot was restarted to pick up this change. Seems to be working, e.g.: https://build.webkit.org/#/builders/199/builds/951 435930 2021-08-19 17:43:45 -0700 2021-08-26 10:39:21 -0700 Patch bug-229312-20210820014314.patch text/plain 4165 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMjg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTEwZGNiMzIyNmQ1OGQ3YWE2MDBkMTFjODE1MzhlYWU0 MzJkOGE3Mi4uMDZlMzFmYTE2MDgwZWQxNTRhMTlmZTdmM2NiYWU2YjUxNjc2MWZiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA4LTE5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtidWlsZC53ZWJraXQub3JnXSBHVEstTGludXgtNjQtYml0LVJl bGVhc2UtU2tpcC1GYWlsaW5nLVRlc3RzIHdvcmtlciBzaG91bGQgcnVuIG9ubHkgbGF5b3V0IHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkz MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg YSBuZXcgZmFjdG9yeSBmb3IgdGVzdGluZyBvbmx5IGxheW91dCB0ZXN0cyBhbmQgbWFrZSB0aGlz IGJvdCB1c2UgaXQuCisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9jb25m aWcuanNvbjoKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9mYWN0b3JpZXMu cHk6CisgICAgICAgIChUZXN0TGF5b3V0RmFjdG9yeSk6CisgICAgICAgIChUZXN0TGF5b3V0RmFj dG9yeS5fX2luaXRfXyk6CisgICAgICAgICogQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFj dG9yaWVzX3VuaXR0ZXN0LnB5OgorICAgICAgICAoVGVzdEV4cGVjdGVkQnVpbGRTdGVwcyk6CisK IDIwMjEtMDgtMTkgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5j b20+CiAKICAgICAgICAgW2J1aWxkLndlYmtpdC5vcmddIFBvcnQgb2xkIHVuaXQgdGVzdCB3aXRo IHRoZSBleHBlY3RlZCBidWlsZCBzdGVwcyB0byB0aGUgbmV3IGJ1aWxkYm90CmRpZmYgLS1naXQg YS9Ub29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9jb25maWcuanNvbiBiL1Rvb2xzL0NJ U3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2NvbmZpZy5qc29uCmluZGV4IGZmMTgzYTdkOTUzM2Rm MGVjZTZmNmU3ZGExYmUwYmEzY2ZlMjBhODYuLmJmNmQxYjA5NzRjNjc1YjVkNGE0MjhkYTdhMGM0 NGM1MjJhYWVlN2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3Jn L2NvbmZpZy5qc29uCisrKyBiL1Rvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2NvbmZp Zy5qc29uCkBAIC00MzYsNyArNDM2LDcgQEAKICAgICAgICAgICAgICAgICAgICAgICAid29ya2Vy bmFtZXMiOiBbImd0ay1saW51eC1ib3QtMTgiXQogICAgICAgICAgICAgICAgICAgICB9LAogICAg ICAgICAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiR1RLLUxp bnV4LTY0LWJpdC1SZWxlYXNlLVNraXAtRmFpbGluZy1UZXN0cyIsICJmYWN0b3J5IjogIlRlc3RB bGxCdXRKU0NGYWN0b3J5IiwgImJ1aWxkZGlyIjogImd0ay1saW51eC02NC1yZWxlYXNlLXNraXAt ZmFpbGluZy10ZXN0cyIsCisgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiR1RLLUxpbnV4 LTY0LWJpdC1SZWxlYXNlLVNraXAtRmFpbGluZy1UZXN0cyIsICJmYWN0b3J5IjogIlRlc3RMYXlv dXRGYWN0b3J5IiwgImJ1aWxkZGlyIjogImd0ay1saW51eC02NC1yZWxlYXNlLXNraXAtZmFpbGlu Zy10ZXN0cyIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRmb3JtIjogImd0ayIsICJjb25m aWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0dXJlcyI6IFsieDg2XzY0Il0sCiAgICAg ICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1bWVudHMiOiBbIi0tc2tpcC1mYWlsaW5n LXRlc3RzIl0sCiAgICAgICAgICAgICAgICAgICAgICAgIndvcmtlcm5hbWVzIjogWyJndGstbGlu dXgtYm90LTE5Il0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3Jn L2ZhY3Rvcmllcy5weSBiL1Rvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmll cy5weQppbmRleCAwMmIyNzQ0YTBhODgzZWUwNWYxNDU0OGE3NTQ3NTExMDY0OWY4MjllLi5lMzFl MzExZGM5NmE4OWI5ZGFjNTJlNTI2NDU0N2UwY2M1ZTczNzQwIDEwMDY0NAotLS0gYS9Ub29scy9D SVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9mYWN0b3JpZXMucHkKKysrIGIvVG9vbHMvQ0lTdXBw b3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CkBAIC0yMTUsNiArMjE1LDIwIEBAIGNs YXNzIFRlc3RKU0ZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5UZXN0 MjYyVGVzdHMoKSkKIAogCitjbGFzcyBUZXN0TGF5b3V0RmFjdG9yeShGYWN0b3J5KToKKyAgICBk ZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMs IGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSwgZGV2aWNlX21vZGVsPU5vbmUpOgorICAgICAgICBG YWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1 cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywgZGV2aWNlX21vZGVsKQorICAgICAgICBz ZWxmLmFkZFN0ZXAoRG93bmxvYWRCdWlsdFByb2R1Y3QoKSkKKyAgICAgICAgc2VsZi5hZGRTdGVw KEV4dHJhY3RCdWlsdFByb2R1Y3QoKSkKKyAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bldlYktpdFRl c3RzKCkpCisgICAgICAgIGlmIG5vdCBwbGF0Zm9ybS5zdGFydHN3aXRoKCd3aW4nKToKKyAgICAg ICAgICAgIHNlbGYuYWRkU3RlcChSdW5EYXNoYm9hcmRUZXN0cygpKQorICAgICAgICBzZWxmLmFk ZFN0ZXAoQXJjaGl2ZVRlc3RSZXN1bHRzKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChVcGxvYWRU ZXN0UmVzdWx0cygpKQorICAgICAgICBzZWxmLmFkZFN0ZXAoRXh0cmFjdFRlc3RSZXN1bHRzKCkp CisgICAgICAgIHNlbGYuYWRkU3RlcChTZXRQZXJtaXNzaW9ucygpKQorCisKIGNsYXNzIFRlc3RX ZWJEcml2ZXJGYWN0b3J5KEZhY3RvcnkpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9y bSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25l LCBkZXZpY2VfbW9kZWw9Tm9uZSk6CiAgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxh dGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlvbmFsQXJn dW1lbnRzLCBkZXZpY2VfbW9kZWwpCmRpZmYgLS1naXQgYS9Ub29scy9DSVN1cHBvcnQvYnVpbGQt d2Via2l0LW9yZy9mYWN0b3JpZXNfdW5pdHRlc3QucHkgYi9Ub29scy9DSVN1cHBvcnQvYnVpbGQt d2Via2l0LW9yZy9mYWN0b3JpZXNfdW5pdHRlc3QucHkKaW5kZXggMTI4NzUwN2I2MmJjOGFiMzE0 ODM0N2JlYTE4NGI0ZTg3NzQxZWZjZC4uMjU3YWFmNWY3NTQ0Zjk1ZmNkMTg5ZWJiMTBkMTIwNzg1 ZTgwNmQwMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFj dG9yaWVzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3Jn L2ZhY3Rvcmllc191bml0dGVzdC5weQpAQCAtMTA1NCwxMiArMTA1NCw3IEBAIGNsYXNzIFRlc3RF eHBlY3RlZEJ1aWxkU3RlcHModW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgImFyY2hp dmUtdGVzdC1yZXN1bHRzIiwKICAgICAgICAgICAgICJ1cGxvYWQiLAogICAgICAgICAgICAgImV4 dHJhY3QtdGVzdC1yZXN1bHRzIiwKLSAgICAgICAgICAgICJzZXQtcGVybWlzc2lvbnMiLAotICAg ICAgICAgICAgIndlYmtpdHB5LXRlc3QiLAotICAgICAgICAgICAgIndlYmtpdHBlcmwtdGVzdCIs Ci0gICAgICAgICAgICAiYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cyIsCi0gICAgICAgICAgICAi YnVpbHRpbnMtZ2VuZXJhdG9yLXRlc3RzIiwKLSAgICAgICAgICAgICJBUEktdGVzdHMiCisgICAg ICAgICAgICAic2V0LXBlcm1pc3Npb25zIgogICAgICAgICBdLAogICAgICAgICAiV2luQ2Fpcm8t NjQtYml0LVdLTC1SZWxlYXNlLUJ1aWxkIjogWwogICAgICAgICAgICAgImNvbmZpZ3VyZS1idWls ZCIsCg==