<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22930</bug_id>
          
          <creation_ts>2008-12-18 22:39:59 -0800</creation_ts>
          <short_desc>prepare-ChangeLog (using git) should avoid using any external diff tools</short_desc>
          <delta_ts>2008-12-20 11:47:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="David Levin">levin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aroben</cc>
    
    <cc>ddkilzer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>102960</commentid>
    <comment_count>0</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2008-12-18 22:39:59 -0800</bug_when>
    <thetext>When someone runs prepare-ChangeLog for git and the person has an external diff tool set-up, that tool gets launched and the ChangeLog doesn&apos;t get the appropriate information listed in it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>102961</commentid>
    <comment_count>1</comment_count>
      <attachid>26139</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2008-12-18 22:52:03 -0800</bug_when>
    <thetext>Created attachment 26139
Patch for bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>103049</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-12-19 16:06:37 -0800</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/prepare-ChangeLog
Committed r39415
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>26139</attachid>
            <date>2008-12-18 22:52:03 -0800</date>
            <delta_ts>2008-12-19 01:55:47 -0800</delta_ts>
            <desc>Patch for bug.</desc>
            <filename>patch-for-bug22930.txt</filename>
            <type>text/plain</type>
            <size>1102</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA1OGQzZDczLi5mMDNkNDE3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTIt
MTggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMjkzMAorCisgICAgICAgIE1ha2UgdGhlIGdpdCBkaWZmIGNvbW1hbmQg
dXNlZCBmb3IgcHJlcGFyaW5nIHRoZSBjaGFuZ2UgbG9nIGF2b2lkIHVzaW5nIGFueSBleHRlcm5h
bCBkaWZmIHRvb2xzLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKwog
MjAwOC0xMi0xOCAgQ2FtZXJvbiBad2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgR2VvZmYgR2FyZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp
cHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5n
ZUxvZwppbmRleCBmZjRjZTgwLi41NWE4OGFjIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3Jp
cHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1D
aGFuZ2VMb2cKQEAgLTExMzQsNyArMTEzNCw3IEBAIHN1YiBkaWZmQ29tbWFuZChAKQogICAgIGlm
ICgkaXNTVk4pIHsKICAgICAgICAgJGNvbW1hbmQgPSAiJFNWTiBkaWZmIC0tZGlmZi1jbWQgZGlm
ZiAteCAtTiAkcGF0aHNTdHJpbmciOwogICAgIH0gZWxzaWYgKCRpc0dpdCkgewotICAgICAgICAk
Y29tbWFuZCA9ICIkR0lUIGRpZmYgLVUwICIgLiBkaWZmRnJvbVRvU3RyaW5nKCk7CisgICAgICAg
ICRjb21tYW5kID0gIiRHSVQgZGlmZiAtLW5vLWV4dC1kaWZmIC1VMCAiIC4gZGlmZkZyb21Ub1N0
cmluZygpOwogICAgICAgICAkY29tbWFuZCAuPSAiIC0tICRwYXRoc1N0cmluZyIgdW5sZXNzICRn
aXRDb21taXQ7CiAgICAgfQogCg==
</data>
<flag name="review"
          id="12340"
          type_id="1"
          status="+"
          setter="mrowe"
    />
          </attachment>
      

    </bug>

</bugzilla>