229224 2021-08-17 20:32:11 -0700 Use an enum for the forVisitedLink argument to BuilderState::colorFromPrimitiveValue() 2021-08-19 08:47:21 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser achristensen esprehn+autocc ews-watchlist glenn gyuyoung.kim koivisto macpherson menard simon.fraser webkit-bug-importer oldest_to_newest 1785034 0 simon.fraser 2021-08-17 20:32:11 -0700 Use an enum for the forVisitedLink argument to BuilderState::colorFromPrimitiveValue() 1785035 1 435739 simon.fraser 2021-08-17 20:33:08 -0700 Created attachment 435739 Patch 1785454 2 ews-feeder 2021-08-19 08:46:42 -0700 Committed r281237 (240674@main): <https://commits.webkit.org/240674@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435739. 1785455 3 webkit-bug-importer 2021-08-19 08:47:21 -0700 <rdar://problem/82127110> 435739 2021-08-17 20:33:08 -0700 2021-08-19 08:46:43 -0700 Patch bug-229224-20210817203307.patch text/plain 6352 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJhNDg2ZjI1MWM1Nzhm Mjk0YWRhOWY0YjY5NGMwZjU0OGM0NjZlZC4uNGJmNGI5ZTcxODdmYzgzYjFjNzA4ODg2MTRiMTMy NjkxYzUzYmFjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA4LTE3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBhbiBlbnVt IGZvciB0aGUgZm9yVmlzaXRlZExpbmsgYXJndW1lbnQgdG8gQnVpbGRlclN0YXRlOjpjb2xvckZy b21QcmltaXRpdmVWYWx1ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjkyMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb252ZXJ0IHRoZSBib29sIGFyZ3VtZW50IHRvIGFuIGVudW0gY2xhc3MuCisK KyAgICAgICAgKiBjc3MvbWFrZXByb3AucGw6CisgICAgICAgIChjb2xvckZyb21QcmltaXRpdmVW YWx1ZSk6CisgICAgICAgICogc3R5bGUvU3R5bGVCdWlsZGVyQ3VzdG9tLmg6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZTo6QnVpbGRlckN1c3RvbTo6YXBwbHlWYWx1ZUNhcmV0Q29sb3IpOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGU6OkJ1aWxkZXJDdXN0b206OmFwcGx5VmFsdWVTdHJva2VDb2xv cik6CisgICAgICAgICogc3R5bGUvU3R5bGVCdWlsZGVyU3RhdGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U3R5bGU6OkJ1aWxkZXJTdGF0ZTo6Y29sb3JGcm9tUHJpbWl0aXZlVmFsdWUgY29uc3Qp OgorICAgICAgICAqIHN0eWxlL1N0eWxlQnVpbGRlclN0YXRlLmg6CisKIDIwMjEtMDgtMTcgIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgRGUtZHVwbGljYXRlIHRo ZSBDb2NvYS1zcGVjaWZpYyBNZWRpYVBsYXllclByaXZhdGVSZW1vdGUgY29uc3RydWN0b3IKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9tYWtlcHJvcC5wbAppbmRleCA1OTk3NjZiOGYxMTljYjAzNzI3Nzg0ZGFkZDZlZmY0NzZh ODQxYzk4Li41NjVlM2RjNzI0ODdlODEwYzY3ZGFkYjM2ZTY4ODU3Y2E0YzQ1Mjc3IDEwMDc1NQot LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL21ha2Vwcm9wLnBsCkBAIC0xMDEzLDcgKzEwMTMsNyBAQCBzdWIgY29sb3JGcm9tUHJpbWl0 aXZlVmFsdWUgewogICBteSAkcHJpbWl0aXZlVmFsdWUgPSBzaGlmdDsKICAgbXkgJGZvclZpc2l0 ZWRMaW5rID0gQF8gPyBzaGlmdCA6IE5PVF9GT1JfVklTSVRFRF9MSU5LOwogCi0gIHJldHVybiAi YnVpbGRlclN0YXRlLmNvbG9yRnJvbVByaW1pdGl2ZVZhbHVlKCIgLiAkcHJpbWl0aXZlVmFsdWUg LiAiLCAvKiBmb3JWaXNpdGVkTGluayAqLyAiIC4gKCRmb3JWaXNpdGVkTGluayA/ICJ0cnVlIiA6 ICJmYWxzZSIpIC4gIikiOworICByZXR1cm4gImJ1aWxkZXJTdGF0ZS5jb2xvckZyb21QcmltaXRp dmVWYWx1ZSgiIC4gJHByaW1pdGl2ZVZhbHVlIC4gIiwgRm9yVmlzaXRlZExpbms6OiIgLiAoJGZv clZpc2l0ZWRMaW5rID8gIlllcyIgOiAiTm8iKSAuICIpIjsKIH0KIAogdXNlIGNvbnN0YW50IHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlckN1c3RvbS5oIGIv U291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ3VzdG9tLmgKaW5kZXggZDcxNzlhMGVi ZTc0OWU3NjdkODIzZWVmNTQ4MTdmMmYxNWRiOWFiNy4uNDM5NDVjNWVkZWUxNDM1MjcwZWI1M2Zl NmYwNzQ4N2JhMGIxNjYzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVC dWlsZGVyQ3VzdG9tLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ3Vz dG9tLmgKQEAgLTgyNSwxMyArODI1LDEzIEBAIGlubGluZSB2b2lkIEJ1aWxkZXJDdXN0b206OmFw cGx5VmFsdWVDYXJldENvbG9yKEJ1aWxkZXJTdGF0ZSYgYnVpbGRlclN0YXRlLCBDU1NWCiAgICAg ICAgIGlmIChwcmltaXRpdmVWYWx1ZS52YWx1ZUlEKCkgPT0gQ1NTVmFsdWVBdXRvKQogICAgICAg ICAgICAgYnVpbGRlclN0YXRlLnN0eWxlKCkuc2V0SGFzQXV0b0NhcmV0Q29sb3IoKTsKICAgICAg ICAgZWxzZQotICAgICAgICAgICAgYnVpbGRlclN0YXRlLnN0eWxlKCkuc2V0Q2FyZXRDb2xvcihi dWlsZGVyU3RhdGUuY29sb3JGcm9tUHJpbWl0aXZlVmFsdWUocHJpbWl0aXZlVmFsdWUsIC8qIGZv clZpc2l0ZWRMaW5rICovIGZhbHNlKSk7CisgICAgICAgICAgICBidWlsZGVyU3RhdGUuc3R5bGUo KS5zZXRDYXJldENvbG9yKGJ1aWxkZXJTdGF0ZS5jb2xvckZyb21QcmltaXRpdmVWYWx1ZShwcmlt aXRpdmVWYWx1ZSwgRm9yVmlzaXRlZExpbms6Ok5vKSk7CiAgICAgfQogICAgIGlmIChidWlsZGVy U3RhdGUuYXBwbHlQcm9wZXJ0eVRvVmlzaXRlZExpbmtTdHlsZSgpKSB7CiAgICAgICAgIGlmIChw cmltaXRpdmVWYWx1ZS52YWx1ZUlEKCkgPT0gQ1NTVmFsdWVBdXRvKQogICAgICAgICAgICAgYnVp bGRlclN0YXRlLnN0eWxlKCkuc2V0SGFzVmlzaXRlZExpbmtBdXRvQ2FyZXRDb2xvcigpOwogICAg ICAgICBlbHNlCi0gICAgICAgICAgICBidWlsZGVyU3RhdGUuc3R5bGUoKS5zZXRWaXNpdGVkTGlu a0NhcmV0Q29sb3IoYnVpbGRlclN0YXRlLmNvbG9yRnJvbVByaW1pdGl2ZVZhbHVlKHByaW1pdGl2 ZVZhbHVlLCAvKiBmb3JWaXNpdGVkTGluayAqLyB0cnVlKSk7CisgICAgICAgICAgICBidWlsZGVy U3RhdGUuc3R5bGUoKS5zZXRWaXNpdGVkTGlua0NhcmV0Q29sb3IoYnVpbGRlclN0YXRlLmNvbG9y RnJvbVByaW1pdGl2ZVZhbHVlKHByaW1pdGl2ZVZhbHVlLCBGb3JWaXNpdGVkTGluazo6WWVzKSk7 CiAgICAgfQogfQogCkBAIC0yMDI0LDkgKzIwMjQsOSBAQCBpbmxpbmUgdm9pZCBCdWlsZGVyQ3Vz dG9tOjphcHBseVZhbHVlU3Ryb2tlQ29sb3IoQnVpbGRlclN0YXRlJiBidWlsZGVyU3RhdGUsIENT UwogewogICAgIGF1dG8mIHByaW1pdGl2ZVZhbHVlID0gZG93bmNhc3Q8Q1NTUHJpbWl0aXZlVmFs dWU+KHZhbHVlKTsKICAgICBpZiAoYnVpbGRlclN0YXRlLmFwcGx5UHJvcGVydHlUb1JlZ3VsYXJT dHlsZSgpKQotICAgICAgICBidWlsZGVyU3RhdGUuc3R5bGUoKS5zZXRTdHJva2VDb2xvcihidWls ZGVyU3RhdGUuY29sb3JGcm9tUHJpbWl0aXZlVmFsdWUocHJpbWl0aXZlVmFsdWUsIC8qIGZvclZp c2l0ZWRMaW5rICovIGZhbHNlKSk7CisgICAgICAgIGJ1aWxkZXJTdGF0ZS5zdHlsZSgpLnNldFN0 cm9rZUNvbG9yKGJ1aWxkZXJTdGF0ZS5jb2xvckZyb21QcmltaXRpdmVWYWx1ZShwcmltaXRpdmVW YWx1ZSwgRm9yVmlzaXRlZExpbms6Ok5vKSk7CiAgICAgaWYgKGJ1aWxkZXJTdGF0ZS5hcHBseVBy b3BlcnR5VG9WaXNpdGVkTGlua1N0eWxlKCkpCi0gICAgICAgIGJ1aWxkZXJTdGF0ZS5zdHlsZSgp LnNldFZpc2l0ZWRMaW5rU3Ryb2tlQ29sb3IoYnVpbGRlclN0YXRlLmNvbG9yRnJvbVByaW1pdGl2 ZVZhbHVlKHByaW1pdGl2ZVZhbHVlLCAvKiBmb3JWaXNpdGVkTGluayAqLyB0cnVlKSk7CisgICAg ICAgIGJ1aWxkZXJTdGF0ZS5zdHlsZSgpLnNldFZpc2l0ZWRMaW5rU3Ryb2tlQ29sb3IoYnVpbGRl clN0YXRlLmNvbG9yRnJvbVByaW1pdGl2ZVZhbHVlKHByaW1pdGl2ZVZhbHVlLCBGb3JWaXNpdGVk TGluazo6WWVzKSk7CiAgICAgYnVpbGRlclN0YXRlLnN0eWxlKCkuc2V0SGFzRXhwbGljaXRseVNl dFN0cm9rZUNvbG9yKHRydWUpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHls ZS9TdHlsZUJ1aWxkZXJTdGF0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1aWxk ZXJTdGF0ZS5jcHAKaW5kZXggYjQyMjlhMTEwMDk2NmZhYjBkYTkzZmZjZmM3YTdiZjYzMDVmMDRi ZC4uNGE4YTc3OWU5N2U1ZWNiOGFlOTExNTJiYjYwZjk3NDdjMTUyMTJjNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyU3RhdGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlclN0YXRlLmNwcApAQCAtMjkwLDcgKzI5MCw3IEBAIGJv b2wgQnVpbGRlclN0YXRlOjppc0NvbG9yRnJvbVByaW1pdGl2ZVZhbHVlRGVyaXZlZEZyb21FbGVt ZW50KGNvbnN0IENTU1ByaW1pdGl2CiAgICAgfQogfQogCi1Db2xvciBCdWlsZGVyU3RhdGU6OmNv bG9yRnJvbVByaW1pdGl2ZVZhbHVlKGNvbnN0IENTU1ByaW1pdGl2ZVZhbHVlJiB2YWx1ZSwgYm9v bCBmb3JWaXNpdGVkTGluaykgY29uc3QKK0NvbG9yIEJ1aWxkZXJTdGF0ZTo6Y29sb3JGcm9tUHJp bWl0aXZlVmFsdWUoY29uc3QgQ1NTUHJpbWl0aXZlVmFsdWUmIHZhbHVlLCBGb3JWaXNpdGVkTGlu ayBmb3JWaXNpdGVkTGluaykgY29uc3QKIHsKICAgICBpZiAodmFsdWUuaXNSR0JDb2xvcigpKQog ICAgICAgICByZXR1cm4gdmFsdWUuY29sb3IoKTsKQEAgLTMwMCw3ICszMDAsNyBAQCBDb2xvciBC dWlsZGVyU3RhdGU6OmNvbG9yRnJvbVByaW1pdGl2ZVZhbHVlKGNvbnN0IENTU1ByaW1pdGl2ZVZh bHVlJiB2YWx1ZSwgYm9vbAogICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRUZXh0OgogICAgICAgICBy ZXR1cm4gZG9jdW1lbnQoKS50ZXh0Q29sb3IoKTsKICAgICBjYXNlIENTU1ZhbHVlV2Via2l0TGlu azoKLSAgICAgICAgcmV0dXJuIChlbGVtZW50KCkgJiYgZWxlbWVudCgpLT5pc0xpbmsoKSAmJiBm b3JWaXNpdGVkTGluaykgPyBkb2N1bWVudCgpLnZpc2l0ZWRMaW5rQ29sb3IoKSA6IGRvY3VtZW50 KCkubGlua0NvbG9yKCk7CisgICAgICAgIHJldHVybiAoZWxlbWVudCgpICYmIGVsZW1lbnQoKS0+ aXNMaW5rKCkgJiYgZm9yVmlzaXRlZExpbmsgPT0gRm9yVmlzaXRlZExpbms6OlllcykgPyBkb2N1 bWVudCgpLnZpc2l0ZWRMaW5rQ29sb3IoKSA6IGRvY3VtZW50KCkubGlua0NvbG9yKCk7CiAgICAg Y2FzZSBDU1NWYWx1ZVdlYmtpdEFjdGl2ZWxpbms6CiAgICAgICAgIHJldHVybiBkb2N1bWVudCgp LmFjdGl2ZUxpbmtDb2xvcigpOwogICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRGb2N1c1JpbmdDb2xv cjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlclN0YXRlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1aWxkZXJTdGF0ZS5oCmluZGV4IGE2ODFlOTI4 ZTk4ODRlMTJmMDZlMzU2ZWI3Mjg5OWYyNmVlZGM5MGEuLjJlYmMxZGI3N2JjM2Q2YWFjYjJmODIw YzE1ZWU3Zjk0Y2QyMDhiOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxl QnVpbGRlclN0YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyU3Rh dGUuaApAQCAtNDQsNiArNDQsMTEgQEAgY2xhc3MgQnVpbGRlclN0YXRlOwogCiB2b2lkIG1heWJl VXBkYXRlRm9udEZvckxldHRlclNwYWNpbmcoQnVpbGRlclN0YXRlJiwgQ1NTVmFsdWUmKTsKIAor ZW51bSBjbGFzcyBGb3JWaXNpdGVkTGluayA6IGJvb2wgeworICAgIE5vLAorICAgIFllcworfTsK Kwogc3RydWN0IEJ1aWxkZXJDb250ZXh0IHsKICAgICBSZWY8Y29uc3QgRG9jdW1lbnQ+IGRvY3Vt ZW50OwogICAgIGNvbnN0IFJlbmRlclN0eWxlJiBwYXJlbnRTdHlsZTsKQEAgLTkwLDcgKzk1LDcg QEAgcHVibGljOgogICAgIGJvb2wgY3JlYXRlRmlsdGVyT3BlcmF0aW9ucyhjb25zdCBDU1NWYWx1 ZSYsIEZpbHRlck9wZXJhdGlvbnMmIG91dE9wZXJhdGlvbnMpOwogCiAgICAgc3RhdGljIGJvb2wg aXNDb2xvckZyb21QcmltaXRpdmVWYWx1ZURlcml2ZWRGcm9tRWxlbWVudChjb25zdCBDU1NQcmlt aXRpdmVWYWx1ZSYpOwotICAgIENvbG9yIGNvbG9yRnJvbVByaW1pdGl2ZVZhbHVlKGNvbnN0IENT U1ByaW1pdGl2ZVZhbHVlJiwgYm9vbCBmb3JWaXNpdGVkTGluayA9IGZhbHNlKSBjb25zdDsKKyAg ICBDb2xvciBjb2xvckZyb21QcmltaXRpdmVWYWx1ZShjb25zdCBDU1NQcmltaXRpdmVWYWx1ZSYs IEZvclZpc2l0ZWRMaW5rID0gRm9yVmlzaXRlZExpbms6Ok5vKSBjb25zdDsKICAgICAvLyBGSVhN RTogUmVtb3ZlLiAnY3VycmVudGNvbG9yJyBzaG91bGQgYmUgcmVzb2x2ZWQgYXQgdXNlIHRpbWUu IEFsbCBjYWxsIHNpdGVzIGFyZSBicm9rZW4gd2l0aCBpbmhlcml0YW5jZS4KICAgICBDb2xvciBj b2xvckZyb21QcmltaXRpdmVWYWx1ZVdpdGhSZXNvbHZlZEN1cnJlbnRDb2xvcihjb25zdCBDU1NQ cmltaXRpdmVWYWx1ZSYpIGNvbnN0OwogCg==