229210 2021-08-17 15:36:27 -0700 Remove old unused code and out of date comments. 2021-08-19 15:26:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner andersca thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1784955 0 megan_gardner 2021-08-17 15:36:27 -0700 Remove old unused code and out of date comments. 1784956 1 435717 megan_gardner 2021-08-17 15:37:20 -0700 Created attachment 435717 Patch 1785324 2 435717 andersca 2021-08-18 19:15:31 -0700 Comment on attachment 435717 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435717&action=review > Source/WebKitLegacy/ios/WebKit.iOS.exp:-44 > -__WebViewRemoteInspectorHasSessionChangedNotification Is WebKit.iOS.exp even used at all these days? 1785596 3 ews-feeder 2021-08-19 15:25:10 -0700 Committed r281273 (240698@main): <https://commits.webkit.org/240698@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435717. 1785597 4 webkit-bug-importer 2021-08-19 15:26:21 -0700 <rdar://problem/82144510> 435717 2021-08-17 15:37:20 -0700 2021-08-19 15:25:10 -0700 Patch bug-229210-20210817153720.patch text/plain 5435 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L2lvcy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9DaGFuZ2VMb2cKaW5k ZXggY2FiMjUyYjJmMTk3NDg2OGE0Y2QyYzFkZmFiYzhlZDRmNjM0NGU4YS4uOTRmZjJjZTk0OGUy YjM1MjE3MTQwNTkxYTdjOTM4OTQ0ZTJjODFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9pb3MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvaW9zL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA4LTE3ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2Fy ZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIG9sZCB1bnVzZWQgY29kZSBhbmQgb3V0 IG9mIGRhdGUgY29tbWVudHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjkyMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYktpdC5pT1MuZXhwOgorCiAyMDIxLTA1LTMwICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgV1RGOjpPcHRpb25hbCBzeW5vbnlt IGZvciBzdGQ6Om9wdGlvbmFsLCB1c2luZyB0aGF0IGNsYXNzIHRlbXBsYXRlIGRpcmVjdGx5IGlu c3RlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCBiNTg2N2FmNzc2ZmM1MzAyYjVi YTc1OGQzMTQ0MjVmMGY5NDBhZThlLi43YWMxOWYxMjI3NWZkOTZjNzQxZTM0MWIzZmMxZWRmOWRj ZTZjYWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjEtMDgtMTcgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAg ICAgICBSZW1vdmUgb2xkIHVudXNlZCBjb2RlIGFuZCBvdXQgb2YgZGF0ZSBjb21tZW50cy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTIxMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9X ZWJWaWV3Lm1tOgorICAgICAgICAqIFdlYlZpZXcvV2ViVmlld1ByaXZhdGUuaDoKKwogMjAyMS0w OC0xNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgICJtYWtl IGFuYWx5emUiIHNob3VsZCBydW4gY2xhbmcgc3RhdGljIGFuYWx5emVyIGluIGRlZXAgbW9kZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9pb3MvV2ViS2l0LmlPUy5leHAgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L2lvcy9XZWJLaXQuaU9TLmV4cAppbmRleCA1ZTJkMDQ1ZGQ3YjYwYjUz OTZiZDliODRhZGE1Y2YwNDQ2MmIxNWZlLi4wZjFmM2M5MmQ3YzA2N2Q3MGNiNmI4NTlhMmU5ZWUx MTZhOWZhZTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9XZWJLaXQuaU9T LmV4cAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9XZWJLaXQuaU9TLmV4cApAQCAtNDAs OCArNDAsNSBAQCBfV2ViVmlld3BvcnRXaWR0aEtleQogX1dlYlZpZXdQcm9ncmVzc0JhY2tncm91 bmRDb2xvcktleQogX1dlYlZpZXdQcm9ncmVzc0VzdGltYXRlZFByb2dyZXNzS2V5CiAKLSMgRm9y IFdlYkluc3BlY3RvciBub3RpZmljYXRpb25zCi1fX1dlYlZpZXdSZW1vdGVJbnNwZWN0b3JIYXNT ZXNzaW9uQ2hhbmdlZE5vdGlmaWNhdGlvbgotCiAjIFdlYktpdDEgaW50ZXJuYWwgdHlwZXMgZXhw b3NlZCBmb3IgV2ViS2l0Mi4KIC5vYmpjX2NsYXNzX25hbWVfV2ViR2VvbG9jYXRpb25Db3JlTG9j YXRpb25Qcm92aWRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmll dy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1t CmluZGV4IDMwMmNiOTlmOTE0YmQ4YzMwMGZmZjY2MzUyMWIyZGU2MWJhOTUyNGUuLmNkNmE1ZjU3 Mjk5NGY3ZWM0ZmJkZTc2MzdkZjg2N2JkNTJmM2M4MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTk1OSwxMSArOTU5LDYgQEAgTlNTdHJpbmcgKldl YlF1aWNrTG9va1VUSUtleSAgICAgID0gQCJXZWJRdWlja0xvb2tVVElLZXkiOwogTlNTdHJpbmcg Kl9XZWJWaWV3RGlkU3RhcnRBY2NlbGVyYXRlZENvbXBvc2l0aW5nTm90aWZpY2F0aW9uID0gQCJf V2ViVmlld0RpZFN0YXJ0QWNjZWxlcmF0ZWRDb21wb3NpdGluZyI7CiBOU1N0cmluZyAqIGNvbnN0 IFdlYlZpZXdXaWxsQ2xvc2VOb3RpZmljYXRpb24gPSBAIldlYlZpZXdXaWxsQ2xvc2VOb3RpZmlj YXRpb24iOwogCi0jaWYgRU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCi0vLyBGSVhNRTogTGVnYWN5 LCByZW1vdmUgdGhpcywgc3dpdGNoIHRvIHNvbWV0aGluZyBmcm9tIEphdmFTY3JpcHRDb3JlIElu c3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU2VydmVyLgotTlNTdHJpbmcgKl9XZWJWaWV3UmVtb3Rl SW5zcGVjdG9ySGFzU2Vzc2lvbkNoYW5nZWROb3RpZmljYXRpb24gPSBAIl9XZWJWaWV3UmVtb3Rl SW5zcGVjdG9ySGFzU2Vzc2lvbkNoYW5nZWROb3RpZmljYXRpb24iOwotI2VuZGlmCi0KIEBpbnRl cmZhY2UgV2ViUHJvZ3Jlc3NJdGVtIDogTlNPYmplY3QKIHsKIEBwdWJsaWMKQEAgLTgxMDUsMTMg KzgxMDAsMTEgQEAgQGVuZAogI2lmICFQTEFURk9STShJT1NfRkFNSUxZKQogQGltcGxlbWVudGF0 aW9uIFdlYlZpZXcgKFdlYlZpZXdHcmFtbWFyQ2hlY2tpbmcpCiAKLS8vIEZJWE1FOiBUaGlzIG1l dGhvZCBzaG91bGQgYmUgbWVyZ2VkIGludG8gV2ViVmlld0VkaXRpbmcgd2hlbiB3ZSdyZSBub3Qg aW4gQVBJIGZyZWV6ZQogLSAoQk9PTClpc0dyYW1tYXJDaGVja2luZ0VuYWJsZWQKIHsKICAgICBy ZXR1cm4gZ3JhbW1hckNoZWNraW5nRW5hYmxlZDsKIH0KIAotLy8gRklYTUU6IFRoaXMgbWV0aG9k IHNob3VsZCBiZSBtZXJnZWQgaW50byBXZWJWaWV3RWRpdGluZyB3aGVuIHdlJ3JlIG5vdCBpbiBB UEkgZnJlZXplCiAtICh2b2lkKXNldEdyYW1tYXJDaGVja2luZ0VuYWJsZWQ6KEJPT0wpZmxhZwog ewogICAgIGlmIChncmFtbWFyQ2hlY2tpbmdFbmFibGVkID09IGZsYWcpCkBAIC04MTI4LDcgKzgx MjEsNiBAQCAtICh2b2lkKXNldEdyYW1tYXJDaGVja2luZ0VuYWJsZWQ6KEJPT0wpZmxhZwogICAg ICAgICBbW3NlbGYgbWFpbkZyYW1lXSBfdW5tYXJrQWxsQmFkR3JhbW1hcl07CiB9CiAKLS8vIEZJ WE1FOiBUaGlzIG1ldGhvZCBzaG91bGQgYmUgbWVyZ2VkIGludG8gV2ViSUJBY3Rpb25zIHdoZW4g d2UncmUgbm90IGluIEFQSSBmcmVlemUKIC0gKHZvaWQpdG9nZ2xlR3JhbW1hckNoZWNraW5nOihp ZClzZW5kZXIKIHsKICAgICBbc2VsZiBzZXRHcmFtbWFyQ2hlY2tpbmdFbmFibGVkOiFbc2VsZiBp c0dyYW1tYXJDaGVja2luZ0VuYWJsZWRdXTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFj L1dlYlZpZXcvV2ViVmlld1ByaXZhdGUuaAppbmRleCAyYzUzYTZiYjQyZjc2MGQyNjk1MWU5M2M2 ZTg3ZDNkMGU3MjAxNjc0Li5lZjg3NjM1YzcxYmE1ZThjZGY5Y2Q0MWJlYzkxN2U3NjM5YWI3Mzdk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXdQcml2 YXRlLmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3UHJpdmF0 ZS5oCkBAIC0xMDUsMTMgKzEwNSw2IEBAIGV4dGVybiBOU1N0cmluZyAqV2ViRWxlbWVudElzSW5T Y3JvbGxCYXJLZXk7CiAvLyBPbmUgb2YgdGhlIHN1YnZpZXdzIG9mIHRoZSBXZWJWaWV3IGVudGVy ZWQgY29tcG9zaXRpbmcgbW9kZS4KIGV4dGVybiBOU1N0cmluZyAqX1dlYlZpZXdEaWRTdGFydEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdOb3RpZmljYXRpb247CiAKLSNpZiBFTkFCTEVfUkVNT1RFX0lO U1BFQ1RPUgotLy8gRklYTUU6IExlZ2FjeSwgcmVtb3ZlIHRoaXMsIHN3aXRjaCB0byBzb21ldGhp bmcgZnJvbSBKYXZhU2NyaXB0Q29yZSBJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3RvclNlcnZlci4K LS8vIE5vdGlmaWNhdGlvbiB3aGVuIHRoZSBudW1iZXIgb2YgaW5zcGVjdG9yIHNlc3Npb25zIGJl Y29tZXMgbm9uLXplcm8gb3IgcmV0dXJucyB0byAwLgotLy8gQ2hlY2sgdGhlIGN1cnJlbnQgc3Rh dGUgdmlhIC1bV2ViVmlldyBfaGFzUmVtb3RlSW5zcGVjdG9yU2Vzc2lvbl0uCi1leHRlcm4gTlNT dHJpbmcgKl9XZWJWaWV3UmVtb3RlSW5zcGVjdG9ySGFzU2Vzc2lvbkNoYW5nZWROb3RpZmljYXRp b247Ci0jZW5kaWYKLQogI2lmIFRBUkdFVF9PU19JUEhPTkUKIGV4dGVybiBOU1N0cmluZyAqV2Vi UXVpY2tMb29rRmlsZU5hbWVLZXk7CiBleHRlcm4gTlNTdHJpbmcgKldlYlF1aWNrTG9va1VUSUtl eTsKQEAgLTE2MCwxMSArMTUzLDYgQEAgdHlwZWRlZiBlbnVtIHsKICAgICBXZWJQYWdpbmF0aW9u TW9kZVJpZ2h0VG9MZWZ0LAogICAgIFdlYlBhZ2luYXRpb25Nb2RlVG9wVG9Cb3R0b20sCiAgICAg V2ViUGFnaW5hdGlvbk1vZGVCb3R0b21Ub1RvcCwKLSNpZiBUQVJHRVRfT1NfSVBIT05FCi0gICAg Ly8gRklYTUU6IFJlbW92ZSB0aGVzZSBvbmNlIFVJS2l0IGhhcyBzd2l0Y2hlZCB0byB0aGUgYWJv dmUuCi0gICAgV2ViUGFnaW5hdGlvbk1vZGVIb3Jpem9udGFsID0gV2ViUGFnaW5hdGlvbk1vZGVM ZWZ0VG9SaWdodCwKLSAgICBXZWJQYWdpbmF0aW9uTW9kZVZlcnRpY2FsID0gV2ViUGFnaW5hdGlv bk1vZGVUb3BUb0JvdHRvbSwKLSNlbmRpZgogfSBXZWJQYWdpbmF0aW9uTW9kZTsKIAogZW51bSB7 CkBAIC05NDksMTEgKzkzNyw5IEBAIHR5cGVkZWYgc3RydWN0IFdlYkVkZ2VJbnNldHMgewogCiBA aW50ZXJmYWNlIFdlYlZpZXcgKFdlYlZpZXdHcmFtbWFyQ2hlY2tpbmcpCiAKLS8vIEZJWE1FOiBU aGVzZSB0d28gbWV0aG9kcyBzaG91bGQgYmUgbWVyZ2VkIGludG8gV2ViVmlld0VkaXRpbmcgd2hl biB3ZSdyZSBub3QgaW4gQVBJIGZyZWV6ZQogLSAoQk9PTClpc0dyYW1tYXJDaGVja2luZ0VuYWJs ZWQ7CiAtICh2b2lkKXNldEdyYW1tYXJDaGVja2luZ0VuYWJsZWQ6KEJPT0wpZmxhZzsKIAotLy8g RklYTUU6IFRoaXMgbWV0aG9kIHNob3VsZCBiZSBtZXJnZWQgaW50byBXZWJJQkFjdGlvbnMgd2hl biB3ZSdyZSBub3QgaW4gQVBJIGZyZWV6ZQogLSAodm9pZCl0b2dnbGVHcmFtbWFyQ2hlY2tpbmc6 KGlkKXNlbmRlcjsKIAogQGVuZAo=