229200 2021-08-17 12:45:44 -0700 REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page 2021-08-18 06:42:57 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh dino mmaxfield sabouhallawa simon.fraser thorton webkit-bug-importer oldest_to_newest 1784902 0 wenson_hsieh 2021-08-17 12:45:44 -0700 rdar://81636256 1784927 1 435712 wenson_hsieh 2021-08-17 13:45:29 -0700 Created attachment 435712 For EWS 1784983 2 435712 mmaxfield 2021-08-17 16:33:09 -0700 Comment on attachment 435712 For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=435712&action=review > Source/WebKit/ChangeLog:43 > + Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet). Ideally a new test would be good, but I think it's evident that this is already tested by existing tests, which are currently flakey now. 1784986 3 435712 wenson_hsieh 2021-08-17 16:37:01 -0700 Comment on attachment 435712 For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=435712&action=review Thanks for the review! (Let's wait for ios-wk2 before adding the cq+) >> Source/WebKit/ChangeLog:43 >> + Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet). > > Ideally a new test would be good, but I think it's evident that this is already tested by existing tests, which are currently flakey now. Indeed — I'm still actively working on a layout test for this. I suspect that figuring out how to trigger the race conditions that cause this bug will also help us write more tests in this area, moving forward. 1785031 4 wenson_hsieh 2021-08-17 19:46:01 -0700 (In reply to Wenson Hsieh from comment #3) > Comment on attachment 435712 [details] > For EWS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435712&action=review > > Thanks for the review! > > (Let's wait for ios-wk2 before adding the cq+) > > >> Source/WebKit/ChangeLog:43 > >> + Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet). > > > > Ideally a new test would be good, but I think it's evident that this is already tested by existing tests, which are currently flakey now. > > Indeed — I'm still actively working on a layout test for this. > I suspect that figuring out how to trigger the race conditions that cause > this bug will also help us write more tests in this area, moving forward. (Tracking a test in https://bugs.webkit.org/show_bug.cgi?id=229222) 1785101 5 435712 wenson_hsieh 2021-08-18 06:32:33 -0700 Comment on attachment 435712 For EWS Looks like iOS test failures are unrelated. 1785103 6 ews-feeder 2021-08-18 06:42:55 -0700 Committed r281186 (240631@main): <https://commits.webkit.org/240631@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435712. 435712 2021-08-17 13:45:29 -0700 2021-08-18 06:42:56 -0700 For EWS bug-229200-20210817134528.patch text/plain 4420 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk3ZGZkMGUyNWEyMmY1ZDA3 Mjk4OTZlNzlmNzkzY2E3YzQzMGUzZTkuLjNkOWRmYTc0YmUxY2YwNzkwNTNiM2I3YTgwMDQ5MTMy Zjg4YTQzYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNTAgQEAKKzIwMjEtMDgtMTcgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoaU9T IDE1KTogRG91YmxlRG93biBDYXNpbm8gYXBwIHdvbid0IGxvYWQgcGFzdCBsYXVuY2ggcGFnZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MjAwCisg ICAgICAgIHJkYXI6Ly84MTYzNjI1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBjaGFuZ2VzIGluIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIyODIx NiB0byBmaXggcmRhcjovLzgwNDczODA1IGludHJvZHVjZWQgYSBtZWNoYW5pc20gdG8ga2VlcCB0 cmFjayBvZiB1c2VzCisgICAgICAgIG9mIGNhY2hlZCBmb250cyBhbmQgaW1hZ2VzIGluIGRpc3Bs YXkgbGlzdCBpdGVtcyBpbiB0aGUgd2ViIGFuZCBHUFUgcHJvY2Vzc2VzLCB2aWEgYSBgdXNlQ291 bnRgIGNvdW50ZXIgdmFyaWFibGUKKyAgICAgICAgdGhhdCdzIGluY3JlbWVudGVkIGluIHRoZSB3 ZWIgcHJvY2VzcyB3aGVuZXZlciB0aGUgZm9udCBvciBpbWFnZSBpcyB1c2VkIGluIGEgZGlzcGxh eSBsaXN0IGl0ZW0gYW5kIGRlY3JlbWVudGVkCisgICAgICAgIGluIHRoZSBHUFUgcHJvY2VzcyB3 aGVuZXZlciB0aGUgaXRlbSBpcyBwcm9jZXNzZWQuCisKKyAgICAgICAgSG93ZXZlciwgdGhlIGNv ZGUgdG8gaW5jcmVtZW50IGB1c2VDb3VudGAgaW4gdGhlIHdlYiBwcm9jZXNzIGN1cnJlbnRseSBv bmx5IHRyaWdnZXJzIGF0IG1vc3Qgb25jZSBwZXIgcmVuZGVyaW5nCisgICAgICAgIHVwZGF0ZSDi gJQgdGhpcyBtZWFucyB0aGF0IGlmIHRoZXJlIGFyZSBtdWx0aXBsZSBjYW52YXMgZHJhd2luZyBj b21tYW5kcyB0aGF0IHVzZSBmb250cyBpbiB0aGUgc2FtZSByZW5kZXJpbmcKKyAgICAgICAgdXBk YXRlLCB0aGUgd2ViIHByb2Nlc3MnIG5vdGlvbiBvZiBgdXNlQ291bnRgIHdpbGwgZmFsbCBvdXQg b2Ygc3luYyB3aXRoIHRoZSBHUFUgcHJvY2Vzcycgbm90aW9uIG9mIGB1c2VDb3VudGAuCisKKyAg ICAgICAgSW4gbW9zdCBjYXNlcywgdGhpcyBjYXVzZXMgdGhlIGNhY2hlZCBmb250IHRvIHJlbWFp biBmb3IgbG9uZ2VyIGluIHRoZSBHUFUgcHJvY2VzcyB0aGFuIG5lY2Vzc2FyeTsgaG93ZXZlciwg aW4KKyAgICAgICAgdGhpcyBzcGVjaWZpYyBzY2VuYXJpbywgaXQncyBwb3NzaWJsZSBmb3IgdGhl IHdlYiBwcm9jZXNzIHRvIHRlbGwgdGhlIEdQVSBwcm9jZXNzIHRvIHJlbGVhc2UgdGhlIGNhY2hl ZCBmb250IHRvbworICAgICAgICBlYXJseSwgd2hpY2ggY2F1c2VzIHRoZSBHUFUgcHJvY2VzcyB0 byBwcmVtYXR1cmVseSBwdXJnZSB0aGUgZm9udCBmcm9tIHRoZSBjYWNoZSwgYW5kIHN1YnNlcXVl bnRseSB3YWl0IGZvciB0aGUKKyAgICAgICAgY2FjaGVkIGZvbnQgdG8gYXJyaXZlICh3aGljaCB3 aWxsIG5ldmVyIGFycml2ZSwgc2luY2UgdGhlIHdlYiBwcm9jZXNzIGhhcyBhbHJlYWR5IHJlbGVh c2VkIHRoZSBmb250KS4KKworICAgICAgICBJbiBvdGhlciB3b3JkcywgdGhlIHRpbWVsaW5lIG9m IGV2ZW50cyBiZXR3ZWVuIHRoZSB3ZWIgYW5kIEdQVSBwcm9jZXNzZXMgbG9va3MgbGlrZSB0aGlz ICh3aGVyZSBgZmAgaXMgYSBjYWNoZWQKKyAgICAgICAgd2ViIGZvbnQsIGBBX2ZgIGlzIGEgZHJh d2luZyBjb21tYW5kIHRoYXQgdXNlcyBgZmAsIGFuZCBgQl9mYCBpcyBhbm90aGVyIGRyYXdpbmcg Y29tbWFuZCB0aGF0IHVzZXMgYGZgKS4KKworICAgICAgICBXRUIgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBHUFUKKyAgICAgICAgPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KKyAgICAgICAgMS4g Q2FjaGUgYGZgCisgICAgICAgIDIuIEFwcGVuZCBgQV9mYAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAzLiBDYWNoZSBgZmAKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgNC4gUGxheSBi YWNrIGBBX2ZgCisgICAgICAgIDUuIEFwcGVuZCBgQl9mYAorICAgICAgICA2LiBSZWxlYXNlIGBm YCAodXNlIGNvdW50IHdhcyAxIGhlcmUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDcuIFJlbGVhc2UgYGZgICh1c2UgY291bnQgZHJvcHBl ZCBmcm9tIDEgdG8gMCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOC4gUGxheSBiYWNrIGBCX2ZgCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC4uLmFuZCB0aGVuIGRpc3BsYXkgbGlz dCBwbGF5YmFjayBzdG9wcyBkdWUgdG8gYGZgIG5vdCBiZWluZyBpbgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0aGUgY2FjaGUuCisKKyAg ICAgICAgVG8gYWRkcmVzcyB0aGlzLCB3ZSBzaW1wbHkgbW92ZSB0aGUgYHVzZUNvdW50YCBpbmNy ZW1lbnQgaW4gdGhlIHdlYiBwcm9jZXNzIG91dCBvZiB0aGUgcmVuZGVyaW5nIHVwZGF0ZSBjaGVj ay4KKyAgICAgICAgVGhlIG9yaWdpbmFsIGludGVudCBvZiB0aGUgZml4IGZvciBidWcgIzIyODIx NiB3YXMgdG8gYWxsb3cgZm9yIGB1c2VDb3VudGAgdG8gaW5jcmVtZW50IGFzIG1hbnkgdGltZXMg YXMgbmVlZGVkCisgICAgICAgIHBlciByZW5kZXJpbmcgdXBkYXRlLCBzbyB0aGlzIGxpbWl0YXRp b24gd2FzIHVuaW50ZW50aW9uYWwuCisKKyAgICAgICAgVW5mb3J0dW5hdGVseSwgSSBoYXZlIG5v dCBiZWVuIGFibGUgdG8gY29tZSB1cCB3aXRoIGEgbGF5b3V0IHRlc3QgdGhhdCByZWxpYWJseSBy ZXByb2R1Y2VzIHRoaXMgc2NlbmFyaW8gKHlldCkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQ VS9ncmFwaGljcy9SZW1vdGVSZXNvdXJjZUNhY2hlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0 OjpSZW1vdGVSZXNvdXJjZUNhY2hlUHJveHk6OnJlY29yZEZvbnRVc2UpOgorCiAyMDIxLTA4LTE2 ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtX aW5DYWlyb11bR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXJdIERyYXdpbmdBcmVhUHJveHlDb29y ZGluYXRlZEdyYXBoaWNzIGRvZXNuJ3QgZW50ZXIgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9k ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1v dGVSZXNvdXJjZUNhY2hlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9n cmFwaGljcy9SZW1vdGVSZXNvdXJjZUNhY2hlUHJveHkuY3BwCmluZGV4IGYyNzI5YjIwYThiN2Qz YzgwNGUxZjA0ZjdjYzMzODA4ZGNmNGMxYzMuLmUyMTVmMDk5MTliM2RkODhmYTgwMGUxYTdkOTg4 Y2ZjMzNkZDdlYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3Jh cGhpY3MvUmVtb3RlUmVzb3VyY2VDYWNoZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZVJlc291cmNlQ2FjaGVQcm94eS5jcHAKQEAgLTEz Miw5ICsxMzIsOSBAQCB2b2lkIFJlbW90ZVJlc291cmNlQ2FjaGVQcm94eTo6cmVjb3JkRm9udFVz ZShGb250JiBmb250KQogICAgIH0KIAogICAgIGF1dG8mIGN1cnJlbnRTdGF0ZSA9IHJlc3VsdC5p dGVyYXRvci0+dmFsdWU7CisgICAgKytjdXJyZW50U3RhdGUudXNlQ291bnQ7CiAgICAgaWYgKGN1 cnJlbnRTdGF0ZS5sYXN0UmVuZGVyaW5nVXBkYXRlVmVyc2lvblVzZWRXaXRoaW4gIT0gbV9yZW1v dGVSZW5kZXJpbmdCYWNrZW5kUHJveHkucmVuZGVyaW5nVXBkYXRlSUQoKSkgewogICAgICAgICBj dXJyZW50U3RhdGUubGFzdFJlbmRlcmluZ1VwZGF0ZVZlcnNpb25Vc2VkV2l0aGluID0gbV9yZW1v dGVSZW5kZXJpbmdCYWNrZW5kUHJveHkucmVuZGVyaW5nVXBkYXRlSUQoKTsKLSAgICAgICAgKytj dXJyZW50U3RhdGUudXNlQ291bnQ7CiAgICAgICAgICsrbV9udW1iZXJPZkZvbnRzVXNlZEluQ3Vy cmVudFJlbmRlcmluZ1VwZGF0ZTsKICAgICB9CiB9Cg==