22919 2008-12-18 11:14:27 -0800 Should use consistent algorithm to compute elapsedTime 2009-03-02 11:51:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin simon.fraser oldest_to_newest 102910 0 cmarrin 2008-12-18 11:14:27 -0800 KeyframeAnimation::animate() and AnimationBase::progress() both compute elapsedTime differently. This has not caused any visible problems so far. But with the new pauseAnimationAtTimeOnElementWithId() interface could expose problems since the differences are mostly in how they deal with pause. So I need to unify this into a common function 102911 1 26125 cmarrin 2008-12-18 11:17:27 -0800 Created attachment 26125 Patch 104647 2 26125 eric 2009-01-06 15:05:49 -0800 Comment on attachment 26125 Patch It appears the behavior or progress() for elapsed times < 0 changes with this patch. I don't have enough context to tell if that's a good thing or not. 105413 3 cmarrin 2009-01-12 15:45:47 -0800 It does change the elapsed time < 0 behavior. When reviewing this I noticed that difference. The current formula is a composite of the two old formulae and I believe the current one does the right thing in all cases. 105579 4 cmarrin 2009-01-13 14:57:21 -0800 Fixed by Changeset 39849 26125 2008-12-18 11:17:27 -0800 2009-01-09 16:16:17 -0800 Patch 22919.patch text/plain 3470 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTM3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDgtMTItMTggIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eGVkIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkxOQorCisgICAg ICAgIEkgYWRkZWQgYSBjb21tb24gZ2V0RWxhcHNlZFRpbWUoKSBmdW5jdGlvbiB0byBBbmltYXRp b25CYXNlIHdoaWNoIHVzZXMgYSBjb21iaW5hdGlvbiBvZgorICAgICAgICB0aGUgdGVjaG5pcXVl cyBmcm9tIEtleWZyYW1lQW5pbWF0aW9uIGFuZCBBbmltYXRpb25CYXNlIHRvIGNvbXB1dGUgZWxh cHNlZFRpbWUgaW4gYWxsCisgICAgICAgIHN0YXRlcy4KKworICAgICAgICAqIHBhZ2UvYW5pbWF0 aW9uL0FuaW1hdGlvbkJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QW5pbWF0aW9uQmFzZTo6 cHJvZ3Jlc3MpOgorICAgICAgICAoV2ViQ29yZTo6QW5pbWF0aW9uQmFzZTo6Z2V0RWxhcHNlZFRp bWUpOgorICAgICAgICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuaDoKKyAgICAgICAg KiBwYWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpLZXlmcmFtZUFuaW1hdGlvbjo6YW5pbWF0ZSk6CisKIDIwMDgtMTItMTggIENhbWVyb24gWndh cmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdh cmVuLgpJbmRleDogV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCShyZXZp c2lvbiAzOTM3MykKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTc4MCw5ICs3ODAsNyBAQCBkb3VibGUgQW5pbWF0aW9uQmFzZTo6 cHJvZ3Jlc3MoZG91YmxlIHNjCiAgICAgaWYgKHByZUFjdGl2ZSgpKQogICAgICAgICByZXR1cm4g MDsKIAotICAgIGRvdWJsZSBlbGFwc2VkVGltZSA9IHJ1bm5pbmcoKSAmJiAhcGF1c2VkKCkgPyAo Y3VycmVudFRpbWUoKSAtIG1fc3RhcnRUaW1lKSA6IChtX3BhdXNlVGltZSAtIG1fc3RhcnRUaW1l KTsKLSAgICBpZiAocnVubmluZygpICYmIGVsYXBzZWRUaW1lIDwgMCkKLSAgICAgICAgcmV0dXJu IDA7CisgICAgZG91YmxlIGVsYXBzZWRUaW1lID0gZ2V0RWxhcHNlZFRpbWUoKTsKIAogICAgIGRv dWJsZSBkdXIgPSBtX2FuaW1hdGlvbi0+ZHVyYXRpb24oKTsKICAgICBpZiAobV9hbmltYXRpb24t Pml0ZXJhdGlvbkNvdW50KCkgPiAwKQpAQCAtODUyLDQgKzg1MCwxNSBAQCB2b2lkIEFuaW1hdGlv bkJhc2U6OnBhdXNlQXRUaW1lKGRvdWJsZSB0CiAgICAgbV9wYXVzZVRpbWUgPSBtX3N0YXJ0VGlt ZSArIHQgLSBtX2FuaW1hdGlvbi0+ZGVsYXkoKTsKIH0KIAorZG91YmxlIEFuaW1hdGlvbkJhc2U6 OmdldEVsYXBzZWRUaW1lKCkgY29uc3QKK3sKKyAgICBpZiAocGF1c2VkKCkpICAgIAorICAgICAg ICByZXR1cm4gbV9wYXVzZVRpbWUgLSBtX3N0YXJ0VGltZTsKKyAgICBpZiAobV9zdGFydFRpbWUg PD0gMCkKKyAgICAgICAgcmV0dXJuIDA7CisgICAgaWYgKHBvc3RBY3RpdmUoKSkKKyAgICAgICAg cmV0dXJuIDE7CisgICAgcmV0dXJuIGN1cnJlbnRUaW1lKCkgLSBtX3N0YXJ0VGltZTsKK30KKyAg ICAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUvcGFnZS9hbmltYXRpb24v QW5pbWF0aW9uQmFzZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5p bWF0aW9uQmFzZS5oCShyZXZpc2lvbiAzOTM3MykKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRpb24v QW5pbWF0aW9uQmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw2IEBAIHB1YmxpYzoK ICAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyKCkgY29uc3QgeyByZXR1cm4gbV9vYmplY3Q7IH0K ICAgICB2b2lkIGNsZWFyUmVuZGVyZXIoKSB7IG1fb2JqZWN0ID0gMDsgfQogICAgIAotICAgIGRv dWJsZSBzdGFydFRpbWUoKSBjb25zdCB7IHJldHVybiBtX3N0YXJ0VGltZTsgfQogICAgIGRvdWJs ZSBkdXJhdGlvbigpIGNvbnN0OwogCiAgICAgLy8gQW5pbWF0aW9ucyBhbmQgVHJhbnNpdGlvbnMg Z28gdGhyb3VnaCB0aGUgc3RhdGVzIGJlbG93LiBXaGVuIGVudGVyaW5nIHRoZSBTVEFSVEVEIHN0 YXRlCkBAIC0xNTMsNiArMTUyLDggQEAgcHVibGljOgogICAgIAogICAgIHZvaWQgcGF1c2VBdFRp bWUoZG91YmxlIHQpOwogICAgIAorICAgIGRvdWJsZSBnZXRFbGFwc2VkVGltZSgpIGNvbnN0Owor ICAgIAogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBvdmVycmlkZUFuaW1hdGlvbnMoKSB7 IH0KICAgICB2aXJ0dWFsIHZvaWQgcmVzdW1lT3ZlcnJpZGRlbkFuaW1hdGlvbnMoKSB7IH0KSW5k ZXg6IFdlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCShyZXZp c2lvbiAzOTM3MykKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OCw5ICs4OCw3IEBAIHZvaWQgS2V5ZnJhbWVBbmltYXRp b246OmFuaW1hdGUoQ29tcG9zaXQKICAgICAvLyBXZSBzaG91bGQgY2FjaGUgdGhlIGxhc3QgcGFp ciBvciBzb21ldGhpbmcuCiAKICAgICAvLyBGaW5kIHRoZSBmaXJzdCBrZXkKLSAgICBkb3VibGUg ZWxhcHNlZFRpbWUgPSAobV9zdGFydFRpbWUgPiAwIHx8IG1fcGF1c2VUaW1lID4gMCkgPyAoKCFw YXVzZWQoKSA/IGN1cnJlbnRUaW1lKCkgOiBtX3BhdXNlVGltZSkgLSBtX3N0YXJ0VGltZSkgOiAw OwotICAgIGlmIChlbGFwc2VkVGltZSA8IDApCi0gICAgICAgIGVsYXBzZWRUaW1lID0gMDsKKyAg ICBkb3VibGUgZWxhcHNlZFRpbWUgPSBnZXRFbGFwc2VkVGltZSgpOwogCiAgICAgZG91YmxlIHQg PSBtX2FuaW1hdGlvbi0+ZHVyYXRpb24oKSA/IChlbGFwc2VkVGltZSAvIG1fYW5pbWF0aW9uLT5k dXJhdGlvbigpKSA6IDE7CiAgICAgaW50IGkgPSBzdGF0aWNfY2FzdDxpbnQ+KHQpOwo=