229188 2021-08-17 05:53:27 -0700 Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging 2022-02-12 20:40:07 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230733 InRadar P2 Normal --- 1 youennf youennf ehutchison ews-watchlist glenn jbedard jenner ryanhaddad webkit-bug-importer youennf oldest_to_newest 1784792 0 youennf 2021-08-17 05:53:27 -0700 Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging 1784793 1 435681 youennf 2021-08-17 06:05:28 -0700 Created attachment 435681 Patch 1784864 2 435681 jbedard 2021-08-17 10:17:35 -0700 Comment on attachment 435681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review > Tools/Scripts/webkitpy/port/mac.py:-299 > - Why are you deleting these? 1785068 3 435681 youennf 2021-08-18 00:52:35 -0700 Comment on attachment 435681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review >> Tools/Scripts/webkitpy/port/mac.py:-299 >> - > > Why are you deleting these? They should be covered by Negotiation String and LRP which signal encoder is doing some logging. These additional lines were attempts to cover the fact encoder logging is being wrapped in multiple lines, but as we see, it does not work well. 1785720 4 ews-feeder 2021-08-20 00:50:26 -0700 Committed r281297 (240721@main): <https://commits.webkit.org/240721@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435681. 1785721 5 webkit-bug-importer 2021-08-20 00:51:15 -0700 <rdar://problem/82160516> 1785861 6 youennf 2021-08-20 09:16:20 -0700 *** Bug 225525 has been marked as a duplicate of this bug. *** 1787555 7 youennf 2021-08-26 05:45:00 -0700 As can be seen in https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r280628%20(4289)/webrtc/video-setDirection-pretty-diff.html, this is not covering all cases: the underlying codec related logging is sometimes half captured. 1787556 8 youennf 2021-08-26 05:45:45 -0700 One possibility would be to remove all logging before Content-Type:text/plain in all webrtc tests. 1840870 9 bfulgham 2022-02-12 20:40:07 -0800 *** Bug 225523 has been marked as a duplicate of this bug. *** 435681 2021-08-17 06:05:28 -0700 2021-08-20 00:50:27 -0700 Patch bug-229188-20210817150526.patch text/plain 5827 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmUwMGQwNjc3ODhjNjQ0YjlmNmM5Y2E5OGRjYTY3N2Ez OGE1YjBjOS4uNWVjZmVjZTY3ZjIzZmQ1YmVkZmM2NTA0ZjdkZDFjOTljZTViMWJhNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDIxLTA4LTE3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBSZW1vdmUgYWxsIFdUUiBvdXRwdXQgYmVmb3JlIENvbnRlbnQtVHlwZTp0ZXh0L3BsYWlu IGZvciBXZWJSVEMgdGVzdHMgaW4gY2FzZSBvZiBrbm93biBleGNlc3NpdmUgbG9nZ2luZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MTg4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSBsb2dnaW5n IGJlbmVhdGggV2ViS2l0IGlzIG1ha2luZyBXZWJSVEMgdGVzdHMgZmxha3kuCisgICAgICAgIFdo aWxlIHdlIHdvcmsgb24gdGhlIGNhdXNlIG9mIHRoaXMgYnVnLCB3ZSBjYW4gc3RpbGwgYmVlZi11 cCBvdXIgdGVzdCBvdXRwdXQgY2xlYW4gdXAgc3RlcHMgdG8gaGFuZGxlIHRoaXMgbG9nZ2luZy4K KyAgICAgICAgSW5zdGVhZCBvZiBzdHJpcHBpbmcgbGluZXMgYmFzZWQgb24gYSBrbm93biBwYXR0 ZXJuLCB3aGljaCBkb2VzIG5vdCBhbHdheXMgd29yayBhcyBwZXIgY3VycmVudCByZXN1bHRzLAor ICAgICAgICB3ZSBjYW4gc2ltcGx5IHJlbW92ZSBhbGwgbG9nZ2luZyBiZWZvcmUgdGhlICdDb250 ZW50LVR5cGU6dGV4dC9wbGFpblxuJyBzdHJpbmcgdGhhdCBXZWJLaXRUZXN0UnVubmVyIGlzIGFk ZGluZyBiZWZvcmUKKyAgICAgICAgcHJpbnRpbmcgdGhlIHRleHQgZ2VuZXJhdGVkIGJ5IHRoZSB0 ZXN0IGl0c2VsZi4KKyAgICAgICAgV2UgdXBkYXRlIHdlYmtpdHB5IHNjcmlwdHMgYWNjb3JkaW5n bHkgYW5kIGFkZCB0aGlzIG5ldyBjbGVhbi11cCBmb3I6CisgICAgICAgIC0gdGVzdHMgdGhhdCBo YXZlIHdlYnJ0YyBpbiB0aGVpciBuYW1lCisgICAgICAgIC0gdGVzdHMgd2hvc2Ugb3V0cHV0IGNv bnRhaW4gc29tZSBrbm93biBsb2dnaW5nIHN0cmluZ3MgbGlrZSAnTFJQJyBvciAnTmVnb3RpYXRp b24gU3RyaW5nJy4KKyAgICAgICAgVGhpcyBzaG91bGQgaG9wZWZ1bGx5IGJlIG1vcmUgcm9idXN0 IHdoaWxlIG5vdCBoaWRpbmcgcmVhbCByZWdyZXNzaW9ucy4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weToK KyAgICAgICAgKFNpbmdsZVRlc3RSdW5uZXIpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv cG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5sb2dnaW5nX2RldGVjdG9yc190b19zdHJpcF90 ZXh0X3N0YXJ0KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5Ogor ICAgICAgICAoRHJpdmVyT3V0cHV0LnN0cmlwX3RleHRfc3RhcnRfaWZfbmVlZGVkKToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9ydC5sb2dn aW5nX3BhdHRlcm5zX3RvX3N0cmlwKToKKyAgICAgICAgKE1hY1BvcnQubG9nZ2luZ19kZXRlY3Rv cnNfdG9fc3RyaXBfdGV4dF9zdGFydCk6CisKIDIwMjEtMDgtMTMgIExhdXJvIE1vdXJhICA8bG1v dXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gV2ViRXh0ZW5zaW9uIEFQSSB0ZXN0IC93 ZWJraXQvV2ViS2l0V2ViVmlldy93ZWItcHJvY2Vzcy1jcmFzaGVkIGlzIGZsYWt5IGZhaWxpbmcK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQppbmRleCA3YTMyNTdlMDJl MDhlOTU2YWQ3Y2QxNTQwNGVlOTE1OWJiNDRhMTA2Li5kMTdhY2ZkMDE4OWU4NDUxZTg4ZjY2ZTNi NmI2NmNlNTdmN2Y2NTFiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVy LnB5CkBAIC0xMzIsNiArMTMyLDggQEAgY2xhc3MgU2luZ2xlVGVzdFJ1bm5lcihvYmplY3QpOgog ICAgICAgICBleHBlY3RlZF9kcml2ZXJfb3V0cHV0LnN0cmlwX3BhdHRlcm5zKHBhdHRlcm5zKQog ICAgICAgICBkcml2ZXJfb3V0cHV0LnN0cmlwX3BhdHRlcm5zKHBhdHRlcm5zKQogCisgICAgICAg IGRyaXZlcl9vdXRwdXQuc3RyaXBfdGV4dF9zdGFydF9pZl9uZWVkZWQoc2VsZi5fcG9ydC5sb2dn aW5nX2RldGVjdG9yc190b19zdHJpcF90ZXh0X3N0YXJ0KHNlbGYuX2RyaXZlcl9pbnB1dCgpLnRl c3RfbmFtZSkpCisKICAgICAgICAgZHJpdmVyX291dHB1dC5zdHJpcF9zdGRlcnJvcl9wYXR0ZXJu cyhzZWxmLl9wb3J0LnN0ZGVycl9wYXR0ZXJuc190b19zdHJpcCgpKQogCiAgICAgICAgIHRlc3Rf cmVzdWx0ID0gc2VsZi5fY29tcGFyZV9vdXRwdXQoZXhwZWN0ZWRfZHJpdmVyX291dHB1dCwgZHJp dmVyX291dHB1dCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNl LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXggNDg0OTg4ODk3 ODQwYjUxZGUzODY1ZjNlNWUxNDM3OTQ4OTcxNjFjZC4uMmNiMTFkMWM1NmY3ZmExZjc5ZDA1YmM1 NGU4YzNiOTgxMTUxYTBlZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2Jhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKQEAgLTE0 MjAsNiArMTQyMCw5IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICBkZWYgc3RkZXJyX3BhdHRl cm5zX3RvX3N0cmlwKHNlbGYpOgogICAgICAgICByZXR1cm4gW10KIAorICAgIGRlZiBsb2dnaW5n X2RldGVjdG9yc190b19zdHJpcF90ZXh0X3N0YXJ0KHNlbGYsIHRlc3RfbmFtZSk6CisgICAgICAg IHJldHVybiBbXQorCiAgICAgZGVmIHRlc3RfZXhwZWN0YXRpb25zX2ZpbGVfcG9zaXRpb24oc2Vs Zik6CiAgICAgICAgICMgQnkgZGVmYXVsdCBiYXNlbGluZSBzZWFyY2ggcGF0aCBzY2hlbWEgaXMg aS5lLiBwb3J0LXdrMiAtPiB3azIgLT4gcG9ydCAtPiBnZW5lcmljLCBzbyBwb3J0IGV4cGVjdGF0 aW9ucyBmaWxlIGlzIGF0IHNlY29uZCB0byBsYXN0IHBvc2l0aW9uLgogICAgICAgICByZXR1cm4g MQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKaW5kZXggZWU5MDNhOWVjMzA2MTQ4 NDBiN2JlNmU4MzA4ZThiNmUxZWFmNmRjYy4uODYzNzAzOTk5MzEzMzkyMWVkZDA1NjNlNjJlY2Zm MTExMmQ0ZTAyMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZl ci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CkBAIC0xMTQs NiArMTE0LDIwIEBAIGNsYXNzIERyaXZlck91dHB1dChvYmplY3QpOgogICAgICAgICBmb3IgcGF0 dGVybiBpbiBwYXR0ZXJuczoKICAgICAgICAgICAgIHNlbGYudGV4dCA9IHJlLnN1YihwYXR0ZXJu WzBdLCBwYXR0ZXJuWzFdLCBzZWxmLnRleHQpCiAKKyAgICBkZWYgc3RyaXBfdGV4dF9zdGFydF9p Zl9uZWVkZWQoc2VsZiwgZGV0ZWN0b3JzKToKKyAgICAgICAgaWYgbm90IHNlbGYudGV4dCBvciBu b3QgbGVuKGRldGVjdG9ycyk6CisgICAgICAgICAgICByZXR1cm4KKworICAgICAgICByZXN1bHQg PSBzZWxmLnRleHQuc3BsaXQoJ0NvbnRlbnQtVHlwZTogdGV4dC9wbGFpblxuJykKKyAgICAgICAg aWYgbGVuKHJlc3VsdCkgIT0gMjoKKyAgICAgICAgICAgIHJldHVybgorCisgICAgICAgIGZvciBk ZXRlY3RvciBpbiBkZXRlY3RvcnM6CisgICAgICAgICAgICBpZiBkZXRlY3RvciBpbiByZXN1bHRb MF06CisgICAgICAgICAgICAgICAgc2VsZi50ZXh0ID0gcmVzdWx0WzFdCisgICAgICAgICAgICAg ICAgc2VsZi5lcnJvciArPSAnXG5SZW1vdmVkIGxvZ2dpbmcgZnJvbSBzdGRvdXQ6XG4nICsgcmVz dWx0WzBdCisgICAgICAgICAgICAgICAgcmV0dXJuCisKICAgICBkZWYgc3RyaXBfc3RkZXJyb3Jf cGF0dGVybnMoc2VsZiwgcGF0dGVybnMpOgogICAgICAgICBpZiBub3Qgc2VsZi5lcnJvcjoKICAg ICAgICAgICAgIHJldHVybgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L21hYy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMucHkKaW5kZXggODAwMjU2 ZjYzZWEyZDBmNTMyY2YxMzhkOTBlMmZkOTQzYzA3ZWM1Mi4uZDA1NjQ3MjYyZGIzYWRhNzIxMzZi OTJlYWUxZDNiM2ZhNTc1ZmQ3OSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L21hYy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CkBAIC0y OTAsMTUgKzI5MCwxNyBAQCBjbGFzcyBNYWNQb3J0KERhcndpblBvcnQpOgogICAgICAgICAjIEZJ WE1FOiBGaW5kIHdoZXJlIHRoaXMgaXMgY29taW5nIGZyb20gYW5kIGZpbGUgYSBidWcgdG8gaGF2 ZSBpdCByZW1vdmVkICh0aGVuIHJlbW92ZSB0aGlzIGxpbmUpLgogICAgICAgICBsb2dnaW5nX3Bh dHRlcm5zLmFwcGVuZCgocmUuY29tcGlsZSgnVlA5IEluZm86LipcbicpLCAnJykpCiAKLSAgICAg ICAgIyBGSVhNRTogUmVwbGFjZSB0aGlzIHdpdGggYSBkZWZhdWx0cyB3cml0ZSBhZnRlciBib3Rz IHVwZGF0ZSB0byBhIGJ1aWxkIHRoYXQgaGFzIHJkYXI6Ly9wcm9ibGVtLzc0MDMxNDAwIGZpeGVk LgotICAgICAgICBsb2dnaW5nX3BhdHRlcm5zLmFwcGVuZCgocidOZWdvdGlhdGlvbiBTdHJpbmc6 LipcbicsICcnKSkKLSAgICAgICAgbG9nZ2luZ19wYXR0ZXJucy5hcHBlbmQoKHInTFJQLipcbics ICcnKSkKLSAgICAgICAgbG9nZ2luZ19wYXR0ZXJucy5hcHBlbmQoKHInLiogXChzZWNvbmRzXCkg JywgJycpKQotICAgICAgICBsb2dnaW5nX3BhdHRlcm5zLmFwcGVuZCgocicuKiAwICAwIFxbXF1c bicsICcnKSkKLSAgICAgICAgbG9nZ2luZ19wYXR0ZXJucy5hcHBlbmQoKHInXFtcXVxuJywgJycp KQotCiAgICAgICAgIHJldHVybiBsb2dnaW5nX3BhdHRlcm5zCiAKKyAgICBkZWYgbG9nZ2luZ19k ZXRlY3RvcnNfdG9fc3RyaXBfdGV4dF9zdGFydChzZWxmLCB0ZXN0X25hbWUpOgorICAgICAgICBs b2dnaW5nX2RldGVjdG9ycyA9IFtdCisKKyAgICAgICAgaWYgJ3dlYnJ0YycgaW4gdGVzdF9uYW1l OgorICAgICAgICAgICAgbG9nZ2luZ19kZXRlY3RvcnMuYXBwZW5kKCdOZWdvdGlhdGlvbiBTdHJp bmc6JykKKyAgICAgICAgICAgIGxvZ2dpbmdfZGV0ZWN0b3JzLmFwcGVuZCgnTFJQJykKKworICAg ICAgICByZXR1cm4gbG9nZ2luZ19kZXRlY3RvcnMKKwogICAgIGRlZiBzdGRlcnJfcGF0dGVybnNf dG9fc3RyaXAoc2VsZik6CiAgICAgICAgIHdvcnRobGVzc19wYXR0ZXJucyA9IFtdCiAgICAgICAg IHdvcnRobGVzc19wYXR0ZXJucy5hcHBlbmQoKHJlLmNvbXBpbGUoJy4qKEZpZ3xmaWd8aXRlbWFz eW5jfHZ0fG12X3xQdWxsUGFyYW1TZXRTUFN8Y2NycF98Y2xpZW50KS4qIHNpZ25hbGxlZCBlcnI9 LipcbicpLCAnJykpCg==