22917 2008-12-18 09:42:10 -0800 break out text selection on initial focus as separate feature 2009-02-04 17:28:22 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 caryclark caryclark oldest_to_newest 102896 0 caryclark 2008-12-18 09:42:10 -0800 Focusing on a textarea sets the caret at the beginning of the selection. The ANDROID platform user interface guidelines requires selecting all when focusing on a textarea. I'd like a compile-time flag to select this behavior. 102901 1 26122 caryclark 2008-12-18 09:45:47 -0800 Created attachment 26122 patch to allow selecting all text on initial focus of text area 104128 2 26122 darin 2009-01-02 11:11:58 -0800 Comment on attachment 26122 patch to allow selecting all text on initial focus of text area > +#if !defined(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) > +#define ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL 0 > +#endif Seems slightly excessive to control this with Platform.h, but I suppose we can refactor this when we refactor Platform.h in the future. > + WARNING: NO TEST CASES ADDED OR CHANGED Please remove this line from the ChangeLog. The warning is to you, the person writing the ChangeLog, and shouldn't be checked in. The ChangeLog should include the URL of this bug report. r=me 104433 3 26431 caryclark 2009-01-05 08:31:20 -0800 Created attachment 26431 patch to allow selecting all text on initial focus of text area removed WARNING from WebCore ChangeLog; added bug URLs to both ChangeLogs 104625 4 26431 eric 2009-01-06 14:06:24 -0800 Comment on attachment 26431 patch to allow selecting all text on initial focus of text area You seem to have addressed darin's comments, and this otherwise looks fine. 108362 5 eric 2009-02-04 16:00:12 -0800 Your defined() check did not match what you were defining. But I fixed the check to ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL when landing. I'm surprised this patch worked for you. 108365 6 eric 2009-02-04 16:28:15 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/wtf/Platform.h M WebCore/ChangeLog M WebCore/html/HTMLTextAreaElement.cpp Committed r40645 108375 7 eric 2009-02-04 17:27:11 -0800 Patch was wrong. Fixed: Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Element.cpp Committed r40654 108377 8 eric 2009-02-04 17:28:22 -0800 Sorry, that was destined for bug 23163. 26122 2008-12-18 09:45:47 -0800 2009-01-05 08:31:20 -0800 patch to allow selecting all text on initial focus of text area patchForBug22917.txt text/plain 3110 caryclark SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5MzcyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMTggIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgRU5BQkxFX09OX0ZJUlNUX1RFWFRBUkVBX0ZPQ1VTX1NF TEVDVF9BTEwgdG8gcGVybWl0IHRoZSBBTkRST0lEIAorICAgICAgICBwbGF0Zm9ybSB0byBzZWxl Y3QgYWxsIHdoZW4gZm9jdXNpbmcgb24gYSB0ZXh0YXJlYS4gVGhpcyBtYXRjaGVzCisgICAgICAg IHRoZSB1c2VyIGludGVyZmFjZSBndWlkZWxpbmVzIG90aGVyIGFwcGxpY2F0aW9ucyBvbiB0aGUg cGxhdGZvcm0uCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAwOC0xMi0xNyAgR2F2 aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQ2FtZXJvbiBad2FyaWNoLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3Jt LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9u IDM5MzcyKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkK QEAgLTQyNyw2ICs0MjcsMTAgQEAKICNkZWZpbmUgRU5BQkxFX1RFWFRfQ0FSRVQgMQogI2VuZGlm CiAKKyNpZiAhZGVmaW5lZChPTl9GSVJTVF9URVhUQVJFQV9GT0NVU19TRUxFQ1RfQUxMKQorI2Rl ZmluZSBFTkFCTEVfT05fRklSU1RfVEVYVEFSRUFfRk9DVVNfU0VMRUNUX0FMTCAwCisjZW5kaWYK KwogLyogQ1RJIG9ubHkgc3VwcG9ydHMgeDg2IGF0IHRoZSBtb21lbnQsIGFuZCBoYXMgb25seSBi ZWVuIHRlc3RlZCBvbiBNYWMgYW5kIFdpbmRvd3MuICovCiAjaWYgIWRlZmluZWQoRU5BQkxFX0pJ VCkgJiYgUExBVEZPUk0oWDg2KSAmJiAoUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShXSU4pKQog I2RlZmluZSBFTkFCTEVfSklUIDEKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAzOTM3MikKKysrIFdlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTItMTggIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5H RUQKKyAgICAgICAgCisgICAgICAgIEFkZCBFTkFCTEVfT05fRklSU1RfVEVYVEFSRUFfRk9DVVNf U0VMRUNUX0FMTCB0byBwZXJtaXQgdGhlIEFORFJPSUQgCisgICAgICAgIHBsYXRmb3JtIHRvIHNl bGVjdCBhbGwgd2hlbiBmb2N1c2luZyBvbiBhIHRleHRhcmVhLiBUaGlzIG1hdGNoZXMKKyAgICAg ICAgdGhlIHVzZXIgaW50ZXJmYWNlIGd1aWRlbGluZXMgb3RoZXIgYXBwbGljYXRpb25zIG9uIHRo ZSBwbGF0Zm9ybS4KKworICAgICAgICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50Ojp1cGRhdGVGb2N1c0FwcGVhcmFu Y2UpOgorCiAyMDA4LTEyLTE3ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNv cmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0 bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAJKHJldmlzaW9uIDM5MzcyKQorKysgV2ViQ29yZS9o dG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjksMTAgKzIy OSwxNyBAQCB2b2lkIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OnVwZGF0ZUZvY3VzQXBwCiAgICAgQVNT RVJUKHJlbmRlcmVyKCkpOwogICAgIAogICAgIGlmICghcmVzdG9yZVByZXZpb3VzU2VsZWN0aW9u IHx8IG1fY2FjaGVkU2VsZWN0aW9uU3RhcnQgPCAwKSB7CisjaWYgRU5BQkxFKE9OX0ZJUlNUX1RF WFRBUkVBX0ZPQ1VTX1NFTEVDVF9BTEwpCisgICAgICAgIC8vIERldmljZXMgd2l0aCB0cmFja2Jh bGxzIG9yIGQtcGFkcyBtYXkgZm9jdXMgb24gYSB0ZXh0YXJlYSBpbiByb3V0ZQorICAgICAgICAv LyB0byBhbm90aGVyIGZvY3VzYWJsZSBub2RlLiBCeSBzZWxlY3RpbmcgYWxsIHRleHQsIHRoZSBu ZXh0IG1vdmVtZW50CisgICAgICAgIC8vIGNhbiBtb3JlIHJlYWRpbHkgYmUgaW50ZXJwcmV0ZWQg YXMgbW92aW5nIHRvIHRoZSBuZXh0IG5vZGUuCisgICAgICAgIHNlbGVjdCgpOworI2Vsc2UKICAg ICAgICAgLy8gSWYgdGhpcyBpcyB0aGUgZmlyc3QgZm9jdXMsIHNldCBhIGNhcmV0IGF0IHRoZSBi ZWdpbm5pbmcgb2YgdGhlIHRleHQuICAKICAgICAgICAgLy8gVGhpcyBtYXRjaGVzIHNvbWUgYnJv d3NlcnMnIGJlaGF2aW9yOyBzZWUgYnVnIDExNzQ2IENvbW1lbnQgIzE1LgogICAgICAgICAvLyBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc0NiNjMTUKICAgICAgICAg c2V0U2VsZWN0aW9uUmFuZ2UoMCwgMCk7CisjZW5kaWYKICAgICB9IGVsc2UgewogICAgICAgICAv LyBSZXN0b3JlIHRoZSBjYWNoZWQgc2VsZWN0aW9uLiAgVGhpcyBtYXRjaGVzIG90aGVyIGJyb3dz ZXJzJyBiZWhhdmlvci4KICAgICAgICAgc2V0U2VsZWN0aW9uUmFuZ2UobV9jYWNoZWRTZWxlY3Rp b25TdGFydCwgbV9jYWNoZWRTZWxlY3Rpb25FbmQpOwo= 26431 2009-01-05 08:31:20 -0800 2009-01-06 14:06:24 -0800 patch to allow selecting all text on initial focus of text area patchForBug22917.txt text/plain 3179 caryclark SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5MzcyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMTggIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlczogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyOTE3CisKKyAgICAgICAgQWRkIEVOQUJMRV9PTl9GSVJTVF9URVhUQVJFQV9G T0NVU19TRUxFQ1RfQUxMIHRvIHBlcm1pdCB0aGUgQU5EUk9JRCAKKyAgICAgICAgcGxhdGZvcm0g dG8gc2VsZWN0IGFsbCB3aGVuIGZvY3VzaW5nIG9uIGEgdGV4dGFyZWEuIFRoaXMgbWF0Y2hlcwor ICAgICAgICB0aGUgdXNlciBpbnRlcmZhY2UgZ3VpZGVsaW5lcyBvdGhlciBhcHBsaWNhdGlvbnMg b24gdGhlIHBsYXRmb3JtLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDgtMTIt MTcgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IENhbWVyb24gWndhcmljaC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9Q bGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShy ZXZpc2lvbiAzOTM3MikKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5n IGNvcHkpCkBAIC00MjcsNiArNDI3LDEwIEBACiAjZGVmaW5lIEVOQUJMRV9URVhUX0NBUkVUIDEK ICNlbmRpZgogCisjaWYgIWRlZmluZWQoT05fRklSU1RfVEVYVEFSRUFfRk9DVVNfU0VMRUNUX0FM TCkKKyNkZWZpbmUgRU5BQkxFX09OX0ZJUlNUX1RFWFRBUkVBX0ZPQ1VTX1NFTEVDVF9BTEwgMAor I2VuZGlmCisKIC8qIENUSSBvbmx5IHN1cHBvcnRzIHg4NiBhdCB0aGUgbW9tZW50LCBhbmQgaGFz IG9ubHkgYmVlbiB0ZXN0ZWQgb24gTWFjIGFuZCBXaW5kb3dzLiAqLwogI2lmICFkZWZpbmVkKEVO QUJMRV9KSVQpICYmIFBMQVRGT1JNKFg4NikgJiYgKFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0o V0lOKSkKICNkZWZpbmUgRU5BQkxFX0pJVCAxCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMzkzNzIpCisrKyBXZWJDb3Jl L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDA4LTEyLTE4ICBD YXJ5IENsYXJrICA8Y2FyeWNsYXJrQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXM6IGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjkxNworCisgICAgICAgIEFkZCBFTkFCTEVfT05fRklSU1RfVEVY VEFSRUFfRk9DVVNfU0VMRUNUX0FMTCB0byBwZXJtaXQgdGhlIEFORFJPSUQgCisgICAgICAgIHBs YXRmb3JtIHRvIHNlbGVjdCBhbGwgd2hlbiBmb2N1c2luZyBvbiBhIHRleHRhcmVhLiBUaGlzIG1h dGNoZXMKKyAgICAgICAgdGhlIHVzZXIgaW50ZXJmYWNlIGd1aWRlbGluZXMgb3RoZXIgYXBwbGlj YXRpb25zIG9uIHRoZSBwbGF0Zm9ybS4KKworICAgICAgICAqIGh0bWwvSFRNTFRleHRBcmVhRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50Ojp1cGRhdGVG b2N1c0FwcGVhcmFuY2UpOgorCiAyMDA4LTEyLTE3ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEu Z29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K SW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAJKHJldmlzaW9uIDM5MzcyKQor KysgV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMjksMTAgKzIyOSwxNyBAQCB2b2lkIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OnVwZGF0ZUZvY3Vz QXBwCiAgICAgQVNTRVJUKHJlbmRlcmVyKCkpOwogICAgIAogICAgIGlmICghcmVzdG9yZVByZXZp b3VzU2VsZWN0aW9uIHx8IG1fY2FjaGVkU2VsZWN0aW9uU3RhcnQgPCAwKSB7CisjaWYgRU5BQkxF KE9OX0ZJUlNUX1RFWFRBUkVBX0ZPQ1VTX1NFTEVDVF9BTEwpCisgICAgICAgIC8vIERldmljZXMg d2l0aCB0cmFja2JhbGxzIG9yIGQtcGFkcyBtYXkgZm9jdXMgb24gYSB0ZXh0YXJlYSBpbiByb3V0 ZQorICAgICAgICAvLyB0byBhbm90aGVyIGZvY3VzYWJsZSBub2RlLiBCeSBzZWxlY3RpbmcgYWxs IHRleHQsIHRoZSBuZXh0IG1vdmVtZW50CisgICAgICAgIC8vIGNhbiBtb3JlIHJlYWRpbHkgYmUg aW50ZXJwcmV0ZWQgYXMgbW92aW5nIHRvIHRoZSBuZXh0IG5vZGUuCisgICAgICAgIHNlbGVjdCgp OworI2Vsc2UKICAgICAgICAgLy8gSWYgdGhpcyBpcyB0aGUgZmlyc3QgZm9jdXMsIHNldCBhIGNh cmV0IGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIHRleHQuICAKICAgICAgICAgLy8gVGhpcyBtYXRj aGVzIHNvbWUgYnJvd3NlcnMnIGJlaGF2aW9yOyBzZWUgYnVnIDExNzQ2IENvbW1lbnQgIzE1Lgog ICAgICAgICAvLyBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc0NiNj MTUKICAgICAgICAgc2V0U2VsZWN0aW9uUmFuZ2UoMCwgMCk7CisjZW5kaWYKICAgICB9IGVsc2Ug ewogICAgICAgICAvLyBSZXN0b3JlIHRoZSBjYWNoZWQgc2VsZWN0aW9uLiAgVGhpcyBtYXRjaGVz IG90aGVyIGJyb3dzZXJzJyBiZWhhdmlvci4KICAgICAgICAgc2V0U2VsZWN0aW9uUmFuZ2UobV9j YWNoZWRTZWxlY3Rpb25TdGFydCwgbV9jYWNoZWRTZWxlY3Rpb25FbmQpOwo=