229161 2021-08-16 13:54:26 -0700 Ensure that unused LLInt opcodes are not inadvertently used. 2021-08-16 16:13:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1784641 0 mark.lam 2021-08-16 13:54:26 -0700 Patch coming. 1784644 1 435628 mark.lam 2021-08-16 13:57:50 -0700 Created attachment 435628 proposed patch. 1784648 2 435628 rmorisset 2021-08-16 14:13:42 -0700 Comment on attachment 435628 proposed patch. r=me 1784669 3 435635 mark.lam 2021-08-16 15:43:52 -0700 Created attachment 435635 proposed patch. 1784670 4 435635 rmorisset 2021-08-16 15:46:04 -0700 Comment on attachment 435635 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=435635&action=review r=me, thanks a lot for the better Changelog! > Source/JavaScriptCore/ChangeLog:27 > + currently emits nothing. As a result, if we ever have a bug that ends up typo: emits -> emit 1784680 5 mark.lam 2021-08-16 16:12:59 -0700 Thanks for the review. Landed in r281115: <http://trac.webkit.org/r281115>. 1784681 6 webkit-bug-importer 2021-08-16 16:13:21 -0700 <rdar://problem/82003176> 435628 2021-08-16 13:57:50 -0700 2021-08-16 15:43:52 -0700 proposed patch. bug-229161.patch text/plain 1150 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgxMTA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDIxLTA4LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF bnN1cmUgdGhhdCB1bnVzZWQgTExJbnQgb3Bjb2RlcyBhcmUgbm90IGluYWR2ZXJ0ZW50bHkgdXNl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTE2 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisKIDIwMjEtMDgtMTUgIFlpamlhIEh1YW5nICA8 eWlqaWFfaHVhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtBUk02NF0gQWRkIFByZS9Qb3N0LUlu ZGV4ZWQgQWRkcmVzcyBNb2RlIHRvIEFpciBmb3IgQVJNNjQgKFN0b3JlIEluc3RydWN0aW9uKQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbQkocmV2aXNpb24gMjgxMTA2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC00NTcsNyArNDU3 LDcgQEAgZW5kCiAKIG1hY3JvIG9wKGwsIGZuKQogICAgIGNvbW1vbk9wKGwsIG1hY3JvICgpIGVu ZCwgbWFjcm8gKHNpemUpCi0gICAgICAgIHNpemUoZm4sIG1hY3JvKCkgZW5kLCBtYWNybygpIGVu ZCwgbWFjcm8oZ2VuKSBnZW4oKSBlbmQpCisgICAgICAgIHNpemUoZm4sIG1hY3JvKCkgY3Jhc2go KSBlbmQsIG1hY3JvKCkgY3Jhc2goKSBlbmQsIG1hY3JvKGdlbikgZ2VuKCkgZW5kKQogICAgIGVu ZCkKIGVuZAogCg== 435635 2021-08-16 15:43:52 -0700 2021-08-16 15:46:04 -0700 proposed patch. bug-229161.patch text/plain 2419 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgxMTA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBA CisyMDIxLTA4LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF bnN1cmUgdGhhdCB1bnVzZWQgTExJbnQgb3Bjb2RlcyBhcmUgbm90IGluYWR2ZXJ0ZW50bHkgdXNl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTE2 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBv cCBtYWNybyBpcyB1c2VkIGZvciBnZW5lcmF0aW5nIExMSW50IGFzbSBjb2RlIGZvciBzb21lIGVu dHJ5IHBvaW50cyB0byB0aGUKKyAgICAgICAgTExJbnQsIHdoZXJlIHdlIGRvbid0IG5lZWQgMTYg Yml0cyBhbmQgMzIgYml0IHdpZGUgdmVyc2lvbnMgb2YgdGhlIGVudHJ5IHBvaW50LgorICAgICAg ICBGb3IgZXhhbXBsZSwgd2UgdXNlIGl0IGZvciBsbGludF9wcm9ncmFtX3Byb2xvZ3VlLgorCisg ICAgICAgIE5vdGUgdGhhdCBsbGludF9wcm9ncmFtX3Byb2xvZ3VlIGlzIGdlbmVyYXRlZCB1c2lu ZzoKKworICAgICAgICAgICAgb3AobGxpbnRfcHJvZ3JhbV9wcm9sb2d1ZSwgbWFjcm8gKCkgLi4u CisKKyAgICAgICAgd2hlcmUgb3AgaXM6CisKKyAgICAgICAgICAgIG1hY3JvIG9wKGwsIGZuKQor ICAgICAgICAgICAgICAgIGNvbW1vbk9wKGwsIG1hY3JvICgpIGVuZCwgbWFjcm8gKHNpemUpCisg ICAgICAgICAgICAgICAgICAgIHNpemUoZm4sIG1hY3JvKCkgZW5kLCBtYWNybygpIGVuZCwgbWFj cm8oZ2VuKSBnZW4oKSBlbmQpCisgICAgICAgICAgICAgICAgICAgICMgICAgICAgIF4gICAgICAg ICAgICBeLS0tLS0gd2lkZTMyIGdlbmVyYXRvcgorICAgICAgICAgICAgICAgICAgICAjICAgICAg ICBgLS0tLS0tLS0tLS0tLS0tLS0tIHdpZGUxNiBnZW5lcmF0b3IKKyAgICAgICAgICAgICAgICBl bmQpCisgICAgICAgICAgICBlbmQKKworICAgICAgICBOb3RlIHRoYXQgdGhlIGdlbmVyYXRvcnMg Zm9yIHRoZSB3aWRlMTYgYW5kIHdpZGUzMiB2ZXJzaW9ucyBvZiB0aGUgZW50cnkgcG9pbnQKKyAg ICAgICAgY3VycmVudGx5IGVtaXRzIG5vdGhpbmcuICBBcyBhIHJlc3VsdCwgaWYgd2UgZXZlciBo YXZlIGEgYnVnIHRoYXQgZW5kcyB1cAorICAgICAgICBkaXNwYXRjaGluZyB0byBsbGludF9wcm9n cmFtX3Byb2xvZ3VlX3dpZGUxNiBvciBsbGludF9wcm9ncmFtX3Byb2xvZ3VlX3dpZGUzMiwKKyAg ICAgICAgd2UnbGwgZW5kIHVwIGZhbGxpbmcgdGhydSB0byBsbGludF9tb2R1bGVfcHJvZ3JhbV9w cm9sb2d1ZSwgd2hpY2gganVzdCBoYXBwZW5zCisgICAgICAgIHRvIGJlIHRoZSBlbnRyeSBwb2lu dCBwb3NpdGlvbmVkIGFmdGVyIHRob3NlIGxhYmVscy4KKworICAgICAgICBUaGlzIHBhdGNoIGFk ZHMgYnJlYWtwb2ludHMgaW4gdGhvc2UgMiB1bnVzZWQgZ2VuZXJhdG9ycyBzbyB0aGF0IHdlIHdv bid0CisgICAgICAgIGluYWR2ZXJ0ZW50bHkgZXhlY3V0ZSBjb2RlIGZvciBzb21ldGhpbmcgZWxz ZS4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorCiAyMDIxLTA4 LTE1ICBZaWppYSBIdWFuZyAgPHlpamlhX2h1YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbQVJN NjRdIEFkZCBQcmUvUG9zdC1JbmRleGVkIEFkZHJlc3MgTW9kZSB0byBBaXIgZm9yIEFSTTY0IChT dG9yZSBJbnN0cnVjdGlvbikKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM ZXZlbEludGVycHJldGVyLmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20JKHJldmlzaW9uIDI4MTEwNikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkod29ya2luZyBj b3B5KQpAQCAtNDU3LDcgKzQ1Nyw3IEBAIGVuZAogCiBtYWNybyBvcChsLCBmbikKICAgICBjb21t b25PcChsLCBtYWNybyAoKSBlbmQsIG1hY3JvIChzaXplKQotICAgICAgICBzaXplKGZuLCBtYWNy bygpIGVuZCwgbWFjcm8oKSBlbmQsIG1hY3JvKGdlbikgZ2VuKCkgZW5kKQorICAgICAgICBzaXpl KGZuLCBtYWNybygpIGJyZWFrIGVuZCwgbWFjcm8oKSBicmVhayBlbmQsIG1hY3JvKGdlbikgZ2Vu KCkgZW5kKQogICAgIGVuZCkKIGVuZAogCg==