229135 2021-08-16 04:31:47 -0700 Make most pseudo elements with display: contents; compute display value to inline by default 2025-05-11 12:13:07 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified NEW https://github.com/w3c/csswg-drafts/issues/6518 InRadar P2 Normal --- 1 ntim webkit-unassigned ahmad.saleem792 koivisto webkit-bug-importer oldest_to_newest 1784463 0 ntim 2021-08-16 04:31:47 -0700 Except ::before/::after/::file-selector-button where display: contents should just work. Except ::backdrop where it should compute to block (though this will be handled along with the backdrop + top layer implementation). 1784464 1 ntim 2021-08-16 04:32:03 -0700 See also: https://github.com/w3c/csswg-drafts/issues/6518 1786392 2 webkit-bug-importer 2021-08-23 04:32:15 -0700 <rdar://problem/82239251> 1804740 3 441352 ntim 2021-10-15 02:05:21 -0700 Created attachment 441352 Patch 1804744 4 koivisto 2021-10-15 02:37:37 -0700 this needs a test 1804761 5 ntim 2021-10-15 04:12:36 -0700 (In reply to Antti Koivisto from comment #4) > this needs a test Do you know where this case is ever reached? I'm tempted to remove the block if it isn't reached. 1804773 6 koivisto 2021-10-15 05:37:34 -0700 > Do you know where this case is ever reached? I'm tempted to remove the block > if it isn't reached. No, but I would expect that the person who wants to change the code does. 1804818 7 ntim 2021-10-15 08:25:16 -0700 Will look into this when I have more time. 2116368 8 ahmad.saleem792 2025-05-11 12:13:07 -0700 is it now Not Applicable since Gecko has bug filed against it? https://bugzilla.mozilla.org/show_bug.cgi?id=1418138 This part - style.setEffectiveDisplay(DisplayType::Inline); Don't know about: if (isInTopLayerOrBackdrop(style, m_element) || m_document.documentElement() == m_element) 441352 2021-10-15 02:05:21 -0700 2021-10-15 08:25:30 -0700 Patch bug-229135-20211015110520.patch text/plain 1900 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRmNDA3MDc5NTFmZjFj NTAxNGFhZGUxMzRmNzFmOTkyYTc1MWVlOS4uZjZhMDE5Y2RkNDFmY2VmYWNlZjgyMWQ4MWU3ZjBl NzdlY2EyNzQ3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTE1ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBkZWZhdWx0IGBkaXNwbGF5 OiBjb250ZW50c2Agc3R5bGUgZm9yIHBzZXVkbyBlbGVtZW50cyBgZGlzcGxheTogaW5saW5lYAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MTM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90IHN1cmUg aW4gd2hpY2ggY2FzZSB0aGlzIGlzIHJlYWNoZWQsIGJ1dCBgZGlzcGxheTogaW5saW5lO2AgaXMg YSBiZXR0ZXIgZml0IHRoYW4gaGlkaW5nCisgICAgICAgIHRoZSBlbGVtZW50IGNvbXBsZXRlbHku IEFsc28gbWF0Y2hlcyBGaXJlZm94J3MgZGVmYXVsdC4KKworICAgICAgICAqIHN0eWxlL1N0eWxl QWRqdXN0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OkFkanVzdGVyOjphZGp1c3RE aXNwbGF5Q29udGVudHNTdHlsZSBjb25zdCk6CisKIDIwMjEtMTAtMTQgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRnVydGhlciBhZGp1c3Qgc3R5bGUg b2YgYWx0ZXJuYXRlIGZvcm0gY29udHJvbCBkZXNpZ24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3N0eWxlL1N0eWxlQWRqdXN0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVB ZGp1c3Rlci5jcHAKaW5kZXggMTVhNGI3Mzk1MGZhNDgyNjVlNzhmMjkyNzI1OTAzNmY3MWI3YjY3 MS4uOGU4NzAyOGEwZjM3NjMwNGYyMGIyOWNmYjYwOGUzMDZiODJlYTYyMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVBZGp1c3Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvc3R5bGUvU3R5bGVBZGp1c3Rlci5jcHAKQEAgLTU5NiwxNCArNTk2LDEzIEBAIHN0YXRpYyBi b29sIGhhc0VmZmVjdGl2ZURpc3BsYXlOb25lRm9yRGlzcGxheUNvbnRlbnRzKGNvbnN0IEVsZW1l bnQmIGVsZW1lbnQpCiAKIHZvaWQgQWRqdXN0ZXI6OmFkanVzdERpc3BsYXlDb250ZW50c1N0eWxl KFJlbmRlclN0eWxlJiBzdHlsZSkgY29uc3QKIHsKLSAgICBib29sIGlzSW5Ub3BMYXllciA9IGlz SW5Ub3BMYXllck9yQmFja2Ryb3Aoc3R5bGUsIG1fZWxlbWVudCk7Ci0gICAgaWYgKGlzSW5Ub3BM YXllciB8fCBtX2RvY3VtZW50LmRvY3VtZW50RWxlbWVudCgpID09IG1fZWxlbWVudCkgeworICAg IGlmIChpc0luVG9wTGF5ZXJPckJhY2tkcm9wKHN0eWxlLCBtX2VsZW1lbnQpIHx8IG1fZG9jdW1l bnQuZG9jdW1lbnRFbGVtZW50KCkgPT0gbV9lbGVtZW50KSB7CiAgICAgICAgIHN0eWxlLnNldEVm ZmVjdGl2ZURpc3BsYXkoRGlzcGxheVR5cGU6OkJsb2NrKTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KIAogICAgIGlmICghbV9lbGVtZW50ICYmIHN0eWxlLnN0eWxlVHlwZSgpICE9IFBzZXVkb0lk OjpCZWZvcmUgJiYgc3R5bGUuc3R5bGVUeXBlKCkgIT0gUHNldWRvSWQ6OkFmdGVyKSB7Ci0gICAg ICAgIHN0eWxlLnNldEVmZmVjdGl2ZURpc3BsYXkoRGlzcGxheVR5cGU6Ok5vbmUpOworICAgICAg ICBzdHlsZS5zZXRFZmZlY3RpdmVEaXNwbGF5KERpc3BsYXlUeXBlOjpJbmxpbmUpOwogICAgICAg ICByZXR1cm47CiAgICAgfQogCg==