229134 2021-08-16 04:31:25 -0700 [GLib] Enable mediastream setting if it's enabled at build-time 2021-08-16 09:18:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand aperez berto bugs-noreply cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1784462 0 pnormand 2021-08-16 04:31:25 -0700 https://bugs.webkit.org/show_bug.cgi?id=217991#c15 : > My concern here is that these APIs will be public, but they won't do anything in releases until it no longer depends on ${ENABLE_EXPERIMENTAL_FEATURES}. Reminds me of the broken webkit_settings_[g,s]et_media_stream() API, which has been exposed since WebKitGTK 2.4, but has never worked in releases because media stream is still disabled at build time. What I would do instead is enable the setting at runtime so that the public API isn't required for testing it. Then in the future when we're finally ready to enable media session in releases, that's when we would want to add these APIs. So if this is enabled at build-time, maybe we should enable it by default at runtime? wdyt Michael? 1784466 1 435589 pnormand 2021-08-16 04:33:26 -0700 Created attachment 435589 Patch 1784467 2 ews-watchlist 2021-08-16 04:34:14 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1784505 3 mcatanzaro 2021-08-16 08:18:12 -0700 (In reply to Philippe Normand from comment #0) > So if this is enabled at build-time, maybe we should enable it by default at > runtime? wdyt Michael? Yes please, this is exactly what I suggested! 1784507 4 pnormand 2021-08-16 08:22:49 -0700 Ah, I forgot to check the API tests. 1784512 5 435605 pnormand 2021-08-16 08:33:26 -0700 Created attachment 435605 Patch 1784533 6 ews-feeder 2021-08-16 09:18:53 -0700 Committed r281085 (240545@main): <https://commits.webkit.org/240545@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435605. 435589 2021-08-16 04:33:26 -0700 2021-08-16 08:33:21 -0700 Patch bug-229134-20210816043324.patch text/plain 1718 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1NDdhOWM2ZTIxMzg3ZGRh NjExYTNkNTJiNTdjZGNkNzVkZjI4OGIuLmJhMDk4NTIyMjhmOTBkMWQ3MjIyMGY2ODE0NzA2Mjc1 MzU0ZjY3OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDgtMTYgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTGliXSBFbmFibGUg bWVkaWFzdHJlYW0gc2V0dGluZyBpZiBpdCdzIGVuYWJsZWQgYXQgYnVpbGQtdGltZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MTM0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwOgorICAgICAgICAod2ViS2l0U2V0dGluZ3NDb25zdHJ1 Y3RlZCk6CisKIDIwMjEtMDgtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RLLmNtYWtlIGFu ZCBORVdTIGZvciAyLjMzLjMgcmVsZWFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDlmYTI0YmJjNzBlMDEwZWU2NzMz ZDc5MmY4NmNiNjVjNzJhNTZjMGUuLjc1N2U2ZDk4MjdlYTgxMTA3YmM4YzdmYTJlOGMyOWZmMmIw MDZiYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp dFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRTZXR0aW5ncy5jcHAKQEAgLTE4OSw5ICsxODksMTMgQEAgc3RhdGljIHZvaWQgd2ViS2l0U2V0 dGluZ3NDb25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCiAgICAgV2ViUHJlZmVyZW5jZXMqIHBy ZWZzID0gc2V0dGluZ3MtPnByaXYtPnByZWZlcmVuY2VzLmdldCgpOwogICAgIHByZWZzLT5zZXRT aG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbih0cnVlKTsKIAotICAgIGJvb2wgbWVkaWFTdHJl YW1FbmFibGVkID0gcHJlZnMtPm1lZGlhU3RyZWFtRW5hYmxlZCgpOwotICAgIHByZWZzLT5zZXRN ZWRpYURldmljZXNFbmFibGVkKG1lZGlhU3RyZWFtRW5hYmxlZCk7Ci0gICAgcHJlZnMtPnNldFBl ZXJDb25uZWN0aW9uRW5hYmxlZChtZWRpYVN0cmVhbUVuYWJsZWQpOworI2lmIEVOQUJMRShNRURJ QV9TVFJFQU0pCisgICAgcHJlZnMtPnNldE1lZGlhRGV2aWNlc0VuYWJsZWQodHJ1ZSk7CisgICAg cHJlZnMtPnNldE1lZGlhU3RyZWFtRW5hYmxlZCh0cnVlKTsKKyNpZiBFTkFCTEUoV0VCX1JUQykK KyAgICBwcmVmcy0+c2V0UGVlckNvbm5lY3Rpb25FbmFibGVkKHRydWUpOworI2VuZGlmCisjZW5k aWYKIH0KIAogc3RhdGljIHZvaWQgd2ViS2l0U2V0dGluZ3NTZXRQcm9wZXJ0eShHT2JqZWN0KiBv YmplY3QsIGd1aW50IHByb3BJZCwgY29uc3QgR1ZhbHVlKiB2YWx1ZSwgR1BhcmFtU3BlYyogcGFy YW1TcGVjKQo= 435605 2021-08-16 08:33:26 -0700 2021-08-16 09:18:55 -0700 Patch bug-229134-20210816083325.patch text/plain 3546 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhZDgxMmIwOGM4M2NiYTI3 ZWMyNmJkNThkMTQ1YWRmYjI1ZTQ0ZTkuLjBhYzkxODkyOGJhNjIwNTA5YWU1NzYyYzJmNzAwZGVm NzE5MDg4YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDgtMTYgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTGliXSBFbmFibGUg bWVkaWFzdHJlYW0gc2V0dGluZyBpZiBpdCdzIGVuYWJsZWQgYXQgYnVpbGQtdGltZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MTM0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgQWRyaWFuIFBlcmV6IGRlIENhc3Ryby4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJLaXRTZXR0aW5n c0NvbnN0cnVjdGVkKToKKwogMjAyMS0wOC0xNiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5k QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTWluaUJyb3dzZXIgY3Jhc2hlcyB3aGVuIGNs b3NlZCB3aGlsZSBjYXB0dXJpbmcgZGVza3RvcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDlmYTI0YmJjNzBlMDEwZWU2 NzMzZDc5MmY4NmNiNjVjNzJhNTZjMGUuLjc1N2U2ZDk4MjdlYTgxMTA3YmM4YzdmYTJlOGMyOWZm MmIwMDZiYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTE4OSw5ICsxODksMTMgQEAgc3RhdGljIHZvaWQgd2ViS2l0 U2V0dGluZ3NDb25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCiAgICAgV2ViUHJlZmVyZW5jZXMq IHByZWZzID0gc2V0dGluZ3MtPnByaXYtPnByZWZlcmVuY2VzLmdldCgpOwogICAgIHByZWZzLT5z ZXRTaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbih0cnVlKTsKIAotICAgIGJvb2wgbWVkaWFT dHJlYW1FbmFibGVkID0gcHJlZnMtPm1lZGlhU3RyZWFtRW5hYmxlZCgpOwotICAgIHByZWZzLT5z ZXRNZWRpYURldmljZXNFbmFibGVkKG1lZGlhU3RyZWFtRW5hYmxlZCk7Ci0gICAgcHJlZnMtPnNl dFBlZXJDb25uZWN0aW9uRW5hYmxlZChtZWRpYVN0cmVhbUVuYWJsZWQpOworI2lmIEVOQUJMRShN RURJQV9TVFJFQU0pCisgICAgcHJlZnMtPnNldE1lZGlhRGV2aWNlc0VuYWJsZWQodHJ1ZSk7Cisg ICAgcHJlZnMtPnNldE1lZGlhU3RyZWFtRW5hYmxlZCh0cnVlKTsKKyNpZiBFTkFCTEUoV0VCX1JU QykKKyAgICBwcmVmcy0+c2V0UGVlckNvbm5lY3Rpb25FbmFibGVkKHRydWUpOworI2VuZGlmCisj ZW5kaWYKIH0KIAogc3RhdGljIHZvaWQgd2ViS2l0U2V0dGluZ3NTZXRQcm9wZXJ0eShHT2JqZWN0 KiBvYmplY3QsIGd1aW50IHByb3BJZCwgY29uc3QgR1ZhbHVlKiB2YWx1ZSwgR1BhcmFtU3BlYyog cGFyYW1TcGVjKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IGE5MzJkNzBlYTJjODhjNzE5NWU5YTY1NDhlNjgyYmQ3MzY3OTMwYjQuLjQwYmYyZWNh YmZjZjM0ZmFmNWJmNzcwY2RhZjEzMWU1OGZiY2IwODUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0wOC0xNiAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMaWJd IEVuYWJsZSBtZWRpYXN0cmVhbSBzZXR0aW5nIGlmIGl0J3MgZW5hYmxlZCBhdCBidWlsZC10aW1l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkxMzQK KworICAgICAgICBSZXZpZXdlZCBieSBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHA6 CisgICAgICAgICh0ZXN0V2ViS2l0U2V0dGluZ3MpOgorCiAyMDIxLTA4LTE2ICBEYXZpZCBLaWx6 ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IEFTYW4rVUJTYW4gYnVpbGRz IHdpdGggWGNvZGUgMTMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0R0xpYi9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRHTGliL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggOWM5NjE3MjNlZGY3M2U2 OWNkYjJlOTQyYTlhYjgxNjRkM2IzNmZiMy4uY2ZhNzI0MjEyODcyNmZkN2M0YzY3ZWVlZTc3N2Ji M2Y1NTI1MTk4OCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRH TGliL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRHTGliL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTI4NiwxMCArMjg2LDEwIEBA IHN0YXRpYyB2b2lkIHRlc3RXZWJLaXRTZXR0aW5ncyhUZXN0KiwgZ2NvbnN0cG9pbnRlcikKICAg ICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV93cml0ZV9jb25zb2xlX21lc3NhZ2VzX3RvX3N0 ZG91dChzZXR0aW5ncywgVFJVRSk7CiAgICAgZ19hc3NlcnRfdHJ1ZSh3ZWJraXRfc2V0dGluZ3Nf Z2V0X2VuYWJsZV93cml0ZV9jb25zb2xlX21lc3NhZ2VzX3RvX3N0ZG91dChzZXR0aW5ncykpOwog Ci0gICAgLy8gTWVkaWFTdHJlYW0gaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KLSAgICBnX2Fzc2Vy dF9mYWxzZSh3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV9tZWRpYV9zdHJlYW0oc2V0dGluZ3Mp KTsKLSAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9tZWRpYV9zdHJlYW0oc2V0dGluZ3Ms IFRSVUUpOworICAgIC8vIE1lZGlhU3RyZWFtIGlzIGVuYWJsZWQgYnkgZGVmYXVsdCBhcyBleHBl cmltZW50YWwgZmVhdHVyZS4KICAgICBnX2Fzc2VydF90cnVlKHdlYmtpdF9zZXR0aW5nc19nZXRf ZW5hYmxlX21lZGlhX3N0cmVhbShzZXR0aW5ncykpOworICAgIHdlYmtpdF9zZXR0aW5nc19zZXRf ZW5hYmxlX21lZGlhX3N0cmVhbShzZXR0aW5ncywgRkFMU0UpOworICAgIGdfYXNzZXJ0X2ZhbHNl KHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX21lZGlhX3N0cmVhbShzZXR0aW5ncykpOwogCiAg ICAgLy8gQnkgZGVmYXVsdCwgU3BhdGlhbE5hdmlnYXRpb24gaXMgZGlzYWJsZWQKICAgICBnX2Fz c2VydF9mYWxzZSh3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV9zcGF0aWFsX25hdmlnYXRpb24o c2V0dGluZ3MpKTsK