22913 2008-12-18 01:31:08 -0800 REGRESSION: Space bar doesn't scroll on windows 2009-01-14 10:03:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://www.apple.com/ HasReduction, InRadar P2 Normal --- 1 abarth darin abarth darin m0.interactive oldest_to_newest 102873 0 abarth 2008-12-18 01:31:08 -0800 Steps to reproduce: 1) Visit any page with a vertical scroll bar 2) Press the space button Expected result: Page scrolls down Actual result: Nothing happens This does not appear to reproduce on Mac. Sorry, I don't have a good regression window for this, but its amazingly annoying. 104434 1 wexler 2009-01-05 08:46:34 -0800 Related at all to https://bugs.webkit.org/show_bug.cgi?id=18030? 104527 2 mrowe 2009-01-05 21:13:48 -0800 No, bug 18030 was a Mac-only regression and was addressed 10 months ago. 104531 3 m0.interactive 2009-01-05 22:19:24 -0800 (In reply to comment #1) > Related at all to https://bugs.webkit.org/show_bug.cgi?id=18030? > The other one was 10 month ago, this bug revived from the dead :) BTW with the help of bdash on IRC, I have checked all the nightly builds "almost" to see when the regression happened. FAILS in r38705 2008-11-24 CRASH in r38677 2008-11-22 CRASH in r38672 2008-11-22 CRASH in r38670 2008-11-21 CRASH in r38651 2008-11-21 WORKS in r38492 2008-11-17 FAILS means that the space bar doesn't scroll on windows WORKS means that the space bar does scroll on windows CRASH means that I cannot run that nightly build due to incompatible versions, I tried Safari 3.2.1 and 3.1.2. Basically it worked and 4 builds after it broke. I can look into it tomorrow to see the diffs of the affected files, unless someone else more experienced in those areas can figure it out. Phew, my testing is over, time to sleep :) Binary Search 18 nightly builds to get those results. I hope this could be of any help to start figuring out this annoying bug. 104602 4 26466 m0.interactive 2009-01-06 12:29:56 -0800 Created attachment 26466 Fixing the bug Between 38629 and 38410 for Editor.cpp it broke space scroll. This patch is to revert the change. And I tested it, and works fine as it should be. 104809 5 mrowe 2009-01-07 16:36:49 -0800 <rdar://problem/6479834> 104810 6 mrowe 2009-01-07 16:38:00 -0800 Darin, it sounds like your change in <http://trac.webkit.org/changeset/38629> caused this. 105089 7 26584 darin 2009-01-09 16:23:21 -0800 Created attachment 26584 patch 105091 8 darin 2009-01-09 16:42:27 -0800 http://trac.webkit.org/changeset/39771 105092 9 26584 darin 2009-01-09 16:42:39 -0800 Comment on attachment 26584 patch Jon Honeycutt reviewed this. 105687 10 abarth 2009-01-14 09:48:35 -0800 The space bar is still broken. Now the window scrolls even if you are entering text into an input box. Test case: 1) Search for "dog" on google. 2) Type a space in the search box on the top of the page. Notice that he window scrolls instead of putting the space in the box. 105690 11 darin 2009-01-14 09:57:58 -0800 (In reply to comment #10) > The space bar is still broken. Now the window scrolls even if you are entering > text into an input box. Test case: > > 1) Search for "dog" on google. > 2) Type a space in the search box on the top of the page. > > Notice that he window scrolls instead of putting the space in the box. Yes, others noticed that and opened a new bug about it, bug 23277, which is now fixed. Could you try testing again? 105694 12 abarth 2009-01-14 10:03:02 -0800 (In reply to comment #11) > Could you try testing again? Oh, ok. I was testing with the nightly which missed that fix by 10 revisions. 26466 2009-01-06 12:29:56 -0800 2009-01-09 16:23:21 -0800 Fixing the bug spacescrollfix.patch text/plain 712 m0.interactive SW5kZXg6IEVkaXRvci5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBFZGl0b3IuY3BwCShyZXZpc2lvbiAz OTQzNykNCisrKyBFZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTAxLDEzICsxMDEsMTUg QEANCiB2b2lkIEVkaXRvcjo6aGFuZGxlS2V5Ym9hcmRFdmVudChLZXlib2FyZEV2ZW50KiBldmVu dCkKIHsKICAgICBpZiAoRWRpdG9yQ2xpZW50KiBjID0gY2xpZW50KCkpCi0gICAgICAgIGMtPmhh bmRsZUtleWJvYXJkRXZlbnQoZXZlbnQpOworICAgICAgICBpZiAoc2VsZWN0aW9uRm9yQ29tbWFu ZChldmVudCkuaXNDb250ZW50RWRpdGFibGUoKSkKKyAgICAgICAgICAgIGMtPmhhbmRsZUtleWJv YXJkRXZlbnQoZXZlbnQpOwogfQogCiB2b2lkIEVkaXRvcjo6aGFuZGxlSW5wdXRNZXRob2RLZXlk b3duKEtleWJvYXJkRXZlbnQqIGV2ZW50KQogewogICAgIGlmIChFZGl0b3JDbGllbnQqIGMgPSBj bGllbnQoKSkKLSAgICAgICAgYy0+aGFuZGxlSW5wdXRNZXRob2RLZXlkb3duKGV2ZW50KTsKKyAg ICAgICAgaWYgKHNlbGVjdGlvbkZvckNvbW1hbmQoZXZlbnQpLmlzQ29udGVudEVkaXRhYmxlKCkp CisgICAgICAgICAgICBjLT5oYW5kbGVJbnB1dE1ldGhvZEtleWRvd24oZXZlbnQpOwogfQogCiBi b29sIEVkaXRvcjo6Y2FuRWRpdCgpIGNvbnN0Cg== 26584 2009-01-09 16:23:21 -0800 2009-01-09 16:42:39 -0800 patch SpaceBarPatch.txt text/plain 5670 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTc2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMDEtMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy MjkxMzogUkVHUkVTU0lPTjogU3BhY2UgYmFyIGRvZXNuJ3Qgc2Nyb2xsIG9uIHdpbmRvd3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTEzCisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzY0Nzk4MzQKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGVmYXVsdEtleWJvYXJkRXZl bnRIYW5kbGVyKTogQWRkZWQgY29kZSB0byBjYWxsCisgICAgICAgIGRlZmF1bHRTcGFjZUV2ZW50 SGFuZGxlci4KKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGVmYXVsdFNwYWNlRXZl bnRIYW5kbGVyKTogQWRkZWQuIFNjcm9sbHMgZG93biBvciB1cCBiYXNlZAorICAgICAgICBvbiB0 aGUgc2hpZnQga2V5LgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6IEFkZGVkIGRlZmF1 bHRTcGFjZUV2ZW50SGFuZGxlci4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxWaWV3 TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cGxhdGZvcm1TY3JvbGwpOiBS ZXR1cm4gZmFsc2UsIGJlY2F1c2UgdGhpcyBmdW5jdGlvbiBkb2VzCisgICAgICAgIG5vdCBzY3Jv bGwuIEluIGFuIGVhcmxpZXIgdmVyc2lvbiBvZiB0aGlzIHBhdGNoLCBJIHVzZWQgdGhpcyB0byBw cmV2ZW50IHRoZQorICAgICAgICBwYXRjaCBmcm9tIGFmZmVjdGluZyB0aGUgTWFjLCBidXQgSSBk ZWNpZGVkIHRvIHVzZSAjaWYgaW5zdGVhZC4KKwogMjAwOS0wMS0wOSAgR2F2aW4gQmFycmFjbG91 Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVy IEh1bnQuCkluZGV4OiBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkocmV2aXNpb24gMzk3NjkpCisrKyBXZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg3Nyw4ICsxODc3 LDExIEBAIHZvaWQgRXZlbnRIYW5kbGVyOjpkZWZhdWx0S2V5Ym9hcmRFdmVudEgKICAgICAgICAg bV9mcmFtZS0+ZWRpdG9yKCktPmhhbmRsZUtleWJvYXJkRXZlbnQoZXZlbnQpOwogICAgICAgICBp ZiAoZXZlbnQtPmRlZmF1bHRIYW5kbGVkKCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAg IGlmIChldmVudC0+a2V5SWRlbnRpZmllcigpID09ICJVKzAwMDkiKQorICAgICAgICBjb25zdCBT dHJpbmcmIGtleUlkZW50aWZpZXIgPSBldmVudC0+a2V5SWRlbnRpZmllcigpOworICAgICAgICBp ZiAoa2V5SWRlbnRpZmllciA9PSAiVSswMDA5IikKICAgICAgICAgICAgIGRlZmF1bHRUYWJFdmVu dEhhbmRsZXIoZXZlbnQpOworICAgICAgICBlbHNlIGlmIChrZXlJZGVudGlmaWVyID09ICJVKzAw MjAiKQorICAgICAgICAgICAgZGVmYXVsdFNwYWNlRXZlbnRIYW5kbGVyKGV2ZW50KTsKIAogICAg ICAgIC8vIHByb3ZpZGVzIEtCIG5hdmlnYXRpb24gYW5kIHNlbGVjdGlvbiBmb3IgZW5oYW5jZWQg YWNjZXNzaWJpbGl0eSB1c2VycwogICAgICAgIGlmIChBWE9iamVjdENhY2hlOjphY2Nlc3NpYmls aXR5RW5oYW5jZWRVc2VySW50ZXJmYWNlRW5hYmxlZCgpKQpAQCAtMjE0Niw2ICsyMTQ5LDM2IEBA IHZvaWQgRXZlbnRIYW5kbGVyOjpkZWZhdWx0VGV4dElucHV0RXZlbnQKICAgICB9CiB9CiAKKyNp ZiBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oTUFDKQorCisvLyBUaGVzZSB0d28gcGxhdGZvcm1z IGhhbmRsZSB0aGUgc3BhY2UgZXZlbnQgaW4gdGhlIHBsYXRmb3JtLXNwZWNpZmljIFdlYktpdCBj b2RlLgorLy8gRXZlbnR1YWxseSBpdCB3b3VsZCBiZSBnb29kIHRvIGVsaW1pbmF0ZSB0aGF0IGFu ZCB1c2UgdGhlIGNvZGUgaGVyZSBpbnN0ZWFkLCBidXQKKy8vIHRoZSBRdCB2ZXJzaW9uIGlzIGlu c2lkZSBhbiBpZmRlZiBhbmQgdGhlIE1hYyB2ZXJzaW9uIGhhcyBzb21lIGV4dHJhIGJlaGF2aW9y CisvLyBzbyB3ZSBjYW4ndCB1bmlmeSBldmVyeXRoaW5nIHlldC4KK3ZvaWQgRXZlbnRIYW5kbGVy OjpkZWZhdWx0U3BhY2VFdmVudEhhbmRsZXIoS2V5Ym9hcmRFdmVudCopCit7Cit9CisKKyNlbHNl CisKK3ZvaWQgRXZlbnRIYW5kbGVyOjpkZWZhdWx0U3BhY2VFdmVudEhhbmRsZXIoS2V5Ym9hcmRF dmVudCogZXZlbnQpCit7CisgICAgU2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiA9IGV2ZW50LT5z aGlmdEtleSgpID8gU2Nyb2xsVXAgOiBTY3JvbGxEb3duOworICAgIGlmIChzY3JvbGxPdmVyZmxv dyhkaXJlY3Rpb24sIFNjcm9sbEJ5UGFnZSkpIHsKKyAgICAgICAgZXZlbnQtPnNldERlZmF1bHRI YW5kbGVkKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBGcmFtZVZpZXcqIHZpZXcg PSBtX2ZyYW1lLT52aWV3KCk7CisgICAgaWYgKCF2aWV3KQorICAgICAgICByZXR1cm47CisKKyAg ICBpZiAodmlldy0+c2Nyb2xsKGRpcmVjdGlvbiwgU2Nyb2xsQnlQYWdlKSkKKyAgICAgICAgZXZl bnQtPnNldERlZmF1bHRIYW5kbGVkKCk7Cit9CisKKyNlbmRpZgorCiB2b2lkIEV2ZW50SGFuZGxl cjo6ZGVmYXVsdFRhYkV2ZW50SGFuZGxlcihLZXlib2FyZEV2ZW50KiBldmVudCkKIHsKICAgICAv LyBXZSBzaG91bGQgb25seSBhZHZhbmNlIGZvY3VzIG9uIHRhYnMgaWYgbm8gc3BlY2lhbCBtb2Rp ZmllciBrZXlzIGFyZSBoZWxkIGRvd24uCkluZGV4OiBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCShyZXZpc2lvbiAz OTc2OSkKKysrIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkod29ya2luZyBjb3B5KQpAQCAt MjY1LDYgKzI2NSw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBwYXNzTW91c2VEb3duRXZlbnRUb1dp ZGdldChXaWRnZXQqKTsKICAgICBib29sIHBhc3NXaGVlbEV2ZW50VG9XaWRnZXQoUGxhdGZvcm1X aGVlbEV2ZW50JiwgV2lkZ2V0Kik7CiAKKyAgICB2b2lkIGRlZmF1bHRTcGFjZUV2ZW50SGFuZGxl cihLZXlib2FyZEV2ZW50Kik7CiAgICAgdm9pZCBkZWZhdWx0VGFiRXZlbnRIYW5kbGVyKEtleWJv YXJkRXZlbnQqKTsKIAogICAgIHZvaWQgYWxsb3dESFRNTERyYWcoYm9vbCYgZmxhZ0RIVE1MLCBi b29sJiBmbGFnVUEpIGNvbnN0OwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsVmll d01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxWaWV3TWFj Lm1tCShyZXZpc2lvbiAzOTc2OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbFZpZXdN YWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE1Nyw3ICsxNTcsNyBAQCBib29sIFNjcm9sbFZpZXc6 OnBsYXRmb3JtU2Nyb2xsKFNjcm9sbERpCiB7CiAgICAgLy8gRklYTUU6IEl0IHdvdWxkIGJlIG5p Y2UgdG8gaW1wbGVtZW50IHRoaXMgc28gdGhhdCBhbGwgb2YgdGhlIGNvZGUgaW4gV2ViRnJhbWVW aWV3IGNvdWxkIGdvIGF3YXkuCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gdHJ1 ZTsKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIHZvaWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1SZXBh aW50Q29udGVudFJlY3RhbmdsZShjb25zdCBJbnRSZWN0JiByZWN0LCBib29sIG5vdykKSW5kZXg6 IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTc2OSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1 ZyAyMjkxMzogUkVHUkVTU0lPTjogU3BhY2UgYmFyIGRvZXNuJ3Qgc2Nyb2xsIG9uIHdpbmRvd3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTEzCisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzY0Nzk4MzQKKworICAgICAgICAqIFdlYlZpZXcuY3BwOgor ICAgICAgICAoV2ViVmlldzo6a2V5UHJlc3MpOiBSZW1vdmVkIGNvZGUgdG8gaGFuZGxlIHNwYWNl IGJhciBoZXJlOyBwdXQgaXQgaW4KKyAgICAgICAgV2ViQ29yZSBpbnN0ZWFkLgorCiAyMDA5LTAx LTA5ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AZ21haWwuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDM5NzY5KQorKysgV2ViS2l0 L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYwNiwxNyArMTYwNiw3IEBAIGJv b2wgV2ViVmlldzo6a2V5UHJlc3MoV1BBUkFNIGNoYXJDb2RlLCAKICAgICAvLyBJRSBkb2VzIG5v dCBkaXNwYXRjaCBrZXlwcmVzcyBldmVudCBmb3IgV01fU1lTQ0hBUi4KICAgICBpZiAoc3lzdGVt S2V5RG93bikKICAgICAgICAgcmV0dXJuIGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlQWNj ZXNzS2V5KGtleUV2ZW50KTsKLSAgICBpZiAoZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5rZXlFdmVu dChrZXlFdmVudCkpCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0gICAgLy8gTmVlZCB0byBzY3Jv bGwgdGhlIHBhZ2UgaWYgc3BhY2UgaXMgaGl0LgotICAgIGlmIChjaGFyQ29kZSA9PSAnICcpIHsK LSAgICAgICAgU2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiA9IGtleUV2ZW50LnNoaWZ0S2V5KCkg PyBTY3JvbGxVcCA6IFNjcm9sbERvd247Ci0gICAgICAgIGlmICghZnJhbWUtPmV2ZW50SGFuZGxl cigpLT5zY3JvbGxPdmVyZmxvdyhkaXJlY3Rpb24sIFNjcm9sbEJ5UGFnZSkpCi0gICAgICAgICAg ICBmcmFtZS0+dmlldygpLT5zY3JvbGwoZGlyZWN0aW9uLCBTY3JvbGxCeVBhZ2UpOwotICAgICAg ICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBmcmFt ZS0+ZXZlbnRIYW5kbGVyKCktPmtleUV2ZW50KGtleUV2ZW50KTsKIH0KIAogYm9vbCBXZWJWaWV3 OjppblJlc2l6ZXIoTFBBUkFNIGxQYXJhbSkK