229125 2021-08-15 11:01:01 -0700 [LFC Display] Make Display::ImageBox a CachedImageClient to get image repaint working 2021-08-15 13:47:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1784396 0 simon.fraser 2021-08-15 11:01:01 -0700 [LFC Display] Make Display::ImageBox a CachedImageClient to get image repaint working 1784397 1 435569 simon.fraser 2021-08-15 11:03:04 -0700 Created attachment 435569 Patch 1784406 2 ews-feeder 2021-08-15 13:46:26 -0700 Committed r281067 (240528@main): <https://commits.webkit.org/240528@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435569. 1784407 3 webkit-bug-importer 2021-08-15 13:47:16 -0700 <rdar://problem/81959456> 435569 2021-08-15 11:03:04 -0700 2021-08-15 13:46:27 -0700 Patch bug-229125-20210815110303.patch text/plain 5915 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU0NjJhYThmN2Q2NjFh OTBlYTk1MjkxMGE5M2IzNmM0MWZjZmQ3NS4uY2Y2MzNlZTFhMDhlM2YxNGE5ZDgzYmUwNDk5NWZh ZDI5ZTY0ZjZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTA4LTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtMRkMgRGlzcGxh eV0gTWFrZSBEaXNwbGF5OjpJbWFnZUJveCBhIENhY2hlZEltYWdlQ2xpZW50IHRvIGdldCBpbWFn ZSByZXBhaW50IHdvcmtpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyOTEyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1ha2UgRGlzcGxheTo6SW1hZ2VCb3ggaG9sZCBhIENhY2hlZFJlc291cmNlSGFu ZGxlPENhY2hlZEltYWdlPiBzbyBpdCBjYW4gcmVnaXN0ZXIKKyAgICAgICAgYXMgYSBjbGllbnQg YW5kIGdldCBub3RpZmllZCBhYm91dCBpbWFnZSBjaGFuZ2VzLCBmb3IgcmVwYWludGluZy4KKwor ICAgICAgICAqIGRpc3BsYXkvY3NzL0Rpc3BsYXlCb3hGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRpc3BsYXk6OkJveEZhY3Rvcnk6OmRpc3BsYXlCb3hGb3JMYXlvdXRCb3ggY29uc3Qp OgorICAgICAgICAqIGRpc3BsYXkvY3NzL0Rpc3BsYXlJbWFnZUJveC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEaXNwbGF5OjpJbWFnZUJveDo6SW1hZ2VCb3gpOgorICAgICAgICAoV2ViQ29yZTo6 RGlzcGxheTo6bV9jYWNoZWRJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpJbWFn ZUJveDo6fkltYWdlQm94KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkltYWdlQm94Ojpp bWFnZSBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpJbWFnZUJveDo6aW1hZ2VD aGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkltYWdlQm94OjpkZWJ1Z0Rlc2Ny aXB0aW9uIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6Om1faW1hZ2UpOiBEZWxl dGVkLgorICAgICAgICAqIGRpc3BsYXkvY3NzL0Rpc3BsYXlJbWFnZUJveC5oOgorICAgICAgICAo V2ViQ29yZTo6RGlzcGxheTo6SW1hZ2VCb3g6OmltYWdlIGNvbnN0KTogRGVsZXRlZC4KKwogMjAy MS0wOC0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBbTEZDIERpc3BsYXldIEludHJvZHVjZSB0eXBlLXNhZmUgcmVjdCB0eXBlcyBmb3IgdGhlIGRp c3BsYXkgdHJlZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZGlzcGxheS9jc3MvRGlzcGxh eUJveEZhY3RvcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvZGlzcGxheS9jc3MvRGlzcGxheUJveEZh Y3RvcnkuY3BwCmluZGV4IGFkNTk2OTNiMTdhMTBjMTk3OWY1OGU5ZGI2MTk5NTc2Y2ZiMmNhOWEu LmMzYjk2NDMyZWNmNzk2MDI1MjRkZDYwMzQ3MTJhMDFhMjZlMzZhNzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Rpc3BsYXkvY3NzL0Rpc3BsYXlCb3hGYWN0b3J5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kaXNwbGF5L2Nzcy9EaXNwbGF5Qm94RmFjdG9yeS5jcHAKQEAgLTEyMiwxMSAr MTIyLDggQEAgc3RkOjp1bmlxdWVfcHRyPEJveD4gQm94RmFjdG9yeTo6ZGlzcGxheUJveEZvckxh eW91dEJveChjb25zdCBMYXlvdXQ6OkJveCYgbGF5b3UKICAgICAKICAgICBpZiAoaXM8TGF5b3V0 OjpSZXBsYWNlZEJveD4obGF5b3V0Qm94KSkgewogICAgICAgICAvLyBGSVhNRTogRG9uJ3QgYXNz dW1lIGl0J3MgYW4gaW1hZ2UuCi0gICAgICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2U7Ci0gICAgICAg IGlmIChhdXRvKiBjYWNoZWRJbWFnZSA9IGRvd25jYXN0PExheW91dDo6UmVwbGFjZWRCb3g+KGxh eW91dEJveCkuY2FjaGVkSW1hZ2UoKSkKLSAgICAgICAgICAgIGltYWdlID0gY2FjaGVkSW1hZ2Ut PmltYWdlKCk7Ci0KLSAgICAgICAgYXV0byBpbWFnZUJveCA9IG1ha2VVbmlxdWU8SW1hZ2VCb3g+ KG1fdHJlZUJ1aWxkZXIudHJlZSgpLCBwaXhlbFNuYXBwZWRCb3JkZXJCb3hSZWN0LCBXVEZNb3Zl KHN0eWxlKSwgV1RGTW92ZShpbWFnZSkpOworICAgICAgICBDYWNoZWRSZXNvdXJjZUhhbmRsZTxD YWNoZWRJbWFnZT4gY2FjaGVkSW1hZ2VIYW5kbGUgPSBkb3duY2FzdDxMYXlvdXQ6OlJlcGxhY2Vk Qm94PihsYXlvdXRCb3gpLmNhY2hlZEltYWdlKCk7CisgICAgICAgIGF1dG8gaW1hZ2VCb3ggPSBt YWtlVW5pcXVlPEltYWdlQm94PihtX3RyZWVCdWlsZGVyLnRyZWUoKSwgcGl4ZWxTbmFwcGVkQm9y ZGVyQm94UmVjdCwgV1RGTW92ZShzdHlsZSksIFdURk1vdmUoY2FjaGVkSW1hZ2VIYW5kbGUpKTsK ICAgICAgICAgc2V0dXBCb3hNb2RlbEJveCgqaW1hZ2VCb3gsIGxheW91dEJveCwgZ2VvbWV0cnks IGNvbnRhaW5pbmdCbG9ja0NvbnRleHQsIHN0eWxlRm9yQmFja2dyb3VuZCk7CiAgICAgICAgIHJl dHVybiBpbWFnZUJveDsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5 L2Nzcy9EaXNwbGF5SW1hZ2VCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvZGlzcGxheS9jc3MvRGlz cGxheUltYWdlQm94LmNwcAppbmRleCBhZjg0ODExNTdhZGQwMjAyOTdkYWRiMmY2NDViZjdmMmI1 Y2QwZmQ1Li4yYWI4MTMyMmFlMjFiYTM1ZmU4OGIyMDc4MmQwNjQ5OTY0ODQ0NWEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5L2Nzcy9EaXNwbGF5SW1hZ2VCb3guY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvY3NzL0Rpc3BsYXlJbWFnZUJveC5jcHAKQEAgLTI4LDcg KzI4LDcgQEAKIAogI2lmIEVOQUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQogCi0jaW5j bHVkZSAiSW1hZ2UuaCIKKyNpbmNsdWRlICJDYWNoZWRJbWFnZS5oIgogI2luY2x1ZGUgPHd0Zi9J c29NYWxsb2NJbmxpbmVzLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTM2LDEwICszNiwy OCBAQCBuYW1lc3BhY2UgRGlzcGxheSB7CiAKIERFRklORV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lE RU5USUZJRVIoSW1hZ2VCb3gpOwogCi1JbWFnZUJveDo6SW1hZ2VCb3goVHJlZSYgdHJlZSwgVW5h ZGp1c3RlZEFic29sdXRlRmxvYXRSZWN0IGJvcmRlckJveCwgU3R5bGUmJiBkaXNwbGF5U3R5bGUs IFJlZlB0cjxJbWFnZT4mJiBpbWFnZSkKK0ltYWdlQm94OjpJbWFnZUJveChUcmVlJiB0cmVlLCBV bmFkanVzdGVkQWJzb2x1dGVGbG9hdFJlY3QgYm9yZGVyQm94LCBTdHlsZSYmIGRpc3BsYXlTdHls ZSwgQ2FjaGVkUmVzb3VyY2VIYW5kbGU8Q2FjaGVkSW1hZ2U+JiYgaW1hZ2UpCiAgICAgOiBSZXBs YWNlZEJveCh0cmVlLCBib3JkZXJCb3gsIFdURk1vdmUoZGlzcGxheVN0eWxlKSwgeyBUeXBlRmxh Z3M6OkltYWdlQm94IH0pCi0gICAgLCBtX2ltYWdlKFdURk1vdmUoaW1hZ2UpKQorICAgICwgbV9j YWNoZWRJbWFnZShXVEZNb3ZlKGltYWdlKSkKIHsKKyAgICBpZiAobV9jYWNoZWRJbWFnZSkKKyAg ICAgICAgbV9jYWNoZWRJbWFnZS0+YWRkQ2xpZW50KCp0aGlzKTsKK30KKworSW1hZ2VCb3g6On5J bWFnZUJveCgpCit7CisgICAgaWYgKG1fY2FjaGVkSW1hZ2UpCisgICAgICAgIG1fY2FjaGVkSW1h Z2UtPnJlbW92ZUNsaWVudCgqdGhpcyk7Cit9CisKK0ltYWdlKiBJbWFnZUJveDo6aW1hZ2UoKSBj b25zdAoreworICAgIHJldHVybiBtX2NhY2hlZEltYWdlID8gbV9jYWNoZWRJbWFnZS0+aW1hZ2Uo KSA6IG51bGxwdHI7Cit9CisKK3ZvaWQgSW1hZ2VCb3g6OmltYWdlQ2hhbmdlZChDYWNoZWRJbWFn ZSosIGNvbnN0IEludFJlY3QqKQoreworICAgIHNldE5lZWRzRGlzcGxheSgpOyAvLyBGSVhNRTog Q29tcHV0ZSBjb3JyZWN0IHJlY3QuCiB9CiAKIGNvbnN0IGNoYXIqIEltYWdlQm94Ojpib3hOYW1l KCkgY29uc3QKQEAgLTUwLDcgKzY4LDcgQEAgY29uc3QgY2hhciogSW1hZ2VCb3g6OmJveE5hbWUo KSBjb25zdAogU3RyaW5nIEltYWdlQm94OjpkZWJ1Z0Rlc2NyaXB0aW9uKCkgY29uc3QKIHsKICAg ICBUZXh0U3RyZWFtIHN0cmVhbTsKLSAgICBzdHJlYW0gPDwgYm94TmFtZSgpIDw8ICIgIiA8PCBh YnNvbHV0ZUJvcmRlckJveFJlY3QoKSA8PCAiICgiIDw8IHRoaXMgPDwgIikgcmVwbGFjZWQgY29u dGVudCByZWN0OiAiIDw8IHJlcGxhY2VkQ29udGVudFJlY3QoKSA8PCAiIGltYWdlOiAiIDw8IG1f aW1hZ2UuZ2V0KCk7CisgICAgc3RyZWFtIDw8IGJveE5hbWUoKSA8PCAiICIgPDwgYWJzb2x1dGVC b3JkZXJCb3hSZWN0KCkgPDwgIiAoIiA8PCB0aGlzIDw8ICIpIHJlcGxhY2VkIGNvbnRlbnQgcmVj dDogIiA8PCByZXBsYWNlZENvbnRlbnRSZWN0KCkgPDwgIiBpbWFnZTogIiA8PCBtX2NhY2hlZElt YWdlLmdldCgpOwogICAgIHJldHVybiBzdHJlYW0ucmVsZWFzZSgpOwogfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5L2Nzcy9EaXNwbGF5SW1hZ2VCb3guaCBiL1NvdXJjZS9X ZWJDb3JlL2Rpc3BsYXkvY3NzL0Rpc3BsYXlJbWFnZUJveC5oCmluZGV4IDM1NTgyNTFjMTMzYWRk MzYyMGJiNWE4ZjZlYWIxMzg5YzQ5OWZmOTYuLjE1MDA1NWUzMzMwMjRiNzg2N2I5ZGU3YjgzNzhm NzcwZjJjNmI4NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvY3NzL0Rpc3Bs YXlJbWFnZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvY3NzL0Rpc3BsYXlJbWFn ZUJveC5oCkBAIC0yNywyOSArMjcsMzUgQEAKIAogI2lmIEVOQUJMRShMQVlPVVRfRk9STUFUVElO R19DT05URVhUKQogCisjaW5jbHVkZSAiQ2FjaGVkSW1hZ2VDbGllbnQuaCIKKyNpbmNsdWRlICJD YWNoZWRSZXNvdXJjZUhhbmRsZS5oIgogI2luY2x1ZGUgIkRpc3BsYXlSZXBsYWNlZEJveC5oIgog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIEltYWdlOwotCiBuYW1lc3BhY2UgRGlzcGxh eSB7CiAKIGNsYXNzIFN0eWxlOwogCiBERUNMQVJFX0FMTE9DQVRPUl9XSVRIX0hFQVBfSURFTlRJ RklFUihJbWFnZUJveCk7Ci1jbGFzcyBJbWFnZUJveCA6IHB1YmxpYyBSZXBsYWNlZEJveCB7CisK K2NsYXNzIEltYWdlQm94IDogcHVibGljIFJlcGxhY2VkQm94LCBwdWJsaWMgQ2FjaGVkSW1hZ2VD bGllbnQgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEX1dJVEhfSEVBUF9JREVOVElGSUVS KEltYWdlQm94KTsKIHB1YmxpYzoKLSAgICBJbWFnZUJveChUcmVlJiwgVW5hZGp1c3RlZEFic29s dXRlRmxvYXRSZWN0IGJvcmRlckJveCwgU3R5bGUmJiwgUmVmUHRyPEltYWdlPiYmKTsKKyAgICBJ bWFnZUJveChUcmVlJiwgVW5hZGp1c3RlZEFic29sdXRlRmxvYXRSZWN0IGJvcmRlckJveCwgU3R5 bGUmJiwgQ2FjaGVkUmVzb3VyY2VIYW5kbGU8Q2FjaGVkSW1hZ2U+JiYpOworICAgIH5JbWFnZUJv eCgpOwogCi0gICAgSW1hZ2UqIGltYWdlKCkgY29uc3QgeyByZXR1cm4gbV9pbWFnZS5nZXQoKTsg fQorICAgIEltYWdlKiBpbWFnZSgpIGNvbnN0OwogCiBwcml2YXRlOgorCisgICAgLy8gQ2FjaGVk SW1hZ2VDbGllbnQKKyAgICB2b2lkIGltYWdlQ2hhbmdlZChDYWNoZWRJbWFnZSosIGNvbnN0IElu dFJlY3QqKSBmaW5hbDsKKwogICAgIGNvbnN0IGNoYXIqIGJveE5hbWUoKSBjb25zdCBmaW5hbDsK ICAgICBTdHJpbmcgZGVidWdEZXNjcmlwdGlvbigpIGNvbnN0IGZpbmFsOwogCi0gICAgUmVmUHRy PEltYWdlPiBtX2ltYWdlOworICAgIENhY2hlZFJlc291cmNlSGFuZGxlPENhY2hlZEltYWdlPiBt X2NhY2hlZEltYWdlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgRGlzcGxheQo=