229114 2021-08-14 14:35:44 -0700 [WTF] Fix static analyzer warnings for clang tidy bugprone-move-forwarding-reference checker 2022-02-06 10:08:23 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236181 https://bugs.webkit.org/show_bug.cgi?id=236202 https://clang.llvm.org/extra/clang-tidy/checks/bugprone-move-forwarding-reference.html InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1784354 0 ddkilzer 2021-08-14 14:35:44 -0700 Fix static analyzer warnings in WTF for clang tidy bugprone-move-forwarding-reference checker. See: <https://clang.llvm.org/extra/clang-tidy/checks/bugprone-move-forwarding-reference.html> In file included from OpenSource/Source/WTF/wtf/AutomaticThread.cpp:27: In file included from WebKitBuild/usr/local/include/wtf/AutomaticThread.h:29: In file included from WebKitBuild/usr/local/include/wtf/Condition.h:30: In file included from WebKitBuild/usr/local/include/wtf/ParkingLot.h:29: WebKitBuild/usr/local/include/wtf/ScopedLambda.h:128:55: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead return ScopedLambdaFunctor<FunctionType, Functor>(WTFMove(functor)); ^ In file included from OpenSource/Source/WTF/wtf/AutomaticThread.cpp:26: In file included from OpenSource/Source/WTF/config.h:31: In file included from WebKitBuild/usr/local/include/wtf/FastMalloc.h:26: WebKitBuild/usr/local/include/wtf/StdLibExtras.h:568:24: note: expanded from macro 'WTFMove' #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) ^ 1784355 1 435551 ddkilzer 2021-08-14 14:46:37 -0700 Created attachment 435551 Patch v1 1785578 2 ews-feeder 2021-08-19 14:25:21 -0700 Committed r281270 (240695@main): <https://commits.webkit.org/240695@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435551. 1785579 3 webkit-bug-importer 2021-08-19 14:26:21 -0700 <rdar://problem/82142002> 435551 2021-08-14 14:46:37 -0700 2022-02-05 13:44:20 -0800 Patch v1 bug-229114-20210814144636.patch text/plain 3346 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZlMTViM2Q2YmYxZTFmNTA0MmFhNjhh NWUyODdjNGRhNmM3NTBlMTguLjFhYzQwMDZiZTRlZmUzODA5OTgyOGEyOWZhZGQ3MTg4ZjNmMDJh NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDgtMTQgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBGaXggc3RhdGljIGFuYWx5emVyIHdhcm5p bmdzIGZvciBjbGFuZyB0aWR5IGJ1Z3Byb25lLW1vdmUtZm9yd2FyZGluZy1yZWZlcmVuY2UgY2hl Y2tlcgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjI5MTE0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0RlcXVlLmg6CisgICAg ICAgIChXVEY6OmlubGluZUNhcGFjaXR5Pjo6YXBwZW5kQW5kQnViYmxlKToKKyAgICAgICAgKiB3 dGYvU2NvcGUuaDoKKyAgICAgICAgKFdURjo6U2NvcGVFeGl0OjpTY29wZUV4aXQpOgorICAgICAg ICAqIHd0Zi9TY29wZWRMYW1iZGEuaDoKKyAgICAgICAgKFdURjo6c2NvcGVkTGFtYmRhKToKKyAg ICAgICAgKiB3dGYvU2hhcmVkVGFzay5oOgorICAgICAgICAoV1RGOjpjcmVhdGVTaGFyZWRUYXNr KToKKyAgICAgICAgLSBSZXBsYWNlIFdURk1vdmUoKSB3aXRoIHN0ZDo6Zm9yd2FyZDw+KCkuCisK IDIwMjEtMDgtMDcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog ICAgICAgICBEZWR1cGxpY2F0ZSBsb2dnaW5nIGNoYW5uZWwgYWxnb3JpdGhtcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvRGVxdWUuaCBiL1NvdXJjZS9XVEYvd3RmL0RlcXVlLmgKaW5kZXgg YTg5MjM0OTIwYjAzMzZiZWUwNzE1NGQyZWRiYzU4ZjY2M2FkNGFmNy4uMmU5YzExYjMwNTczMmY1 MjhmZGYyYjZkZWE3MDk2MDFhNzNmNTBjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRGVx dWUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9EZXF1ZS5oCkBAIC01NzUsNyArNTc1LDcgQEAgdGVt cGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgogdGVtcGxhdGU8dHlwZW5h bWUgVSwgdHlwZW5hbWUgRnVuYz4KIGlubGluZSB2b2lkIERlcXVlPFQsIGlubGluZUNhcGFjaXR5 Pjo6YXBwZW5kQW5kQnViYmxlKFUmJiB2YWx1ZSwgY29uc3QgRnVuYyYgZnVuYykKIHsKLSAgICBh cHBlbmQoV1RGTW92ZSh2YWx1ZSkpOworICAgIGFwcGVuZChzdGQ6OmZvcndhcmQ8VT4odmFsdWUp KTsKICAgICBpdGVyYXRvciBiZWdpbiA9IHRoaXMtPmJlZ2luKCk7CiAgICAgaXRlcmF0b3IgaXRl ciA9IGVuZCgpOwogICAgIC0taXRlcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1Njb3Bl LmggYi9Tb3VyY2UvV1RGL3d0Zi9TY29wZS5oCmluZGV4IGI3NGQ3NWFhNTdmNWIwZWUxOWU5NzIx NzQ4YmQyMWJkZDVjNzFkMGYuLmI3YjkwMWI0MjAyZWQ3OGM4ZmU1OGY1NGJkMjM4MmFmOTdiODQ2 MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Njb3BlLmgKKysrIGIvU291cmNlL1dURi93 dGYvU2NvcGUuaApAQCAtMzcsNyArMzcsNyBAQCBjbGFzcyBTY29wZUV4aXQgZmluYWwgewogcHVi bGljOgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEV4aXRGdW5jdGlvblBhcmFtZXRlcj4KICAgICBl eHBsaWNpdCBTY29wZUV4aXQoRXhpdEZ1bmN0aW9uUGFyYW1ldGVyJiYgZXhpdEZ1bmN0aW9uKQot ICAgICAgICA6IG1fZXhpdEZ1bmN0aW9uKFdURk1vdmUoZXhpdEZ1bmN0aW9uKSkKKyAgICAgICAg OiBtX2V4aXRGdW5jdGlvbihzdGQ6OmZvcndhcmQ8RXhpdEZ1bmN0aW9uUGFyYW1ldGVyPihleGl0 RnVuY3Rpb24pKQogICAgIHsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1Nj b3BlZExhbWJkYS5oIGIvU291cmNlL1dURi93dGYvU2NvcGVkTGFtYmRhLmgKaW5kZXggZDJkZDZh MzA1NGZmZDg1YWI3YjUxYTA4OGU4OWU2MjhiZWQxNjdiNC4uMzM1NzYxNTA2Zjg1NDc3YzRiNDFm YjVjYzBjNDQ5ZGM3MmE3ZDA4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU2NvcGVkTGFt YmRhLmgKKysrIGIvU291cmNlL1dURi93dGYvU2NvcGVkTGFtYmRhLmgKQEAgLTEyNSw3ICsxMjUs NyBAQCBTY29wZWRMYW1iZGFGdW5jdG9yPEZ1bmN0aW9uVHlwZSwgRnVuY3Rvcj4gc2NvcGVkTGFt YmRhKGNvbnN0IEZ1bmN0b3ImIGZ1bmN0b3IpCiB0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdGlvblR5 cGUsIHR5cGVuYW1lIEZ1bmN0b3I+CiBTY29wZWRMYW1iZGFGdW5jdG9yPEZ1bmN0aW9uVHlwZSwg RnVuY3Rvcj4gc2NvcGVkTGFtYmRhKEZ1bmN0b3ImJiBmdW5jdG9yKQogewotICAgIHJldHVybiBT Y29wZWRMYW1iZGFGdW5jdG9yPEZ1bmN0aW9uVHlwZSwgRnVuY3Rvcj4oV1RGTW92ZShmdW5jdG9y KSk7CisgICAgcmV0dXJuIFNjb3BlZExhbWJkYUZ1bmN0b3I8RnVuY3Rpb25UeXBlLCBGdW5jdG9y PihzdGQ6OmZvcndhcmQ8RnVuY3Rvcj4oZnVuY3RvcikpOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFt ZSBGdW5jdGlvblR5cGUsIHR5cGVuYW1lIEZ1bmN0b3I+IGNsYXNzIFNjb3BlZExhbWJkYVJlZkZ1 bmN0b3I7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TaGFyZWRUYXNrLmggYi9Tb3VyY2Uv V1RGL3d0Zi9TaGFyZWRUYXNrLmgKaW5kZXggMjg1ZWQyZDg3ZDA3YzRhYTIzYjJhZmQxNDJiN2M0 ZjVkZGNkZTQzZC4uMzc2ZmI4MzIwZjM1YzQ4Zjc0MGZiMjM4ZjkwNDhlNWZjNGJkZDUxNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvU2hhcmVkVGFzay5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L1NoYXJlZFRhc2suaApAQCAtMTE5LDcgKzExOSw3IEBAIFJlZjxTaGFyZWRUYXNrPEZ1bmN0aW9u VHlwZT4+IGNyZWF0ZVNoYXJlZFRhc2soY29uc3QgRnVuY3RvciYgZnVuY3RvcikKIHRlbXBsYXRl PHR5cGVuYW1lIEZ1bmN0aW9uVHlwZSwgdHlwZW5hbWUgRnVuY3Rvcj4KIFJlZjxTaGFyZWRUYXNr PEZ1bmN0aW9uVHlwZT4+IGNyZWF0ZVNoYXJlZFRhc2soRnVuY3RvciYmIGZ1bmN0b3IpCiB7Ci0g ICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU2hhcmVkVGFza0Z1bmN0b3I8RnVuY3Rpb25UeXBlLCBG dW5jdG9yPihXVEZNb3ZlKGZ1bmN0b3IpKSk7CisgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU2hh cmVkVGFza0Z1bmN0b3I8RnVuY3Rpb25UeXBlLCBGdW5jdG9yPihzdGQ6OmZvcndhcmQ8RnVuY3Rv cj4oZnVuY3RvcikpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV1RGCg==