229113 2021-08-14 13:25:27 -0700 ThreadSanitizer: ignore uninteresting data races for reference counting of static WTF::StringImpl objects 2021-08-16 09:51:43 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin cdumez cmarcelo darin ews-watchlist ggaren webkit-bug-importer oldest_to_newest 1784349 0 ddkilzer 2021-08-14 13:25:27 -0700 ThreadSanitizer: ignore uninteresting data races for reference counting of static WTF::StringImpl objects. Calls to WTF::StringImpl::isStatic(), WTF::StringImpl::ref() and WTF::StringImpl::deref() for static WTF::StringImpl objects result in uninteresting data races since static WTF::StringImpl objects are never released (because they start with a refcount of 1, and refcounts are incremented or decremented by 2). The WTF::StringImpl::s_emptyAtomString object generates hundreds of reports when running layout tests with TSan, such as this, which simply aren't interesting: ================== WARNING: ThreadSanitizer: data race (pid=64095) Write of size 4 at 0x00011ca70258 by thread T3: #0 WTF::StringImpl::ref() <null> (JavaScriptCore:x86_64+0x18da1a0) #1 WTF::Ref<WTF::StringImpl, WTF::RawPtrTraits<WTF::StringImpl> >::Ref(WTF::StringImpl&) <null> (JavaScriptCore:x86_64+0x18e5b88) #2 WTF::Ref<WTF::StringImpl, WTF::RawPtrTraits<WTF::StringImpl> >::Ref(WTF::StringImpl&) <null> (JavaScriptCore:x86_64+0xe270) #3 WTF::Ref<WTF::StringImpl, WTF::RawPtrTraits<WTF::StringImpl> > WTF::StringImpl::createInternal<unsigned char>(unsigned char const*, unsigned int) <null> (JavaScriptCore:x86_64+0x9dd99) #4 WTF::StringImpl::create(unsigned char const*, unsigned int) <null> (JavaScriptCore:x86_64+0x9dd09) #5 WTF::StringImpl::substring(unsigned int, unsigned int) <null> (JavaScriptCore:x86_64+0x9e174) #6 WTF::String::substring(unsigned int, unsigned int) const <null> (JavaScriptCore:x86_64+0x11446e) #7 WebCore::SecurityOriginData::fromDatabaseIdentifier(WTF::String const&) <null> (WebCore:x86_64+0x2db32d0) #8 WebKit::getSecurityOriginData(char const*, WebCore::KeyedDecoder*) <null> (WebKit:x86_64+0x11501f8) #9 WebKit::DeviceIdHashSaltStorage::getDataFromDecoder(WebCore::KeyedDecoder*, WTF::String&&) const <null> (WebKit:x86_64+0x114fe39) #10 WebKit::DeviceIdHashSaltStorage::loadStorageFromDisk(WTF::CompletionHandler<void (WTF::HashMap<WTF::String, std::__1::unique_ptr<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin, std::__1::default_delete<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin> >, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::unique_ptr<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin, std::__1::default_delete<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin> > >, WTF::HashTableTraits>&&)>&&)::$_6::operator()() <null> (WebKit:x86_64+0x115e7e9) #11 WTF::Detail::CallableWrapper<WebKit::DeviceIdHashSaltStorage::loadStorageFromDisk(WTF::CompletionHandler<void (WTF::HashMap<WTF::String, std::__1::unique_ptr<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin, std::__1::default_delete<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin> >, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::unique_ptr<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin, std::__1::default_delete<WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin> > >, WTF::HashTableTraits>&&)>&&)::$_6, void>::call() <null> (WebKit:x86_64+0x115e59d) #12 WTF::Function<void ()>::operator()() const <null> (JavaScriptCore:x86_64+0x2620d) #13 WTF::(anonymous namespace)::DispatchWorkItem::operator()() <null> (JavaScriptCore:x86_64+0x11285d) #14 void WTF::dispatchWorkItem<WTF::(anonymous namespace)::DispatchWorkItem>(void*) <null> (JavaScriptCore:x86_64+0x111849) #15 __tsan::dispatch_callback_wrap(void*) <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64+0x734d1) #16 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x34ff) Previous write of size 4 at 0x00011ca70258 by main thread: #0 WTF::StringImpl::ref() <null> (WebKit:x86_64+0x9150) #1 WTF::String::String(WTF::String const&) <null> (WebKit:x86_64+0x9118) #2 WTF::String::String(WTF::String const&) <null> (WebKit:x86_64+0x90c0) #3 WebCore::ResourceRequestBase::ResourceRequestBase(WTF::URL const&, WebCore::ResourceRequestCachePolicy) <null> (WebKit:x86_64+0x79ac1) #4 WebCore::ResourceRequest::ResourceRequest() <null> (WebKit:x86_64+0x799bf) #5 WebCore::ResourceRequest::ResourceRequest() <null> (WebKit:x86_64+0x79909) #6 WebKit::FrameInfoData::FrameInfoData() <null> (WebKit:x86_64+0x1276ce9) #7 WebKit::FrameInfoData::FrameInfoData() <null> (WebKit:x86_64+0x12769e9) #8 WebKit::WebAuthenticationRequestData::WebAuthenticationRequestData() <null> (WebKit:x86_64+0x1276880) #9 WebKit::WebAuthenticationRequestData::WebAuthenticationRequestData() <null> (WebKit:x86_64+0x1276679) #10 WebKit::AuthenticatorManager::AuthenticatorManager() <null> (WebKit:x86_64+0x16ea81d) #11 WebKit::AuthenticatorManager::AuthenticatorManager() <null> (WebKit:x86_64+0x16eaaf9) #12 WTF::UniqueRef<WebKit::AuthenticatorManager> WTF::makeUniqueRefWithoutFastMallocCheck<WebKit::AuthenticatorManager>() <null> (WebKit:x86_64+0x17a3447) #13 WTF::UniqueRef<WebKit::AuthenticatorManager> WTF::makeUniqueRef<WebKit::AuthenticatorManager>() <null> (WebKit:x86_64+0x17875a9) #14 WebKit::WebsiteDataStore::WebsiteDataStore(WTF::Ref<WebKit::WebsiteDataStoreConfiguration, WTF::RawPtrTraits<WebKit::WebsiteDataStoreConfiguration> >&&, PAL::SessionID) <null> (WebKit:x86_64+0x1786d5d) #15 WebKit::WebsiteDataStore::WebsiteDataStore(WTF::Ref<WebKit::WebsiteDataStoreConfiguration, WTF::RawPtrTraits<WebKit::WebsiteDataStoreConfiguration> >&&, PAL::SessionID) <null> (WebKit:x86_64+0x1786b29) #16 WebKit::WebsiteDataStore::create(WTF::Ref<WebKit::WebsiteDataStoreConfiguration, WTF::RawPtrTraits<WebKit::WebsiteDataStoreConfiguration> >&&, PAL::SessionID) <null> (WebKit:x86_64+0x1786b87) #17 WKWebsiteDataStoreCreateWithConfiguration <null> (WebKit:x86_64+0x1554bd6) #18 WTR::TestController::defaultWebsiteDataStore() <null> (WebKitTestRunner:x86_64+0x10005740d) #19 WTR::initializeWebViewConfiguration(char const*, OpaqueWKString const*, OpaqueWKContext const*, OpaqueWKContextConfiguration const*)::$_0::operator()() const <null> (WebKitTestRunner:x86_64+0x10008078b) #20 WTR::initializeWebViewConfiguration(char const*, OpaqueWKString const*, OpaqueWKContext const*, OpaqueWKContextConfiguration const*) <null> (WebKitTestRunner:x86_64+0x1000806b7) #21 WTR::TestController::platformAdjustContext(OpaqueWKContext const*, OpaqueWKContextConfiguration const*) <null> (WebKitTestRunner:x86_64+0x10008234a) #22 WTR::TestController::generatePageConfiguration(WTR::TestOptions const&) <null> (WebKitTestRunner:x86_64+0x100057555) #23 WTR::TestController::createWebViewWithOptions(WTR::TestOptions const&) <null> (WebKitTestRunner:x86_64+0x100057dd6) #24 WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&) <null> (WebKitTestRunner:x86_64+0x1000587a1) #25 WTR::TestController::configureViewForTest(WTR::TestInvocation const&) <null> (WebKitTestRunner:x86_64+0x10005b480) #26 WTR::TestInvocation::invoke() <null> (WebKitTestRunner:x86_64+0x10009784c) #27 WTR::TestController::runTest(char const*) <null> (WebKitTestRunner:x86_64+0x10005b66e) #28 WTR::TestController::runTestingServerLoop() <null> (WebKitTestRunner:x86_64+0x10005ba17) #29 WTR::TestController::run() <null> (WebKitTestRunner:x86_64+0x10005523d) #30 WTR::TestController::TestController(int, char const**) <null> (WebKitTestRunner:x86_64+0x100054d4b) #31 WTR::TestController::TestController(int, char const**) <null> (WebKitTestRunner:x86_64+0x1000552e9) #32 main <null> (WebKitTestRunner:x86_64+0x10000804a) Location is global 'WTF::StringImpl::s_emptyAtomString' at 0x00011ca70258 (JavaScriptCore+0x00000224a258) Thread T3 (tid=13697474, running) is a GCD worker thread SUMMARY: ThreadSanitizer: data race (WebKitBuild/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x18da1a0) in WTF::StringImpl::ref()+0x20 ================== 1784350 1 435548 ddkilzer 2021-08-14 13:31:50 -0700 Created attachment 435548 Patch v1 1784556 2 ews-feeder 2021-08-16 09:50:05 -0700 Committed r281091 (240551@main): <https://commits.webkit.org/240551@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435548. 1784559 3 webkit-bug-importer 2021-08-16 09:51:43 -0700 <rdar://problem/81985419> 435548 2021-08-14 13:31:50 -0700 2021-08-16 09:50:06 -0700 Patch v1 bug-229113-20210814133150.patch text/plain 2286 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ4MGVhNTNkMGYyYWM2MzhiYzY3M2Qy NzJiNmQzZTNiNTJjYzQ0OGQuLmI2YTJjNTMyM2U0ZmU3YTU4MjBjNTY1YzU2MjVjZWZiZjVkMjEw ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDgtMTQgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBUaHJlYWRTYW5pdGl6ZXI6IGlnbm9yZSB1bmludGVy ZXN0aW5nIGRhdGEgcmFjZXMgZm9yIHJlZmVyZW5jZSBjb3VudGluZyBvZiBzdGF0aWMgV1RGOjpT dHJpbmdJbXBsIG9iamVjdHMKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIyOTExMz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi90 ZXh0L1N0cmluZ0ltcGwuaDoKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6aXNTdGF0aWMgY29u c3QpOgorICAgICAgICAtIEFkZCBTVVBQUkVTU19UU0FOIGF0dHJpYnV0ZSBzaW5jZSB0aGUgMHgx IGJpdCBpcyBzZXQgYXQKKyAgICAgICAgICBjb25zdHJ1Y3Rpb24gYW5kIHJlZmNvdW50aW5nIG9j Y3VycyBpbiBpbmNyZW1lbnRzIG9mIDB4Miwgc28KKyAgICAgICAgICB0aGUgc3RhdGljIGJpdCBu ZXZlciBjaGFuZ2VzLgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpyZWYpOgorICAgICAgICAo V1RGOjpTdHJpbmdJbXBsOjpkZXJlZik6CisgICAgICAgIC0gUmV0dXJuIGVhcmx5IGZvciBzdGF0 aWMgV1RGOjpTdHJpbmdJbXBsIG9iamVjdHMgdG8gcHJldmVudAorICAgICAgICAgIFRTYW4gZnJv bSByZXBvcnRpbmcgZGF0YSByYWNlcyBmb3IgbV9yZWZDb3VudC4KKwogMjAyMS0wNy0xOCAgRGF2 aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEdldElkZW50aWZpZXJT dHJpbmdGb3JQcmVmZXJyZWRWb2ljZUluTGlzdFdpdGhMb2NhbGUoKSBpcyBkZXByZWNhdGVkIGlu IE1vbnRlcmV5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IGIwM2Y5NjhlZWVjOTZkYzY3 MjMxNTMzMjA4ODExNmZlZGVlYjMwODguLjQyMDNjMWM4MjU0MWE5ZDg3ZDdiNWIwZmJiNzQ4YjE2 YWNhNTg4NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC0zMzEsNyArMzMxLDcgQEAg cHVibGljOgogICAgIHVuc2lnbmVkIHN5bWJvbEF3YXJlSGFzaCgpIGNvbnN0OwogICAgIHVuc2ln bmVkIGV4aXN0aW5nU3ltYm9sQXdhcmVIYXNoKCkgY29uc3Q7CiAKLSAgICBib29sIGlzU3RhdGlj KCkgY29uc3QgeyByZXR1cm4gbV9yZWZDb3VudCAmIHNfcmVmQ291bnRGbGFnSXNTdGF0aWNTdHJp bmc7IH0KKyAgICBTVVBQUkVTU19UU0FOIGJvb2wgaXNTdGF0aWMoKSBjb25zdCB7IHJldHVybiBt X3JlZkNvdW50ICYgc19yZWZDb3VudEZsYWdJc1N0YXRpY1N0cmluZzsgfQogCiAgICAgc2l6ZV90 IHJlZkNvdW50KCkgY29uc3QgeyByZXR1cm4gbV9yZWZDb3VudCAvIHNfcmVmQ291bnRJbmNyZW1l bnQ7IH0KICAgICBib29sIGhhc09uZVJlZigpIGNvbnN0IHsgcmV0dXJuIG1fcmVmQ291bnQgPT0g c19yZWZDb3VudEluY3JlbWVudDsgfQpAQCAtMTA5NSw2ICsxMDk1LDExIEBAIGlubGluZSB2b2lk IFN0cmluZ0ltcGw6OnJlZigpCiB7CiAgICAgU1RSSU5HX1NUQVRTX1JFRl9TVFJJTkcoKnRoaXMp OwogCisjaWYgVFNBTl9FTkFCTEVECisgICAgaWYgKGlzU3RhdGljKCkpCisgICAgICAgIHJldHVy bjsKKyNlbmRpZgorCiAgICAgbV9yZWZDb3VudCArPSBzX3JlZkNvdW50SW5jcmVtZW50OwogfQog CkBAIC0xMTAyLDYgKzExMDcsMTEgQEAgaW5saW5lIHZvaWQgU3RyaW5nSW1wbDo6ZGVyZWYoKQog ewogICAgIFNUUklOR19TVEFUU19ERVJFRl9TVFJJTkcoKnRoaXMpOwogCisjaWYgVFNBTl9FTkFC TEVECisgICAgaWYgKGlzU3RhdGljKCkpCisgICAgICAgIHJldHVybjsKKyNlbmRpZgorCiAgICAg dW5zaWduZWQgdGVtcFJlZkNvdW50ID0gbV9yZWZDb3VudCAtIHNfcmVmQ291bnRJbmNyZW1lbnQ7 CiAgICAgaWYgKCF0ZW1wUmVmQ291bnQpIHsKICAgICAgICAgU3RyaW5nSW1wbDo6ZGVzdHJveSh0 aGlzKTsK