229096 2021-08-13 14:10:34 -0700 REGRESSION(r281013): broke windows build 2021-08-14 12:09:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 229068 1 commit-queue commit-queue aakash_jain jean-yves.avenard youennf oldest_to_newest 1784214 0 commit-queue 2021-08-13 14:10:34 -0700 https://commits.webkit.org/r281013 introduced a regression: broke windows build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1784216 1 435509 commit-queue 2021-08-13 14:10:39 -0700 Created attachment 435509 REVERT of r281013 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1784306 2 jean-yves.avenard 2021-08-13 20:15:07 -0700 There is NO way this commit broke windows build. It’s just swapping two existing lines. 1784336 3 aakash_jain 2021-08-14 12:09:43 -0700 Yeah. See https://bugs.webkit.org/show_bug.cgi?id=229068#c11 435509 2021-08-13 14:10:39 -0700 2021-08-13 14:17:13 -0700 REVERT of r281013 bug-229096-20210813141039.patch text/plain 2095 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UyZTBhNmE4OTk4NjBi ZWExN2Q0NTY4YjQzMmNiNDdhYWE1ZjAwZC4uODM0Zjc3ZTVjODM4MjM5YTEyNGVkY2UzZjJhOWY4 YTc2MGNjNDUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTEzICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI4MTAxMy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyOTA5NgorCisgICAgICAgIGJyb2tlIHdpbmRvd3MgYnVpbGQKKworICAg ICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIm5leHR0cmFjayBhbmQgcHJldmlv dXN0cmFjayBNZWRpYVNlc3Npb24gaGFuZGxlcnMgbm90CisgICAgICAgIHdvcmtpbmciCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkwNjgKKyAgICAg ICAgaHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvcjI4MTAxMworCiAyMDIxLTA4LTEzICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcmV2ZXJ0aW5nIHIyODEwMDkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcAppbmRleCBhYzkwNzhlMzhiYzNhNzVjYWMx ZDUxZjhmZTQwZWIyNDIzMmQ2NjAyLi41MDA5MTMwNDkwODg0MDJhNjg0YjkzYzJmMTc2ZTNiZmY1 NDA3ZTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9N ZWRpYVNlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9u L01lZGlhU2Vzc2lvbi5jcHAKQEAgLTY0LDggKzY0LDggQEAgc3RhdGljIFBsYXRmb3JtTWVkaWFT ZXNzaW9uOjpSZW1vdGVDb250cm9sQ29tbWFuZFR5cGUgcGxhdGZvcm1Db21tYW5kRm9yTWVkaWFT ZXMKICAgICAgICAgICAgIHsgTWVkaWFTZXNzaW9uQWN0aW9uOjpQYXVzZSwgUGxhdGZvcm1NZWRp YVNlc3Npb246OlBhdXNlQ29tbWFuZCB9LAogICAgICAgICAgICAgeyBNZWRpYVNlc3Npb25BY3Rp b246OlNlZWtmb3J3YXJkLCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbjo6U2tpcEZvcndhcmRDb21tYW5k IH0sCiAgICAgICAgICAgICB7IE1lZGlhU2Vzc2lvbkFjdGlvbjo6U2Vla2JhY2t3YXJkLCBQbGF0 Zm9ybU1lZGlhU2Vzc2lvbjo6U2tpcEJhY2t3YXJkQ29tbWFuZCB9LAotICAgICAgICAgICAgeyBN ZWRpYVNlc3Npb25BY3Rpb246OlByZXZpb3VzdHJhY2ssIFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpQ cmV2aW91c1RyYWNrQ29tbWFuZCB9LAotICAgICAgICAgICAgeyBNZWRpYVNlc3Npb25BY3Rpb246 Ok5leHR0cmFjaywgUGxhdGZvcm1NZWRpYVNlc3Npb246Ok5leHRUcmFja0NvbW1hbmQgfSwKKyAg ICAgICAgICAgIHsgTWVkaWFTZXNzaW9uQWN0aW9uOjpQcmV2aW91c3RyYWNrLCBQbGF0Zm9ybU1l ZGlhU2Vzc2lvbjo6TmV4dFRyYWNrQ29tbWFuZCB9LAorICAgICAgICAgICAgeyBNZWRpYVNlc3Np b25BY3Rpb246Ok5leHR0cmFjaywgUGxhdGZvcm1NZWRpYVNlc3Npb246OlByZXZpb3VzVHJhY2tD b21tYW5kIH0sCiAgICAgICAgICAgICB7IE1lZGlhU2Vzc2lvbkFjdGlvbjo6U3RvcCwgUGxhdGZv cm1NZWRpYVNlc3Npb246OlN0b3BDb21tYW5kIH0sCiAgICAgICAgICAgICB7IE1lZGlhU2Vzc2lv bkFjdGlvbjo6U2Vla3RvLCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbjo6U2Vla1RvUGxheWJhY2tQb3Np dGlvbkNvbW1hbmQgfSwKICAgICAgICAgICAgIHsgTWVkaWFTZXNzaW9uQWN0aW9uOjpTa2lwYWQs IFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpOZXh0VHJhY2tDb21tYW5kIH0sCg==