229067 2021-08-12 20:30:03 -0700 [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing 2021-08-13 07:40:32 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lmoura lmoura bugs-noreply cgarcia oldest_to_newest 1784035 0 lmoura 2021-08-12 20:30:03 -0700 /WPE/TestWebExtensions /webkit/WebKitWebView/web-process-crashed Output: /webkit/WebKitWebView/web-process-crashed: FAIL WPE-FDO-FATAL-WARNING: Instance::dispatchFrameCallbacks(): Cannot find surface with bridgeId 1 in view backend map. Probably the associated surface is gone due to a premature exit in the client side (/app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WPE/TestWebExtensions:778): WPE-FDO-WARNING **: 06:40:11.689: Instance::dispatchFrameCallbacks(): Cannot find surface with bridgeId 1 in view backend map. Probably the associated surface is gone due to a premature exit in the client side In the release bot, the first failure was in the build #2602 for identifier 240345@main. Since this revision, it failed 31 out of 41 runs. Locally: Laptop: 4 fails in 20 runs Desktop: 7 fails in 20 runs In a manual build outside Flatpak, no errors in 10 runs. 1784047 1 cgarcia 2021-08-12 23:12:01 -0700 I guess that's expected to happen in case of web process crash, so maybe we can just make warnings non fatal at that point or not use g_warning in wpe-fdo 1784088 2 435477 lmoura 2021-08-13 05:26:36 -0700 Created attachment 435477 Patch 1784089 3 lmoura 2021-08-13 05:27:08 -0700 (In reply to Carlos Garcia Campos from comment #1) > I guess that's expected to happen in case of web process crash, so maybe we > can just make warnings non fatal at that point or not use g_warning in > wpe-fdo Indeed. With this patch, it's consistently passing. 1784090 4 435478 lmoura 2021-08-13 05:59:20 -0700 Created attachment 435478 Patch with updated expectations 1784101 5 435478 cgarcia 2021-08-13 07:20:48 -0700 Comment on attachment 435478 Patch with updated expectations View in context: https://bugs.webkit.org/attachment.cgi?id=435478&action=review > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:166 > + Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING); > g_main_loop_run(test->m_mainLoop); > + Test::addLogFatalFlag(G_LOG_LEVEL_WARNING); Ok, I think we should still check if we can remove the g_warning in wpe-fdo, because thi might hide other warnings happening. 1784106 6 ews-feeder 2021-08-13 07:40:30 -0700 Committed r281015 (240505@main): <https://commits.webkit.org/240505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435478. 435477 2021-08-13 05:26:36 -0700 2021-08-13 05:59:16 -0700 Patch bug-229067-20210813092634.patch text/plain 1478 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTgxY2Y3MjdhMTAzZWExN2FjMDNlMzk0OGFiMmVhN2Yx NzNhYTJlYy4uNTMyNGIyOGVhMDg2YWJkNThkNTczNDM4OTI4ZjIyYmUwMWFmNmIyNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA4LTEzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXUEVdIFdlYkV4dGVuc2lvbiBBUEkgdGVzdCAvd2Via2l0L1dlYktpdFdlYlZpZXcvd2Vi LXByb2Nlc3MtY3Jhc2hlZCBpcyBmbGFreSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkwNjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xp Yi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0V2ViVmlld1Byb2Nl c3NDcmFzaGVkKTogTWFrZSB3YXJuaW5ncyBub24tZmF0YWwgd2hpbGUgd2FpdGluZyBmb3IgdGhl IGNyYXNoLgorCiAyMDIxLTA4LTEyICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIEdhcmRlbmluZyB3ZWItcHJvY2Vzcy1jcmFzaGVkIEFQSSB0ZXN0IGZh aWx1cmUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9U ZXN0V2ViRXh0ZW5zaW9ucy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdM aWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwCmluZGV4IDU1OWFmOTUyOGQ2NjRmM2FhYTkyZWJmMzMy NGIxYWE3NDdjNTAxZmEuLjQwZWFlYjdiZjI3YTRiODRkNzMwYjQzOWY3MWY2OTZiZWRjZWZiMTEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2Vi RXh0ZW5zaW9ucy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGli L1Rlc3RXZWJFeHRlbnNpb25zLmNwcApAQCAtMTYxLDcgKzE2MSw5IEBAIHN0YXRpYyB2b2lkIHRl c3RXZWJLaXRXZWJWaWV3UHJvY2Vzc0NyYXNoZWQoV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCiAgICAgICAgIEdfREJVU19DQUxMX0ZMQUdTX05PTkUsCiAgICAgICAgIC0xLCAwLCAw KSk7CiAgICAgZ19hc3NlcnRfbnVsbChyZXN1bHQpOworICAgIFRlc3Q6OnJlbW92ZUxvZ0ZhdGFs RmxhZyhHX0xPR19MRVZFTF9XQVJOSU5HKTsKICAgICBnX21haW5fbG9vcF9ydW4odGVzdC0+bV9t YWluTG9vcCk7CisgICAgVGVzdDo6YWRkTG9nRmF0YWxGbGFnKEdfTE9HX0xFVkVMX1dBUk5JTkcp OwogICAgIHRlc3QtPm1fZXhwZWN0ZWRXZWJQcm9jZXNzQ3Jhc2ggPSBmYWxzZTsKIH0KIAo= 435478 2021-08-13 05:59:20 -0700 2021-08-13 07:40:31 -0700 Patch with updated expectations bug-229067-20210813095919.patch text/plain 2326 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTdhODAxYzg3ZGM1MzM2ZTgyZDc2NzQwZDkyNTg4ZmY1 YTQ4ZTAyZi4uMTUyYzhlNzZiNmU3N2EyYzE4ZWY2ZjhlZjVmNDkzMjg4ZWIzZjAyZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTA4LTEzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXUEVdIFdlYkV4dGVuc2lvbiBBUEkgdGVzdCAvd2Via2l0L1dlYktpdFdlYlZpZXcvd2Vi LXByb2Nlc3MtY3Jhc2hlZCBpcyBmbGFreSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkwNjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xp Yi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0V2ViVmlld1Byb2Nl c3NDcmFzaGVkKTogTWFrZSB3YXJuaW5ncyBub24tZmF0YWwgd2hpbGUgd2FpdGluZyBmb3IgdGhl IGNyYXNoLgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpz b246IFJlbW92ZSBleHBlY3RhdGlvbgorCiAyMDIxLTA4LTEzICBNYXJ0aW4gUm9iaW5zb24gIDxt cm9iaW5zb25Ad2Via2l0Lm9yZz4KIAogICAgICAgICBHZXQgbGludC10ZXN0LWV4cGVjdGF0aW9u cyBwYXNzaW5nCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdM aWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRHTGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcAppbmRleCA1NTlhZjk1MjhkNjY0ZjNhYWE5MmVi ZjMzMjRiMWFhNzQ3YzUwMWZhLi40MGVhZWI3YmYyN2E0Yjg0ZDczMGI0MzlmNzFmNjk2YmVkY2Vm YjExIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVz dFdlYkV4dGVuc2lvbnMuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 R0xpYi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHAKQEAgLTE2MSw3ICsxNjEsOSBAQCBzdGF0aWMgdm9p ZCB0ZXN0V2ViS2l0V2ViVmlld1Byb2Nlc3NDcmFzaGVkKFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29u c3Rwb2ludGVyKQogICAgICAgICBHX0RCVVNfQ0FMTF9GTEFHU19OT05FLAogICAgICAgICAtMSwg MCwgMCkpOwogICAgIGdfYXNzZXJ0X251bGwocmVzdWx0KTsKKyAgICBUZXN0OjpyZW1vdmVMb2dG YXRhbEZsYWcoR19MT0dfTEVWRUxfV0FSTklORyk7CiAgICAgZ19tYWluX2xvb3BfcnVuKHRlc3Qt Pm1fbWFpbkxvb3ApOworICAgIFRlc3Q6OmFkZExvZ0ZhdGFsRmxhZyhHX0xPR19MRVZFTF9XQVJO SU5HKTsKICAgICB0ZXN0LT5tX2V4cGVjdGVkV2ViUHJvY2Vzc0NyYXNoID0gZmFsc2U7CiB9CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpz b24gYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uCmluZGV4 IDJjOTMzNjIyMGQ4Y2U4OGQ2ZjA1MmViZTJmOGU5MWQ4ZDQyYTk1MDkuLjE4MmRhYjcyMjM1ZTFk ZGNkNmU1NjI2ZWM4NzY3YTc3NTUyYjg3ZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9n bGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgpAQCAtNzQsOSArNzQsNiBAQAogICAgIH0sCiAgICAg IlRlc3RXZWJFeHRlbnNpb25zIjogewogICAgICAgICAic3VidGVzdHMiOiB7Ci0gICAgICAgICAg ICAiL3dlYmtpdC9XZWJLaXRXZWJWaWV3L3dlYi1wcm9jZXNzLWNyYXNoZWQiOiB7Ci0gICAgICAg ICAgICAgICAgImV4cGVjdGVkIjogeyJ3cGUiOiB7InN0YXR1cyI6IFsiRkFJTCIsICJQQVNTIl0s ICJidWciOiBbIndlYmtpdC5vcmcvYi8yMjkwNjciXX19Ci0gICAgICAgICAgICB9LAogICAgICAg ICAgICAgIi93ZWJraXQvV2ViS2l0V2ViVmlldy9pbnN0YWxsLW1pc3NpbmctcGx1Z2lucy1wZXJt aXNzaW9uLXJlcXVlc3QiOiB7CiAgICAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJndGsiOiB7 InN0YXR1cyI6IFsiVElNRU9VVCIsICJGQUlMIl0sICJidWciOiBbIndlYmtpdC5vcmcvYi8xNDc4 MjIiLCAid2Via2l0Lm9yZy9iLzIxMDYzNSJdfX0KICAgICAgICAgICAgIH0sCg==