229051 2021-08-12 14:09:46 -0700 [GTK][WPE] Tests webgl/1.0.x/conformance/glsl/bugs/character-set.html and webgl/1.0.x/conformance/misc/invalid-passed-params.html still fail after r280904 2022-09-29 12:54:40 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228951 https://bugs.webkit.org/show_bug.cgi?id=166536 https://bugs.webkit.org/show_bug.cgi?id=208188 InRadar P2 Normal --- 1 clopez webkit-unassigned alex bugs-noreply dino kbr kkinnunen webkit-bug-importer oldest_to_newest 1783948 0 clopez 2021-08-12 14:09:46 -0700 r280904 cherry-picked an upstream Angle commit to fix the following tests: webgl/1.0.x/conformance/misc/invalid-passed-params.html webgl/1.0.x/conformance/glsl/bugs/character-set.html webgl/2.0.y/conformance/misc/invalid-passed-params.html webgl/2.0.y/conformance/glsl/bugs/character-set.html But all this 4 tests still fail after that on platforms GTK and WPE - The 2.0.y tests fail, as expected, because WebGL 2.0 is still not supported on this two platforms ( see bug 166536 and bug 208188 ) - However, the failure on the 1.0.x tests is not expected This are the text failures this two 1.0.x tests give: --- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/webgl/1.0.x/conformance/glsl/bugs/character-set-expected.txt +++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/webgl/1.0.x/conformance/glsl/bugs/character-set-actual.txt @@ -1,4 +1,57 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../../../resources/webgl_test_files/conformance/glsl/bugs/character-set.html -[ PASS ] All tests passed + +[ 1: PASS ] context exists +[ 2: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '$' in identifier until compilation. +[ 3: PASS ] getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string '$' in comment until compilation. +[ 4: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '$' in ifdef-out until compilation. +[ 5: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '$' in ifdef-out #preproc until compilation. +[ 6: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '$' in #preproc until compilation. +[ 7: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '$' in comment after #define until compilation. +[ 8: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '"' in identifier until compilation. +[ 9: PASS ] getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string '"' in comment until compilation. +[ 10: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '"' in ifdef-out until compilation. +[ 11: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '"' in ifdef-out #preproc until compilation. +[ 12: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '"' in #preproc until compilation. +[ 13: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '"' in comment after #define until compilation. +[ 14: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '一些注释' in identifier until compilation. +[ 15: PASS ] getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string '一些注释' in comment until compilation. +[ 16: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '一些注释' in ifdef-out until compilation. +[ 17: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '一些注释' in ifdef-out #preproc until compilation. +[ 18: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '一些注释' in #preproc until compilation. +[ 19: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '一些注释' in comment after #define until compilation. +[ 20: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '#line 42 "foo.glsl"' in identifier until compilation. +[ 21: PASS ] getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string '#line 42 "foo.glsl"' in comment until compilation. +[ 22: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '#line 42 "foo.glsl"' in ifdef-out until compilation. +[ 23: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '#line 42 "foo.glsl"' in ifdef-out #preproc until compilation. +[ 24: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '#line 42 "foo.glsl"' in #preproc until compilation. +[ 25: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string '#line 42 "foo.glsl"' in comment after #define until compilation. +[ 26: PASS ] Out-of-charset string '$' in identifier MUST NOT compile. +[ 27: PASS ] Out-of-charset string '$' in comment MUST compile. +[ 28: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '$' in ifdef-out MUST compile. +[ 29: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '$' in ifdef-out #preproc MUST compile. +[ 30: PASS ] Out-of-charset string '$' in #preproc MUST NOT compile. +[ 31: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '$' in comment after #define MUST compile. +[ 32: PASS ] Out-of-charset string '"' in identifier MUST NOT compile. +[ 33: PASS ] Out-of-charset string '"' in comment MUST compile. +[ 34: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '"' in ifdef-out MUST compile. +[ 35: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '"' in ifdef-out #preproc MUST compile. +[ 36: PASS ] Out-of-charset string '"' in #preproc MUST NOT compile. +[ 37: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '"' in comment after #define MUST compile. +[ 38: PASS ] Out-of-charset string '一些注释' in identifier MUST NOT compile. +[ 39: PASS ] Out-of-charset string '一些注释' in comment MUST compile. +[ 40: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '一些注释' in ifdef-out MUST compile. +[ 41: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '一些注释' in ifdef-out #preproc MUST compile. +[ 42: PASS ] Out-of-charset string '一些注释' in #preproc MUST NOT compile. +[ 43: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '一些注释' in comment after #define MUST compile. +[ 44: PASS ] Out-of-charset string '#line 42 "foo.glsl"' in identifier MUST NOT compile. +[ 45: PASS ] Out-of-charset string '#line 42 "foo.glsl"' in comment MUST compile. +[ 46: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '#line 42 "foo.glsl"' in ifdef-out MUST compile. +[ 47: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '#line 42 "foo.glsl"' in ifdef-out #preproc MUST compile. +[ 48: PASS ] Out-of-charset string '#line 42 "foo.glsl"' in #preproc MUST NOT compile. +[ 49: FAIL ] [unexpected fragment shader compile status] (expected: true) Out-of-charset string '#line 42 "foo.glsl"' in comment after #define MUST compile. +[ 50: PASS ] successfullyParsed is true +[ 51: PASS ] successfullyParsed is true +[ FAIL ] 32 failures reported +[ FAIL ] 32 failures reported --- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/webgl/1.0.x/conformance/misc/invalid-passed-params-expected.txt +++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/webgl/1.0.x/conformance/misc/invalid-passed-params-actual.txt @@ -1,4 +1,69 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../../resources/webgl_test_files/conformance/misc/invalid-passed-params.html -[ PASS ] All tests passed + +[ 1: PASS ] getError was expected value: NO_ERROR : after evaluating: context.createShader(context.FRAGMENT_SHADER) +[ 2: PASS ] getError was expected value: NO_ERROR : after evaluating: context.createShader(context.VERTEX_SHADER) +[ 3: PASS ] getError was expected value: INVALID_ENUM : after evaluating: context.createShader(0) +[ 4: PASS ] getError was expected value: INVALID_ENUM : after evaluating: context.createShader(context.TRIANGLES) +[ 5: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.clear(desktopGL['ACCUM_BUFFER_BIT']) +[ 6: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.clear(desktopGL['ACCUM_BUFFER_BIT'] | context.COLOR_BUFFER_BIT) +[ 7: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.clear(desktopGL['ACCUM_BUFFER_BIT'] | context.COLOR_BUFFER_BIT | context.DEPTH_BUFFER_BIT | context.STENCIL_BUFFER_BIT) +[ 8: PASS ] getError was expected value: NO_ERROR : after evaluating: context.clear(context.COLOR_BUFFER_BIT | context.DEPTH_BUFFER_BIT | context.STENCIL_BUFFER_BIT) +[ 9: PASS ] getError was expected value: NO_ERROR : after evaluating: context.bindTexture(context.TEXTURE_2D, tex) +[ 10: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.texImage2D(context.TEXTURE_2D, 0, context.RGBA, -16, -16, 0, context.RGBA, context.UNSIGNED_BYTE, null) +[ 11: PASS ] getError was expected value: NO_ERROR : after evaluating: context.texImage2D(context.TEXTURE_2D, 0, context.RGBA, 16, 16, 0, context.RGBA, context.UNSIGNED_BYTE, null) +[ 12: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.texSubImage2D(context.TEXTURE_2D, 0, -1, -1, 2, 2, context.RGBA, context.UNSIGNED_BYTE, pixels) +[ 13: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.texSubImage2D(context.TEXTURE_2D, 0, 0, 0, -1, -1, context.RGBA, context.UNSIGNED_BYTE, pixels) +[ 14: PASS ] getError was expected value: NO_ERROR : after evaluating: context.texSubImage2D(context.TEXTURE_2D, 0, 0, 0, 2, 2, context.RGBA, context.UNSIGNED_BYTE, pixels) +[ 15: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.copyTexImage2D(context.TEXTURE_2D, 0, context.RGBA, 0, 0, -1, -1, 0) +[ 16: PASS ] getError was expected value: NO_ERROR : after evaluating: context.copyTexImage2D(context.TEXTURE_2D, 0, context.RGBA, 0, 0, 16, 16, 0) +[ 17: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.copyTexSubImage2D(context.TEXTURE_2D, 0, -1, -1, 0, 0, 2, 2) +[ 18: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.copyTexSubImage2D(context.TEXTURE_2D, 0, 0, 0, 0, 0, -1, -1) +[ 19: PASS ] getError was expected value: NO_ERROR : after evaluating: context.copyTexSubImage2D(context.TEXTURE_2D, 0, 0, 0, 0, 0, 2, 2) +[ 20: PASS ] getError was expected value: NO_ERROR : after evaluating: context.bindRenderbuffer(context.RENDERBUFFER, renderbuffer) +[ 21: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.renderbufferStorage(context.RENDERBUFFER, context.RGBA4, -2, -2) +[ 22: PASS ] getError was expected value: NO_ERROR : after evaluating: context.renderbufferStorage(context.RENDERBUFFER, context.RGBA4, 16, 16) +[ 23: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.scissor(0, 0, -2, -2) +[ 24: PASS ] getError was expected value: NO_ERROR : after evaluating: context.scissor(0, 0, 16, 16) +[ 25: PASS ] getError was expected value: INVALID_VALUE : after evaluating: context.viewport(0, 0, -2, -2) +[ 26: PASS ] getError was expected value: NO_ERROR : after evaluating: context.viewport(0, 0, 16, 16) +[ 27: PASS ] context.getError() is context.NO_ERROR +[ 28: PASS ] context.getError() is context.NO_ERROR +[ 29: PASS ] linkStatus is true +[ 30: PASS ] context.getError() is context.NO_ERROR +[ 31: PASS ] context.getError() is context.NO_ERROR +[ 32: PASS ] context.getError() is context.NO_ERROR +[ 33: PASS ] context.getError() is context.NO_ERROR +[ 34: PASS ] context.getError() is context.NO_ERROR +[ 35: FAIL ] context.getError() should be 0. Was 1281. +[ 36: PASS ] context.getError() is context.NO_ERROR +[ 37: FAIL ] context.getError() should be 0. Was 1281. +[ 38: PASS ] context.getError() is context.NO_ERROR +[ 39: FAIL ] context.getError() should be 0. Was 1281. +[ 40: PASS ] context.getError() is context.NO_ERROR +[ 41: FAIL ] context.getError() should be 0. Was 1281. +[ 42: PASS ] context.getError() is context.NO_ERROR +[ 43: FAIL ] context.getError() should be 0. Was 1281. +[ 44: PASS ] context.getError() is context.NO_ERROR +[ 45: FAIL ] context.getError() should be 0. Was 1281. +[ 46: PASS ] context.getError() is context.INVALID_VALUE +[ 47: PASS ] context.getError() is context.INVALID_VALUE +[ 48: PASS ] context.getError() is context.INVALID_VALUE +[ 49: PASS ] context.getError() is context.INVALID_VALUE +[ 50: PASS ] context.getError() is context.INVALID_VALUE +[ 51: PASS ] context.getError() is context.INVALID_VALUE +[ 52: PASS ] context.getError() is context.INVALID_VALUE +[ 53: PASS ] context.getError() is context.INVALID_VALUE +[ 54: PASS ] context.getError() is context.INVALID_VALUE +[ 55: PASS ] context.getError() is context.INVALID_VALUE +[ 56: PASS ] context.getError() is context.INVALID_VALUE +[ 57: PASS ] context.getError() is context.INVALID_VALUE +[ 58: PASS ] context.getError() is context.INVALID_VALUE +[ 59: PASS ] context.getError() is context.INVALID_VALUE +[ 60: PASS ] context.getError() is context.INVALID_VALUE +[ 61: PASS ] context.getError() is context.INVALID_VALUE +[ 62: PASS ] context.getError() is context.INVALID_VALUE +[ 63: PASS ] context.getError() is context.INVALID_VALUE +[ 64: PASS ] successfullyParsed is true +[ FAIL ] 6 failures reported 1784012 1 clopez 2021-08-12 18:29:03 -0700 Expectations updated on r281002 1784196 2 kbr 2021-08-13 12:54:36 -0700 Have the GTK / WPE ports switched over to using ANGLE as their WebGL 1.0 backend? If not that would explain these continued failures. 1902153 3 alex 2022-09-29 12:53:54 -0700 After replacing the WebGL backend with ANGLE this test is fixed. The gardening commit is: https://commits.webkit.org/255008@main 1902155 4 webkit-bug-importer 2022-09-29 12:54:40 -0700 <rdar://problem/100578197>