229050 2021-08-12 13:31:38 -0700 [GTK][WPE] Test fast/canvas/webgl/shader-with-comma-op.html and fast/canvas/webgl/shader-with-struct-array.html fail since they were added 2022-09-29 12:49:22 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=227723 https://bugs.webkit.org/show_bug.cgi?id=226865 InRadar P2 Normal --- 1 clopez webkit-unassigned alex bugs-noreply dino kbr kkinnunen kpiddington webkit-bug-importer oldest_to_newest 1783936 0 clopez 2021-08-12 13:31:38 -0700 Test fast/canvas/webgl/shader-with-comma-op.html fails since it was added on r279656 on GTK and WPE. The text failure is: --- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-comma-op-expected.txt +++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-comma-op-actual.txt @@ -1,12 +1,16 @@ +CONSOLE MESSAGE: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays +CONSOLE MESSAGE: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays +CONSOLE MESSAGE: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays Tests compiling programs that use the 'sequence' operator.. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS getError was expected value: NO_ERROR : no error for using comma operator with void function -PASS getError was expected value: NO_ERROR : no error for using comma operator with non-void function -PASS getError was expected value: NO_ERROR : no error for using comma operator with standard type +FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : no error for using comma operator with void function +FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : no error for using comma operator with non-void function +FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : no error for using comma operator with standard type PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1783939 1 clopez 2021-08-12 13:40:05 -0700 Also, likely related to the same issue, test fast/canvas/webgl/shader-with-struct-array.html fails since it was added on r279968 on GTK and WPE The text failure is: --- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-struct-array-expected.txt +++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-struct-array-actual.txt @@ -1,10 +1,11 @@ +CONSOLE MESSAGE: TypeError: null is not an object (evaluating 'gl.createShader') Tests that program compiling/linking with a struct-array construct. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS getError was expected value: NO_ERROR : no error for struct array in program -PASS successfullyParsed is true +FAIL successfullyParsed should be true. Was false. +Some tests failed. TEST COMPLETE 1783940 2 clopez 2021-08-12 13:42:04 -0700 This two tests seems related to the Metal backend of WebGL. On Linux Metal is not supported. I wonder if the output they give is expected and we should simply skip them or there is something to fix on the WebKit Linux/WebGL backend? 1784015 3 clopez 2021-08-12 18:29:16 -0700 Expectations updated on r281002 1784241 4 kpiddington 2021-08-13 14:57:17 -0700 As a heads up, these tests were added to verify fixing the following two samples: https://bugs.webkit.org/show_bug.cgi?id=226865 Shader-with-struct-array: https://zynaps.com/content/photon/ Shader with comma-op https://bugs.webkit.org/show_bug.cgi?id=227723 https://jsfiddle.net/9p1f3t5r/2/ 1902144 5 alex 2022-09-29 12:48:15 -0700 After replacing the WebGL backend with ANGLE these tests are fixed. The gardening commit is: https://commits.webkit.org/255008@main 1902145 6 webkit-bug-importer 2022-09-29 12:49:22 -0700 <rdar://problem/100577998>