229036 2021-08-12 05:19:00 -0700 ANGLE translator testing does not support MSL 2022-02-10 16:41:05 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 229033 1 kkinnunen kkinnunen dino ews-watchlist kbr kkinnunen kondapallykalyan oldest_to_newest 1783798 0 kkinnunen 2021-08-12 05:19:00 -0700 ANGLE translator fuzzer does not support MSL 1783799 1 435418 kkinnunen 2021-08-12 05:25:51 -0700 Created attachment 435418 Patch 1783800 2 ews-watchlist 2021-08-12 05:26:53 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1784245 3 435418 kbr 2021-08-13 15:02:00 -0700 Comment on attachment 435418 Patch Is this a cherry-pick of an upstream commit? If so could you please refer to it in the commit message? If not - would you please put up a CL against upstream ANGLE making this change so it can be reviewed there first? 1784430 4 kkinnunen 2021-08-16 00:35:10 -0700 (In reply to Kenneth Russell from comment #3) > Is this a cherry-pick of an upstream commit? If so could you please refer to > it in the commit message? > > If not - would you please put up a CL against upstream ANGLE making this > change so it can be reviewed there first? This one is "original content" by yours truly. I'll check what's the status with contributing directly to upstream... 435418 2021-08-12 05:25:51 -0700 2022-02-10 16:41:05 -0800 Patch bug-229036-20210812152550.patch text/plain 6480 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwOTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNGNiMjUxOGQxNDFiMmZkZTk0ZTA4ZmQ4NjRiN2JkMzVlOGY2NjZjYi4uYWEzZmZlMDAzODc1 ZTRjZTkwYTU5ZjliY2MzZWNiODRmOThkMTY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA4LTEyICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgdHJhbnNsYXRvciB0ZXN0aW5nIGRvZXMgbm90 IHN1cHBvcnQgTVNMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjkwMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgdGhlIG1pc3Npbmcgb3V0cHV0cy4KKyAgICAgICAgQWRkIHRoZSBhYmlsaXR5IHRv IHVzZSBhbiBlbnZpcm9ubWVudCB2YXJpYWJsZSB0bworICAgICAgICBsaW1pdCB0aGUgdGVzdGlu ZyB0byBjZXJ0YWluIG91dHB1dHMuCisKKyAgICAgICAgKiBzcmMvY29tcGlsZXIvZnV6ei90cmFu c2xhdG9yX2Z1enplci5jcHA6CisgICAgICAgIChzaDo6aW5pdGlhbGl6ZVZhbGlkT3V0cHV0cyk6 CisgICAgICAgIChMTFZNRnV6emVyVGVzdE9uZUlucHV0KToKKwogMjAyMS0wOC0xMiAgS2ltbW8g S2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAgIENoZXJyeS1waWNrIEFO R0xFOiBGaXggdHJhbnNsYXRvciBmdXp6ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21waWxlci9mdXp6L3RyYW5zbGF0b3JfZnV6emVyLmNwcCBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9mdXp6L3RyYW5zbGF0b3JfZnV6emVyLmNwcApp bmRleCA5MDY5Y2NmM2JhYjNiZTE0NTg5ZWNjMzdmOGIzMWRjN2YxZTA1Nzg4Li5hZGEzYjJjZTFm NjUzODliMmY1YmFlMzdmMThlMWZjNjRhODQ0M2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZnV6ei90cmFuc2xhdG9yX2Z1enplci5jcHAKKysrIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL2Z1enovdHJhbnNsYXRvcl9mdXp6 ZXIuY3BwCkBAIC0xNCw2ICsxNCw4IEBACiAKICNpbmNsdWRlICJhbmdsZV9nbC5oIgogI2luY2x1 ZGUgImFuZ2xlYmFzZS9ub19kZXN0cnVjdG9yLmgiCisjaW5jbHVkZSAiY29tbW9uL3N0cmluZ191 dGlscy5oIgorI2luY2x1ZGUgImNvbW1vbi9zeXN0ZW1fdXRpbHMuaCIKICNpbmNsdWRlICJjb21w aWxlci90cmFuc2xhdG9yL0NvbXBpbGVyLmgiCiAjaW5jbHVkZSAiY29tcGlsZXIvdHJhbnNsYXRv ci91dGlsLmgiCiAKQEAgLTcyLDYgKzc0LDg5IEBAIGNvbnN0ZXhwciBTaENvbXBpbGVPcHRpb25z IGtITFNMT25seU9wdGlvbnMgPSBTSF9FWFBBTkRfU0VMRUNUX0hMU0xfSU5URUdFUl9QT1dfCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU0hfQUxMT1dfVFJB TlNMQVRFX1VOSUZPUk1fQkxPQ0tfVE9fU1RSVUNUVVJFREJVRkZFUiB8CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU0hfUkVXUklURV9JTlRFR0VSX1VOQVJZ X01JTlVTX09QRVJBVE9SOwogCitzdGF0aWMgdWludDMyX3QgdmFsaWRPdXRwdXRzW10gPSB7Cisg ICAgU0hfRVNTTF9PVVRQVVQsCisgICAgU0hfR0xTTF9DT01QQVRJQklMSVRZX09VVFBVVCwKKyAg ICBTSF9HTFNMXzEzMF9PVVRQVVQsCisgICAgU0hfR0xTTF8xNDBfT1VUUFVULAorICAgIFNIX0dM U0xfMTUwX0NPUkVfT1VUUFVULAorICAgIFNIX0dMU0xfMzMwX0NPUkVfT1VUUFVULAorICAgIFNI X0dMU0xfNDAwX0NPUkVfT1VUUFVULAorICAgIFNIX0dMU0xfNDEwX0NPUkVfT1VUUFVULAorICAg IFNIX0dMU0xfNDIwX0NPUkVfT1VUUFVULAorICAgIFNIX0dMU0xfNDMwX0NPUkVfT1VUUFVULAor ICAgIFNIX0dMU0xfNDQwX0NPUkVfT1VUUFVULAorICAgIFNIX0dMU0xfNDUwX0NPUkVfT1VUUFVU LAorICAgIFNIX0hMU0xfM18wX09VVFBVVCwKKyAgICBTSF9ITFNMXzRfMV9PVVRQVVQsCisgICAg U0hfSExTTF80XzBfRkw5XzNfT1VUUFVULAorICAgIFNIX0dMU0xfVlVMS0FOX09VVFBVVCwKKyAg ICBTSF9HTFNMX01FVEFMX09VVFBVVCwKKyAgICBTSF9NU0xfTUVUQUxfT1VUUFVUCit9OworCitz dGF0aWMgaW50IGluaXRpYWxpemVWYWxpZE91dHB1dHMoKQoreworICAgIHN0ZDo6c3RyaW5nIG91 dHB1dFNwZWMgPSBhbmdsZTo6R2V0RW52aXJvbm1lbnRWYXIoIkFOR0xFX1RSQU5TTEFUT1JfRlVa WkVSX09VVFBVVCIpOworICAgIHN0ZDo6dmVjdG9yPHN0ZDo6c3RyaW5nPiBvdXRwdXRzID0gYW5n bGU6OlNwbGl0U3RyaW5nKG91dHB1dFNwZWMsICI7LDogIiwgYW5nbGU6OktFRVBfV0hJVEVTUEFD RSwgYW5nbGU6OlNQTElUX1dBTlRfTk9ORU1QVFkpOworICAgIGlmIChvdXRwdXRzLmVtcHR5KCkp CisgICAgeworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisgICAgaW50IG8gPSAwOworICAgIGZv ciAoc3RkOjpzdHJpbmcgb3V0cHV0IDogb3V0cHV0cykKKyAgICB7CisgICAgICAgIGlmIChvdXRw dXQgPT0gIkVTU0wiKQorICAgICAgICB7CisgICAgICAgICAgICB2YWxpZE91dHB1dHNbbysrXSA9 IFNIX0VTU0xfT1VUUFVUOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKG91dHB1dCA9PSAi R0xTTCIpIHsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0gU0hfR0xTTF9DT01QQVRJ QklMSVRZX09VVFBVVDsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0gU0hfR0xTTF8x MzBfT1VUUFVUOworICAgICAgICAgICAgdmFsaWRPdXRwdXRzW28rK10gPSBTSF9HTFNMXzE0MF9P VVRQVVQ7CisgICAgICAgICAgICB2YWxpZE91dHB1dHNbbysrXSA9IFNIX0dMU0xfMTUwX0NPUkVf T1VUUFVUOworICAgICAgICAgICAgdmFsaWRPdXRwdXRzW28rK10gPSBTSF9HTFNMXzMzMF9DT1JF X09VVFBVVDsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0gU0hfR0xTTF80MDBfQ09S RV9PVVRQVVQ7CisgICAgICAgICAgICB2YWxpZE91dHB1dHNbbysrXSA9IFNIX0dMU0xfNDEwX0NP UkVfT1VUUFVUOworICAgICAgICAgICAgdmFsaWRPdXRwdXRzW28rK10gPSBTSF9HTFNMXzQyMF9D T1JFX09VVFBVVDsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0gU0hfR0xTTF80MzBf Q09SRV9PVVRQVVQ7CisgICAgICAgICAgICB2YWxpZE91dHB1dHNbbysrXSA9IFNIX0dMU0xfNDQw X0NPUkVfT1VUUFVUOworICAgICAgICAgICAgdmFsaWRPdXRwdXRzW28rK10gPSBTSF9HTFNMXzQ1 MF9DT1JFX09VVFBVVDsKKyAgICAgICAgfQorICAgICAgICBlbHNlIGlmIChvdXRwdXQgPT0gIkhM U0wiKQorICAgICAgICB7CisgICAgICAgICAgICB2YWxpZE91dHB1dHNbbysrXSA9IFNIX0hMU0xf M18wX09VVFBVVDsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0gU0hfSExTTF80XzFf T1VUUFVUOworICAgICAgICAgICAgdmFsaWRPdXRwdXRzW28rK10gPSBTSF9ITFNMXzRfMF9GTDlf M19PVVRQVVQ7CisgICAgICAgIH0KKyAgICAgICAgZWxzZSBpZiAob3V0cHV0ID09ICJHTFNMX1ZV TEtBTiIpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0gU0hfR0xT TF9WVUxLQU5fT1VUUFVUOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKG91dHB1dCA9PSAi R0xTTF9NRVRBTCIpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhbGlkT3V0cHV0c1tvKytdID0g U0hfR0xTTF9NRVRBTF9PVVRQVVQ7CisgICAgICAgIH0KKyAgICAgICAgZWxzZSBpZiAob3V0cHV0 ID09ICJNU0wiKQorICAgICAgICB7CisgICAgICAgICAgICB2YWxpZE91dHB1dHNbbysrXSA9IFNI X01TTF9NRVRBTF9PVVRQVVQ7CisgICAgICAgIH0KKyAgICAgICAgZWxzZQorICAgICAgICB7Cisg ICAgICAgICAgICBVTlJFQUNIQUJMRSgpOworICAgICAgICB9CisgICAgfQorICAgIGlmIChvID4g MCkKKyAgICB7CisgICAgICAgIHVpbnQzMl90IGxhc3RWYWxpZE91dHB1dCA9IHZhbGlkT3V0cHV0 c1tvIC0gMV07CisgICAgICAgIGZvciAoaW50IGkgPSBvOyBpIDwgc2l6ZW9mKHZhbGlkT3V0cHV0 cykgLyBzaXplb2YoKnZhbGlkT3V0cHV0cyk7ICsraSkKKyAgICAgICAgeworICAgICAgICAgICAg dmFsaWRPdXRwdXRzW2ldID0gbGFzdFZhbGlkT3V0cHV0OworICAgICAgICB9CisgICAgfQorICAg IHJldHVybiAwOworfQorCiBzdHJ1Y3QgVHJhbnNsYXRvckNhY2hlS2V5CiB7CiAgICAgYm9vbCBv cGVyYXRvcj09KGNvbnN0IFRyYW5zbGF0b3JDYWNoZUtleSAmb3RoZXIpIGNvbnN0CkBAIC0xMDYs NiArMTkxLDkgQEAgc3RydWN0IFRDb21waWxlckRlbGV0ZXIKIAogZXh0ZXJuICJDIiBpbnQgTExW TUZ1enplclRlc3RPbmVJbnB1dChjb25zdCB1aW50OF90ICpkYXRhLCBzaXplX3Qgc2l6ZSkKIHsK KyAgICBzdGF0aWMgaW50IHVudXNlZCA9IGluaXRpYWxpemVWYWxpZE91dHB1dHMoKTsKKyAgICBB TkdMRV9VTlVTRURfVkFSSUFCTEUodW51c2VkKTsKKwogICAgIC8vIFJlc2VydmUgc29tZSBzaXpl IGZvciBmdXR1cmUgY29tcGlsZSBvcHRpb25zCiAgICAgY29uc3Qgc2l6ZV90IGtIZWFkZXJTaXpl ID0gMTI4OwogCkBAIC0xNjIsMjIgKzI1MCw2IEBAIGV4dGVybiAiQyIgaW50IExMVk1GdXp6ZXJU ZXN0T25lSW5wdXQoY29uc3QgdWludDhfdCAqZGF0YSwgc2l6ZV90IHNpemUpCiAgICAgICAgIHJl dHVybiAwOwogICAgIH0KIAotICAgIHN0ZDo6dmVjdG9yPHVpbnQzMl90PiB2YWxpZE91dHB1dHM7 Ci0gICAgdmFsaWRPdXRwdXRzLnB1c2hfYmFjayhTSF9FU1NMX09VVFBVVCk7Ci0gICAgdmFsaWRP dXRwdXRzLnB1c2hfYmFjayhTSF9HTFNMX0NPTVBBVElCSUxJVFlfT1VUUFVUKTsKLSAgICB2YWxp ZE91dHB1dHMucHVzaF9iYWNrKFNIX0dMU0xfMTMwX09VVFBVVCk7Ci0gICAgdmFsaWRPdXRwdXRz LnB1c2hfYmFjayhTSF9HTFNMXzE0MF9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2Jh Y2soU0hfR0xTTF8xNTBfQ09SRV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2so U0hfR0xTTF8zMzBfQ09SRV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hf R0xTTF80MDBfQ09SRV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hfR0xT TF80MTBfQ09SRV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hfR0xTTF80 MjBfQ09SRV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hfR0xTTF80MzBf Q09SRV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hfR0xTTF80NDBfQ09S RV9PVVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hfR0xTTF80NTBfQ09SRV9P VVRQVVQpOwotICAgIHZhbGlkT3V0cHV0cy5wdXNoX2JhY2soU0hfSExTTF8zXzBfT1VUUFVUKTsK LSAgICB2YWxpZE91dHB1dHMucHVzaF9iYWNrKFNIX0hMU0xfNF8xX09VVFBVVCk7Ci0gICAgdmFs aWRPdXRwdXRzLnB1c2hfYmFjayhTSF9ITFNMXzRfMF9GTDlfM19PVVRQVVQpOwogICAgIGJvb2wg Zm91bmQgPSBmYWxzZTsKICAgICBmb3IgKGF1dG8gdmFsaWQgOiB2YWxpZE91dHB1dHMpCiAgICAg ewpAQCAtMjI4LDcgKzMwMCwxMSBAQCBleHRlcm4gIkMiIGludCBMTFZNRnV6emVyVGVzdE9uZUlu cHV0KGNvbnN0IHVpbnQ4X3QgKmRhdGEsIHNpemVfdCBzaXplKQogICAgICAgICByZXNvdXJjZXMu RVhUX2RyYXdfYnVmZmVycyAgICAgICAgICAgICAgICA9IDE7CiAgICAgICAgIHJlc291cmNlcy5F WFRfZnJhZ19kZXB0aCAgICAgICAgICAgICAgICAgID0gMTsKICAgICAgICAgcmVzb3VyY2VzLkVY VF9zaGFkZXJfdGV4dHVyZV9sb2QgICAgICAgICAgPSAxOwotICAgICAgICByZXNvdXJjZXMuV0VC R0xfZGVidWdfc2hhZGVyX3ByZWNpc2lvbiAgICA9IDE7CisgICAgICAgIGlmIChvdXRwdXQgIT0g U0hfTVNMX01FVEFMX09VVFBVVCkKKyAgICAgICAgeworICAgICAgICAgICAgLy8gRklYTUU6IFRo aXMgaXMgY3VycmVudGx5IHVuaW1wbGVtZW50ZWQuCisgICAgICAgICAgICByZXNvdXJjZXMuV0VC R0xfZGVidWdfc2hhZGVyX3ByZWNpc2lvbiA9IDE7CisgICAgICAgIH0KICAgICAgICAgcmVzb3Vy Y2VzLkVYVF9zaGFkZXJfZnJhbWVidWZmZXJfZmV0Y2ggICAgPSAxOwogICAgICAgICByZXNvdXJj ZXMuTlZfc2hhZGVyX2ZyYW1lYnVmZmVyX2ZldGNoICAgICA9IDE7CiAgICAgICAgIHJlc291cmNl cy5BUk1fc2hhZGVyX2ZyYW1lYnVmZmVyX2ZldGNoICAgID0gMTsK