229030 2021-08-12 03:35:57 -0700 [ATK] Critical warnings on children-changed::add signal emission 2021-08-12 06:51:26 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All All RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1783771 0 cgarcia 2021-08-12 03:35:57 -0700 (WebKitWebProcess:53022): Atk-CRITICAL **: 12:18:23.108: atk_state_set_contains_state: assertion 'ATK_IS_STATE_SET (set)' failed (WebKitWebProcess:53022): GLib-GObject-CRITICAL **: 12:18:23.108: g_object_unref: assertion 'G_IS_OBJECT (object)' failed (WebKitWebProcess:53022): Atk-CRITICAL **: 12:18:23.108: atk_state_set_contains_state: assertion 'ATK_IS_STATE_SET (set)' failed (WebKitWebProcess:53022): GLib-GObject-CRITICAL **: 12:18:23.108: g_object_unref: assertion 'G_IS_OBJECT (object)' failed (WebKitWebProcess:53022): Atk-CRITICAL **: 12:18:23.108: atk_state_set_contains_state: assertion 'ATK_IS_STATE_SET (set)' failed (WebKitWebProcess:53022): GLib-GObject-CRITICAL **: 12:18:23.109: g_object_unref: assertion 'G_IS_OBJECT (object)' failed (WebKitWebProcess:53022): Atk-CRITICAL **: 12:18:23.109: atk_state_set_contains_state: assertion 'ATK_IS_STATE_SET (set)' failed (WebKitWebProcess:53022): GLib-GObject-CRITICAL **: 12:18:23.109: g_object_unref: assertion 'G_IS_OBJECT (object)' failed We should implement AtkObjectClass::ref_state_set in WebKitWebPageAccessibilityObject 1783772 1 435407 cgarcia 2021-08-12 03:39:44 -0700 Created attachment 435407 Patch 1783815 2 cgarcia 2021-08-12 06:51:26 -0700 Committed r280964 (240470@main): <https://commits.webkit.org/240470@main> 435407 2021-08-12 03:39:44 -0700 2021-08-12 06:20:22 -0700 Patch wkatk-criticals.diff text/plain 2313 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZWUyM2E4Y2JjNDNmLi42ZWQzNDMwOWFlZGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjEtMDgtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtBVEtdIENyaXRpY2FsIHdhcm5pbmdzIG9uIGNoaWxkcmVuLWNo YW5nZWQ6OmFkZCBzaWduYWwgZW1pc3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyOTAzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBBdGtPYmplY3RDbGFzczo6cmVmX3N0YXRlX3Nl dC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViS2l0V2ViUGFnZUFjY2Vz c2liaWxpdHlPYmplY3QuY3BwOgorICAgICAgICAod2Via2l0V2ViUGFnZUFjY2Vzc2liaWxpdHlP YmplY3RSZWZTdGF0ZVNldCk6IFJldHVybiBvdXIgY2hpbGQgc3RhdGUgc2V0LgorICAgICAgICAo d2Via2l0X3dlYl9wYWdlX2FjY2Vzc2liaWxpdHlfb2JqZWN0X2NsYXNzX2luaXQpOiBBZGQgYW4g aW1wbGVtZW50YXRpb24gZm9yIEF0a09iamVjdENsYXNzOjpyZWZfc3RhdGVfc2V0LgorCiAyMDIx LTA4LTExICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgRnVuY3Rp b24gX29zX2ZlYXR1cmVfZW5hYmxlZF9pbXBsKCkgZXhwZWN0cyBjb21waWxlLXRpbWUgc3RhdGlj IHN0cmluZ3MgYXMgYXJndW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9hdGsvV2ViS2l0V2ViUGFnZUFjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvYXRrL1dlYktpdFdlYlBhZ2VBY2Nlc3NpYmls aXR5T2JqZWN0LmNwcAppbmRleCBjYzkwNWZkN2RjODQuLmVkZDIxOGI2OWRlOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvYXRrL1dlYktpdFdlYlBhZ2VBY2Nl c3NpYmlsaXR5T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9hdGsvV2ViS2l0V2ViUGFnZUFjY2Vzc2liaWxpdHlPYmplY3QuY3BwCkBAIC0xMzksNiArMTM5 LDE0IEBAIHN0YXRpYyBBdGtPYmplY3QqIHdlYmtpdFdlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0 UmVmQ2hpbGQoQXRrT2JqZWN0KiBhdGtPYmplY3QsCiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAK K3N0YXRpYyBBdGtTdGF0ZVNldCogd2Via2l0V2ViUGFnZUFjY2Vzc2liaWxpdHlPYmplY3RSZWZT dGF0ZVNldChBdGtPYmplY3QqIGF0a09iamVjdCkKK3sKKyAgICBpZiAoYXV0byogcm9vdE9iamVj dFdyYXBwZXIgPSBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIoYXRrT2JqZWN0KSkKKyAg ICAgICAgcmV0dXJuIGF0a19vYmplY3RfcmVmX3N0YXRlX3NldChyb290T2JqZWN0V3JhcHBlcik7 CisKKyAgICByZXR1cm4gYXRrX3N0YXRlX3NldF9uZXcoKTsKK30KKwogc3RhdGljIHZvaWQgd2Vi a2l0X3dlYl9wYWdlX2FjY2Vzc2liaWxpdHlfb2JqZWN0X2NsYXNzX2luaXQoV2ViS2l0V2ViUGFn ZUFjY2Vzc2liaWxpdHlPYmplY3RDbGFzcyoga2xhc3MpCiB7CiAgICAgQXRrT2JqZWN0Q2xhc3Mq IGF0a09iamVjdENsYXNzID0gQVRLX09CSkVDVF9DTEFTUyhrbGFzcyk7CkBAIC0xNDksNiArMTU3 LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9wYWdlX2FjY2Vzc2liaWxpdHlfb2JqZWN0X2Ns YXNzX2luaXQoV2ViS2l0V2ViUGFnZUFjY2Vzc2kKICAgICBhdGtPYmplY3RDbGFzcy0+Z2V0X2lu ZGV4X2luX3BhcmVudCA9IHdlYmtpdFdlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0R2V0SW5kZXhJ blBhcmVudDsKICAgICBhdGtPYmplY3RDbGFzcy0+Z2V0X25fY2hpbGRyZW4gPSB3ZWJraXRXZWJQ YWdlQWNjZXNzaWJpbGl0eU9iamVjdEdldE5DaGlsZHJlbjsKICAgICBhdGtPYmplY3RDbGFzcy0+ cmVmX2NoaWxkID0gd2Via2l0V2ViUGFnZUFjY2Vzc2liaWxpdHlPYmplY3RSZWZDaGlsZDsKKyAg ICBhdGtPYmplY3RDbGFzcy0+cmVmX3N0YXRlX3NldCA9IHdlYmtpdFdlYlBhZ2VBY2Nlc3NpYmls aXR5T2JqZWN0UmVmU3RhdGVTZXQ7CiB9CiAKIEF0a09iamVjdCogd2Via2l0V2ViUGFnZUFjY2Vz c2liaWxpdHlPYmplY3ROZXcoV2ViUGFnZSogcGFnZSkK