<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>229019</bug_id>
          
          <creation_ts>2021-08-11 20:34:49 -0700</creation_ts>
          <short_desc>[JSC] Enable ThinLTO</short_desc>
          <delta_ts>2022-03-08 08:43:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>ap</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1783717</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-08-11 20:34:49 -0700</bug_when>
    <thetext>[JSC] Enable ThinLTO</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783718</commentid>
    <comment_count>1</comment_count>
      <attachid>435392</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-08-11 20:39:04 -0700</bug_when>
    <thetext>Created attachment 435392
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783719</commentid>
    <comment_count>2</comment_count>
      <attachid>435393</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-08-11 20:41:24 -0700</bug_when>
    <thetext>Created attachment 435393
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783720</commentid>
    <comment_count>3</comment_count>
      <attachid>435393</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-08-11 20:44:51 -0700</bug_when>
    <thetext>Comment on attachment 435393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435393&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:3
&gt; +        [JSC] Enable ThinLTO

What is the build time impact? What I’m observing for the rest of WebKit is substantially slower than what was promised when we were enabling it, and we should consider disabling it everywhere :(

If this adds minutes to build time, it’s likely not worth 0.3%.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783722</commentid>
    <comment_count>4</comment_count>
      <attachid>435393</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2021-08-11 20:51:18 -0700</bug_when>
    <thetext>Comment on attachment 435393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435393&amp;action=review

r=me

&gt; Source/JavaScriptCore/ChangeLog:14
&gt; +        We should enable ThinLTO for all WebKit components (only JSC is not using that).

I think you meant to say that &quot;We already enable ThinLTO for all WebKit components (only JSC is not using it).  This patch now allows JSC to use ThinLTO too.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783723</commentid>
    <comment_count>5</comment_count>
      <attachid>435393</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-08-11 20:52:26 -0700</bug_when>
    <thetext>Comment on attachment 435393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435393&amp;action=review

&gt;&gt; Source/JavaScriptCore/ChangeLog:3
&gt;&gt; +        [JSC] Enable ThinLTO
&gt; 
&gt; What is the build time impact? What I’m observing for the rest of WebKit is substantially slower than what was promised when we were enabling it, and we should consider disabling it everywhere :(
&gt; 
&gt; If this adds minutes to build time, it’s likely not worth 0.3%.

No, we are really needing to have any sub-percent currently. 0.3% is *huge*.

&gt;&gt; Source/JavaScriptCore/ChangeLog:14
&gt;&gt; +        We should enable ThinLTO for all WebKit components (only JSC is not using that).
&gt; 
&gt; I think you meant to say that &quot;We already enable ThinLTO for all WebKit components (only JSC is not using it).  This patch now allows JSC to use ThinLTO too.&quot;

Added.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783724</commentid>
    <comment_count>6</comment_count>
      <attachid>435393</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-08-11 20:54:29 -0700</bug_when>
    <thetext>Comment on attachment 435393
Patch

r-, this is unacceptable to land when the trade off isn’t even measured.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783827</commentid>
    <comment_count>7</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2021-08-12 08:26:13 -0700</bug_when>
    <thetext>I&apos;m not going to comment on whether .3% is or isn&apos;t worth the trade-off in build time but I think it</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783830</commentid>
    <comment_count>8</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2021-08-12 08:29:29 -0700</bug_when>
    <thetext>(In reply to Keith Miller from comment #7)
&gt; I&apos;m not going to comment on whether .3% is or isn&apos;t worth the trade-off in
&gt; build time but I think it

Ugh, I hate how easy it is to press tab then enter and submit before finishing typing... Anyway,

I&apos;m not going to comment on whether .3% is or isn&apos;t worth the trade-off in build time but I think it might be worth considering having a non-lto release testing build flavor and a release/production build, which enables it. We already have this to some degree for JSC, where we have a release build with debug asserts enabled. Perhaps we should consider migrating to something like that more generally?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1784001</commentid>
    <comment_count>9</comment_count>
      <attachid>435393</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-08-12 17:40:55 -0700</bug_when>
    <thetext>Comment on attachment 435393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435393&amp;action=review

&gt;&gt;&gt; Source/JavaScriptCore/ChangeLog:3
&gt;&gt;&gt; +        [JSC] Enable ThinLTO
&gt;&gt; 
&gt;&gt; What is the build time impact? What I’m observing for the rest of WebKit is substantially slower than what was promised when we were enabling it, and we should consider disabling it everywhere :(
&gt;&gt; 
&gt;&gt; If this adds minutes to build time, it’s likely not worth 0.3%.
&gt; 
&gt; No, we are really needing to have any sub-percent currently. 0.3% is *huge*.

Turned out this only adds ~1 min to builder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1784033</commentid>
    <comment_count>10</comment_count>
      <attachid>435393</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-08-12 20:01:32 -0700</bug_when>
    <thetext>Comment on attachment 435393
Patch

This is still not ready for review, as discussed online.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1785350</commentid>
    <comment_count>11</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-08-18 20:35:27 -0700</bug_when>
    <thetext>&lt;rdar://problem/82107543&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849264</commentid>
    <comment_count>12</comment_count>
      <attachid>454122</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2022-03-08 07:58:35 -0800</bug_when>
    <thetext>Created attachment 454122
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849265</commentid>
    <comment_count>13</comment_count>
      <attachid>454122</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2022-03-08 08:04:10 -0800</bug_when>
    <thetext>Comment on attachment 454122
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849282</commentid>
    <comment_count>14</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-03-08 08:43:41 -0800</bug_when>
    <thetext>Committed r290993 (248171@main): &lt;https://commits.webkit.org/248171@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454122.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>435392</attachid>
            <date>2021-08-11 20:39:04 -0700</date>
            <delta_ts>2021-08-11 20:41:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-229019-20210811203903.patch</filename>
            <type>text/plain</type>
            <size>4979</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx
ZDM4N2Q3MjBmMzEyNjFlMjRkMmU5ZTRmYTM5ZTBhOGIwMDhjMmU3Li5iMTc2ZjQ0MmZjOTI0YjMy
OGI3ZjhmNzYyNzc4ZmU0MjhhOGU2ZmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSw0OSBAQAorMjAyMS0wOC0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIEVuYWJsZSBUaGluTFRPIGluIEphdmFTY3JpcHRDb3JlCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkwMTkKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvcmlnaW5hbGx5
IGRpc2FibGVkIChmdWxsKSBMVE8gb24gSlNDIGJlY2F1c2Ugb2YgWzFdLAorICAgICAgICBhbmQg
bGF0ZXIgVGhpbkxUTyBpcyBqdXN0IGRpc2FibGVkIGZvciBKU0MgZnJvbSB0aGUgYmVnaW5uaW5n
LgorICAgICAgICBJdCB3YXMgMjAxNiwgd2hpY2ggaXMgNSB5ZWFycyBhZ28sIGFuZCB0aGVyZSB3
YXMgbm8gdGVzdCBmb3IgVGhpbkxUTy4KKworICAgICAgICBXZSB0cmllZCBhbmQgdGhlIHByb2Js
ZW0gaW4gcmRhcjovLzI0NTQzNTQ3IGRvZXMgbm90IG9jY3VyIGFueW1vcmUuCisgICAgICAgIEFu
ZCB3ZSBvYnNlcnZlZCB0aGF0IHRoaXMgb2ZmZXJzIDAuMyUgaW1wcm92ZW1lbnQgaW4gU3BlZWRv
bWV0ZXIyLgorICAgICAgICBXZSBzaG91bGQgZW5hYmxlIFRoaW5MVE8gZm9yIGFsbCBXZWJLaXQg
Y29tcG9uZW50cyAob25seSBKU0MgaXMgbm90IHVzaW5nIHRoYXQpLgorCisgICAgICAgIC0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0KKyAgICAgICAgfCAgICAgICAgICAgICAgIHN1YnRlc3QgICAgICAgICAgICAg
ICAgfCAgICAgbXMgICAgICB8ICAgICBtcyAgICAgIHwgIGIgLyBhICAgfCBwVmFsdWUgKHNpZ25p
ZmljYW5jZSB1c2luZyBGYWxzZSBEaXNjb3ZlcnkgUmF0ZSkgfAorICAgICAgICAtLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tCisgICAgICAgIHwgRWxtLVRvZG9NVkMgICAgICAgICAgICAgICAgICAgICAgICAgIHwx
MjIuMjEyNTAwICAgfDEyMC44NDU4MzMgICB8MC45ODg4MTcgIHwgMC4wMDUwODIgKHNpZ25pZmlj
YW50KSAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyAgICAgICAgfCBWdWVKUy1Ub2RvTVZD
ICAgICAgICAgICAgICAgICAgICAgICAgfDI1Ljg1MDAwMCAgICB8MjYuMDU0MTY3ICAgIHwxLjAw
Nzg5OCAgfCAwLjU2OTI1MyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
fAorICAgICAgICB8IEVtYmVySlMtVG9kb01WQyAgICAgICAgICAgICAgICAgICAgICB8MTI4LjYz
NzUwMCAgIHwxMjYuOTIwODMzICAgfDAuOTg2NjU1ICB8IDAuMDAyMDI0IChzaWduaWZpY2FudCkg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAgIHwgQmFja2JvbmVKUy1Ub2RvTVZD
ICAgICAgICAgICAgICAgICAgIHw0OC44NzUwMDAgICAgfDQ4Ljc1NDE2NyAgICB8MC45OTc1Mjgg
IHwgMC42MDI0NTUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyAg
ICAgICAgfCBQcmVhY3QtVG9kb01WQyAgICAgICAgICAgICAgICAgICAgICAgfDE5Ljc1MDAwMCAg
ICB8MTkuNjA4MzMzICAgIHwwLjk5MjgyNyAgfCAwLjY4NTE0NSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgICB8IEFuZ3VsYXJKUy1Ub2RvTVZDICAgICAg
ICAgICAgICAgICAgICB8MTM0LjAzMzMzMyAgIHwxMzMuODMzMzMzICAgfDAuOTk4NTA4ICB8IDAu
NzMyNTI4ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAg
IHwgVmFuaWxsYS1FUzIwMTUtVG9kb01WQyAgICAgICAgICAgICAgIHw2My44MTI1MDAgICAgfDY0
LjEyOTE2NyAgICB8MS4wMDQ5NjIgIHwgMC4xNzI5NDUgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHwKKyAgICAgICAgfCBJbmZlcm5vLVRvZG9NVkMgICAgICAgICAgICAg
ICAgICAgICAgfDY0LjE2NjY2NyAgICB8NjQuMjMzMzMzICAgIHwxLjAwMTAzOSAgfCAwLjg3NTU2
MSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgICB8IEZs
aWdodC1Ub2RvTVZDICAgICAgICAgICAgICAgICAgICAgICB8NzcuNjY2NjY3ICAgIHw3OC4xMzc1
MDAgICAgfDEuMDA2MDYyICB8IDAuNDYwOTI1ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB8CisgICAgICAgIHwgQW5ndWxhcjItVHlwZVNjcmlwdC1Ub2RvTVZDICAgICAg
ICAgIHw0MC4zOTU4MzMgICAgfDQwLjQyNTAwMCAgICB8MS4wMDA3MjIgIHwgMC45NTE4MzUgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyAgICAgICAgfCBWYW5pbGxh
SlMtVG9kb01WQyAgICAgICAgICAgICAgICAgICAgfDUyLjMxMjUwMCAgICB8NTIuMzQxNjY3ICAg
IHwxLjAwMDU1OCAgfCAwLjkyOTQxMiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfAorICAgICAgICB8IGpRdWVyeS1Ub2RvTVZDICAgICAgICAgICAgICAgICAgICAgICB8
MjI2Ljc5NTgzMyAgIHwyMjYuNTQ1ODMzICAgfDAuOTk4ODk4ICB8IDAuNjcwODYyICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAgIHwgRW1iZXJKUy1EZWJ1
Zy1Ub2RvTVZDICAgICAgICAgICAgICAgIHwzNDMuNDMzMzMzICAgfDM0MS41MzMzMzMgICB8MC45
OTQ0NjggIHwgMC4wMzI5NTIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHwKKyAgICAgICAgfCBSZWFjdC1Ub2RvTVZDICAgICAgICAgICAgICAgICAgICAgICAgfDg3LjY0
MTY2NyAgICB8ODYuMTgzMzMzICAgIHwwLjk4MzM2MCAgfCAwLjAwMDAwMCAoc2lnbmlmaWNhbnQp
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgICB8IFJlYWN0LVJlZHV4LVRvZG9N
VkMgICAgICAgICAgICAgICAgICB8MTQ3LjAwODMzMyAgIHwxNDUuMTE2NjY3ICAgfDAuOTg3MTMy
ICB8IDAuMDAwMDEyIChzaWduaWZpY2FudCkgICAgICAgICAgICAgICAgICAgICAgICAgICB8Cisg
ICAgICAgIHwgVmFuaWxsYS1FUzIwMTUtQmFiZWwtV2VicGFjay1Ub2RvTVZDIHw2MS44ODc1MDAg
ICAgfDYxLjUxNjY2NyAgICB8MC45OTQwMDggIHwgMC4wMTc2MzggICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwKKyAgICAgICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorICAgICAg
ICBhIG1lYW4gPSAyNTQuODIyMDgKKyAgICAgICAgYiBtZWFuID0gMjU1LjY1OTkzCisgICAgICAg
IHBWYWx1ZSA9IDAuMzQ3NDM5OTExNQorICAgICAgICAoQmlnZ2VyIG1lYW5zIGFyZSBiZXR0ZXIu
KQorICAgICAgICAxLjAwMyB0aW1lcyBiZXR0ZXIKKyAgICAgICAgUmVzdWx0cyBBUkUgTk9UIHNp
Z25pZmljYW50CisKKyAgICAgICAgWzFdOiByZGFyOi8vMjQ1NDM1NDcKKworICAgICAgICAqIENv
bmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6CisKIDIwMjEtMDgtMTEgIFl1c3VrZSBTdXp1a2kg
IDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBXVEZDcmFzaCBpbiBKU0M6OkxleGVyPGNo
YXIxNl90Pjo6YXBwZW5kOApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZp
Z3VyYXRpb25zL0Jhc2UueGNjb25maWcgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJh
dGlvbnMvQmFzZS54Y2NvbmZpZwppbmRleCA4OGQzZDRlOTk0MjU3NmViMDJmMTE4M2FmYjcxNDU2
NWIyODQ4M2E3Li42ZWE5ZWZlMjRmY2FjOWU4NGExMjFkMjM0OGZlNzVkNzllMDU3OGQwIDEwMDY0
NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZp
ZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZp
ZwpAQCAtMTgwLDkgKzE4MCw3IEBAIFdLX0NPQ09BX1RPVUNIX2FwcGxldHZvcyA9IGNvY29hdG91
Y2g7CiBXS19DT0NPQV9UT1VDSF9hcHBsZXR2c2ltdWxhdG9yID0gY29jb2F0b3VjaDsKIFdLX0lT
X0NPQ09BX1RPVUNIID0gJChXS19OT1RfJChXS19FTVBUWV8kKFdLX0NPQ09BX1RPVUNIKSkpOwog
Ci0vLyBEaXNhYmxlIExUTyBmb3IgSmF2YVNjcmlwdENvcmUsIGR1ZSB0byA8cmRhcjovL3Byb2Js
ZW0vMjQ1NDM1NDc+LiBBZGQgYmFjayB0aGUgZm9sbG93aW5nIGxpbmUgYW5kIGRlbGV0ZSB0aGUg
b25lIHRoYXQgc2F5cyAiTExWTV9MVE8gPSBOTyIgd2hlbiB0aGF0IGlzc3VlIGlzIHJlc29sdmVk
LgotLy8gTExWTV9MVE8gPSAkKFdLX0xMVk1fTFRPXyQoV0tfWENPREVfU1VQUE9SVFNfTFRPKSk7
Ci1MTFZNX0xUTyA9IE5POworTExWTV9MVE8gPSAkKFdLX0xMVk1fTFRPXyQoV0tfWENPREVfU1VQ
UE9SVFNfTFRPKSk7CiBXS19MTFZNX0xUT19OTyA9IE5POwogV0tfTExWTV9MVE9fWUVTID0gJChX
S19VU0VSX0xUT19NT0RFKTsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>435393</attachid>
            <date>2021-08-11 20:41:24 -0700</date>
            <delta_ts>2022-03-08 07:58:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-229019-20210811204123.patch</filename>
            <type>text/plain</type>
            <size>4974</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx
ZDM4N2Q3MjBmMzEyNjFlMjRkMmU5ZTRmYTM5ZTBhOGIwMDhjMmU3Li4wYzY3Y2IyYmNjNGFiYWE0
NzlhY2VhYmZhNjQ5MDkzNjRkYTdiMzk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSw0OSBAQAorMjAyMS0wOC0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIEVuYWJsZSBUaGluTFRPCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjkwMTkKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvcmlnaW5hbGx5IGRpc2FibGVkIChmdWxsKSBM
VE8gb24gSlNDIGJlY2F1c2Ugb2YgWzFdLAorICAgICAgICBhbmQgbGF0ZXIgVGhpbkxUTyBpcyBq
dXN0IGRpc2FibGVkIGZvciBKU0MgZnJvbSB0aGUgYmVnaW5uaW5nLgorICAgICAgICBJdCB3YXMg
MjAxNiwgd2hpY2ggaXMgNSB5ZWFycyBhZ28sIGFuZCB0aGVyZSB3YXMgYXR0ZW1wdCBlbmFibGlu
ZyBUaGluTFRPIGZvciBKU0MuCisKKyAgICAgICAgV2UgdHJpZWQgYW5kIHRoZSBwcm9ibGVtIGlu
IHJkYXI6Ly8yNDU0MzU0NyBkb2VzIG5vdCBvY2N1ciBhbnltb3JlLgorICAgICAgICBBbmQgd2Ug
b2JzZXJ2ZWQgdGhhdCB0aGlzIG9mZmVycyAwLjMlIGltcHJvdmVtZW50IGluIFNwZWVkb21ldGVy
Mi4KKyAgICAgICAgV2Ugc2hvdWxkIGVuYWJsZSBUaGluTFRPIGZvciBhbGwgV2ViS2l0IGNvbXBv
bmVudHMgKG9ubHkgSlNDIGlzIG5vdCB1c2luZyB0aGF0KS4KKworICAgICAgICAtLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tCisgICAgICAgIHwgICAgICAgICAgICAgICBzdWJ0ZXN0ICAgICAgICAgICAgICAgIHwg
ICAgIG1zICAgICAgfCAgICAgbXMgICAgICB8ICBiIC8gYSAgIHwgcFZhbHVlIChzaWduaWZpY2Fu
Y2UgdXNpbmcgRmFsc2UgRGlzY292ZXJ5IFJhdGUpIHwKKyAgICAgICAgLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LQorICAgICAgICB8IEVsbS1Ub2RvTVZDICAgICAgICAgICAgICAgICAgICAgICAgICB8MTIyLjIx
MjUwMCAgIHwxMjAuODQ1ODMzICAgfDAuOTg4ODE3ICB8IDAuMDA1MDgyIChzaWduaWZpY2FudCkg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAgIHwgVnVlSlMtVG9kb01WQyAgICAg
ICAgICAgICAgICAgICAgICAgIHwyNS44NTAwMDAgICAgfDI2LjA1NDE2NyAgICB8MS4wMDc4OTgg
IHwgMC41NjkyNTMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyAg
ICAgICAgfCBFbWJlckpTLVRvZG9NVkMgICAgICAgICAgICAgICAgICAgICAgfDEyOC42Mzc1MDAg
ICB8MTI2LjkyMDgzMyAgIHwwLjk4NjY1NSAgfCAwLjAwMjAyNCAoc2lnbmlmaWNhbnQpICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgICB8IEJhY2tib25lSlMtVG9kb01WQyAgICAg
ICAgICAgICAgICAgICB8NDguODc1MDAwICAgIHw0OC43NTQxNjcgICAgfDAuOTk3NTI4ICB8IDAu
NjAyNDU1ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAg
IHwgUHJlYWN0LVRvZG9NVkMgICAgICAgICAgICAgICAgICAgICAgIHwxOS43NTAwMDAgICAgfDE5
LjYwODMzMyAgICB8MC45OTI4MjcgIHwgMC42ODUxNDUgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHwKKyAgICAgICAgfCBBbmd1bGFySlMtVG9kb01WQyAgICAgICAgICAg
ICAgICAgICAgfDEzNC4wMzMzMzMgICB8MTMzLjgzMzMzMyAgIHwwLjk5ODUwOCAgfCAwLjczMjUy
OCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgICB8IFZh
bmlsbGEtRVMyMDE1LVRvZG9NVkMgICAgICAgICAgICAgICB8NjMuODEyNTAwICAgIHw2NC4xMjkx
NjcgICAgfDEuMDA0OTYyICB8IDAuMTcyOTQ1ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB8CisgICAgICAgIHwgSW5mZXJuby1Ub2RvTVZDICAgICAgICAgICAgICAgICAg
ICAgIHw2NC4xNjY2NjcgICAgfDY0LjIzMzMzMyAgICB8MS4wMDEwMzkgIHwgMC44NzU1NjEgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKyAgICAgICAgfCBGbGlnaHQt
VG9kb01WQyAgICAgICAgICAgICAgICAgICAgICAgfDc3LjY2NjY2NyAgICB8NzguMTM3NTAwICAg
IHwxLjAwNjA2MiAgfCAwLjQ2MDkyNSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfAorICAgICAgICB8IEFuZ3VsYXIyLVR5cGVTY3JpcHQtVG9kb01WQyAgICAgICAgICB8
NDAuMzk1ODMzICAgIHw0MC40MjUwMDAgICAgfDEuMDAwNzIyICB8IDAuOTUxODM1ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAgICAgIHwgVmFuaWxsYUpTLVRv
ZG9NVkMgICAgICAgICAgICAgICAgICAgIHw1Mi4zMTI1MDAgICAgfDUyLjM0MTY2NyAgICB8MS4w
MDA1NTggIHwgMC45Mjk0MTIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHwKKyAgICAgICAgfCBqUXVlcnktVG9kb01WQyAgICAgICAgICAgICAgICAgICAgICAgfDIyNi43
OTU4MzMgICB8MjI2LjU0NTgzMyAgIHwwLjk5ODg5OCAgfCAwLjY3MDg2MiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAgICB8IEVtYmVySlMtRGVidWctVG9k
b01WQyAgICAgICAgICAgICAgICB8MzQzLjQzMzMzMyAgIHwzNDEuNTMzMzMzICAgfDAuOTk0NDY4
ICB8IDAuMDMyOTUyICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8Cisg
ICAgICAgIHwgUmVhY3QtVG9kb01WQyAgICAgICAgICAgICAgICAgICAgICAgIHw4Ny42NDE2Njcg
ICAgfDg2LjE4MzMzMyAgICB8MC45ODMzNjAgIHwgMC4wMDAwMDAgKHNpZ25pZmljYW50KSAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwKKyAgICAgICAgfCBSZWFjdC1SZWR1eC1Ub2RvTVZDICAg
ICAgICAgICAgICAgICAgfDE0Ny4wMDgzMzMgICB8MTQ1LjExNjY2NyAgIHwwLjk4NzEzMiAgfCAw
LjAwMDAxMiAoc2lnbmlmaWNhbnQpICAgICAgICAgICAgICAgICAgICAgICAgICAgfAorICAgICAg
ICB8IFZhbmlsbGEtRVMyMDE1LUJhYmVsLVdlYnBhY2stVG9kb01WQyB8NjEuODg3NTAwICAgIHw2
MS41MTY2NjcgICAgfDAuOTk0MDA4ICB8IDAuMDE3NjM4ICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8CisgICAgICAgIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyAgICAgICAgYSBt
ZWFuID0gMjU0LjgyMjA4CisgICAgICAgIGIgbWVhbiA9IDI1NS42NTk5MworICAgICAgICBwVmFs
dWUgPSAwLjM0NzQzOTkxMTUKKyAgICAgICAgKEJpZ2dlciBtZWFucyBhcmUgYmV0dGVyLikKKyAg
ICAgICAgMS4wMDMgdGltZXMgYmV0dGVyCisgICAgICAgIFJlc3VsdHMgQVJFIE5PVCBzaWduaWZp
Y2FudAorCisgICAgICAgIFsxXTogcmRhcjovLzI0NTQzNTQ3CisKKyAgICAgICAgKiBDb25maWd1
cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorCiAyMDIxLTA4LTExICBZdXN1a2UgU3V6dWtpICA8eXN1
enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgV1RGQ3Jhc2ggaW4gSlNDOjpMZXhlcjxjaGFyMTZf
dD46OmFwcGVuZDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0
aW9ucy9CYXNlLnhjY29uZmlnIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25z
L0Jhc2UueGNjb25maWcKaW5kZXggODhkM2Q0ZTk5NDI1NzZlYjAyZjExODNhZmI3MTQ1NjViMjg0
ODNhNy4uNmVhOWVmZTI0ZmNhYzllODRhMTIxZDIzNDhmZTc1ZDc5ZTA1NzhkMCAxMDA2NDQKLS0t
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAg
LTE4MCw5ICsxODAsNyBAQCBXS19DT0NPQV9UT1VDSF9hcHBsZXR2b3MgPSBjb2NvYXRvdWNoOwog
V0tfQ09DT0FfVE9VQ0hfYXBwbGV0dnNpbXVsYXRvciA9IGNvY29hdG91Y2g7CiBXS19JU19DT0NP
QV9UT1VDSCA9ICQoV0tfTk9UXyQoV0tfRU1QVFlfJChXS19DT0NPQV9UT1VDSCkpKTsKIAotLy8g
RGlzYWJsZSBMVE8gZm9yIEphdmFTY3JpcHRDb3JlLCBkdWUgdG8gPHJkYXI6Ly9wcm9ibGVtLzI0
NTQzNTQ3Pi4gQWRkIGJhY2sgdGhlIGZvbGxvd2luZyBsaW5lIGFuZCBkZWxldGUgdGhlIG9uZSB0
aGF0IHNheXMgIkxMVk1fTFRPID0gTk8iIHdoZW4gdGhhdCBpc3N1ZSBpcyByZXNvbHZlZC4KLS8v
IExMVk1fTFRPID0gJChXS19MTFZNX0xUT18kKFdLX1hDT0RFX1NVUFBPUlRTX0xUTykpOwotTExW
TV9MVE8gPSBOTzsKK0xMVk1fTFRPID0gJChXS19MTFZNX0xUT18kKFdLX1hDT0RFX1NVUFBPUlRT
X0xUTykpOwogV0tfTExWTV9MVE9fTk8gPSBOTzsKIFdLX0xMVk1fTFRPX1lFUyA9ICQoV0tfVVNF
Ul9MVE9fTU9ERSk7CiAK
</data>
<flag name="review"
          id="458194"
          type_id="1"
          status="-"
          setter="ap"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454122</attachid>
            <date>2022-03-08 07:58:35 -0800</date>
            <delta_ts>2022-03-08 08:43:42 -0800</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>1554</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkwOTkwKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA
CisyMDIyLTAzLTA4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IFtKU0NdIEVuYWJsZSBUaGluTFRPCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMjkwMTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgyMTA3NTQzPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3MgYSAx
JSBzcGVlZHVwIG9uIFNwZWVkb21ldGVyMiBhY3Jvc3MgeDg2IGFuZCBhcm02NCwgYW5kIDAuNS0x
JSBzcGVlZHVwIG9uCisgICAgICAgIEpldFN0cmVhbTIgZGVwZW5kaW5nIG9uIHRoZSBkZXZpY2Uu
CisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorCiAyMDIyLTAzLTA4
ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg
cmV2ZXJ0aW5nIHIyOTA5NzUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJh
dGlvbnMvQmFzZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
Q29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwkocmV2aXNpb24gMjkwOTY1KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcJKHdvcmtpbmcgY29w
eSkKQEAgLTE5MCw5ICsxOTAsNyBAQCBFWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FUyA9IGxpYldl
YktpdEFkCiBXS19XRUJLSVRBRERJVElPTlNfSU5TVEFMTF9QQVRIID0gL3Vzci9sb2NhbC9pbmNs
dWRlL1dlYktpdEFkZGl0aW9ucwogV0tfV0VCS0lUQURESVRJT05TX0hFQURFUlNfRk9MREVSX1BB
VEggPSAkKFNES1JPT1QpLyQoV0tfV0VCS0lUQURESVRJT05TX0lOU1RBTExfUEFUSCkKIAotLy8g
RGlzYWJsZSBMVE8gZm9yIEphdmFTY3JpcHRDb3JlLCBkdWUgdG8gPHJkYXI6Ly9wcm9ibGVtLzI0
NTQzNTQ3Pi4gQWRkIGJhY2sgdGhlIGZvbGxvd2luZyBsaW5lIGFuZCBkZWxldGUgdGhlIG9uZSB0
aGF0IHNheXMgIkxMVk1fTFRPID0gTk8iIHdoZW4gdGhhdCBpc3N1ZSBpcyByZXNvbHZlZC4KLS8v
IExMVk1fTFRPID0gJChXS19MTFZNX0xUT18kKFdLX1hDT0RFX1NVUFBPUlRTX0xUTykpOwotTExW
TV9MVE8gPSBOTzsKK0xMVk1fTFRPID0gJChXS19MTFZNX0xUT18kKFdLX1hDT0RFX1NVUFBPUlRT
X0xUTykpOwogV0tfTExWTV9MVE9fTk8gPSBOTzsKIFdLX0xMVk1fTFRPX1lFUyA9ICQoV0tfVVNF
Ul9MVE9fTU9ERSk7CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>